mirror of
https://github.com/morluto/rea.git
synced 2026-11-05 06:45:22 +00:00
Closed
opened 2026-10-31 01:11:45 +00:00 by bsakaguchi
·
0 comments
No Branch/Tag specified
main
codex/procedure-reference-stacked
release-please--branches--main--components--rea-agents
release-please--branches--main--components--rea-agents--release-notes
codex/kuna-independent-retry
codex/byte-search-overlay-coverage
codex/open-failure-target-receipt
codex/kuna-xref-evidence
codex/ghidra-ambiguous-procedure-recovery
codex/function-source-bundle
codex/trace-function-integration-prototype
codex/snapshot-source-closure
codex/recorded-evidence-array-pages
codex/evidence-recovery-redesign
codex/trace-feature-address-scope
codex/call-discovery-scope
codex/ghidra-literal-candidate-evidence
codex/decompile-directory-independent-retry
codex/retry-provenance-base
codex/value-flow-capability-experiment
codex/ghidra-containing-instruction
cursor/readme-discord-button-ef9f
dependabot/github_actions/actions/setup-node-7.1.0
dependabot/github_actions/actions/upload-artifact-7.0.2
dependabot/npm_and_yarn/npm-minor-and-patch-d8d97ce6df
codex/kuna-1989
fix/8559-native-ui-fixture-ownership
fix/8555-go-verifier-mcp-ownership
codex/provider-capability-recovery
fix/8642-rizin-target-stdin
codex/ghidra-memory-effect-scope
codex/ghidra-annotation-entry-selector
codex/ghidra-readonly-recovery
codex/ghidra-regex-verifier-recovery
codex/evidence-discovery-view-guidance
fix/8545-bulk-append-overflow
fix/8428-navigation-refusal-alternatives
codex/address-context-recovery
codex/matching-member-limitations
codex/unknown-scope-contract
codex/evidence-view-guidance
feat/8373-native-trace-views
codex/ghidra-snapshot-verifier-binding
codex/elf-export-visibility
codex/evidence-view-recovery
codex/native-reference-cli-help
codex/provider-candidate-observation-scope
codex/kuna-session-verification
codex/ghidra-switch-lifetime-guidance
codex/pseudocode-paging-discovery
codex/clarify-evidence-view-support
codex/kuna-xrefs-selector-recovery
codex/context-capacity-recovery
codex/evidence-closure-large-links
codex/same-function-evidence-identity
codex/ghidra-verifier-inspected-jdk
codex/audit-guided-workflows
codex/crash-prompt-retained-dossiers
codex/analysis-view-error-recovery
codex/kuna-verifier-target-selection
codex/ghidra-selected-project-call-coverage
codex/docs-native-analysis-scope
codex/ghidra-java-socket-boundary
codex/ghidra-retained-snapshot-verifier
codex/ghidra-search-inventory-facts
fix/8284-zero-argument-parameter-bindings
fix/8198-ui-action-handler-offset
fix/8257-elf-entry-label-identity
fix/8304-deferred-output-schema-projection
fix/8277-call-path-computed-target-uncertainty
fix/pr-8089-conflicts
fix/ci-static-duplicate-export
dependabot/npm_and_yarn/lint-staged-17.6.0
dependabot/github_actions/actions/download-artifact-8.0.2
dependabot/npm_and_yarn/write-file-atomic-8.0.0
dependabot/npm_and_yarn/canonicalize-5.1.0
dependabot/github_actions/actions/cache/restore-6.1.0
dependabot/npm_and_yarn/toon-format/toon-4.4.0
dependabot/github_actions/actions/deploy-pages-5.0.1
codex/review-fixes-pr-2403
codex/review-fixes-pr-2400
codex/process-terminal-width
codex/test-brittleness-cleanup
verify/7167-browser-connect-macos
fix/7167-browser-connect
feat/native-matching-allowance-setting
feat/browser-scenario-dry-run
test/managed-caller-parameters-20261024
codex/parser-fortythird-boundaries
fix/6926-pinvoke-platform-decorations-20261023
fix/6889-har-body-encoding-20261023
fix/6888-sqlite-schema-budget-20261023
fix/dependency-security-gates-6708
cursor/evidence-overwrite-rebase-b4ac
feat/4057-verify-native-exports
fix/windows-acl-observer-overhead-20261022
cursor/erlang-beam-restack-4476
cursor/pe-certificate-review-bf32
fix/6116-javascript-application-fs-errors
fix/6061-unmapped-runtime-script-unknown
feat/browser-scenario-summary
fix/pe-certificates
codex/verify-3407
cursor/rebase-5699
cursor/rebase-5352
cursor/rebase-5600
cursor/fix-cli-schema-omission-10a8
codex/audit-hopper-shutdown-reasons-20261021
fix/demangle-swift-omitted-record
fix/nib-boolean-value-types
cursor/cancellation-partial-observation-a5ac
fix/ib-object-limit-reasons
fix/electron-fuse-limit-advice
fix/kuna-doctor-dangling-cache
fix/fixed-budget-refusal-advice
fix/js-ipc-listener-dedup
fix/js-return-member-provenance
fix/dmg-integrity-retry-advice
fix/ida-doctor-readiness
fix/kuna-version-probe-output-drain
fix/legacy-swift-runtime-name-matching
fix/dylib-lazy-load-commands
fix/browser-scenario-startup-cancel
fix/swift-nested-punycode-classification
fix/compare-unselected-scopes
fix/objc-method-budget-coverage
fix/dmg-mounted-root-observations
audit/ci-tests-20261019-round2
release/6.7.0
fix/wabt-cleanup-retry-resolution
fix/electron-fuse-elf-pe-architecture
fix/native-plist-descriptor-ownership
fix/kuna-caller-cleanup-ownership
experiment/atomic-codemode-20261016
review/first-contributor-3776
fix/call-resolution-full-read-cycles
fix/member-mutation-selection-repeat
experiment/atomic-re-tools-20261015
perf/member-mutation-lazy-origins
perf/static-network-mutation-index
fix/hopper-startup-lifecycle
audit/3050-windows-proof-20261015
feat/windows-window-capture-2183
audit/3049-windows-proof-20261015
audit/3735-macos-fixtures-20261015
fix/batch-decompile-null-pseudocode
fix/kuna-inventory-honors-jobs
experiment/browser-codemode-tool-design-20261015
fix/hopper-clean-runtime-argv
codex/review-2049-27f1b367
review-fixes/pr-2787-routing
fix/3360-scoped-this-emitters
fix/3367-replaced-global-effects
fix/3838-compact-any-value-items
test/hopper-download-probe-20261015
codex/windows-runtime-creation-red-green-20261015
codex/windows-readonly-root-red-green-20261015
codex/windows-root-share-red-green-20261015
codex/exp-1685-win-mcp-startup
codex/bug-sweep-20261015
investigate/2190-windows-package-phases
investigate/3543-macos-cli-deadline
perf/3281-reverse-tools-feedback-quality
fix/3406-hopper-doctor-fixture
fix/3341-wrapper-require-test-context
fix/3301-owned-uninstall-fixtures
fix/3164-compiler-input-ownership
fix/pcap-cleanup-stdout-newline-20261014
perf/interface-builder-summary
codex/review-fixes-pr-1977
fix/ghidra-effective-jvm-platform
fix/docs-turkish-rust-link-20261013
fix/main-maintenance-ci-20261010
fix/recover-binary-session-process-effects
codex/review-fixes-pr-2457
codex/ci-required-cancellation-gate
fix/main-format-baseline-20261013
fix/setup-preserve-entry-fields
cursor/restore-main-checks-1ffc
fix/ghidra-bridge-hashmap-import
codex/shared-ci-jadx-json-default-20261013
codex/shared-ci-ghidra-test-groups-20261013
codex/shared-ci-java-fixture-format-20261013
codex/fix-intrinsic-invocation-boundaries
test/release-preflight-reusable-jobs
test/js-parameter-provenance-expectation
fix/linux-hopper-verification-current
test/2419-ghidra-elf-probe-size
followup/pr-1544-native-ida
codex/fold-pr-2230-contribution
docs/readme-responsible-use
fix/issue-2064
fix/issue-2050
fix/issue-2053
fix/issue-1968
fix/issue-1945
experiment/codemode-bridge-20261011
fix/tool-effects-negative-wording-1904-20261012
fix/1842-electron-interop-provenance
feat/recover-javascript-multi-input
refactor/website-i18n-prep
fix/nativeaot-pe-virtual-extent
fix/browser-verifier-ci-hang
fix/pe-resources-input-selection
docs/beginner-friendly-guides
docs/beginner-setup-guide
fix/javascript-analysis-worker-1563
fix/1649-ghidra-duplicate-names
fix/javascript-export-keys-integration-1369
test/maintenance-boundary-contracts-20261011
review/javascript-export-keys-1369
review/process-live-progress-1483
test/javascript-1495-growth-ratio
fix/ci-escape-timing
docs/normalized-terminal-geometry-1450
release/6.3.0
archive/release-6.3.0-pr1381
release/6.2.0
fix/electron-preload-dynamic-override
fix/javascript-self-referential-bundler-edges
release/6.1.0
cursor/grok-client-cherry-pick-0b56
feat/signature-posture
feat/dyld-shared-cache
feat/artifact-integrity-policy
feat/pkg-inventory
release/6.0.0
chore/sync-release-5.0.0
release/5.0.0
cursor/cloud-agent-node-787e
fix/javascript-xhr-open-endpoints
review/pr-711-realpath-fallback-wording
cleanup/replay-confinement
codex/test-suite-performance
codex/issue-foundations
codex/address-open-issues-2026-07-20
agent/javascript-vite-rollup-esbuild-adapters
agent/process-cleanup
agent/triage-integration
agent/unknown-commands-registry
feat/mcp-identity-metadata
morlvps/issue_cleanup
codex/installer-redesign
morl/roadmap-investigation-core
morl/roadmap-investigation-docs
release-please--branches--main--components--rea
rea-agents-6.8.0
rea-agents-6.7.0
rea-agents-6.6.0
experiment/atomic-codemode-wait-runtime-20261016
rea-agents-6.5.0
rea-agents-6.4.0
rea-agents-6.3.0
rea-agents-6.2.0
rea-agents-6.1.0
rea-agents-6.0.0
rea-agents-5.0.0
rea-agents-4.1.0
rea-agents-4.0.1
rea-agents-4.0.0
rea-agents-3.2.1
rea-agents-3.2.0
rea-agents-3.1.0
rea-agents-3.0.0
rea-agents-2.7.0
rea-agents-2.6.0
rea-agents-2.5.1
rea-agents-2.5.0
rea-agents-2.4.0
rea-agents-2.3.0
rea-agents-2.2.0
rea-agents-2.1.0
rea-agents-2.0.0
rea-agents-1.7.0
rea-agents-1.6.0
rea-agents-1.5.0
rea-agents-1.4.0
rea-agents-1.3.0
rea-agents-1.2.0
rea-agents-1.1.0
rea-agents-1.0.0
rea-agents-0.5.0
rea-agents-0.4.0
rea-agents-0.3.0
rea-0.2.1
rea-0.2.0
Labels
Clear labels
area: bridge
area: bridge
area: build
area: build
area: build
area: cli
area: domain
area: evidence
area: mcp
area: native
area: providers
area: runtime
area: server
area: setup
area: tests
bug
design
documentation
enhancement
enhancement
enhancement
experiment
help wanted
i18n
invalid
P0: critical
P1: high
P2: medium
P2: medium
P2: medium
P3: low
performance
provider-request
pull-request
Mirrored from GitHub Pull Request
question
roadmap
triage
No labels
area: bridge
area: bridge
area: build
area: build
area: build
area: cli
area: domain
area: evidence
area: mcp
area: native
area: providers
area: runtime
area: server
area: setup
area: tests
bug
design
documentation
enhancement
enhancement
enhancement
experiment
help wanted
i18n
invalid
P0: critical
P1: high
P2: medium
P2: medium
P2: medium
P3: low
performance
provider-request
pull-request
question
roadmap
triage
Milestone
Clear milestone
No items
No milestone
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".
No due date set.
Dependencies
No dependencies set.
Reference
morluto/rea#6087
Loading…
Add table
Add a link
Reference in a new issue
No description provided.
Delete branch "%!s()"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
📋 Pull Request Information
Original PR: https://github.com/morluto/rea/pull/4147
Author: @akushonkamen
Created: 10/15/2026
Status: ❌ Closed
Base:
main← Head:fix/4058-inline-input-schema📝 Commits (2)
1415731fix(mcp): advertise tool inputs without shared $defs84d255ftest(contracts): scan schema map values in the advertised-reference guard📊 Changes
3 files changed (+174 additions, -176 deletions)
View changed files
📝
src/contracts/inputSchemaPresentation.ts(+4 -67)📝
src/contracts/toolInputReferences.test.ts(+152 -81)📝
src/contracts/toolSchemaMetadata.ts(+18 -28)📄 Description
Summary
Fixes #4058. Calling
compare_web_screenshotsthrough Claude Desktop's MCP bridge failed before execution withexpected object, received string, because the advertisedinputSchemapublished shared subschemas as$defs+$ref, and the bridge — which does not resolve schema-local references — serialized the object arguments as strings. Published tool inputs are now always advertised fully inlined, so every parameter carries its complete structure on the wire and no client needs reference resolution to call a tool.Problem and expected behavior
$refagainst$defs(Claude Desktop's bridge, per the issue), calling a tool whose advertised input shares a subschema between parameters.toolInputSchemaWithMetadata(src/contracts/toolSchemaMetadata.ts:60-69atb3b5c8b13) projected inputs withlibraryOptions: { reused: "ref" }.webScreenshotArtifactSchemais shared bybeforeandafter, socompare_web_screenshotsadvertisedproperties.before = { "$ref": "#/$defs/__schema0", ... }with$defs __schema0..__schema5(probe atb3b5c8b13). A catalog-wide scan on the unfixed tree counted 169 published tools advertising$defson their inputs in draft-2020-12, including the flatcapture_web_screenshot.compare_web_capturesis reported failing through the same bridge, but its advertised input carries no shared definitions at all (verified in draft-2020-12 and draft-07), so the reported failure there is not explained by this mechanism and is left unchanged.Change and scope
toolInputSchemaWithMetadata(src/contracts/toolSchemaMetadata.ts:56-66) now projects advertised inputs withreused: "inline": each parameter ships its complete schema. Inlining also serves budget-limited reference resolvers (#1632): with no references on the wire, no reference-expansion budget can degrade a field to unknown.$defsand$iddigests (src/contracts/toolSchemaMetadata.ts:105still projects outputs withreused: "ref"), and callers can still request the shared form explicitly throughlibraryOptions.inputSchemaWithinReferenceExpansionBudget,countLocalReferenceExpansions,advertisedReferenceExpansionBudget) are removed with their last caller; a repo-wide search finds no remaining references.src/contracts/toolInputReferences.test.tsnow walks every entry inTOOL_CONTRACTSunder both dialects (draft-2020-12 and draft-07) and asserts that no advertised input schema contains$refor$defs. This is also the enumeration the issue asked for: the catalog-wide scan/test lists every affected tool mechanically.JSON.parsefallback for stringified objects (floated in the issue). The schema is now self-contained, so accepting strings would mask contract violations instead of fixing the advertisement; that safety net can be added separately if a maintainer wants it.Contribution scope: a bug fix within the existing static, read-only boundary; no new providers or capabilities; linked maintainer scope decision not applicable.
Contract and boundary impact
src/contracts/toolSchemaMetadata.ts, shared projection insrc/contracts/inputSchemaPresentation.ts), consumed at the MCP server boundary.inputSchemano longer contains$ref/$defsin either dialect; output schemas and explicitlibraryOptionssharing are unchanged.docs/public/product-catalog.json), package, or installation impact: none. The local gitignored.cache/mcp-tool-catalog.jsonwas regenerated vianpm run mcp-catalog:generate; no build outputs are committed.Expected effects (check known effects; use documentation-only on its own).
Unchecked items do not establish absence; leave uncertainties visible.
Evidence and regression coverage
src/contracts/toolInputReferences.test.ts— catalog-wide assertions (20 tests). Against basea40ee741cwith the new test file: 7 failed | 13 passed (red); with the fix: 20 passed (green). The same red/green split was observed at the previous baseb3b5c8b13(7/13 → 20/20).b3b5c8b13showed the advertised input ofcompare_web_screenshotscontaining$defs __schema0..__schema5withproperties.before = { "$ref": "#/$defs/__schema0", ... }, and the directory-level scan counted 169 tools advertising$defs(draft-2020-12), including bothcompare_*tools named in the issue and the flatcapture_web_screenshot(executed before the fix; recorded in the issue claim comment).compare_web_screenshotswith aninputSchemacontaining no$defsand no$ref;properties.beforeis the complete object schema (type/properties/required/description, with inlinedbytes,data_base64,media_type, …), checked here against.cache/mcp-tool-catalog.jsonregenerated from this tree.compare_web_captures' reported failure is not explained by shared definitions and is unchanged.For evidence-bearing changes:
Validation performed
timeout 300 npx vitest run src/contracts— 12 files, 107 passed | 3 skipped (110 tests).npx vitest run src/contracts/toolInputReferences.test.ts— 20 passed on this branch; 7 failed | 13 passed when the same test file runs against basea40ee741c.npx vitest run src/server/EvidenceMcpServer.test.ts— 1 file, 2 passed.npx vitest run --project mcp-boundary— 139 files (137 passed | 2 skipped), 770 passed | 5 skipped. The first run after rebasing onto currentmainfailed 15 tests across 7 files because the local gitignored.cache/mcp-tool-catalog.jsonpredatedmain's #4095 description changes; afternpm run mcp-catalog:generatethe same suite passes fully.npm run typecheck— clean.npm run check:fast— passed.npx oxlint src/contracts/inputSchemaPresentation.ts src/contracts/toolInputReferences.test.ts src/contracts/toolSchemaMetadata.ts— Found 0 warnings and 0 errors.npx oxfmt --check src/contracts/inputSchemaPresentation.ts src/contracts/toolInputReferences.test.ts src/contracts/toolSchemaMetadata.ts— all matched files use the correct format.npm run verify:test-discovery— 1347 test files discovered exactly once.Compatibility, safety, and release
libraryOptions. The removed helpers were input-side projection internals with no remaining references.Author readiness
Human owner:
Before merge
type(scope): outcome.🤖 Prepared with AI assistance (autonomous contributor agent run); the work is disclosed as AI-assisted in the issue claim comment and awaits human-owner review.
🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.