morluto/rea

Fork 0

mirror of https://github.com/morluto/rea.git synced 2026-11-05 06:45:22 +00:00

[PR #4154] [CLOSED] test(verifiers): expand tar listing identity coverage #6093

New issue

Closed

opened 2026-10-31 01:11:48 +00:00 by bsakaguchi · 0 comments

bsakaguchi commented

2026-10-31 01:11:48 +00:00

Owner

📋 Pull Request Information

Original PR: https://github.com/morluto/rea/pull/4154
Author: @Abdooo2235
Created: 10/15/2026
Status: ❌ Closed

Base: main ← Head: fix/package-tar-line-endings

📝 Commits (5)

995eb91 fix(verifiers): parse Windows tar listing line endings
526623d Merge branch 'main' into fix/package-tar-line-endings
a102a2c Merge branch 'main' into fix/package-tar-line-endings
27ff443 fix(verifiers): preserve filename CRs in LF tar listings
acfa1a1 merge: reconcile tar listing tests with current main

📊 Changes

1 file changed (+62 additions, -29 deletions)

View changed files

📝 tests/boundary/process/packageTarListing.test.ts (+62 -29)

📄 Description

Summary

Expand the package tar-listing regression matrix to cover every currently required bridge, LF and CRLF listings, forbidden package content, and significant filename whitespace. Refs #4128.

The runtime fix from this contribution is already on main in 306d531, with contributor credit preserved. This PR now changes only tests/boundary/process/packageTarListing.test.ts.

Change and scope

Keep main's complete list of eleven required bridge members and apply the trailing-CR regression to each member. Retain LF/CRLF acceptance, .pyc and __pycache__ rejection, authored-skill/cache exclusion, and leading/trailing whitespace identity checks. The add/add conflict was resolved by combining main's current fixture with the broader regression matrix; no runtime implementation is replaced.

Contract and boundary impact

Owner: package-verifier process-boundary tests.
Scope: regression coverage within existing behavior; no additional maintainer scope decision applies.
CLI/MCP, providers, package metadata, installation and runtime cleanup: unchanged.
Tests launch Node subprocesses in owned temporary directories with controlled command-output fixtures. They do not establish real-provider behavior.

Validation performed

Windows, Node 24.18.0 / npm 11.16.0.
npm run test:focused -- tests/boundary/process/packageTarListing.test.ts tests/boundary/process/packagePackIsolation.test.ts — 27/27 passed, including real npm pack isolation.
npm run check — passed, including typecheck, format, lint, module boundaries and architecture guards; existing repository lint warnings remain.
Independent read-only review of the conflict resolution — no actionable findings; main's regression coverage retained.

Compatibility and limitations

Test-only change relative to main edfd502. The prior combined 42-case Windows runs are historical evidence linked in the discussion; that full lane was not rerun for this test-only merge resolution. Current-head CI results remain separate from local checks.

Author readiness

Human owner: @N0zoM1z0

I reviewed the final diff and relevant existing code, understand the change and its edge cases, and take responsibility for the complete PR, including AI-assisted work.
I checked the evidence above, confirmed it supports the current change, and recorded meaningful validation gaps.
I declare this PR ready for initial maintainer review.

Before merge

Focused test-only scope and existing coverage retained.
Required CI checks complete for the current head.

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/morluto/rea/pull/4154 **Author:** [@Abdooo2235](https://github.com/Abdooo2235) **Created:** 10/15/2026 **Status:** ❌ Closed **Base:** `main` ← **Head:** `fix/package-tar-line-endings` --- ### 📝 Commits (5) - [`995eb91`](https://github.com/morluto/rea/commit/995eb91fed940a1b67920645278e869ab12ba830) fix(verifiers): parse Windows tar listing line endings - [`526623d`](https://github.com/morluto/rea/commit/526623d36d705af78977e6be57fdef3598c35253) Merge branch 'main' into fix/package-tar-line-endings - [`a102a2c`](https://github.com/morluto/rea/commit/a102a2ca6ea23db89a3b4b073356cb4a5c94a088) Merge branch 'main' into fix/package-tar-line-endings - [`27ff443`](https://github.com/morluto/rea/commit/27ff4436aaf6dbf7bed207bde4221ff3fe41f2d3) fix(verifiers): preserve filename CRs in LF tar listings - [`acfa1a1`](https://github.com/morluto/rea/commit/acfa1a18c900096aa95420f9de94157e34fc9d6f) merge: reconcile tar listing tests with current main ### 📊 Changes **1 file changed** (+62 additions, -29 deletions) <details> <summary>View changed files</summary> 📝 `tests/boundary/process/packageTarListing.test.ts` (+62 -29) </details> ### 📄 Description ## Summary Expand the package tar-listing regression matrix to cover every currently required bridge, LF and CRLF listings, forbidden package content, and significant filename whitespace. Refs #4128. The runtime fix from this contribution is already on main in 306d531, with contributor credit preserved. This PR now changes only `tests/boundary/process/packageTarListing.test.ts`. ## Change and scope Keep main's complete list of eleven required bridge members and apply the trailing-CR regression to each member. Retain LF/CRLF acceptance, `.pyc` and `__pycache__` rejection, authored-skill/cache exclusion, and leading/trailing whitespace identity checks. The add/add conflict was resolved by combining main's current fixture with the broader regression matrix; no runtime implementation is replaced. ## Contract and boundary impact - Owner: package-verifier process-boundary tests. - Scope: regression coverage within existing behavior; no additional maintainer scope decision applies. - CLI/MCP, providers, package metadata, installation and runtime cleanup: unchanged. - Tests launch Node subprocesses in owned temporary directories with controlled command-output fixtures. They do not establish real-provider behavior. ## Validation performed - Windows, Node 24.18.0 / npm 11.16.0. - `npm run test:focused -- tests/boundary/process/packageTarListing.test.ts tests/boundary/process/packagePackIsolation.test.ts` — **27/27 passed**, including real npm pack isolation. - `npm run check` — passed, including typecheck, format, lint, module boundaries and architecture guards; existing repository lint warnings remain. - Independent read-only review of the conflict resolution — no actionable findings; main's regression coverage retained. ## Compatibility and limitations Test-only change relative to main `edfd502`. The prior combined 42-case Windows runs are historical evidence linked in the discussion; that full lane was not rerun for this test-only merge resolution. Current-head CI results remain separate from local checks. ## Author readiness Human owner: @N0zoM1z0 - [x] I reviewed the final diff and relevant existing code, understand the change and its edge cases, and take responsibility for the complete PR, including AI-assisted work. - [x] I checked the evidence above, confirmed it supports the current change, and recorded meaningful validation gaps. - [x] I declare this PR ready for initial maintainer review. ## Before merge - [x] Focused test-only scope and existing coverage retained. - [x] Required CI checks complete for the current head. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>

bsakaguchi

2026-10-31 01:11:48 +00:00

closed this issue
added the
pull-request
label

bsakaguchi referenced this issue

2026-11-01 21:48:01 +00:00

[PR #6942] fix(artifacts): retain completed Rust, BEAM, and pyc facts through finalization #7463

No milestone

No project

No assignees

1 participant

Notifications

Due date

The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference

morluto/rea#6093

No description provided.

Rows
Columns