[PR #4224] fix(browser): preserve uncertainty for omitted initiator URLs (#4211) #6136

New issue

Open

opened 2026-10-31 01:12:09 +00:00 by bsakaguchi · 0 comments

bsakaguchi commented

2026-10-31 01:12:09 +00:00

Owner

📋 Pull Request Information

Original PR: https://github.com/morluto/rea/pull/4224
Author: @glaucojrcarvalho
Created: 10/15/2026
Status: 🔄 Open

Base: main ← Head: fix/4211-network-initiator-omissions

📝 Commits (3)

28de95a fix(browser): preserve uncertainty for omitted initiator URLs (#4211)
4c42e80 test(browser): cover omitted initiator comparisons (#4211)
e5e9f0a fix(browser): distinguish omitted initiator evidence from nullable URLs

📊 Changes

2 files changed (+80 additions, -1 deletions)

View changed files

📝 src/domain/webCaptureDiff.network.test.ts (+61 -0)
📝 src/domain/webCaptureDiff.ts (+19 -1)

📄 Description

Summary

Fixes #4211.

Treat explicitly omitted initiator URLs as unknown evidence rather than comparable null or a proven modification.
Project out the affected URL only for identities whose initiator URL is incomplete, retaining other known metadata, request membership, and real response/initiator differences.
Add regression coverage for both-sided and one-sided omissions, observed differences, and unrelated filtering.

Verification

Contributor-executed on Linux with Node.js v24.18.0 and npm 12.0.1: npm ci succeeded; focused src/domain/webCaptureDiff.network.test.ts suite passed 50/50 tests; npm run check:fast passed 2/2 tasks; and npm run build:cached passed 3/3 tasks.
Original issue #4211 nine-case public CLI reproduction passed 9/9 against the rebuilt implementation. complete and unrelatedOmission were unchanged; bothOmitted, oneOmitted, reverseOmitted, attachComplete, and attachOmission were unknown with no changes; known initiator and response changes remained changed with one modification each.
Fix committed and pushed as e5e9f0a; Git pre-push static checks passed again.
Evidence comes from contributor-shared terminal output, not an independent rerun by the assisting agent. Real browser/provider behavior and upstream CI are not verified.

Author readiness

I reviewed the final diff and relevant existing code and take human ownership of this contribution.
I reviewed the verification results and explicitly described relevant untested scope.
This PR is ready for initial maintainer review.

Ready for review: The human contributor completed the author-readiness declarations and marked the PR ready for maintainer review.

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/morluto/rea/pull/4224 **Author:** [@glaucojrcarvalho](https://github.com/glaucojrcarvalho) **Created:** 10/15/2026 **Status:** 🔄 Open **Base:** `main` ← **Head:** `fix/4211-network-initiator-omissions` --- ### 📝 Commits (3) - [`28de95a`](https://github.com/morluto/rea/commit/28de95ac06d8e37b92c29d5b148bd5b36b175ee4) fix(browser): preserve uncertainty for omitted initiator URLs (#4211) - [`4c42e80`](https://github.com/morluto/rea/commit/4c42e8064c3612f00c706336951658a78cc15e42) test(browser): cover omitted initiator comparisons (#4211) - [`e5e9f0a`](https://github.com/morluto/rea/commit/e5e9f0a4388ea4a11f6e8c88f71e5a71bbb0bd3c) fix(browser): distinguish omitted initiator evidence from nullable URLs ### 📊 Changes **2 files changed** (+80 additions, -1 deletions) <details> <summary>View changed files</summary> 📝 `src/domain/webCaptureDiff.network.test.ts` (+61 -0) 📝 `src/domain/webCaptureDiff.ts` (+19 -1) </details> ### 📄 Description ## Summary Fixes #4211. - Treat explicitly omitted initiator URLs as unknown evidence rather than comparable null or a proven modification. - Project out the affected URL only for identities whose initiator URL is incomplete, retaining other known metadata, request membership, and real response/initiator differences. - Add regression coverage for both-sided and one-sided omissions, observed differences, and unrelated filtering. ## Verification - Contributor-executed on Linux with Node.js v24.18.0 and npm 12.0.1: `npm ci` succeeded; focused `src/domain/webCaptureDiff.network.test.ts` suite passed **50/50** tests; `npm run check:fast` passed **2/2** tasks; and `npm run build:cached` passed **3/3** tasks. - Original issue #4211 nine-case public CLI reproduction passed **9/9** against the rebuilt implementation. `complete` and `unrelatedOmission` were unchanged; `bothOmitted`, `oneOmitted`, `reverseOmitted`, `attachComplete`, and `attachOmission` were unknown with no changes; known initiator and response changes remained changed with one modification each. - Fix committed and pushed as `e5e9f0a`; Git pre-push static checks passed again. - Evidence comes from contributor-shared terminal output, not an independent rerun by the assisting agent. Real browser/provider behavior and upstream CI are not verified. ## Author readiness - [x] I reviewed the final diff and relevant existing code and take human ownership of this contribution. - [x] I reviewed the verification results and explicitly described relevant untested scope. - [x] This PR is ready for initial maintainer review. **Ready for review:** The human contributor completed the author-readiness declarations and marked the PR ready for maintainer review. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>

bsakaguchi added the

pull-request

label

2026-10-31 01:12:09 +00:00

bsakaguchi referenced this issue

2026-11-01 21:45:46 +00:00

[PR #6136] [MERGED] feat(environment): serve writes whose values the application renames or regenerates #7152

bsakaguchi referenced this issue

2026-11-01 21:46:49 +00:00

[PR #6345] [MERGED] fix(environment): preserve UUID renewal ownership #7293