mirror of
https://github.com/morluto/rea.git
synced 2026-11-05 06:45:22 +00:00
[PR #4267] [CLOSED] fix(go): report a missing main-module record as an unknown dependency list #6147
Closed
opened 2026-10-31 01:12:13 +00:00 by bsakaguchi
·
0 comments
No Branch/Tag specified
main
codex/procedure-reference-stacked
release-please--branches--main--components--rea-agents
release-please--branches--main--components--rea-agents--release-notes
codex/kuna-independent-retry
codex/byte-search-overlay-coverage
codex/open-failure-target-receipt
codex/kuna-xref-evidence
codex/ghidra-ambiguous-procedure-recovery
codex/function-source-bundle
codex/trace-function-integration-prototype
codex/snapshot-source-closure
codex/recorded-evidence-array-pages
codex/evidence-recovery-redesign
codex/trace-feature-address-scope
codex/call-discovery-scope
codex/ghidra-literal-candidate-evidence
codex/decompile-directory-independent-retry
codex/retry-provenance-base
codex/value-flow-capability-experiment
codex/ghidra-containing-instruction
cursor/readme-discord-button-ef9f
dependabot/github_actions/actions/setup-node-7.1.0
dependabot/github_actions/actions/upload-artifact-7.0.2
dependabot/npm_and_yarn/npm-minor-and-patch-d8d97ce6df
codex/kuna-1989
fix/8559-native-ui-fixture-ownership
fix/8555-go-verifier-mcp-ownership
codex/provider-capability-recovery
fix/8642-rizin-target-stdin
codex/ghidra-memory-effect-scope
codex/ghidra-annotation-entry-selector
codex/ghidra-readonly-recovery
codex/ghidra-regex-verifier-recovery
codex/evidence-discovery-view-guidance
fix/8545-bulk-append-overflow
fix/8428-navigation-refusal-alternatives
codex/address-context-recovery
codex/matching-member-limitations
codex/unknown-scope-contract
codex/evidence-view-guidance
feat/8373-native-trace-views
codex/ghidra-snapshot-verifier-binding
codex/elf-export-visibility
codex/evidence-view-recovery
codex/native-reference-cli-help
codex/provider-candidate-observation-scope
codex/kuna-session-verification
codex/ghidra-switch-lifetime-guidance
codex/pseudocode-paging-discovery
codex/clarify-evidence-view-support
codex/kuna-xrefs-selector-recovery
codex/context-capacity-recovery
codex/evidence-closure-large-links
codex/same-function-evidence-identity
codex/ghidra-verifier-inspected-jdk
codex/audit-guided-workflows
codex/crash-prompt-retained-dossiers
codex/analysis-view-error-recovery
codex/kuna-verifier-target-selection
codex/ghidra-selected-project-call-coverage
codex/docs-native-analysis-scope
codex/ghidra-java-socket-boundary
codex/ghidra-retained-snapshot-verifier
codex/ghidra-search-inventory-facts
fix/8284-zero-argument-parameter-bindings
fix/8198-ui-action-handler-offset
fix/8257-elf-entry-label-identity
fix/8304-deferred-output-schema-projection
fix/8277-call-path-computed-target-uncertainty
fix/pr-8089-conflicts
fix/ci-static-duplicate-export
dependabot/npm_and_yarn/lint-staged-17.6.0
dependabot/github_actions/actions/download-artifact-8.0.2
dependabot/npm_and_yarn/write-file-atomic-8.0.0
dependabot/npm_and_yarn/canonicalize-5.1.0
dependabot/github_actions/actions/cache/restore-6.1.0
dependabot/npm_and_yarn/toon-format/toon-4.4.0
dependabot/github_actions/actions/deploy-pages-5.0.1
codex/review-fixes-pr-2403
codex/review-fixes-pr-2400
codex/process-terminal-width
codex/test-brittleness-cleanup
verify/7167-browser-connect-macos
fix/7167-browser-connect
feat/native-matching-allowance-setting
feat/browser-scenario-dry-run
test/managed-caller-parameters-20261024
codex/parser-fortythird-boundaries
fix/6926-pinvoke-platform-decorations-20261023
fix/6889-har-body-encoding-20261023
fix/6888-sqlite-schema-budget-20261023
fix/dependency-security-gates-6708
cursor/evidence-overwrite-rebase-b4ac
feat/4057-verify-native-exports
fix/windows-acl-observer-overhead-20261022
cursor/erlang-beam-restack-4476
cursor/pe-certificate-review-bf32
fix/6116-javascript-application-fs-errors
fix/6061-unmapped-runtime-script-unknown
feat/browser-scenario-summary
fix/pe-certificates
codex/verify-3407
cursor/rebase-5699
cursor/rebase-5352
cursor/rebase-5600
cursor/fix-cli-schema-omission-10a8
codex/audit-hopper-shutdown-reasons-20261021
fix/demangle-swift-omitted-record
fix/nib-boolean-value-types
cursor/cancellation-partial-observation-a5ac
fix/ib-object-limit-reasons
fix/electron-fuse-limit-advice
fix/kuna-doctor-dangling-cache
fix/fixed-budget-refusal-advice
fix/js-ipc-listener-dedup
fix/js-return-member-provenance
fix/dmg-integrity-retry-advice
fix/ida-doctor-readiness
fix/kuna-version-probe-output-drain
fix/legacy-swift-runtime-name-matching
fix/dylib-lazy-load-commands
fix/browser-scenario-startup-cancel
fix/swift-nested-punycode-classification
fix/compare-unselected-scopes
fix/objc-method-budget-coverage
fix/dmg-mounted-root-observations
audit/ci-tests-20261019-round2
release/6.7.0
fix/wabt-cleanup-retry-resolution
fix/electron-fuse-elf-pe-architecture
fix/native-plist-descriptor-ownership
fix/kuna-caller-cleanup-ownership
experiment/atomic-codemode-20261016
review/first-contributor-3776
fix/call-resolution-full-read-cycles
fix/member-mutation-selection-repeat
experiment/atomic-re-tools-20261015
perf/member-mutation-lazy-origins
perf/static-network-mutation-index
fix/hopper-startup-lifecycle
audit/3050-windows-proof-20261015
feat/windows-window-capture-2183
audit/3049-windows-proof-20261015
audit/3735-macos-fixtures-20261015
fix/batch-decompile-null-pseudocode
fix/kuna-inventory-honors-jobs
experiment/browser-codemode-tool-design-20261015
fix/hopper-clean-runtime-argv
codex/review-2049-27f1b367
review-fixes/pr-2787-routing
fix/3360-scoped-this-emitters
fix/3367-replaced-global-effects
fix/3838-compact-any-value-items
test/hopper-download-probe-20261015
codex/windows-runtime-creation-red-green-20261015
codex/windows-readonly-root-red-green-20261015
codex/windows-root-share-red-green-20261015
codex/exp-1685-win-mcp-startup
codex/bug-sweep-20261015
investigate/2190-windows-package-phases
investigate/3543-macos-cli-deadline
perf/3281-reverse-tools-feedback-quality
fix/3406-hopper-doctor-fixture
fix/3341-wrapper-require-test-context
fix/3301-owned-uninstall-fixtures
fix/3164-compiler-input-ownership
fix/pcap-cleanup-stdout-newline-20261014
perf/interface-builder-summary
codex/review-fixes-pr-1977
fix/ghidra-effective-jvm-platform
fix/docs-turkish-rust-link-20261013
fix/main-maintenance-ci-20261010
fix/recover-binary-session-process-effects
codex/review-fixes-pr-2457
codex/ci-required-cancellation-gate
fix/main-format-baseline-20261013
fix/setup-preserve-entry-fields
cursor/restore-main-checks-1ffc
fix/ghidra-bridge-hashmap-import
codex/shared-ci-jadx-json-default-20261013
codex/shared-ci-ghidra-test-groups-20261013
codex/shared-ci-java-fixture-format-20261013
codex/fix-intrinsic-invocation-boundaries
test/release-preflight-reusable-jobs
test/js-parameter-provenance-expectation
fix/linux-hopper-verification-current
test/2419-ghidra-elf-probe-size
followup/pr-1544-native-ida
codex/fold-pr-2230-contribution
docs/readme-responsible-use
fix/issue-2064
fix/issue-2050
fix/issue-2053
fix/issue-1968
fix/issue-1945
experiment/codemode-bridge-20261011
fix/tool-effects-negative-wording-1904-20261012
fix/1842-electron-interop-provenance
feat/recover-javascript-multi-input
refactor/website-i18n-prep
fix/nativeaot-pe-virtual-extent
fix/browser-verifier-ci-hang
fix/pe-resources-input-selection
docs/beginner-friendly-guides
docs/beginner-setup-guide
fix/javascript-analysis-worker-1563
fix/1649-ghidra-duplicate-names
fix/javascript-export-keys-integration-1369
test/maintenance-boundary-contracts-20261011
review/javascript-export-keys-1369
review/process-live-progress-1483
test/javascript-1495-growth-ratio
fix/ci-escape-timing
docs/normalized-terminal-geometry-1450
release/6.3.0
archive/release-6.3.0-pr1381
release/6.2.0
fix/electron-preload-dynamic-override
fix/javascript-self-referential-bundler-edges
release/6.1.0
cursor/grok-client-cherry-pick-0b56
feat/signature-posture
feat/dyld-shared-cache
feat/artifact-integrity-policy
feat/pkg-inventory
release/6.0.0
chore/sync-release-5.0.0
release/5.0.0
cursor/cloud-agent-node-787e
fix/javascript-xhr-open-endpoints
review/pr-711-realpath-fallback-wording
cleanup/replay-confinement
codex/test-suite-performance
codex/issue-foundations
codex/address-open-issues-2026-07-20
agent/javascript-vite-rollup-esbuild-adapters
agent/process-cleanup
agent/triage-integration
agent/unknown-commands-registry
feat/mcp-identity-metadata
morlvps/issue_cleanup
codex/installer-redesign
morl/roadmap-investigation-core
morl/roadmap-investigation-docs
release-please--branches--main--components--rea
rea-agents-6.8.0
rea-agents-6.7.0
rea-agents-6.6.0
experiment/atomic-codemode-wait-runtime-20261016
rea-agents-6.5.0
rea-agents-6.4.0
rea-agents-6.3.0
rea-agents-6.2.0
rea-agents-6.1.0
rea-agents-6.0.0
rea-agents-5.0.0
rea-agents-4.1.0
rea-agents-4.0.1
rea-agents-4.0.0
rea-agents-3.2.1
rea-agents-3.2.0
rea-agents-3.1.0
rea-agents-3.0.0
rea-agents-2.7.0
rea-agents-2.6.0
rea-agents-2.5.1
rea-agents-2.5.0
rea-agents-2.4.0
rea-agents-2.3.0
rea-agents-2.2.0
rea-agents-2.1.0
rea-agents-2.0.0
rea-agents-1.7.0
rea-agents-1.6.0
rea-agents-1.5.0
rea-agents-1.4.0
rea-agents-1.3.0
rea-agents-1.2.0
rea-agents-1.1.0
rea-agents-1.0.0
rea-agents-0.5.0
rea-agents-0.4.0
rea-agents-0.3.0
rea-0.2.1
rea-0.2.0
Labels
Clear labels
area: bridge
area: bridge
area: build
area: build
area: build
area: cli
area: domain
area: evidence
area: mcp
area: native
area: providers
area: runtime
area: server
area: setup
area: tests
bug
design
documentation
enhancement
enhancement
enhancement
experiment
help wanted
i18n
invalid
P0: critical
P1: high
P2: medium
P2: medium
P2: medium
P3: low
performance
provider-request
pull-request
Mirrored from GitHub Pull Request
question
roadmap
triage
No labels
area: bridge
area: bridge
area: build
area: build
area: build
area: cli
area: domain
area: evidence
area: mcp
area: native
area: providers
area: runtime
area: server
area: setup
area: tests
bug
design
documentation
enhancement
enhancement
enhancement
experiment
help wanted
i18n
invalid
P0: critical
P1: high
P2: medium
P2: medium
P2: medium
P3: low
performance
provider-request
pull-request
question
roadmap
triage
Milestone
Clear milestone
No items
No milestone
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".
No due date set.
Dependencies
No dependencies set.
Reference
morluto/rea#6147
Loading…
Add table
Add a link
Reference in a new issue
No description provided.
Delete branch "%!s()"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
📋 Pull Request Information
Original PR: https://github.com/morluto/rea/pull/4267
Author: @Y0UW1SH
Created: 10/15/2026
Status: ❌ Closed
Base:
main← Head:fix/4191-go-missing-main-module-limitation📝 Commits (1)
50d4639fix(go): report a missing main-module record as an unknown dependency list📊 Changes
3 files changed (+102 additions, -21 deletions)
View changed files
📝
docs/go-binaries.md(+4 -0)📝
src/go/GoBinaryProvider.ts(+32 -21)📝
tests/boundary/go/goBinaryProvider.test.ts(+66 -0)📄 Description
Status: incorporated upstream
The maintainer incorporated this fix into
mainin a05092726f1283d32b2afe761f430abd2de18386. That commit explicitly references #4191 and #4267 and credits @Y0UW1SH as co-author.The upstream version retains the same missing-main-module condition, improves the wording to distinguish unknown dependency coverage from successfully decoded dependency records, documents parse completeness separately, and adds public CLI Evidence coverage. This draft is superseded; its original implementation does not need another submission.
Verification of the incorporated change
Executed against upstream
d52a488476e7c41f573f23a1965d3f32d4e6a7f2on Linux x64 with the pinned Node 24.18.0/npm 11.16.0 and locked dependencies:npm run test:focused -- tests/boundary/go/goBinaryProvider.test.ts tests/boundary/go/goBinaryMappings.test.ts tests/boundary/go/goBinaryImage.test.ts tests/boundary/go/goModuleText.test.ts tests/boundary/mcp/goBinaryMcp.test.ts tests/acceptance/goBinaryCli.test.ts: runtime build succeeded; all 160 tests passed across six files.npm run checkdid not pass: it stopped on an existing formatting issue insrc/adb/AdbProvider.tson this unchanged upstream checkout. This is unrelated to the Go fix; later check stages are not claimed as passing.Original draft proposal and earlier validation
Summary
inspect_go_binary/inspect-go-binaryreturnedmodule.dependencies: []withmodule.complete: trueand no limitation for Go binaries whose embedded build information has nomodrecord, which is how Debian's dh-golang GOPATH-mode builds (gh,hugo,rclone,restic, …) embed their metadata. An agent or SBOM workflow reads that as "no third-party modules", although those binaries carry dozens of dependencies that the record simply does not list. Evidence for such binaries now carries a limitation stating that the main module and dependency list are unknown, not empty. Fixes #4191.Problem and expected behavior
Trigger: a build-info record whose module text holds a
pathline andbuildsettings but nomod/deplines (GOPATH mode), or an empty module string (moduleless Go 1.12–1.17 builds).GoModuleTextparses both completely, socompleteistrue, andGoBinaryProvideronly added limitations for a missing build-info record, non-UTF-8 strings and incomplete parsing. Nothing marked the dependency list as unknown.Violated invariant: explicit unknowns must stay visible.
docs/go-binaries.mdpromises that unfamiliar, malformed or undecodable records "do not disappear behind a complete result", andAGENTS.mdrequires preserving omission and explicit unknowns across boundaries.Expected:
module.main: nullandmodule.dependencies: []stay as observed, and the result and Evidencelimitationsstate that the main module and dependency list are unknown rather than empty. A module-mode build with amodrecord and nodeplines keeps its genuinely empty list without that limitation.Change and scope
src/go/GoBinaryProvider.ts: the limitations list now comes from alimitationsFor(info, module)helper. It addsNo main-module record was decoded from the embedded module information, as in GOPATH-mode builds; the main module and dependency list are unknown, not empty.whenever parsed module metadata hasmain === null. The existing limitation strings and their conditions are unchanged; moving them into the helper keepsinspectwithin the lint complexity budget it already exceeded (thecomplexitywarning oninspectis gone, the pre-existing one onfailureForPrimaryis untouched).docs/go-binaries.md: documents the behavior.tests/boundary/go/goBinaryProvider.test.ts: regression coverage (below).Intentionally not included: the optional
module_modefield suggested in #4191. It would change theinspect_go_binaryoutput contract and generated catalog, while the limitation delivers the same information within the existing contract.completekeeps its meaning (every module-text line was parsed).GoModuleText.tsis untouched: it reports what the record contains, and the provider owns the statement of what remains unknown, as for the other limitations.Maintainer scope decision: not applicable (ordinary fix within an existing read-only inspection).
Contract and boundary impact
GoBinaryProvider.inspectlimitation assembly, after module-text parsing and before output-schema validation.limitationsarray of the normalized result and of the Evidence.limitationsgain the conditional entry; observed fields, digests and source ranges unchanged.docs/public/product-catalog.json), package, or installation impact: none; limitation strings are not catalog content (metadata:checkpassed insidenpm run check).Expected effects (check known effects; use documentation-only on its own).
Unchecked items do not establish absence; leave uncertainties visible.
Evidence and regression coverage
Tests added or updated:
tests/boundary/go/goBinaryProvider.test.tsgains three cases on authored ELF fixtures fromtests/fixtures/go/image.ts: (1) GOPATH-mode module text (path+buildlines only) and (2) a moduleless legacy pointer-encoded image whose module string header holds a nil pointer and zero length both returnmain: null,dependencies: [],complete: trueand the new limitation; (3) control: a module-mode record withmodand nodeplines keepsdependencies: []with no such limitation.Base reproduction or other evidence: executed. On the base revision
2202e3f0bthe GOPATH-mode case fails with exactly the three fixed limitations and nothing about the dependency list:User-visible CLI/MCP output: built CLI (
node scripts/rea.mjs inspect-go-binary <file> --json, isolatedHOME/XDG_*) on three authored fixtures, exit 0 and empty stderr each time. Printed fields arego_version, themodulerecord (settingsabbreviated to its count) and thelimitationsarray of the returned Evidence.GOPATH-mode fixture (
path+ fivebuildsettings, nomod/dep):Moduleless Go 1.17 fixture (pointer encoding, empty module string):
Control, module mode with no dependencies:
The MCP route shares the provider, and
GoBinaryServicepasses the limitations into the Evidence unchanged;tests/boundary/mcp/goBinaryMcp.test.tskeeps covering that propagation.Remaining proof gaps: no real GOPATH-built binary (the Debian
gh/hugopackages from the issue) was run; the fixtures are authored images from the repository's Go fixture builder that reproduce the record shapego version -mshows for them.npm run verify:go:binaryneeds a Go toolchain and was not run; it compares build information againstdebug/buildinfoand does not assert limitations.For evidence-bearing changes:
Validation performed
Windows 11 x64, Node 24.21.0, npm 11.19.0, locked dependencies (
npm ci), basemainat2202e3f0b.node node_modules/vitest/vitest.mjs run tests/boundary/go/goBinaryProvider.test.tsbefore the fix — 2 new tests failed as shown above, 5 passed, 1 skipped.node node_modules/vitest/vitest.mjs run tests/boundary/go/ tests/boundary/mcp/goBinaryMcp.test.ts— 5 files, 131 passed, 2 skipped.npm run build:cached— passed.node node_modules/vitest/vitest.mjs run tests/acceptance/goBinaryCli.test.tsagainst the rebuilt runtime — 26 passed, 1 skipped.npm run check(typecheck, lint, format, knip, metadata, architecture guards) — passed, 0 lint errors.npx tsc --noEmit— passed.node scripts/verify-test-discovery.mjs—Discovered all 1368 test files exactly once.node scripts/check-doc-facts.mjs— passed.npx oxlint src/go/GoBinaryProvider.ts tests/boundary/go/goBinaryProvider.test.ts— no errors; one pre-existingcomplexitywarning onfailureForPrimary(also present onmain), none oninspectany more.npx oxfmt --check src/go/GoBinaryProvider.ts tests/boundary/go/goBinaryProvider.test.ts docs/go-binaries.md— formatted.npm run verify:go:binary(no Go toolchain), Linux/macOS.Compatibility, safety, and release
verify:go:binarynot run.Author readiness
Human owner: @Y0UW1SH
Before merge
type(scope): outcome.🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.