[PR #4270] [CLOSED] fix(setup): fall back for empty Claude config directory #6149

New issue

Closed

opened 2026-10-31 01:12:14 +00:00 by bsakaguchi · 0 comments

bsakaguchi commented

2026-10-31 01:12:14 +00:00

Owner

📋 Pull Request Information

Original PR: https://github.com/morluto/rea/pull/4270
Author: @pollychen-lab
Created: 10/15/2026
Status: ❌ Closed

Base: main ← Head: agent/claude-empty-config-dir

📝 Commits (2)

3bca1a6 fix(setup): fall back for empty Claude config directory
1b26087 Merge remote-tracking branch 'origin/main' into agent/claude-empty-config-dir

📄 Description

Summary

Fixes #4262. When CLAUDE_CONFIG_DIR="", Claude Code registration setup now falls back to the home directory, matching Claude Code's config selection behavior.

Change

The global .claude.json registration path treats an empty override as unset. Marker and skill path handling remain unchanged. A public CLI regression test covers dry-run target selection, setup, doctor, and uninstall while preserving unrelated config.

Scope and effects

Ordinary setup path fix; no maintainer scope decision applies. Setup reads and updates a local client configuration file. No process launch, injection, network service, or protected-code interaction.

Validation

npm run build:cached — passed.
npm run test:focused -- tests/boundary/cli/clientProfiles.test.ts — passed (15 tests).
npm run check:fast — passed.
Push precheck npm run check:fast — passed.
Real Claude Code process verification was not run; the public CLI lifecycle test uses an isolated home and working directory.

Author readiness

Human owner:

I reviewed the final diff and relevant existing code, understand the change and its edge cases, and take responsibility for the complete PR, including AI-assisted work.
I checked the evidence above, confirmed it supports the current change, and recorded meaningful validation gaps.
I declare this PR ready for initial maintainer review.

Draft per repository PR readiness rules: a human owner must complete these declarations before requesting review.

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/morluto/rea/pull/4270 **Author:** [@pollychen-lab](https://github.com/pollychen-lab) **Created:** 10/15/2026 **Status:** ❌ Closed **Base:** `main` ← **Head:** `agent/claude-empty-config-dir` --- ### 📝 Commits (2) - [`3bca1a6`](https://github.com/morluto/rea/commit/3bca1a68e2dea7c7fbb2f1735334876b21282620) fix(setup): fall back for empty Claude config directory - [`1b26087`](https://github.com/morluto/rea/commit/1b260874dc1f4d13078dbeda954aae6ec5f0e8de) Merge remote-tracking branch 'origin/main' into agent/claude-empty-config-dir ### 📄 Description ## Summary Fixes #4262. When `CLAUDE_CONFIG_DIR=""`, Claude Code registration setup now falls back to the home directory, matching Claude Code's config selection behavior. ## Change The global `.claude.json` registration path treats an empty override as unset. Marker and skill path handling remain unchanged. A public CLI regression test covers dry-run target selection, setup, doctor, and uninstall while preserving unrelated config. ## Scope and effects Ordinary setup path fix; no maintainer scope decision applies. Setup reads and updates a local client configuration file. No process launch, injection, network service, or protected-code interaction. ## Validation - `npm run build:cached` — passed. - `npm run test:focused -- tests/boundary/cli/clientProfiles.test.ts` — passed (15 tests). - `npm run check:fast` — passed. - Push precheck `npm run check:fast` — passed. - Real Claude Code process verification was not run; the public CLI lifecycle test uses an isolated home and working directory. ## Author readiness Human owner:  - [ ] I reviewed the final diff and relevant existing code, understand the change and its edge cases, and take responsibility for the complete PR, including AI-assisted work. - [ ] I checked the evidence above, confirmed it supports the current change, and recorded meaningful validation gaps. - [ ] I declare this PR ready for initial maintainer review. Draft per [repository PR readiness rules](https://github.com/morluto/rea/blob/main/AGENTS.md): a human owner must complete these declarations before requesting review. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>

bsakaguchi

2026-10-31 01:12:14 +00:00

closed this issue
added the
pull-request
label

bsakaguchi referenced this issue

2026-11-01 21:45:50 +00:00

[PR #6149] [MERGED] fix(javascript): preserve source-map preparation capability errors #7164

No milestone

No project

No assignees

1 participant

Notifications

Due date

The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference

morluto/rea#6149

No description provided.

Rows
Columns