[PR #4344] [MERGED] fix(docs): correct Korean README formatting and website translations #6186

Closed
opened 2026-10-31 01:12:32 +00:00 by bsakaguchi · 0 comments
Owner

📋 Pull Request Information

Original PR: https://github.com/morluto/rea/pull/4344
Author: @yeseong0412
Created: 10/16/2026
Status: ✅ Merged
Merged: 10/16/2026
Merged by: @morluto

Base: main ← Head: patch-1


📝 Commits (3)

  • 87bb901 Fix formatting in Korean README file
  • 6aaad47 Fix formatting of REA website link in README_ko.md
  • c8b3ee9 fix(docs): prevent misleading Korean website instructions

📊 Changes

2 files changed (+315 additions, -326 deletions)

View changed files

📝 docs/readme/README_ko.md (+1 -1)
📝 website/locales/ko/messages.po (+314 -325)

📄 Description

Summary

Correct misleading Korean documentation and website translations. The Korean README website link now renders in bold, and 221 Korean website messages preserve the English source's technical meaning, identifiers and evidence.

Problem and expected behavior

The machine-assisted Korean catalog included Git translated as “자식”, IPC as “2015 년”, multiplication × changed to 200, corrupted paths and addresses, missing JDK requirements and license names, and · separators changed to *. The Touhou blog card also had an unreadable description and a broken author/date line.

Korean readers should receive the same instructions and recorded facts as readers of the English source. The Touhou card and article now use 작성자: N0zoM1z0 · 2026년 10월 10일, matching the existing author/date format while preserving each article's original date.

Change and scope

  • Retain the Korean README link-formatting correction in docs/readme/README_ko.md.
  • Correct 221 active translations in website/locales/ko/messages.po, including the 71 entries containing unintended asterisks, related repeated mistranslations, blog metadata, setup instructions, case studies, runtime messages and figure labels.
  • Preserve msgid, msgctxt, named placeholders, comments, flags, source references, catalog metadata and obsolete entries. Only active msgstr values change in the website catalog.
  • Keep English source pages, application behavior, dependencies and generated website output unchanged in Git.

Contract and boundary impact

  • Semantic owner and earliest changed stage: Korean documentation and the website's Korean gettext catalog.
  • Contribution scope fit and linked maintainer decision: Documentation corrections within existing functionality; a separate capability scope decision is not applicable.
  • CLI and MCP/tool-catalog contract: No changes.
  • Provider, bridge, target-format, or platform compatibility: No implementation changes; translations now retain the existing English prerequisites and platform names.
  • Evidence, artifact, provenance, or reconstruction contract: Restore source dates, versions, identifiers, attribution and verification scope in the translation; no new investigation claims.
  • Target selection, authority, upstream behavior, and cleanup details: Not applicable; no target interaction.
  • Generated metadata, package, or installation impact: No committed generated output or package changes.

Expected effects

  • Read existing files or captured data.
  • Launch or attach to a process.
  • Inject instrumentation or run scripts/code.
  • Change process memory, registers, files, or configuration.
  • Contact network services.
  • Recover protected code or work around protections.
  • Documentation or usability only; no target interaction.
  • Not sure yet; investigation or maintainer guidance needed.

Evidence and regression coverage

  • Tests added or updated: None; existing catalog and website checks cover placeholders, inline markup, generated routes, links and assets. Wording was compared with the English source.
  • Base reproduction or other evidence: Source comparison confirmed the mistranslations above. Generated Korean blog pages now display the corrected description and author/date line; the article link was followed in a local browser.
  • User-visible CLI/MCP output: Not applicable.
  • Remaining proof gaps: Browser inspection covered the blog index and Touhou article. Every translated page, mobile width and theme was not manually inspected. Production deployment was not performed.

Validation performed

  • website/.venv/bin/python scripts/website.py translations check --language ko --strict — passed; 1,728/1,728 translated, no missing or fuzzy messages.
  • website/.venv/bin/python scripts/website.py check — passed; prepared 380 reading pages in 20 languages, verified 382 HTML pages and 26,087 local references, and passed all 18 maintenance regression tests. Native Cairo was supplied through the documented local library path.
  • npm run check — passed with the pinned Node.js 24.18.0 / npm 11.16.0 toolchain; typecheck, lint, formatting, dependency/metadata checks, module boundaries and architecture guards passed. Existing lint warnings remain.
  • git diff --check — passed.
  • Catalog comparison — confirmed 221 active msgstr changes, with source strings, contexts, metadata, comments, flags and obsolete translations preserved; no unintended asterisks remain in active translations.
  • Local browser — checked corrected blog-card text and bylines, followed the article link, and confirmed the same author/date format and corrected Pass separator in the article.

Compatibility, safety, and release

  • Breaking changes or migration steps: None.
  • Real Hopper/Ghidra, browser, or OS coverage: Local browser check of the generated Korean blog index and Touhou article. Real provider execution is not applicable to catalog-only changes.
  • Package or release metadata impact: None. The website will use the translations when the reviewed commit is published through the existing website workflow.
  • Security, privacy, process, or containment review: Documentation-only changes; no execution or mutation capabilities added.

Author readiness

Human owner: @yeseong0412

  • I reviewed the final diff and relevant existing code, understand the change and its edge cases, and take responsibility for the complete PR, including AI-assisted work.
  • I checked the evidence above, confirmed it supports the current change, and recorded meaningful validation gaps.
  • I declare this PR ready for initial maintainer review.

Before merge

  • This PR addresses a concrete problem or an agreed enhancement.
  • Material scope and authority questions are resolved, and any required maintainer scope decision covers the final diff.
  • The PR has one focused outcome and the title follows type(scope): outcome.
  • No related issue; these are Korean documentation and translation corrections.
  • Existing catalog and website checks cover the changed documentation format; translation meaning was checked against the English source.
  • The affected documentation has been updated.
  • No user-visible CLI/MCP changes.
  • I checked the final diff for secrets, unrelated cleanup, and unsupported claims.

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/morluto/rea/pull/4344 **Author:** [@yeseong0412](https://github.com/yeseong0412) **Created:** 10/16/2026 **Status:** ✅ Merged **Merged:** 10/16/2026 **Merged by:** [@morluto](https://github.com/morluto) **Base:** `main` ← **Head:** `patch-1` --- ### 📝 Commits (3) - [`87bb901`](https://github.com/morluto/rea/commit/87bb9019277a80fabec063682984b92c4e38e60f) Fix formatting in Korean README file - [`6aaad47`](https://github.com/morluto/rea/commit/6aaad47ffc3e4d2384c9b55a7dc42acba69c50de) Fix formatting of REA website link in README_ko.md - [`c8b3ee9`](https://github.com/morluto/rea/commit/c8b3ee978535caf59d5603626d6f89795a66c207) fix(docs): prevent misleading Korean website instructions ### 📊 Changes **2 files changed** (+315 additions, -326 deletions) <details> <summary>View changed files</summary> 📝 `docs/readme/README_ko.md` (+1 -1) 📝 `website/locales/ko/messages.po` (+314 -325) </details> ### 📄 Description ## Summary Correct misleading Korean documentation and website translations. The Korean README website link now renders in bold, and 221 Korean website messages preserve the English source's technical meaning, identifiers and evidence. ### Problem and expected behavior The machine-assisted Korean catalog included `Git` translated as “자식”, `IPC` as “2015 년”, multiplication `×` changed to `200`, corrupted paths and addresses, missing JDK requirements and license names, and `·` separators changed to `*`. The Touhou blog card also had an unreadable description and a broken author/date line. Korean readers should receive the same instructions and recorded facts as readers of the English source. The Touhou card and article now use `작성자: N0zoM1z0 · 2026년 10월 10일`, matching the existing author/date format while preserving each article's original date. ### Change and scope - Retain the Korean README link-formatting correction in `docs/readme/README_ko.md`. - Correct 221 active translations in `website/locales/ko/messages.po`, including the 71 entries containing unintended asterisks, related repeated mistranslations, blog metadata, setup instructions, case studies, runtime messages and figure labels. - Preserve `msgid`, `msgctxt`, named placeholders, comments, flags, source references, catalog metadata and obsolete entries. Only active `msgstr` values change in the website catalog. - Keep English source pages, application behavior, dependencies and generated website output unchanged in Git. ### Contract and boundary impact - **Semantic owner and earliest changed stage:** Korean documentation and the website's Korean gettext catalog. - **Contribution scope fit and linked maintainer decision:** Documentation corrections within existing functionality; a separate capability scope decision is not applicable. - **CLI and MCP/tool-catalog contract:** No changes. - **Provider, bridge, target-format, or platform compatibility:** No implementation changes; translations now retain the existing English prerequisites and platform names. - **Evidence, artifact, provenance, or reconstruction contract:** Restore source dates, versions, identifiers, attribution and verification scope in the translation; no new investigation claims. - **Target selection, authority, upstream behavior, and cleanup details:** Not applicable; no target interaction. - **Generated metadata, package, or installation impact:** No committed generated output or package changes. ### Expected effects - [ ] Read existing files or captured data. - [ ] Launch or attach to a process. - [ ] Inject instrumentation or run scripts/code. - [ ] Change process memory, registers, files, or configuration. - [ ] Contact network services. - [ ] Recover protected code or work around protections. - [x] Documentation or usability only; no target interaction. - [ ] Not sure yet; investigation or maintainer guidance needed. ### Evidence and regression coverage - **Tests added or updated:** None; existing catalog and website checks cover placeholders, inline markup, generated routes, links and assets. Wording was compared with the English source. - **Base reproduction or other evidence:** Source comparison confirmed the mistranslations above. Generated Korean blog pages now display the corrected description and author/date line; the article link was followed in a local browser. - **User-visible CLI/MCP output:** Not applicable. - **Remaining proof gaps:** Browser inspection covered the blog index and Touhou article. Every translated page, mobile width and theme was not manually inspected. Production deployment was not performed. ### Validation performed - `website/.venv/bin/python scripts/website.py translations check --language ko --strict` — passed; 1,728/1,728 translated, no missing or fuzzy messages. - `website/.venv/bin/python scripts/website.py check` — passed; prepared 380 reading pages in 20 languages, verified 382 HTML pages and 26,087 local references, and passed all 18 maintenance regression tests. Native Cairo was supplied through the documented local library path. - `npm run check` — passed with the pinned Node.js 24.18.0 / npm 11.16.0 toolchain; typecheck, lint, formatting, dependency/metadata checks, module boundaries and architecture guards passed. Existing lint warnings remain. - `git diff --check` — passed. - Catalog comparison — confirmed 221 active `msgstr` changes, with source strings, contexts, metadata, comments, flags and obsolete translations preserved; no unintended asterisks remain in active translations. - Local browser — checked corrected blog-card text and bylines, followed the article link, and confirmed the same author/date format and corrected Pass separator in the article. ### Compatibility, safety, and release - **Breaking changes or migration steps:** None. - **Real Hopper/Ghidra, browser, or OS coverage:** Local browser check of the generated Korean blog index and Touhou article. Real provider execution is not applicable to catalog-only changes. - **Package or release metadata impact:** None. The website will use the translations when the reviewed commit is published through the existing website workflow. - **Security, privacy, process, or containment review:** Documentation-only changes; no execution or mutation capabilities added. ### Author readiness **Human owner:** @yeseong0412 - [x] I reviewed the final diff and relevant existing code, understand the change and its edge cases, and take responsibility for the complete PR, including AI-assisted work. - [x] I checked the evidence above, confirmed it supports the current change, and recorded meaningful validation gaps. - [x] I declare this PR ready for initial maintainer review. ### Before merge - [x] This PR addresses a concrete problem or an agreed enhancement. - [x] Material scope and authority questions are resolved, and any required maintainer scope decision covers the final diff. - [x] The PR has one focused outcome and the title follows type(scope): outcome. - [x] No related issue; these are Korean documentation and translation corrections. - [x] Existing catalog and website checks cover the changed documentation format; translation meaning was checked against the English source. - [x] The affected documentation has been updated. - [x] No user-visible CLI/MCP changes. - [x] I checked the final diff for secrets, unrelated cleanup, and unsupported claims. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
bsakaguchi 2026-10-31 01:12:32 +00:00
bsakaguchi changed title from [PR #4344] [MERGED] fix(docs): correct Korean README formatting and website translations to [PR #4344] fix(docs): correct Korean README formatting and website translations 2026-11-03 13:32:08 +00:00
bsakaguchi changed title from [PR #4344] fix(docs): correct Korean README formatting and website translations to [PR #4344] [MERGED] fix(docs): correct Korean README formatting and website translations 2026-11-03 14:33:51 +00:00
Sign in to join this conversation.
No milestone
No project
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference
morluto/rea#6186
No description provided.