[PR #4354] [MERGED] test(adb): cover staged APK names and evidence identity #6199

New issue

Closed

opened 2026-10-31 01:12:37 +00:00 by bsakaguchi · 0 comments

bsakaguchi commented

2026-10-31 01:12:37 +00:00

Owner

📋 Pull Request Information

Original PR: https://github.com/morluto/rea/pull/4354
Author: @ShuaixinHuang
Created: 10/16/2026
Status: ✅ Merged
Merged: 10/16/2026
Merged by: @N0zoM1z0

Base: main ← Head: codex/test-adb-staged-install-identity

📝 Commits (2)

f319ede test(adb): verify staged APK identity in reinstall CLI coverage
f0c8c89 Merge remote-tracking branch 'origin/main' into HEAD

📊 Changes

1 file changed (+11 additions, -3 deletions)

View changed files

📝 tests/boundary/cli/adbCli.test.ts (+11 -3)

📄 Description

Summary

Strengthen the adb reinstall CLI regression for a staged APK whose basename contains spaces. The simulated adb compares each consumed snapshot's bytes to the caller file; assertions check the preserved basename, caller path/size/SHA-256 in Evidence, unique snapshot directories and cleanup. Fresh/replacement/fresh ordering, exact -r choices and replaced: null remain covered.

Upstream 1b97b0f already fixed the stale original-path expectation. After merging main 8ab5024, this PR retains only the additional filename/Evidence identity coverage instead of duplicating that fix. Conflict resolution keeps upstream's per-install byte comparison and snapshot-cleanup checks.

One test file; no production, workflow, timeout, retry or skip changes. The fake adb does not contact a device.

Executed evidence

Synchronized head: f0c8c89. Pinned Windows Node 24.18.0/npm 11.16.0, matching locked dependencies.

npm run test:focused -- tests/boundary/cli/adbCli.test.ts: 10 passed / 2 existing POSIX cases skipped. The enhanced reinstall case is one of the platform skips; it is not locally verified. No Linux WSL distribution is available.
npm run check: 6/6 tasks and architecture guards passed. git diff --check passed.
Prior-head Linux CI had shared browser cancellation/discovery failures; current main contains those fixes and they passed local regression checks. Current-head Linux CI passed, including all five shards and the required aggregate. Shard 5/5 executed adbCli.test.ts: 12/12 passed, including the enhanced reinstall case.

No real device/install behavior is claimed. The human owner explicitly declared initial readiness after reviewing the final scope and validation evidence.

Author readiness

Human owner: @ShuaixinHuang

I reviewed the final diff and relevant existing code, understand the change and its edge cases, and take responsibility for the complete PR, including AI-assisted work.
I checked the evidence above, confirmed it supports the current change, and recorded meaningful validation gaps.
I declare this PR ready for initial maintainer review.

Before merge

Focused staged-input filename and Evidence identity coverage, extending the merged upstream fix.
Existing install-mode and uncertainty assertions retained; no workflow or skip weakened.
Executed validation and unavailable POSIX/device coverage reported.
Human owner declares initial readiness.
Changed POSIX scenario and required current-head CI pass.

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/morluto/rea/pull/4354 **Author:** [@ShuaixinHuang](https://github.com/ShuaixinHuang) **Created:** 10/16/2026 **Status:** ✅ Merged **Merged:** 10/16/2026 **Merged by:** [@N0zoM1z0](https://github.com/N0zoM1z0) **Base:** `main` ← **Head:** `codex/test-adb-staged-install-identity` --- ### 📝 Commits (2) - [`f319ede`](https://github.com/morluto/rea/commit/f319edeff068643fc7efa5219eeacac7eaeb7ce5) test(adb): verify staged APK identity in reinstall CLI coverage - [`f0c8c89`](https://github.com/morluto/rea/commit/f0c8c8948d569dfcb9674b211ace71fa064a4f19) Merge remote-tracking branch 'origin/main' into HEAD ### 📊 Changes **1 file changed** (+11 additions, -3 deletions) <details> <summary>View changed files</summary> 📝 `tests/boundary/cli/adbCli.test.ts` (+11 -3) </details> ### 📄 Description ## Summary Strengthen the adb reinstall CLI regression for a staged APK whose basename contains spaces. The simulated adb compares each consumed snapshot's bytes to the caller file; assertions check the preserved basename, caller path/size/SHA-256 in Evidence, unique snapshot directories and cleanup. Fresh/replacement/fresh ordering, exact `-r` choices and `replaced: null` remain covered. Upstream `1b97b0f` already fixed the stale original-path expectation. After merging main `8ab5024`, this PR retains only the additional filename/Evidence identity coverage instead of duplicating that fix. Conflict resolution keeps upstream's per-install byte comparison and snapshot-cleanup checks. One test file; no production, workflow, timeout, retry or skip changes. The fake adb does not contact a device. ## Executed evidence Synchronized head: `f0c8c89`. Pinned Windows Node 24.18.0/npm 11.16.0, matching locked dependencies. - `npm run test:focused -- tests/boundary/cli/adbCli.test.ts`: **10 passed / 2 existing POSIX cases skipped**. The enhanced reinstall case is one of the platform skips; it is not locally verified. No Linux WSL distribution is available. - `npm run check`: **6/6 tasks and architecture guards passed**. `git diff --check` passed. - Prior-head Linux CI had shared browser cancellation/discovery failures; current main contains those fixes and they passed local regression checks. Current-head [Linux CI passed](https://github.com/morluto/rea/actions/runs/38855292907), including all five shards and the required aggregate. [Shard 5/5](https://github.com/morluto/rea/actions/runs/38855292907/job/116826432924) executed adbCli.test.ts: **12/12 passed**, including the enhanced reinstall case. No real device/install behavior is claimed. The human owner explicitly declared initial readiness after reviewing the final scope and validation evidence. ## Author readiness Human owner: @ShuaixinHuang - [x] I reviewed the final diff and relevant existing code, understand the change and its edge cases, and take responsibility for the complete PR, including AI-assisted work. - [x] I checked the evidence above, confirmed it supports the current change, and recorded meaningful validation gaps. - [x] I declare this PR ready for initial maintainer review. ## Before merge - [x] Focused staged-input filename and Evidence identity coverage, extending the merged upstream fix. - [x] Existing install-mode and uncertainty assertions retained; no workflow or skip weakened. - [x] Executed validation and unavailable POSIX/device coverage reported. - [x] Human owner declares initial readiness. - [x] Changed POSIX scenario and required current-head CI pass. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>

bsakaguchi

2026-10-31 01:12:37 +00:00