[PR #4361] [CLOSED] feat(clients): add support for Froe client #6203

New issue

Closed

opened 2026-10-31 01:12:39 +00:00 by bsakaguchi · 0 comments

bsakaguchi commented

2026-10-31 01:12:39 +00:00

Owner

📋 Pull Request Information

Original PR: https://github.com/morluto/rea/pull/4361
Author: @xfq
Created: 10/16/2026
Status: ❌ Closed

Base: main ← Head: froe

📝 Commits (1)

fb84b5c feat(clients): add support for Froe client

📊 Changes

7 files changed (+157 additions, -2 deletions)

View changed files

📝 .agents/skills/reverse-engineer-anything/SKILL.md (+1 -1)
📝 .agents/skills/reverse-engineer-anything/references/connection-and-recovery.md (+1 -1)
📝 docs/client-configuration.md (+10 -0)
📝 docs/installation.md (+1 -0)
📝 src/application/SupportedClients.ts (+10 -0)
📝 tests/boundary/cli/clientProfiles.test.ts (+133 -0)
📝 tests/boundary/filesystem/clientLifecycle.test.ts (+1 -0)

📄 Description

Summary

Add Froe support to REA’s setup, doctor, and uninstall workflows.

Problem and expected behavior

REA did not recognize froe as a supported client. Users should be able to run rea setup --client froe to register the MCP server and install its skill using Froe’s configuration locations.

Change and scope

Add Froe to the shared client definitions using the existing JSON configuration adapter:

Setting	Value
Client ID	`froe`
Configuration	`$XDG_CONFIG_HOME/froe/config.json`, defaulting to `~/.config/froe/config.json` when unset or empty
MCP entry	`mcpServers.rea`
Skill destination	`~/.froe/skills/reverse-engineer-anything/`
Package-runner command	`npx -y rea-agents@<pinned-version> mcp`

Update installation documentation and authored skill client lists. Existing workflows provide backups, repeat-safe setup, registration checks, and uninstall cleanup.

Contract and boundary impact

Semantic owner and earliest changed stage: SupportedClients.ts, during client discovery and path resolution.
Contribution scope fit and linked maintainer decision: Ordinary client integration within existing configuration boundaries; target-execution scope decision not applicable.
CLI and MCP/tool-catalog contract: Adds froe as a client selection; no MCP tool schema changes.
Provider, bridge, target-format, or platform compatibility: Uses the existing JSON adapter; no analysis-provider changes.
Evidence, artifact, provenance, or reconstruction contract: Unchanged.
Target selection, authority, upstream behavior, and cleanup details: No reverse-engineering target interaction. Existing setup approval, backup, and managed cleanup behavior applies.
Generated metadata, package, or installation impact: Adds a client configuration location and skill destination. Authored skill instructions updated and generated skill metadata checked; no build outputs included.

Expected effects:

Read existing files or captured data.
Launch or attach to a process.
Inject instrumentation or run scripts/code.
Change process memory, registers, files, or configuration.
Contact network services.
Recover protected code or work around protections.
Documentation or usability only; no target interaction.
Not sure yet; investigation or maintainer guidance needed.

Reads and writes concern client configuration and managed skills. Process launch and network access apply when Froe starts the registered npx server.

Evidence and regression coverage

Tests added or updated: CLI lifecycle coverage for unset, empty, and custom XDG_CONFIG_HOME; client discovery expectations include Froe.
Base reproduction or other evidence: Source inspection established the missing client definition. No base-revision runtime reproduction was performed.
User-visible CLI/MCP output: Executed CLI tests observed setup status: "ready", repeat setup with appliedActions: [], doctor registration and skill states of "aligned", and uninstall status: "complete".
Remaining proof gaps: Upstream retrieval failed. Configuration expectations follow the supplied integration contract; live Froe loading and MCP connection were not tested.

The tests verify pinned package-runner registration, the fixed skill destination, dry-run behavior, backup preservation, unrelated settings, repeat setup, doctor, and uninstall.

For evidence-bearing changes: not applicable; this change does not alter analysis Evidence.

Observed, derived, and inferred claims remain distinguishable.
Artifact identity, source provenance, and failed attempts remain preserved.
Unsupported, incomplete, unavailable, or uncertain outcomes remain visible.

Validation performed

npm run test:focused -- tests/boundary/cli/clientProfiles.test.ts tests/boundary/filesystem/clientLifecycle.test.ts — passed, 74 tests across two files.
npm run check:fast — passed type and lint checks.
node scripts/generate-skill-metadata.mjs --check — passed.
oxfmt --check on changed source, test, and documentation files — passed; the subsequent test adjustment was formatted.
git diff --check — passed.

Compatibility, safety, and release

Breaking changes or migration steps: None; additive client support.
Real Hopper/Ghidra, browser, or OS coverage: CLI and filesystem tests ran on macOS. Live Froe, Windows, and Linux execution remain unverified; no analysis-provider behavior changed.
Package or release metadata impact: No version bump or dependency changes. Froe support becomes available in a release containing this change.
Security, privacy, process, or containment review: Reuses existing approval, backup, configuration preservation, and managed cleanup boundaries. No personal Froe configuration was modified during implementation.

Author readiness

Human owner: @xfq

I reviewed the final diff and relevant existing code, understand the change and its edge cases, and take responsibility for the complete PR, including AI-assisted work.
I checked the evidence above, confirmed it supports the current change, and recorded meaningful validation gaps.
I declare this PR ready for initial maintainer review.

Before merge

This PR addresses a concrete problem or an agreed enhancement.
Material scope and authority questions are resolved, and any required maintainer scope decision covers the final diff.
The PR has one focused outcome and the title follows type(scope): outcome.
Related issue is linked, or the reason for not linking one is stated above.
Tests cover changed observable behavior and meaningful failure paths.
Owning docs, contracts, and generated metadata are updated where needed.
User-visible CLI/MCP changes include representative output.
I checked the final diff for secrets, unrelated cleanup, and unsupported claims.

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/morluto/rea/pull/4361 **Author:** [@xfq](https://github.com/xfq) **Created:** 10/16/2026 **Status:** ❌ Closed **Base:** `main` ← **Head:** `froe` --- ### 📝 Commits (1) - [`fb84b5c`](https://github.com/morluto/rea/commit/fb84b5c0d05bdfe5158e21c63b4411b160845ab8) feat(clients): add support for Froe client ### 📊 Changes **7 files changed** (+157 additions, -2 deletions) <details> <summary>View changed files</summary> 📝 `.agents/skills/reverse-engineer-anything/SKILL.md` (+1 -1) 📝 `.agents/skills/reverse-engineer-anything/references/connection-and-recovery.md` (+1 -1) 📝 `docs/client-configuration.md` (+10 -0) 📝 `docs/installation.md` (+1 -0) 📝 `src/application/SupportedClients.ts` (+10 -0) 📝 `tests/boundary/cli/clientProfiles.test.ts` (+133 -0) 📝 `tests/boundary/filesystem/clientLifecycle.test.ts` (+1 -0) </details> ### 📄 Description ## Summary Add [Froe](https://github.com/xfq/froe) support to REA’s setup, doctor, and uninstall workflows. ## Problem and expected behavior REA did not recognize `froe` as a supported client. Users should be able to run `rea setup --client froe` to register the MCP server and install its skill using Froe’s configuration locations. ## Change and scope Add Froe to the shared client definitions using the existing JSON configuration adapter: | Setting | Value | |---|---| | Client ID | `froe` | | Configuration | `$XDG_CONFIG_HOME/froe/config.json`, defaulting to `~/.config/froe/config.json` when unset or empty | | MCP entry | `mcpServers.rea` | | Skill destination | `~/.froe/skills/reverse-engineer-anything/` | | Package-runner command | `npx -y rea-agents@<pinned-version> mcp` | Update installation documentation and authored skill client lists. Existing workflows provide backups, repeat-safe setup, registration checks, and uninstall cleanup. ## Contract and boundary impact - Semantic owner and earliest changed stage: `SupportedClients.ts`, during client discovery and path resolution. - Contribution scope fit and linked maintainer decision: Ordinary client integration within existing configuration boundaries; target-execution scope decision not applicable. - CLI and MCP/tool-catalog contract: Adds `froe` as a client selection; no MCP tool schema changes. - Provider, bridge, target-format, or platform compatibility: Uses the existing JSON adapter; no analysis-provider changes. - Evidence, artifact, provenance, or reconstruction contract: Unchanged. - Target selection, authority, upstream behavior, and cleanup details: No reverse-engineering target interaction. Existing setup approval, backup, and managed cleanup behavior applies. - Generated metadata, package, or installation impact: Adds a client configuration location and skill destination. Authored skill instructions updated and generated skill metadata checked; no build outputs included. Expected effects: - [x] Read existing files or captured data. - [x] Launch or attach to a process. - [ ] Inject instrumentation or run scripts/code. - [x] Change process memory, registers, files, or configuration. - [x] Contact network services. - [ ] Recover protected code or work around protections. - [ ] Documentation or usability only; no target interaction. - [ ] Not sure yet; investigation or maintainer guidance needed. Reads and writes concern client configuration and managed skills. Process launch and network access apply when Froe starts the registered `npx` server. ## Evidence and regression coverage - Tests added or updated: CLI lifecycle coverage for unset, empty, and custom `XDG_CONFIG_HOME`; client discovery expectations include Froe. - Base reproduction or other evidence: Source inspection established the missing client definition. No base-revision runtime reproduction was performed. - User-visible CLI/MCP output: Executed CLI tests observed setup `status: "ready"`, repeat setup with `appliedActions: []`, doctor registration and skill states of `"aligned"`, and uninstall `status: "complete"`. - Remaining proof gaps: Upstream retrieval failed. Configuration expectations follow the supplied integration contract; live Froe loading and MCP connection were not tested. The tests verify pinned package-runner registration, the fixed skill destination, dry-run behavior, backup preservation, unrelated settings, repeat setup, doctor, and uninstall. For evidence-bearing changes: not applicable; this change does not alter analysis Evidence. - [ ] Observed, derived, and inferred claims remain distinguishable. - [ ] Artifact identity, source provenance, and failed attempts remain preserved. - [ ] Unsupported, incomplete, unavailable, or uncertain outcomes remain visible. ## Validation performed - `npm run test:focused -- tests/boundary/cli/clientProfiles.test.ts tests/boundary/filesystem/clientLifecycle.test.ts` — passed, 74 tests across two files. - `npm run check:fast` — passed type and lint checks. - `node scripts/generate-skill-metadata.mjs --check` — passed. - `oxfmt --check` on changed source, test, and documentation files — passed; the subsequent test adjustment was formatted. - `git diff --check` — passed. ## Compatibility, safety, and release - Breaking changes or migration steps: None; additive client support. - Real Hopper/Ghidra, browser, or OS coverage: CLI and filesystem tests ran on macOS. Live Froe, Windows, and Linux execution remain unverified; no analysis-provider behavior changed. - Package or release metadata impact: No version bump or dependency changes. Froe support becomes available in a release containing this change. - Security, privacy, process, or containment review: Reuses existing approval, backup, configuration preservation, and managed cleanup boundaries. No personal Froe configuration was modified during implementation. ## Author readiness Human owner: @xfq - [x] I reviewed the final diff and relevant existing code, understand the change and its edge cases, and take responsibility for the complete PR, including AI-assisted work. - [x] I checked the evidence above, confirmed it supports the current change, and recorded meaningful validation gaps. - [x] I declare this PR ready for initial maintainer review. ## Before merge - [ ] This PR addresses a concrete problem or an agreed enhancement. - [ ] Material scope and authority questions are resolved, and any required maintainer scope decision covers the final diff. - [ ] The PR has one focused outcome and the title follows `type(scope): outcome`. - [ ] Related issue is linked, or the reason for not linking one is stated above. - [ ] Tests cover changed observable behavior and meaningful failure paths. - [ ] Owning docs, contracts, and generated metadata are updated where needed. - [ ] User-visible CLI/MCP changes include representative output. - [ ] I checked the final diff for secrets, unrelated cleanup, and unsupported claims. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>

bsakaguchi

2026-10-31 01:12:39 +00:00