mirror of
https://github.com/morluto/rea.git
synced 2026-11-05 06:45:22 +00:00
[PR #4365] [CLOSED] fix(domain): stop reporting a named-versus-unnamed reference endpoint as a change #6206
Closed
opened 2026-10-31 01:12:41 +00:00 by bsakaguchi
·
0 comments
No Branch/Tag specified
main
codex/procedure-reference-stacked
release-please--branches--main--components--rea-agents
release-please--branches--main--components--rea-agents--release-notes
codex/kuna-independent-retry
codex/byte-search-overlay-coverage
codex/open-failure-target-receipt
codex/kuna-xref-evidence
codex/ghidra-ambiguous-procedure-recovery
codex/function-source-bundle
codex/trace-function-integration-prototype
codex/snapshot-source-closure
codex/recorded-evidence-array-pages
codex/evidence-recovery-redesign
codex/trace-feature-address-scope
codex/call-discovery-scope
codex/ghidra-literal-candidate-evidence
codex/decompile-directory-independent-retry
codex/retry-provenance-base
codex/value-flow-capability-experiment
codex/ghidra-containing-instruction
cursor/readme-discord-button-ef9f
dependabot/github_actions/actions/setup-node-7.1.0
dependabot/github_actions/actions/upload-artifact-7.0.2
dependabot/npm_and_yarn/npm-minor-and-patch-d8d97ce6df
codex/kuna-1989
fix/8559-native-ui-fixture-ownership
fix/8555-go-verifier-mcp-ownership
codex/provider-capability-recovery
fix/8642-rizin-target-stdin
codex/ghidra-memory-effect-scope
codex/ghidra-annotation-entry-selector
codex/ghidra-readonly-recovery
codex/ghidra-regex-verifier-recovery
codex/evidence-discovery-view-guidance
fix/8545-bulk-append-overflow
fix/8428-navigation-refusal-alternatives
codex/address-context-recovery
codex/matching-member-limitations
codex/unknown-scope-contract
codex/evidence-view-guidance
feat/8373-native-trace-views
codex/ghidra-snapshot-verifier-binding
codex/elf-export-visibility
codex/evidence-view-recovery
codex/native-reference-cli-help
codex/provider-candidate-observation-scope
codex/kuna-session-verification
codex/ghidra-switch-lifetime-guidance
codex/pseudocode-paging-discovery
codex/clarify-evidence-view-support
codex/kuna-xrefs-selector-recovery
codex/context-capacity-recovery
codex/evidence-closure-large-links
codex/same-function-evidence-identity
codex/ghidra-verifier-inspected-jdk
codex/audit-guided-workflows
codex/crash-prompt-retained-dossiers
codex/analysis-view-error-recovery
codex/kuna-verifier-target-selection
codex/ghidra-selected-project-call-coverage
codex/docs-native-analysis-scope
codex/ghidra-java-socket-boundary
codex/ghidra-retained-snapshot-verifier
codex/ghidra-search-inventory-facts
fix/8284-zero-argument-parameter-bindings
fix/8198-ui-action-handler-offset
fix/8257-elf-entry-label-identity
fix/8304-deferred-output-schema-projection
fix/8277-call-path-computed-target-uncertainty
fix/pr-8089-conflicts
fix/ci-static-duplicate-export
dependabot/npm_and_yarn/lint-staged-17.6.0
dependabot/github_actions/actions/download-artifact-8.0.2
dependabot/npm_and_yarn/write-file-atomic-8.0.0
dependabot/npm_and_yarn/canonicalize-5.1.0
dependabot/github_actions/actions/cache/restore-6.1.0
dependabot/npm_and_yarn/toon-format/toon-4.4.0
dependabot/github_actions/actions/deploy-pages-5.0.1
codex/review-fixes-pr-2403
codex/review-fixes-pr-2400
codex/process-terminal-width
codex/test-brittleness-cleanup
verify/7167-browser-connect-macos
fix/7167-browser-connect
feat/native-matching-allowance-setting
feat/browser-scenario-dry-run
test/managed-caller-parameters-20261024
codex/parser-fortythird-boundaries
fix/6926-pinvoke-platform-decorations-20261023
fix/6889-har-body-encoding-20261023
fix/6888-sqlite-schema-budget-20261023
fix/dependency-security-gates-6708
cursor/evidence-overwrite-rebase-b4ac
feat/4057-verify-native-exports
fix/windows-acl-observer-overhead-20261022
cursor/erlang-beam-restack-4476
cursor/pe-certificate-review-bf32
fix/6116-javascript-application-fs-errors
fix/6061-unmapped-runtime-script-unknown
feat/browser-scenario-summary
fix/pe-certificates
codex/verify-3407
cursor/rebase-5699
cursor/rebase-5352
cursor/rebase-5600
cursor/fix-cli-schema-omission-10a8
codex/audit-hopper-shutdown-reasons-20261021
fix/demangle-swift-omitted-record
fix/nib-boolean-value-types
cursor/cancellation-partial-observation-a5ac
fix/ib-object-limit-reasons
fix/electron-fuse-limit-advice
fix/kuna-doctor-dangling-cache
fix/fixed-budget-refusal-advice
fix/js-ipc-listener-dedup
fix/js-return-member-provenance
fix/dmg-integrity-retry-advice
fix/ida-doctor-readiness
fix/kuna-version-probe-output-drain
fix/legacy-swift-runtime-name-matching
fix/dylib-lazy-load-commands
fix/browser-scenario-startup-cancel
fix/swift-nested-punycode-classification
fix/compare-unselected-scopes
fix/objc-method-budget-coverage
fix/dmg-mounted-root-observations
audit/ci-tests-20261019-round2
release/6.7.0
fix/wabt-cleanup-retry-resolution
fix/electron-fuse-elf-pe-architecture
fix/native-plist-descriptor-ownership
fix/kuna-caller-cleanup-ownership
experiment/atomic-codemode-20261016
review/first-contributor-3776
fix/call-resolution-full-read-cycles
fix/member-mutation-selection-repeat
experiment/atomic-re-tools-20261015
perf/member-mutation-lazy-origins
perf/static-network-mutation-index
fix/hopper-startup-lifecycle
audit/3050-windows-proof-20261015
feat/windows-window-capture-2183
audit/3049-windows-proof-20261015
audit/3735-macos-fixtures-20261015
fix/batch-decompile-null-pseudocode
fix/kuna-inventory-honors-jobs
experiment/browser-codemode-tool-design-20261015
fix/hopper-clean-runtime-argv
codex/review-2049-27f1b367
review-fixes/pr-2787-routing
fix/3360-scoped-this-emitters
fix/3367-replaced-global-effects
fix/3838-compact-any-value-items
test/hopper-download-probe-20261015
codex/windows-runtime-creation-red-green-20261015
codex/windows-readonly-root-red-green-20261015
codex/windows-root-share-red-green-20261015
codex/exp-1685-win-mcp-startup
codex/bug-sweep-20261015
investigate/2190-windows-package-phases
investigate/3543-macos-cli-deadline
perf/3281-reverse-tools-feedback-quality
fix/3406-hopper-doctor-fixture
fix/3341-wrapper-require-test-context
fix/3301-owned-uninstall-fixtures
fix/3164-compiler-input-ownership
fix/pcap-cleanup-stdout-newline-20261014
perf/interface-builder-summary
codex/review-fixes-pr-1977
fix/ghidra-effective-jvm-platform
fix/docs-turkish-rust-link-20261013
fix/main-maintenance-ci-20261010
fix/recover-binary-session-process-effects
codex/review-fixes-pr-2457
codex/ci-required-cancellation-gate
fix/main-format-baseline-20261013
fix/setup-preserve-entry-fields
cursor/restore-main-checks-1ffc
fix/ghidra-bridge-hashmap-import
codex/shared-ci-jadx-json-default-20261013
codex/shared-ci-ghidra-test-groups-20261013
codex/shared-ci-java-fixture-format-20261013
codex/fix-intrinsic-invocation-boundaries
test/release-preflight-reusable-jobs
test/js-parameter-provenance-expectation
fix/linux-hopper-verification-current
test/2419-ghidra-elf-probe-size
followup/pr-1544-native-ida
codex/fold-pr-2230-contribution
docs/readme-responsible-use
fix/issue-2064
fix/issue-2050
fix/issue-2053
fix/issue-1968
fix/issue-1945
experiment/codemode-bridge-20261011
fix/tool-effects-negative-wording-1904-20261012
fix/1842-electron-interop-provenance
feat/recover-javascript-multi-input
refactor/website-i18n-prep
fix/nativeaot-pe-virtual-extent
fix/browser-verifier-ci-hang
fix/pe-resources-input-selection
docs/beginner-friendly-guides
docs/beginner-setup-guide
fix/javascript-analysis-worker-1563
fix/1649-ghidra-duplicate-names
fix/javascript-export-keys-integration-1369
test/maintenance-boundary-contracts-20261011
review/javascript-export-keys-1369
review/process-live-progress-1483
test/javascript-1495-growth-ratio
fix/ci-escape-timing
docs/normalized-terminal-geometry-1450
release/6.3.0
archive/release-6.3.0-pr1381
release/6.2.0
fix/electron-preload-dynamic-override
fix/javascript-self-referential-bundler-edges
release/6.1.0
cursor/grok-client-cherry-pick-0b56
feat/signature-posture
feat/dyld-shared-cache
feat/artifact-integrity-policy
feat/pkg-inventory
release/6.0.0
chore/sync-release-5.0.0
release/5.0.0
cursor/cloud-agent-node-787e
fix/javascript-xhr-open-endpoints
review/pr-711-realpath-fallback-wording
cleanup/replay-confinement
codex/test-suite-performance
codex/issue-foundations
codex/address-open-issues-2026-07-20
agent/javascript-vite-rollup-esbuild-adapters
agent/process-cleanup
agent/triage-integration
agent/unknown-commands-registry
feat/mcp-identity-metadata
morlvps/issue_cleanup
codex/installer-redesign
morl/roadmap-investigation-core
morl/roadmap-investigation-docs
release-please--branches--main--components--rea
rea-agents-6.8.0
rea-agents-6.7.0
rea-agents-6.6.0
experiment/atomic-codemode-wait-runtime-20261016
rea-agents-6.5.0
rea-agents-6.4.0
rea-agents-6.3.0
rea-agents-6.2.0
rea-agents-6.1.0
rea-agents-6.0.0
rea-agents-5.0.0
rea-agents-4.1.0
rea-agents-4.0.1
rea-agents-4.0.0
rea-agents-3.2.1
rea-agents-3.2.0
rea-agents-3.1.0
rea-agents-3.0.0
rea-agents-2.7.0
rea-agents-2.6.0
rea-agents-2.5.1
rea-agents-2.5.0
rea-agents-2.4.0
rea-agents-2.3.0
rea-agents-2.2.0
rea-agents-2.1.0
rea-agents-2.0.0
rea-agents-1.7.0
rea-agents-1.6.0
rea-agents-1.5.0
rea-agents-1.4.0
rea-agents-1.3.0
rea-agents-1.2.0
rea-agents-1.1.0
rea-agents-1.0.0
rea-agents-0.5.0
rea-agents-0.4.0
rea-agents-0.3.0
rea-0.2.1
rea-0.2.0
Labels
Clear labels
area: bridge
area: bridge
area: build
area: build
area: build
area: cli
area: domain
area: evidence
area: mcp
area: native
area: providers
area: runtime
area: server
area: setup
area: tests
bug
design
documentation
enhancement
enhancement
enhancement
experiment
help wanted
i18n
invalid
P0: critical
P1: high
P2: medium
P2: medium
P2: medium
P3: low
performance
provider-request
pull-request
Mirrored from GitHub Pull Request
question
roadmap
triage
No labels
area: bridge
area: bridge
area: build
area: build
area: build
area: cli
area: domain
area: evidence
area: mcp
area: native
area: providers
area: runtime
area: server
area: setup
area: tests
bug
design
documentation
enhancement
enhancement
enhancement
experiment
help wanted
i18n
invalid
P0: critical
P1: high
P2: medium
P2: medium
P2: medium
P3: low
performance
provider-request
pull-request
question
roadmap
triage
Milestone
Clear milestone
No items
No milestone
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".
No due date set.
Dependencies
No dependencies set.
Reference
morluto/rea#6206
Loading…
Add table
Add a link
Reference in a new issue
No description provided.
Delete branch "%!s()"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
📋 Pull Request Information
Original PR: https://github.com/morluto/rea/pull/4365
Author: @Henglie
Created: 10/16/2026
Status: ❌ Closed
Base:
main← Head:fix/reference-endpoint-asymmetry📝 Commits (3)
ca8e524fix(domain): stop reporting a named-versus-unnamed reference endpoint as a change9b25ec1fix(domain): match reference edges by identity, not by sort positionfd08c24fix(domain): pair reference edges by perfect matching, not greedily📊 Changes
4 files changed (+533 additions, -32 deletions)
View changed files
📝
src/domain/functionComparison.test.ts(+242 -0)📝
src/domain/functionComparisonDimensions.ts(+52 -15)📝
src/domain/functionComparisonNormalization.ts(+37 -17)➕
src/domain/functionComparisonReferenceMatching.ts(+202 -0)📄 Description
Summary
compare_functionsreportedreferences: changedwhen one record resolved areference target to a procedure name and the other left it unresolved, even
though no known reference kind or named target differed. The same false
endpoint-change conclusion appeared within one artifact when both records
identified the same target address and only one supplied a procedure record. In
verify_reconstructionthe first result became a definitefail.The reference comparison now distinguishes a known difference from a knowledge
asymmetry, and the edge-kind projection no longer carries endpoint identity.
Fixes #4210.
Problem and expected behavior
compareReferencescompared the two endpoint projections with canonical JSONequality and reported any difference as
changed. A projection entry is aprocedure name when the record resolved one, an address when it did not and the
artifacts are the same, and
nullwhen it did not and the artifacts differ. So"helper" against
null, and "helper" against{address}at the same address,both read as differing endpoints even though one side simply recorded less.
referenceKindProjectionembedded the same endpoints in every row, so theasymmetry also reached the edge-semantics comparison and produced a change
there.
Expected: a known endpoint difference stays a change, a resolved endpoint
against an unresolved one is neither a difference nor an equality, and the
edge-kind comparison decides kinds.
Change and scope
src/domain/functionComparisonNormalization.tsreferenceEndpointkeeps the address alongside a resolved name within oneartifact, because there the address is the target's identity and the name is
supplementary. Across artifacts an address still names nothing, so only a
resolved name survives and an unresolved endpoint stays
null.referenceKindProjectionno longer projects endpoints. Endpoint identity iscompared on its own, and the projection now decides edge semantics only,
which is what its reported limitation already claimed.
sortedbecame generic, so projections keep their inferred element typeinstead of erasing it to
unknown[].src/domain/functionComparisonDimensions.ts:compareReferencescomparesendpoint lists pairwise with
compareEndpoint, which returnsequal,changedorasymmetric. A known difference is still reported immediately;an unresolved endpoint on either side is an asymmetry; within one artifact the
address decides and a resolved name is supplementary.
src/domain/functionComparison.test.ts: three tests — the reportedmixed-record cases now resolve to
unknownacross artifacts andunchangedinside one artifact; a real address difference beside a named and an unnamed
target stays
changed; and different named targets staychanged.No schema, tool contract, or output shape changes. This is a fix inside existing
boundaries, so no maintainer scope decision is required ("not applicable").
Contract and boundary impact
referencesdimension ofcompare_functions, and thereferencesverdict that feedsverify_reconstruction.difference is the
referencesdimension status and, through it, the overallcomparison status and the
verify_reconstructionverdict for records whosereference targets are resolved on one side only. Reported
left/rightvalues for same-artifact comparisons now carry the address alongside a
resolved name, which is more of the recorded evidence rather than less.
is in provider-neutral domain logic.
reported as a limitation instead of being asserted as a difference, so a
definite
failinverify_reconstructionis no longer produced from amissing record.
applicable; no execution, no writes.
Expected effects:
Evidence and regression coverage
src/domain/functionComparison.test.ts, inside theexisting "function comparison unnamed reference endpoints" group.
functionComparisonDimensions.tsandfunctionComparisonNormalization.tsfailsdoes not report a change when one record names the target and the other does not; restoring them passes. I ran both directions.address difference beside a named and an unnamed target stays
changed, anddifferent named targets stay
changed. They exist so the fix cannot bewidened into "report everything as unknown".
functionComparison(58),reconstructionVerification.functionSources(69),staticRuntimeCorrelation(7), and the MCP boundary suitescomparisonUnknownsMcp(3),functionComparisonCoverageMcp(1),functionComparisonMcp(8) andfunctionCallDirectionsMcp(1) — 147 passed.Those boundary suites compile the runtime, so the type change is covered by a
real build.
with inline Evidence; the regression here is at the comparison domain boundary
the tool calls, and the MCP boundary suites exercise the same path. I did not
re-run the issue's exact fixture script.
For evidence-bearing changes:
Validation performed
npm run test:focused -- src/domain/functionComparison.test.ts— 58 passed;the mixed-record test fails when the fix is reverted.
npm run test:focused -- src/domain/functionComparison.test.ts src/domain/reconstructionVerification.functionSources.test.ts src/domain/staticRuntimeCorrelation.test.ts tests/boundary/mcp/comparisonUnknownsMcp.test.ts tests/boundary/mcp/functionComparisonCoverageMcp.test.ts tests/boundary/mcp/functionComparisonMcp.test.ts tests/boundary/mcp/functionCallDirectionsMcp.test.ts— 147 passed.npx tsc --noEmit— no errors in the changed files.npx oxlint src/domain/— 0 errors.npx oxfmt <changed files>— applied.Not run, and not claimed as passing:
npm run check:fast(itsdeps:checkpre-step fails in this environment) and
npm run test:acceptance. Expected tobe covered by CI.
Compatibility, safety, and release
changed/failtounknown, and one fromchangedtounchangedinside asingle artifact; all three were false endpoints differences. Same-artifact
reference projections gain the address next to a resolved name.
is involved.
new reads, writes or execution.
Author readiness
Human owner: @Henglie
Before merge
type(scope): outcome.🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.