[PR #4409] [CLOSED] fix(reference): retain exact CommonJS template require specifiers #6220

New issue

Closed

opened 2026-10-31 01:12:47 +00:00 by bsakaguchi · 0 comments

bsakaguchi commented

2026-10-31 01:12:47 +00:00

Owner

📋 Pull Request Information

Original PR: https://github.com/morluto/rea/pull/4409
Author: @Franklin-Qi
Created: 10/16/2026
Status: ❌ Closed

Base: main ← Head: fix/4382-template-require-specifiers

📝 Commits (1)

102dc7f fix(reference): retain exact CommonJS template require specifiers

📊 Changes

2 files changed (+64 additions, -2 deletions)

View changed files

➕ src/domain/referenceSourceImportParsing.test.ts (+35 -0)
📝 src/domain/referenceSourceImportParsing.ts (+29 -2)

📄 Description

Summary

Historical-source CommonJS parsing kept require("mod") but dropped exact no-substitution require(mod). Use the shared exact-literal owner for require extraction; keep dynamic import() templates partial.

Closes: #4382

Validation performed

Issue repro: require(mod) retains to: "mod"; import(mod) stays <dynamic-import> partial; invalid static ESM templates still fail parse.
npm run test:focused -- src/domain/referenceSourceImportParsing.test.ts
npm run check:fast

Author readiness declarations are left for the human owner to complete.

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/morluto/rea/pull/4409 **Author:** [@Franklin-Qi](https://github.com/Franklin-Qi) **Created:** 10/16/2026 **Status:** ❌ Closed **Base:** `main` ← **Head:** `fix/4382-template-require-specifiers` --- ### 📝 Commits (1) - [`102dc7f`](https://github.com/morluto/rea/commit/102dc7f27bcc4ae2e88e4e9218b5777e00c040fb) fix(reference): retain exact CommonJS template require specifiers ### 📊 Changes **2 files changed** (+64 additions, -2 deletions) <details> <summary>View changed files</summary> ➕ `src/domain/referenceSourceImportParsing.test.ts` (+35 -0) 📝 `src/domain/referenceSourceImportParsing.ts` (+29 -2) </details> ### 📄 Description ## Summary Historical-source CommonJS parsing kept `require("mod")` but dropped exact no-substitution `require(`mod`)`. Use the shared exact-literal owner for require extraction; keep dynamic `import()` templates partial. Closes: #4382 ## Validation performed - Issue repro: `require(`mod`)` retains `to: "mod"`; `import(`mod`)` stays `<dynamic-import>` partial; invalid static ESM templates still fail parse. - `npm run test:focused -- src/domain/referenceSourceImportParsing.test.ts` - `npm run check:fast` Author readiness declarations are left for the human owner to complete. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>

bsakaguchi

2026-10-31 01:12:47 +00:00