[PR #4410] [CLOSED] fix(inspector): count unresolved locations after script deduplication #6221

New issue

Closed

opened 2026-10-31 01:12:49 +00:00 by bsakaguchi · 0 comments

bsakaguchi commented

2026-10-31 01:12:49 +00:00

Owner

📋 Pull Request Information

Original PR: https://github.com/morluto/rea/pull/4410
Author: @Franklin-Qi
Created: 10/16/2026
Status: ❌ Closed

Base: main ← Head: fix/4380-inspector-deduped-location-warning

📝 Commits (1)

edaf662 fix(inspector): count unresolved locations after script deduplication

📊 Changes

2 files changed (+42 additions, -1 deletions)

View changed files

📝 src/inspector/V8InspectorCaptureProjection.test.ts (+36 -0)
📝 src/inspector/V8InspectorCaptureProjection.ts (+6 -1)

📄 Description

Summary

Reported-mode Inspector warnings counted unresolved locations before script-key deduplication, so duplicate drafts inflated the human-readable message. Derive the warning from retained items; keep observed_total as the raw event count.

Closes: #4380

Validation performed

Issue repro: two identical drafts retain one item and warn about one unverified location; observed_total remains 2.
npm run test:focused -- src/inspector/V8InspectorCaptureProjection.test.ts
npm run check:fast

Author readiness declarations are left for the human owner to complete.

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/morluto/rea/pull/4410 **Author:** [@Franklin-Qi](https://github.com/Franklin-Qi) **Created:** 10/16/2026 **Status:** ❌ Closed **Base:** `main` ← **Head:** `fix/4380-inspector-deduped-location-warning` --- ### 📝 Commits (1) - [`edaf662`](https://github.com/morluto/rea/commit/edaf66268e8663780b7afd83b5f9ffc12208d9f2) fix(inspector): count unresolved locations after script deduplication ### 📊 Changes **2 files changed** (+42 additions, -1 deletions) <details> <summary>View changed files</summary> 📝 `src/inspector/V8InspectorCaptureProjection.test.ts` (+36 -0) 📝 `src/inspector/V8InspectorCaptureProjection.ts` (+6 -1) </details> ### 📄 Description ## Summary Reported-mode Inspector warnings counted unresolved locations before script-key deduplication, so duplicate drafts inflated the human-readable message. Derive the warning from retained items; keep `observed_total` as the raw event count. Closes: #4380 ## Validation performed - Issue repro: two identical drafts retain one item and warn about one unverified location; `observed_total` remains 2. - `npm run test:focused -- src/inspector/V8InspectorCaptureProjection.test.ts` - `npm run check:fast` Author readiness declarations are left for the human owner to complete. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>

bsakaguchi

2026-10-31 01:12:49 +00:00