morluto/rea

Fork

You've already forked rea

mirror of https://github.com/morluto/rea.git synced 2026-11-05 06:45:22 +00:00

Code Issues 1.3k Projects Packages Wiki Activity

[PR #4446] [MERGED] fix(managed): retain descriptor ownership through hash cancellation #6246

New issue

Closed

opened 2026-10-31 01:13:00 +00:00 by bsakaguchi · 0 comments

bsakaguchi commented

2026-10-31 01:13:00 +00:00

Owner

Copy link

📋 Pull Request Information

Original PR: https://github.com/morluto/rea/pull/4446
Author: @N0zoM1z0
Created: 10/16/2026
Status: ✅ Merged
Merged: 10/16/2026
Merged by: @N0zoM1z0

Base: main ← Head: fix/managed-hash-cancellation-4381

📝 Commits (2)

320e319 fix(managed): preserve owned handles during hash cancellation
d6fa191 fix(managed): preserve opaque hash cancellation reasons

📊 Changes

2 files changed (+212 additions, -23 deletions)

View changed files

📝 src/dotnet/ManagedSnapshot.ts (+33 -23)
➕ tests/boundary/providers/managed/managedHashCancellation.test.ts (+179 -0)

📄 Description

Summary

Fixes #4381; lifecycle audit follow-up for #4227.

Cancelling a cached managed-source hash let Node's ReadStream invalidate a borrowed FileHandle before its owner confirmed close. The provider then retained unconfirmable cleanup and could not recover. Hashing now uses bounded reads through the existing owner; cancellation closes normally, and genuine close failure retains that exact owner for retry.

This adopts @xu91102's published patch, preserving original commit authorship. Independent Linux verification also exposed cancellation reasons with filesystem codes or cleanup-record shapes being reinterpreted. Exact caller reasons now remain opaque; independent read errors retain their primary meaning.

Change and boundary impact

Owner/earliest stage: managed static provider source hashing and managed read-error normalization. Fixed 64 KiB buffer; existing 128 MiB snapshot budget and one-byte growth probe remain. Each cached use still verifies the current source digest.
Scope decision: not applicable; ordinary fix to existing read-only static analysis. No target execution, new provider, permissions or recovery authority.
CLI/MCP, schemas, package/dependencies/generated metadata: unchanged. Both adapters retain their shared workflow. No additional response data or cache.
Evidence: same source identity, digest, coverage and full retained Evidence. Cancellation is typed; denied close remains cleanup_incomplete with the primary cancellation, blocks admission, and retries the same descriptor owner.

Expected effects:

Read existing files or captured data.

Evidence and regression coverage

Executed on Linux with pinned Node 24.18.0/npm 11.16.0:

Original issue probe on latest main c8848648: exact SHA-256/pre-abort controls passed; 3/3 real stream cancellations reproduced failed cleanup and rejected retry/close. This does not establish a physical descriptor leak.
Original contributor's two cancellation/denied-close cases passed independently. Additional filesystem-shaped reasons failed 2/4 cases before normalization; an opaque cleanup-record reason failed 1/7 before moving identity recognition before cleanup interpretation.
npm run test:focused -- <28 managed/owner/CLI/MCP files>: 484 passed on the final head, including all seven new hash cases, independent read failure, blocked admission and same-client recovery. The final 15-case owner subset also passed independently.
Final compiled real provider: seven cancellation/read-close/final-close recovery scenarios passed against unchanged Microsoft.Extensions.Primitives 8.0.0, SHA-256 446ff16e903e7479558816e213a3adee9a1c1adad65a56d853801b10933e29d7, downloaded from official NuGet as data, without executing it.
Actual CLI/stdio MCP: two paired runs per revision passed. Each completed task used 2 CLI and 9 MCP requests, selected-type summaries, two method pages, a failed-path recovery control and complete Evidence export. Summary links, exact rows, coverage and source bytes were verified.
npm run check:fast: passed on final source. npm run docs:check: passed (5 tests).

Public managed requests create one-shot providers. Their repetition proves normal public behavior, not cached-hash cancellation; the latter was verified on the retained real provider/file boundary. Public SDK cancellation, other OSes, external disassemblers and physical devices were not exercised for this fix.

Performance

Two runs per revision, same Linux host/two-core affinity, completed equivalent tasks. OS cache uncontrolled; no speedup claim. Public-task medians, base → fix: 7.22 → 7.21 s wall, 9.07 → 9.05 s CPU, 0.673 → 0.669 GiB sampled process-family RSS. Forty warm retained-provider queries: 602 → 604 ms; first snapshot 25.8 → 26.0 ms.

o200k_base estimates for each public task: 9 MCP arguments plus full SDK replies 26,780 → 26,784 tokens; 2 CLI argument/full-report replies 87,351 on both. Complete CLI reports are validation artifacts, not extra agent context. Estimates exclude tool schemas, initialization/control/framing, prompts and model billing; SDK text/structured duplicates are included. Complete Evidence stays local and pageable. A separate synthetic 32 MiB hashing-only control passed exact digests on both revisions; it does not establish managed parsing performance. RSS was sampled every 200 ms and CPU includes reaped descendants.

Compatibility, safety, and release

No breaking changes, migrations or installation changes. Ownership checks remain intact, failed cleanup stays retained, and ambient environment values were not persisted. Local files/packages served as static data only.

Author readiness

Human owner: @N0zoM1z0

Entered under the human owner's explicit working-session instruction to complete the declarations and request review. The assistant performed implementation and validation review; this does not claim a separate manual human review.

I reviewed the final diff and relevant existing code, understand the change and its edge cases, and take responsibility for the complete PR, including AI-assisted work.
I checked the evidence above, confirmed it supports the current change, and recorded meaningful validation gaps.
I declare this PR ready for initial maintainer review.

Before merge

This PR addresses a concrete problem or an agreed enhancement.
Material scope and authority questions are resolved, and any required maintainer scope decision covers the final diff.
The PR has one focused outcome and the title follows type(scope): outcome.
Related issue is linked, or the reason for not linking one is stated above.
Tests cover changed observable behavior and meaningful failure paths.
Owning docs, contracts, and generated metadata are updated where needed.
User-visible CLI/MCP changes include representative output.
I checked the final diff for secrets, unrelated cleanup, and unsupported claims.

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/morluto/rea/pull/4446 **Author:** [@N0zoM1z0](https://github.com/N0zoM1z0) **Created:** 10/16/2026 **Status:** ✅ Merged **Merged:** 10/16/2026 **Merged by:** [@N0zoM1z0](https://github.com/N0zoM1z0) **Base:** `main` ← **Head:** `fix/managed-hash-cancellation-4381` --- ### 📝 Commits (2) - [`320e319`](https://github.com/morluto/rea/commit/320e31900d51285a2f8f4078ae69f48459c4a0ae) fix(managed): preserve owned handles during hash cancellation - [`d6fa191`](https://github.com/morluto/rea/commit/d6fa191e89a3ecd63fc381927e064fcf4e62ba07) fix(managed): preserve opaque hash cancellation reasons ### 📊 Changes **2 files changed** (+212 additions, -23 deletions) <details> <summary>View changed files</summary> 📝 `src/dotnet/ManagedSnapshot.ts` (+33 -23) ➕ `tests/boundary/providers/managed/managedHashCancellation.test.ts` (+179 -0) </details> ### 📄 Description ## Summary Fixes #4381; lifecycle audit follow-up for #4227. Cancelling a cached managed-source hash let Node's ReadStream invalidate a borrowed FileHandle before its owner confirmed close. The provider then retained unconfirmable cleanup and could not recover. Hashing now uses bounded reads through the existing owner; cancellation closes normally, and genuine close failure retains that exact owner for retry. This adopts @xu91102's published [patch](https://github.com/xu91102/rea/commit/ebeec580c839f2f72144282a44f4e11ea5759843), preserving original commit authorship. Independent Linux verification also exposed cancellation reasons with filesystem codes or cleanup-record shapes being reinterpreted. Exact caller reasons now remain opaque; independent read errors retain their primary meaning. ## Change and boundary impact - Owner/earliest stage: managed static provider source hashing and managed read-error normalization. Fixed 64 KiB buffer; existing 128 MiB snapshot budget and one-byte growth probe remain. Each cached use still verifies the current source digest. - Scope decision: not applicable; ordinary fix to existing read-only static analysis. No target execution, new provider, permissions or recovery authority. - CLI/MCP, schemas, package/dependencies/generated metadata: unchanged. Both adapters retain their shared workflow. No additional response data or cache. - Evidence: same source identity, digest, coverage and full retained Evidence. Cancellation is typed; denied close remains `cleanup_incomplete` with the primary cancellation, blocks admission, and retries the same descriptor owner. Expected effects: - [x] Read existing files or captured data. ## Evidence and regression coverage Executed on Linux with pinned Node 24.18.0/npm 11.16.0: - Original issue probe on latest main `c8848648`: exact SHA-256/pre-abort controls passed; 3/3 real stream cancellations reproduced failed cleanup and rejected retry/close. This does not establish a physical descriptor leak. - Original contributor's two cancellation/denied-close cases passed independently. Additional filesystem-shaped reasons failed 2/4 cases before normalization; an opaque cleanup-record reason failed 1/7 before moving identity recognition before cleanup interpretation. - `npm run test:focused -- <28 managed/owner/CLI/MCP files>`: **484 passed on the final head**, including all seven new hash cases, independent read failure, blocked admission and same-client recovery. The final 15-case owner subset also passed independently. - Final compiled real provider: seven cancellation/read-close/final-close recovery scenarios passed against unchanged **Microsoft.Extensions.Primitives 8.0.0**, SHA-256 `446ff16e903e7479558816e213a3adee9a1c1adad65a56d853801b10933e29d7`, downloaded from official NuGet as data, without executing it. - Actual CLI/stdio MCP: two paired runs per revision passed. Each completed task used 2 CLI and 9 MCP requests, selected-type summaries, two method pages, a failed-path recovery control and complete Evidence export. Summary links, exact rows, coverage and source bytes were verified. - `npm run check:fast`: passed on final source. `npm run docs:check`: passed (5 tests). Public managed requests create one-shot providers. Their repetition proves normal public behavior, **not** cached-hash cancellation; the latter was verified on the retained real provider/file boundary. Public SDK cancellation, other OSes, external disassemblers and physical devices were not exercised for this fix. ## Performance Two runs per revision, same Linux host/two-core affinity, completed equivalent tasks. OS cache uncontrolled; no speedup claim. Public-task medians, base → fix: **7.22 → 7.21 s wall**, **9.07 → 9.05 s CPU**, **0.673 → 0.669 GiB sampled process-family RSS**. Forty warm retained-provider queries: **602 → 604 ms**; first snapshot **25.8 → 26.0 ms**. `o200k_base` estimates for each public task: 9 MCP arguments plus full SDK replies **26,780 → 26,784 tokens**; 2 CLI argument/full-report replies **87,351 on both**. Complete CLI reports are validation artifacts, not extra agent context. Estimates exclude tool schemas, initialization/control/framing, prompts and model billing; SDK text/structured duplicates are included. Complete Evidence stays local and pageable. A separate synthetic 32 MiB hashing-only control passed exact digests on both revisions; it does not establish managed parsing performance. RSS was sampled every 200 ms and CPU includes reaped descendants. ## Compatibility, safety, and release No breaking changes, migrations or installation changes. Ownership checks remain intact, failed cleanup stays retained, and ambient environment values were not persisted. Local files/packages served as static data only. ## Author readiness Human owner: @N0zoM1z0 Entered under the human owner's explicit working-session instruction to complete the declarations and request review. The assistant performed implementation and validation review; this does not claim a separate manual human review. - [x] I reviewed the final diff and relevant existing code, understand the change and its edge cases, and take responsibility for the complete PR, including AI-assisted work. - [x] I checked the evidence above, confirmed it supports the current change, and recorded meaningful validation gaps. - [x] I declare this PR ready for initial maintainer review. ## Before merge - [x] This PR addresses a concrete problem or an agreed enhancement. - [x] Material scope and authority questions are resolved, and any required maintainer scope decision covers the final diff. - [x] The PR has one focused outcome and the title follows `type(scope): outcome`. - [x] Related issue is linked, or the reason for not linking one is stated above. - [x] Tests cover changed observable behavior and meaningful failure paths. - [x] Owning docs, contracts, and generated metadata are updated where needed. - [x] User-visible CLI/MCP changes include representative output. - [x] I checked the final diff for secrets, unrelated cleanup, and unsupported claims. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>

bsakaguchi

2026-10-31 01:13:00 +00:00

closed this issue
added the
pull-request
label

bsakaguchi referenced this issue

2026-11-01 21:11:07 +00:00

[GH-ISSUE #5654] [Tracker] Open PRs that can't merge yet: conflicts and red CI (October 2026) #3425

bsakaguchi referenced this issue

2026-11-01 21:11:12 +00:00

[GH-ISSUE #7695] [Bug] Retained analysis-view guidance omits working view families and selectors #4617

bsakaguchi referenced this issue

2026-11-01 21:46:16 +00:00

[PR #6246] [CLOSED] fix: correct pcap parent guidance and preserve loader base uncertainty #7223

No Branch/Tag specified

main

codex/procedure-reference-stacked

release-please--branches--main--components--rea-agents

release-please--branches--main--components--rea-agents--release-notes

codex/kuna-independent-retry

codex/byte-search-overlay-coverage

codex/open-failure-target-receipt

codex/kuna-xref-evidence

codex/ghidra-ambiguous-procedure-recovery

codex/function-source-bundle

codex/trace-function-integration-prototype

codex/snapshot-source-closure

codex/recorded-evidence-array-pages

codex/evidence-recovery-redesign

codex/trace-feature-address-scope

codex/call-discovery-scope

codex/ghidra-literal-candidate-evidence

codex/decompile-directory-independent-retry

codex/retry-provenance-base

codex/value-flow-capability-experiment

codex/ghidra-containing-instruction

cursor/readme-discord-button-ef9f

dependabot/github_actions/actions/setup-node-7.1.0

dependabot/github_actions/actions/upload-artifact-7.0.2

dependabot/npm_and_yarn/npm-minor-and-patch-d8d97ce6df

codex/kuna-1989

fix/8559-native-ui-fixture-ownership

fix/8555-go-verifier-mcp-ownership

codex/provider-capability-recovery

fix/8642-rizin-target-stdin

codex/ghidra-memory-effect-scope

codex/ghidra-annotation-entry-selector

codex/ghidra-readonly-recovery

codex/ghidra-regex-verifier-recovery

codex/evidence-discovery-view-guidance

fix/8545-bulk-append-overflow

fix/8428-navigation-refusal-alternatives

codex/address-context-recovery

codex/matching-member-limitations

codex/unknown-scope-contract

codex/evidence-view-guidance

feat/8373-native-trace-views

codex/ghidra-snapshot-verifier-binding

codex/elf-export-visibility

codex/evidence-view-recovery

codex/native-reference-cli-help

codex/provider-candidate-observation-scope

codex/kuna-session-verification

codex/ghidra-switch-lifetime-guidance

codex/pseudocode-paging-discovery

codex/clarify-evidence-view-support

codex/kuna-xrefs-selector-recovery

codex/context-capacity-recovery

codex/evidence-closure-large-links

codex/same-function-evidence-identity

codex/ghidra-verifier-inspected-jdk

codex/audit-guided-workflows

codex/crash-prompt-retained-dossiers

codex/analysis-view-error-recovery

codex/kuna-verifier-target-selection

codex/ghidra-selected-project-call-coverage

codex/docs-native-analysis-scope

codex/ghidra-java-socket-boundary

codex/ghidra-retained-snapshot-verifier

codex/ghidra-search-inventory-facts

fix/8284-zero-argument-parameter-bindings

fix/8198-ui-action-handler-offset

fix/8257-elf-entry-label-identity

fix/8304-deferred-output-schema-projection

fix/8277-call-path-computed-target-uncertainty

fix/pr-8089-conflicts

fix/ci-static-duplicate-export

dependabot/npm_and_yarn/lint-staged-17.6.0

dependabot/github_actions/actions/download-artifact-8.0.2

dependabot/npm_and_yarn/write-file-atomic-8.0.0

dependabot/npm_and_yarn/canonicalize-5.1.0

dependabot/github_actions/actions/cache/restore-6.1.0

dependabot/npm_and_yarn/toon-format/toon-4.4.0

dependabot/github_actions/actions/deploy-pages-5.0.1

codex/review-fixes-pr-2403

codex/review-fixes-pr-2400

codex/process-terminal-width

codex/test-brittleness-cleanup

verify/7167-browser-connect-macos

fix/7167-browser-connect

feat/native-matching-allowance-setting

feat/browser-scenario-dry-run

test/managed-caller-parameters-20261024

codex/parser-fortythird-boundaries

fix/6926-pinvoke-platform-decorations-20261023

fix/6889-har-body-encoding-20261023

fix/6888-sqlite-schema-budget-20261023

fix/dependency-security-gates-6708

cursor/evidence-overwrite-rebase-b4ac

feat/4057-verify-native-exports

fix/windows-acl-observer-overhead-20261022

cursor/erlang-beam-restack-4476

cursor/pe-certificate-review-bf32

fix/6116-javascript-application-fs-errors

fix/6061-unmapped-runtime-script-unknown

feat/browser-scenario-summary

fix/pe-certificates

codex/verify-3407

cursor/rebase-5699

cursor/rebase-5352

cursor/rebase-5600

cursor/fix-cli-schema-omission-10a8

codex/audit-hopper-shutdown-reasons-20261021

fix/demangle-swift-omitted-record

fix/nib-boolean-value-types

cursor/cancellation-partial-observation-a5ac

fix/ib-object-limit-reasons

fix/electron-fuse-limit-advice

fix/kuna-doctor-dangling-cache

fix/fixed-budget-refusal-advice

fix/js-ipc-listener-dedup

fix/js-return-member-provenance

fix/dmg-integrity-retry-advice

fix/ida-doctor-readiness

fix/kuna-version-probe-output-drain

fix/legacy-swift-runtime-name-matching

fix/dylib-lazy-load-commands

fix/browser-scenario-startup-cancel

fix/swift-nested-punycode-classification

fix/compare-unselected-scopes

fix/objc-method-budget-coverage

fix/dmg-mounted-root-observations

audit/ci-tests-20261019-round2

release/6.7.0

fix/wabt-cleanup-retry-resolution

fix/electron-fuse-elf-pe-architecture

fix/native-plist-descriptor-ownership

fix/kuna-caller-cleanup-ownership

experiment/atomic-codemode-20261016

review/first-contributor-3776

fix/call-resolution-full-read-cycles

fix/member-mutation-selection-repeat

experiment/atomic-re-tools-20261015

perf/member-mutation-lazy-origins

perf/static-network-mutation-index

fix/hopper-startup-lifecycle

audit/3050-windows-proof-20261015

feat/windows-window-capture-2183

audit/3049-windows-proof-20261015

audit/3735-macos-fixtures-20261015

fix/batch-decompile-null-pseudocode

fix/kuna-inventory-honors-jobs

experiment/browser-codemode-tool-design-20261015

fix/hopper-clean-runtime-argv

codex/review-2049-27f1b367

review-fixes/pr-2787-routing

fix/3360-scoped-this-emitters

fix/3367-replaced-global-effects

fix/3838-compact-any-value-items

test/hopper-download-probe-20261015

codex/windows-runtime-creation-red-green-20261015

codex/windows-readonly-root-red-green-20261015

codex/windows-root-share-red-green-20261015

codex/exp-1685-win-mcp-startup

codex/bug-sweep-20261015

investigate/2190-windows-package-phases

investigate/3543-macos-cli-deadline

perf/3281-reverse-tools-feedback-quality

fix/3406-hopper-doctor-fixture

fix/3341-wrapper-require-test-context

fix/3301-owned-uninstall-fixtures

fix/3164-compiler-input-ownership

fix/pcap-cleanup-stdout-newline-20261014

perf/interface-builder-summary

codex/review-fixes-pr-1977

fix/ghidra-effective-jvm-platform

fix/docs-turkish-rust-link-20261013

fix/main-maintenance-ci-20261010

fix/recover-binary-session-process-effects

codex/review-fixes-pr-2457

codex/ci-required-cancellation-gate

fix/main-format-baseline-20261013

fix/setup-preserve-entry-fields

cursor/restore-main-checks-1ffc

fix/ghidra-bridge-hashmap-import

codex/shared-ci-jadx-json-default-20261013

codex/shared-ci-ghidra-test-groups-20261013

codex/shared-ci-java-fixture-format-20261013

codex/fix-intrinsic-invocation-boundaries

test/release-preflight-reusable-jobs

test/js-parameter-provenance-expectation

fix/linux-hopper-verification-current

test/2419-ghidra-elf-probe-size

followup/pr-1544-native-ida

codex/fold-pr-2230-contribution

docs/readme-responsible-use

fix/issue-2064

fix/issue-2050

fix/issue-2053

fix/issue-1968

fix/issue-1945

experiment/codemode-bridge-20261011

fix/tool-effects-negative-wording-1904-20261012

fix/1842-electron-interop-provenance

feat/recover-javascript-multi-input

refactor/website-i18n-prep

fix/nativeaot-pe-virtual-extent

fix/browser-verifier-ci-hang

fix/pe-resources-input-selection

docs/beginner-friendly-guides

docs/beginner-setup-guide

fix/javascript-analysis-worker-1563

fix/1649-ghidra-duplicate-names

fix/javascript-export-keys-integration-1369

test/maintenance-boundary-contracts-20261011

review/javascript-export-keys-1369

review/process-live-progress-1483

test/javascript-1495-growth-ratio

fix/ci-escape-timing

docs/normalized-terminal-geometry-1450

release/6.3.0

archive/release-6.3.0-pr1381

release/6.2.0

fix/electron-preload-dynamic-override

fix/javascript-self-referential-bundler-edges

release/6.1.0

cursor/grok-client-cherry-pick-0b56

feat/signature-posture

feat/dyld-shared-cache

feat/artifact-integrity-policy

feat/pkg-inventory

release/6.0.0

chore/sync-release-5.0.0

release/5.0.0

cursor/cloud-agent-node-787e

fix/javascript-xhr-open-endpoints

review/pr-711-realpath-fallback-wording

cleanup/replay-confinement

codex/test-suite-performance

codex/issue-foundations

codex/address-open-issues-2026-07-20

agent/javascript-vite-rollup-esbuild-adapters

agent/process-cleanup

agent/triage-integration

agent/unknown-commands-registry

feat/mcp-identity-metadata

morlvps/issue_cleanup

codex/installer-redesign

morl/roadmap-investigation-core

morl/roadmap-investigation-docs

release-please--branches--main--components--rea

rea-agents-6.8.0

rea-agents-6.7.0

rea-agents-6.6.0

experiment/atomic-codemode-wait-runtime-20261016

rea-agents-6.5.0

rea-agents-6.4.0

rea-agents-6.3.0

rea-agents-6.2.0

rea-agents-6.1.0

rea-agents-6.0.0

rea-agents-5.0.0

rea-agents-4.1.0

rea-agents-4.0.1

rea-agents-4.0.0

rea-agents-3.2.1

rea-agents-3.2.0

rea-agents-3.1.0

rea-agents-3.0.0

rea-agents-2.7.0

rea-agents-2.6.0

rea-agents-2.5.1

rea-agents-2.5.0

rea-agents-2.4.0

rea-agents-2.3.0

rea-agents-2.2.0

rea-agents-2.1.0

rea-agents-2.0.0

rea-agents-1.7.0

rea-agents-1.6.0

rea-agents-1.5.0

rea-agents-1.4.0

rea-agents-1.3.0

rea-agents-1.2.0

rea-agents-1.1.0

rea-agents-1.0.0

rea-agents-0.5.0

rea-agents-0.4.0

rea-agents-0.3.0

rea-0.2.1

rea-0.2.0

Labels

Clear labels

Mirrored from GitHub Pull Request

No labels

Milestone

Clear milestone

No items

No milestone

Projects

Clear projects

No items

No project

Assignees

Clear assignees

No assignees

1 participant

Notifications

Due date

The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference

morluto/rea#6246

Reference in a new issue

Repository

morluto/rea

Title

Body

No description provided.

Delete branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?

Rows
Columns