mirror of
https://github.com/morluto/rea.git
synced 2026-11-05 06:45:22 +00:00
Closed
opened 2026-10-31 01:13:00 +00:00 by bsakaguchi
·
0 comments
No Branch/Tag specified
main
codex/procedure-reference-stacked
release-please--branches--main--components--rea-agents
release-please--branches--main--components--rea-agents--release-notes
codex/kuna-independent-retry
codex/byte-search-overlay-coverage
codex/open-failure-target-receipt
codex/kuna-xref-evidence
codex/ghidra-ambiguous-procedure-recovery
codex/function-source-bundle
codex/trace-function-integration-prototype
codex/snapshot-source-closure
codex/recorded-evidence-array-pages
codex/evidence-recovery-redesign
codex/trace-feature-address-scope
codex/call-discovery-scope
codex/ghidra-literal-candidate-evidence
codex/decompile-directory-independent-retry
codex/retry-provenance-base
codex/value-flow-capability-experiment
codex/ghidra-containing-instruction
cursor/readme-discord-button-ef9f
dependabot/github_actions/actions/setup-node-7.1.0
dependabot/github_actions/actions/upload-artifact-7.0.2
dependabot/npm_and_yarn/npm-minor-and-patch-d8d97ce6df
codex/kuna-1989
fix/8559-native-ui-fixture-ownership
fix/8555-go-verifier-mcp-ownership
codex/provider-capability-recovery
fix/8642-rizin-target-stdin
codex/ghidra-memory-effect-scope
codex/ghidra-annotation-entry-selector
codex/ghidra-readonly-recovery
codex/ghidra-regex-verifier-recovery
codex/evidence-discovery-view-guidance
fix/8545-bulk-append-overflow
fix/8428-navigation-refusal-alternatives
codex/address-context-recovery
codex/matching-member-limitations
codex/unknown-scope-contract
codex/evidence-view-guidance
feat/8373-native-trace-views
codex/ghidra-snapshot-verifier-binding
codex/elf-export-visibility
codex/evidence-view-recovery
codex/native-reference-cli-help
codex/provider-candidate-observation-scope
codex/kuna-session-verification
codex/ghidra-switch-lifetime-guidance
codex/pseudocode-paging-discovery
codex/clarify-evidence-view-support
codex/kuna-xrefs-selector-recovery
codex/context-capacity-recovery
codex/evidence-closure-large-links
codex/same-function-evidence-identity
codex/ghidra-verifier-inspected-jdk
codex/audit-guided-workflows
codex/crash-prompt-retained-dossiers
codex/analysis-view-error-recovery
codex/kuna-verifier-target-selection
codex/ghidra-selected-project-call-coverage
codex/docs-native-analysis-scope
codex/ghidra-java-socket-boundary
codex/ghidra-retained-snapshot-verifier
codex/ghidra-search-inventory-facts
fix/8284-zero-argument-parameter-bindings
fix/8198-ui-action-handler-offset
fix/8257-elf-entry-label-identity
fix/8304-deferred-output-schema-projection
fix/8277-call-path-computed-target-uncertainty
fix/pr-8089-conflicts
fix/ci-static-duplicate-export
dependabot/npm_and_yarn/lint-staged-17.6.0
dependabot/github_actions/actions/download-artifact-8.0.2
dependabot/npm_and_yarn/write-file-atomic-8.0.0
dependabot/npm_and_yarn/canonicalize-5.1.0
dependabot/github_actions/actions/cache/restore-6.1.0
dependabot/npm_and_yarn/toon-format/toon-4.4.0
dependabot/github_actions/actions/deploy-pages-5.0.1
codex/review-fixes-pr-2403
codex/review-fixes-pr-2400
codex/process-terminal-width
codex/test-brittleness-cleanup
verify/7167-browser-connect-macos
fix/7167-browser-connect
feat/native-matching-allowance-setting
feat/browser-scenario-dry-run
test/managed-caller-parameters-20261024
codex/parser-fortythird-boundaries
fix/6926-pinvoke-platform-decorations-20261023
fix/6889-har-body-encoding-20261023
fix/6888-sqlite-schema-budget-20261023
fix/dependency-security-gates-6708
cursor/evidence-overwrite-rebase-b4ac
feat/4057-verify-native-exports
fix/windows-acl-observer-overhead-20261022
cursor/erlang-beam-restack-4476
cursor/pe-certificate-review-bf32
fix/6116-javascript-application-fs-errors
fix/6061-unmapped-runtime-script-unknown
feat/browser-scenario-summary
fix/pe-certificates
codex/verify-3407
cursor/rebase-5699
cursor/rebase-5352
cursor/rebase-5600
cursor/fix-cli-schema-omission-10a8
codex/audit-hopper-shutdown-reasons-20261021
fix/demangle-swift-omitted-record
fix/nib-boolean-value-types
cursor/cancellation-partial-observation-a5ac
fix/ib-object-limit-reasons
fix/electron-fuse-limit-advice
fix/kuna-doctor-dangling-cache
fix/fixed-budget-refusal-advice
fix/js-ipc-listener-dedup
fix/js-return-member-provenance
fix/dmg-integrity-retry-advice
fix/ida-doctor-readiness
fix/kuna-version-probe-output-drain
fix/legacy-swift-runtime-name-matching
fix/dylib-lazy-load-commands
fix/browser-scenario-startup-cancel
fix/swift-nested-punycode-classification
fix/compare-unselected-scopes
fix/objc-method-budget-coverage
fix/dmg-mounted-root-observations
audit/ci-tests-20261019-round2
release/6.7.0
fix/wabt-cleanup-retry-resolution
fix/electron-fuse-elf-pe-architecture
fix/native-plist-descriptor-ownership
fix/kuna-caller-cleanup-ownership
experiment/atomic-codemode-20261016
review/first-contributor-3776
fix/call-resolution-full-read-cycles
fix/member-mutation-selection-repeat
experiment/atomic-re-tools-20261015
perf/member-mutation-lazy-origins
perf/static-network-mutation-index
fix/hopper-startup-lifecycle
audit/3050-windows-proof-20261015
feat/windows-window-capture-2183
audit/3049-windows-proof-20261015
audit/3735-macos-fixtures-20261015
fix/batch-decompile-null-pseudocode
fix/kuna-inventory-honors-jobs
experiment/browser-codemode-tool-design-20261015
fix/hopper-clean-runtime-argv
codex/review-2049-27f1b367
review-fixes/pr-2787-routing
fix/3360-scoped-this-emitters
fix/3367-replaced-global-effects
fix/3838-compact-any-value-items
test/hopper-download-probe-20261015
codex/windows-runtime-creation-red-green-20261015
codex/windows-readonly-root-red-green-20261015
codex/windows-root-share-red-green-20261015
codex/exp-1685-win-mcp-startup
codex/bug-sweep-20261015
investigate/2190-windows-package-phases
investigate/3543-macos-cli-deadline
perf/3281-reverse-tools-feedback-quality
fix/3406-hopper-doctor-fixture
fix/3341-wrapper-require-test-context
fix/3301-owned-uninstall-fixtures
fix/3164-compiler-input-ownership
fix/pcap-cleanup-stdout-newline-20261014
perf/interface-builder-summary
codex/review-fixes-pr-1977
fix/ghidra-effective-jvm-platform
fix/docs-turkish-rust-link-20261013
fix/main-maintenance-ci-20261010
fix/recover-binary-session-process-effects
codex/review-fixes-pr-2457
codex/ci-required-cancellation-gate
fix/main-format-baseline-20261013
fix/setup-preserve-entry-fields
cursor/restore-main-checks-1ffc
fix/ghidra-bridge-hashmap-import
codex/shared-ci-jadx-json-default-20261013
codex/shared-ci-ghidra-test-groups-20261013
codex/shared-ci-java-fixture-format-20261013
codex/fix-intrinsic-invocation-boundaries
test/release-preflight-reusable-jobs
test/js-parameter-provenance-expectation
fix/linux-hopper-verification-current
test/2419-ghidra-elf-probe-size
followup/pr-1544-native-ida
codex/fold-pr-2230-contribution
docs/readme-responsible-use
fix/issue-2064
fix/issue-2050
fix/issue-2053
fix/issue-1968
fix/issue-1945
experiment/codemode-bridge-20261011
fix/tool-effects-negative-wording-1904-20261012
fix/1842-electron-interop-provenance
feat/recover-javascript-multi-input
refactor/website-i18n-prep
fix/nativeaot-pe-virtual-extent
fix/browser-verifier-ci-hang
fix/pe-resources-input-selection
docs/beginner-friendly-guides
docs/beginner-setup-guide
fix/javascript-analysis-worker-1563
fix/1649-ghidra-duplicate-names
fix/javascript-export-keys-integration-1369
test/maintenance-boundary-contracts-20261011
review/javascript-export-keys-1369
review/process-live-progress-1483
test/javascript-1495-growth-ratio
fix/ci-escape-timing
docs/normalized-terminal-geometry-1450
release/6.3.0
archive/release-6.3.0-pr1381
release/6.2.0
fix/electron-preload-dynamic-override
fix/javascript-self-referential-bundler-edges
release/6.1.0
cursor/grok-client-cherry-pick-0b56
feat/signature-posture
feat/dyld-shared-cache
feat/artifact-integrity-policy
feat/pkg-inventory
release/6.0.0
chore/sync-release-5.0.0
release/5.0.0
cursor/cloud-agent-node-787e
fix/javascript-xhr-open-endpoints
review/pr-711-realpath-fallback-wording
cleanup/replay-confinement
codex/test-suite-performance
codex/issue-foundations
codex/address-open-issues-2026-07-20
agent/javascript-vite-rollup-esbuild-adapters
agent/process-cleanup
agent/triage-integration
agent/unknown-commands-registry
feat/mcp-identity-metadata
morlvps/issue_cleanup
codex/installer-redesign
morl/roadmap-investigation-core
morl/roadmap-investigation-docs
release-please--branches--main--components--rea
rea-agents-6.8.0
rea-agents-6.7.0
rea-agents-6.6.0
experiment/atomic-codemode-wait-runtime-20261016
rea-agents-6.5.0
rea-agents-6.4.0
rea-agents-6.3.0
rea-agents-6.2.0
rea-agents-6.1.0
rea-agents-6.0.0
rea-agents-5.0.0
rea-agents-4.1.0
rea-agents-4.0.1
rea-agents-4.0.0
rea-agents-3.2.1
rea-agents-3.2.0
rea-agents-3.1.0
rea-agents-3.0.0
rea-agents-2.7.0
rea-agents-2.6.0
rea-agents-2.5.1
rea-agents-2.5.0
rea-agents-2.4.0
rea-agents-2.3.0
rea-agents-2.2.0
rea-agents-2.1.0
rea-agents-2.0.0
rea-agents-1.7.0
rea-agents-1.6.0
rea-agents-1.5.0
rea-agents-1.4.0
rea-agents-1.3.0
rea-agents-1.2.0
rea-agents-1.1.0
rea-agents-1.0.0
rea-agents-0.5.0
rea-agents-0.4.0
rea-agents-0.3.0
rea-0.2.1
rea-0.2.0
Labels
Clear labels
area: bridge
area: bridge
area: build
area: build
area: build
area: cli
area: domain
area: evidence
area: mcp
area: native
area: providers
area: runtime
area: server
area: setup
area: tests
bug
design
documentation
enhancement
enhancement
enhancement
experiment
help wanted
i18n
invalid
P0: critical
P1: high
P2: medium
P2: medium
P2: medium
P3: low
performance
provider-request
pull-request
Mirrored from GitHub Pull Request
question
roadmap
triage
No labels
area: bridge
area: bridge
area: build
area: build
area: build
area: cli
area: domain
area: evidence
area: mcp
area: native
area: providers
area: runtime
area: server
area: setup
area: tests
bug
design
documentation
enhancement
enhancement
enhancement
experiment
help wanted
i18n
invalid
P0: critical
P1: high
P2: medium
P2: medium
P2: medium
P3: low
performance
provider-request
pull-request
question
roadmap
triage
Milestone
Clear milestone
No items
No milestone
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".
No due date set.
Dependencies
No dependencies set.
Reference
morluto/rea#6247
Loading…
Add table
Add a link
Reference in a new issue
No description provided.
Delete branch "%!s()"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
📋 Pull Request Information
Original PR: https://github.com/morluto/rea/pull/4442
Author: @LuckVd
Created: 10/16/2026
Status: ❌ Closed
Base:
main← Head:fix/4436-legacy-null-relationship-coverage📝 Commits (5)
af586f3fix(evidence): accept legacy null coverage identityf1dbaeddocs(evidence): record the 6.6 evidence identity migration160f213Merge remote-tracking branch 'origin/main' into fix/4436-legacy-null-relationship-coverage8be2287fix(evidence): accept 6.5.0 legacy IDs in artifact comparison reprojectiondb10e0bMerge remote-tracking branch 'origin/main' into fix/4436-legacy-null-relationship-coverage📊 Changes
6 files changed (+157 additions, -10 deletions)
View changed files
📝
docs/index.md(+2 -1)➕
docs/migration-6.6.md(+34 -0)📝
src/application/artifacts/ArtifactComparisonEvidence.test.ts(+37 -0)📝
src/application/artifacts/ArtifactComparisonEvidence.ts(+7 -2)📝
src/domain/evidence.test.ts(+43 -0)📝
src/domain/evidence.ts(+34 -7)📄 Description
Description
Fixes #4436.
Records exported by rea-agents@6.5.0 with
relationship_coverage: nullchangedevidence_idafterdb8128dc0flippedsemanticProjectionfrom omitting a nullcoverage to hashing
relationship_coverage: null(
src/domain/evidence.ts), so unmodified 6.5.0 bundles are rejected on main withevidence_integrity_mismatch— exactly the records that do state the fieldexplicitly, while records missing the field keep the announced rejection.
This change keeps the current identity rule for everything producers emit, and
adds a verification-side fallback: when the current-rule ID does not match but
the record's
relationship_coverageis explicitlynull, the ID is re-checkedagainst the 6.5.0 projection (null coverage omitted). Records missing the field
are still rejected by the strict base schema, matching the announced breaking
change.
The same fallback now also covers the downstream artifact-comparison
re-projection, which rejected retained 6.5.0 summaries on the documented
compare_artifactspath even when the import-side check had accepted them.Change
semanticProjection/computeEvidenceIdtake an optional{ omitNullRelationshipCoverage }flag; when set and coverage isnull, thefield is left out of the hashed projection, reproducing the pre-db8128dc0
(6.5.0) digest input. Default behavior (no flag) is byte-identical to before,
so
createEvidence/createImmutableEvidenceStepskeep producing current IDs.matchesEvidenceIdentityhelper, shared by theparseEvidencegate(
authenticatedEvidenceSchema, used by bundle import, compare, etc.) and theartifact-comparison path; the fallback only engages for explicit
nullandpreserves the record's original
evidence_id.resolveArtifactComparisonEvidencere-projects the retained parent's summarythrough the current projection, so its exact-ID equality rejected retained
6.5.0 summaries with
EvidenceIntegrityErroron the documentedcompare_artifactspath; it now uses the same dual-projection check.deleting the field fails the schema before the identity check.
main(merge; one import-conflict resolution insrc/domain/evidence.test.ts, keeping both sides' tests).Type of Change
Related Issue
Testing
accepts 6.5.0 Evidence identity when relationship coverage is explicitly null— builds a record whose ID is the 6.5.0-style digest(computed independently via
digestCanonicalValueover the legacyprojection), asserts
parseEvidenceaccepts and preserves it, and asserts arecord with the
relationship_coveragekey removed still throws.accepts a retained 6.5.0 summary whose legacy ID omits null coverage(ArtifactComparisonEvidence.test.ts) — reproduces the reportedrejection on the public
compare_artifactsflow (fails before the fix,passes after) and asserts the record is resolved to its retained parent with
its original ID.
npx vitest run src/domain/evidence.test.ts— 28/28 passed; the originaltest fails on the merge-base (
781d5751a) implementation, confirming itreproduces the reported issue.
npx vitest run src/application/artifacts src/server/runDerivedOperation.test.ts src/domain/evidence.test.ts src/domain/evidenceBundle.test.ts—49/49 passed across 4 files.
npm run check:fast(typecheck + lint via turbo) — 2/2 tasks pass.(verification-scope SLA); left to CI. Targeted affected-scope checks above all
pass. Known baseline failures on this machine (documented in internal notes,
unrelated to this change): ciStaticArtifacts, closedStdout, runnerCancellation,
packageImportAliases.
Checklist
git diff --check origin/main...HEADpassesFollow-ups from review
Added
docs/migration-6.6.md(linked fromdocs/index.md) per reviewfeedback: it records the announced 6.6
relationship_coverageidentitycommitment, the verification-side acceptance of 6.5.0 explicit-null Evidence
with its original ID, and the cross-generation
rea comparebehavior — a6.5.0 export and a 6.6 export of the same analysis keep different
evidence_idvalues, so cross-bundle comparisons reportunknownwith theaffected records unresolved rather than an unchanged pair. The release note's
breaking-change entry can cite the guide.
Re-verified after the doc commit:
npx vitest run src/domain/evidence.test.ts27/27 (EXIT=0);
npx oxfmt --checkon both changed files clean; pre-commitoxfmt hook passed.
Codex review (P2, on
f1dbaedf4): handle legacy IDs during artifact-summaryre-projection — addressed in this push via
matchesEvidenceIdentityreuse inresolveArtifactComparisonEvidence, with a public-flow regression test.Independent verification after the upstream merge (
db10e0bd):vitest run src/domain/evidence.test.ts src/application/artifacts/ArtifactComparisonEvidence.test.ts— 35/35;npm run typecheck, changed-fileoxlint/oxfmt --check, andgit diff --check origin/main...HEADall pass. The push hook'snpm run check:fastalso passed. The full repository suite was not rerun locally; CI is responsible for it.Author readiness
Human owner: @LuckVd
🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.