mirror of
https://github.com/morluto/rea.git
synced 2026-11-05 07:47:29 +00:00
Closed
opened 2026-10-31 01:13:12 +00:00 by bsakaguchi
·
0 comments
No Branch/Tag specified
main
release-please--branches--main--components--rea-agents
release-please--branches--main--components--rea-agents--release-notes
codex/procedure-reference-stacked
codex/kuna-independent-retry
codex/byte-search-overlay-coverage
codex/open-failure-target-receipt
codex/kuna-xref-evidence
codex/ghidra-ambiguous-procedure-recovery
codex/function-source-bundle
codex/trace-function-integration-prototype
codex/snapshot-source-closure
codex/recorded-evidence-array-pages
codex/evidence-recovery-redesign
codex/trace-feature-address-scope
codex/call-discovery-scope
codex/ghidra-literal-candidate-evidence
codex/decompile-directory-independent-retry
codex/retry-provenance-base
codex/value-flow-capability-experiment
codex/ghidra-containing-instruction
cursor/readme-discord-button-ef9f
dependabot/github_actions/actions/setup-node-7.1.0
dependabot/github_actions/actions/upload-artifact-7.0.2
dependabot/npm_and_yarn/npm-minor-and-patch-d8d97ce6df
codex/kuna-1989
fix/8559-native-ui-fixture-ownership
fix/8555-go-verifier-mcp-ownership
codex/provider-capability-recovery
fix/8642-rizin-target-stdin
codex/ghidra-memory-effect-scope
codex/ghidra-annotation-entry-selector
codex/ghidra-readonly-recovery
codex/ghidra-regex-verifier-recovery
codex/evidence-discovery-view-guidance
fix/8545-bulk-append-overflow
fix/8428-navigation-refusal-alternatives
codex/address-context-recovery
codex/matching-member-limitations
codex/unknown-scope-contract
codex/evidence-view-guidance
feat/8373-native-trace-views
codex/ghidra-snapshot-verifier-binding
codex/elf-export-visibility
codex/evidence-view-recovery
codex/native-reference-cli-help
codex/provider-candidate-observation-scope
codex/kuna-session-verification
codex/ghidra-switch-lifetime-guidance
codex/pseudocode-paging-discovery
codex/clarify-evidence-view-support
codex/kuna-xrefs-selector-recovery
codex/context-capacity-recovery
codex/evidence-closure-large-links
codex/same-function-evidence-identity
codex/ghidra-verifier-inspected-jdk
codex/audit-guided-workflows
codex/crash-prompt-retained-dossiers
codex/analysis-view-error-recovery
codex/kuna-verifier-target-selection
codex/ghidra-selected-project-call-coverage
codex/docs-native-analysis-scope
codex/ghidra-java-socket-boundary
codex/ghidra-retained-snapshot-verifier
codex/ghidra-search-inventory-facts
fix/8284-zero-argument-parameter-bindings
fix/8198-ui-action-handler-offset
fix/8257-elf-entry-label-identity
fix/8304-deferred-output-schema-projection
fix/8277-call-path-computed-target-uncertainty
fix/pr-8089-conflicts
fix/ci-static-duplicate-export
dependabot/npm_and_yarn/lint-staged-17.6.0
dependabot/github_actions/actions/download-artifact-8.0.2
dependabot/npm_and_yarn/write-file-atomic-8.0.0
dependabot/npm_and_yarn/canonicalize-5.1.0
dependabot/github_actions/actions/cache/restore-6.1.0
dependabot/npm_and_yarn/toon-format/toon-4.4.0
dependabot/github_actions/actions/deploy-pages-5.0.1
codex/review-fixes-pr-2403
codex/review-fixes-pr-2400
codex/process-terminal-width
codex/test-brittleness-cleanup
verify/7167-browser-connect-macos
fix/7167-browser-connect
feat/native-matching-allowance-setting
feat/browser-scenario-dry-run
test/managed-caller-parameters-20261024
codex/parser-fortythird-boundaries
fix/6926-pinvoke-platform-decorations-20261023
fix/6889-har-body-encoding-20261023
fix/6888-sqlite-schema-budget-20261023
fix/dependency-security-gates-6708
cursor/evidence-overwrite-rebase-b4ac
feat/4057-verify-native-exports
fix/windows-acl-observer-overhead-20261022
cursor/erlang-beam-restack-4476
cursor/pe-certificate-review-bf32
fix/6116-javascript-application-fs-errors
fix/6061-unmapped-runtime-script-unknown
feat/browser-scenario-summary
fix/pe-certificates
codex/verify-3407
cursor/rebase-5699
cursor/rebase-5352
cursor/rebase-5600
cursor/fix-cli-schema-omission-10a8
codex/audit-hopper-shutdown-reasons-20261021
fix/demangle-swift-omitted-record
fix/nib-boolean-value-types
cursor/cancellation-partial-observation-a5ac
fix/ib-object-limit-reasons
fix/electron-fuse-limit-advice
fix/kuna-doctor-dangling-cache
fix/fixed-budget-refusal-advice
fix/js-ipc-listener-dedup
fix/js-return-member-provenance
fix/dmg-integrity-retry-advice
fix/ida-doctor-readiness
fix/kuna-version-probe-output-drain
fix/legacy-swift-runtime-name-matching
fix/dylib-lazy-load-commands
fix/browser-scenario-startup-cancel
fix/swift-nested-punycode-classification
fix/compare-unselected-scopes
fix/objc-method-budget-coverage
fix/dmg-mounted-root-observations
audit/ci-tests-20261019-round2
release/6.7.0
fix/wabt-cleanup-retry-resolution
fix/electron-fuse-elf-pe-architecture
fix/native-plist-descriptor-ownership
fix/kuna-caller-cleanup-ownership
experiment/atomic-codemode-20261016
review/first-contributor-3776
fix/call-resolution-full-read-cycles
fix/member-mutation-selection-repeat
experiment/atomic-re-tools-20261015
perf/member-mutation-lazy-origins
perf/static-network-mutation-index
fix/hopper-startup-lifecycle
audit/3050-windows-proof-20261015
feat/windows-window-capture-2183
audit/3049-windows-proof-20261015
audit/3735-macos-fixtures-20261015
fix/batch-decompile-null-pseudocode
fix/kuna-inventory-honors-jobs
experiment/browser-codemode-tool-design-20261015
fix/hopper-clean-runtime-argv
codex/review-2049-27f1b367
review-fixes/pr-2787-routing
fix/3360-scoped-this-emitters
fix/3367-replaced-global-effects
fix/3838-compact-any-value-items
test/hopper-download-probe-20261015
codex/windows-runtime-creation-red-green-20261015
codex/windows-readonly-root-red-green-20261015
codex/windows-root-share-red-green-20261015
codex/exp-1685-win-mcp-startup
codex/bug-sweep-20261015
investigate/2190-windows-package-phases
investigate/3543-macos-cli-deadline
perf/3281-reverse-tools-feedback-quality
fix/3406-hopper-doctor-fixture
fix/3341-wrapper-require-test-context
fix/3301-owned-uninstall-fixtures
fix/3164-compiler-input-ownership
fix/pcap-cleanup-stdout-newline-20261014
perf/interface-builder-summary
codex/review-fixes-pr-1977
fix/ghidra-effective-jvm-platform
fix/docs-turkish-rust-link-20261013
fix/main-maintenance-ci-20261010
fix/recover-binary-session-process-effects
codex/review-fixes-pr-2457
codex/ci-required-cancellation-gate
fix/main-format-baseline-20261013
fix/setup-preserve-entry-fields
cursor/restore-main-checks-1ffc
fix/ghidra-bridge-hashmap-import
codex/shared-ci-jadx-json-default-20261013
codex/shared-ci-ghidra-test-groups-20261013
codex/shared-ci-java-fixture-format-20261013
codex/fix-intrinsic-invocation-boundaries
test/release-preflight-reusable-jobs
test/js-parameter-provenance-expectation
fix/linux-hopper-verification-current
test/2419-ghidra-elf-probe-size
followup/pr-1544-native-ida
codex/fold-pr-2230-contribution
docs/readme-responsible-use
fix/issue-2064
fix/issue-2050
fix/issue-2053
fix/issue-1968
fix/issue-1945
experiment/codemode-bridge-20261011
fix/tool-effects-negative-wording-1904-20261012
fix/1842-electron-interop-provenance
feat/recover-javascript-multi-input
refactor/website-i18n-prep
fix/nativeaot-pe-virtual-extent
fix/browser-verifier-ci-hang
fix/pe-resources-input-selection
docs/beginner-friendly-guides
docs/beginner-setup-guide
fix/javascript-analysis-worker-1563
fix/1649-ghidra-duplicate-names
fix/javascript-export-keys-integration-1369
test/maintenance-boundary-contracts-20261011
review/javascript-export-keys-1369
review/process-live-progress-1483
test/javascript-1495-growth-ratio
fix/ci-escape-timing
docs/normalized-terminal-geometry-1450
release/6.3.0
archive/release-6.3.0-pr1381
release/6.2.0
fix/electron-preload-dynamic-override
fix/javascript-self-referential-bundler-edges
release/6.1.0
cursor/grok-client-cherry-pick-0b56
feat/signature-posture
feat/dyld-shared-cache
feat/artifact-integrity-policy
feat/pkg-inventory
release/6.0.0
chore/sync-release-5.0.0
release/5.0.0
cursor/cloud-agent-node-787e
fix/javascript-xhr-open-endpoints
review/pr-711-realpath-fallback-wording
cleanup/replay-confinement
codex/test-suite-performance
codex/issue-foundations
codex/address-open-issues-2026-07-20
agent/javascript-vite-rollup-esbuild-adapters
agent/process-cleanup
agent/triage-integration
agent/unknown-commands-registry
feat/mcp-identity-metadata
morlvps/issue_cleanup
codex/installer-redesign
morl/roadmap-investigation-core
morl/roadmap-investigation-docs
release-please--branches--main--components--rea
rea-agents-6.8.0
rea-agents-6.7.0
rea-agents-6.6.0
experiment/atomic-codemode-wait-runtime-20261016
rea-agents-6.5.0
rea-agents-6.4.0
rea-agents-6.3.0
rea-agents-6.2.0
rea-agents-6.1.0
rea-agents-6.0.0
rea-agents-5.0.0
rea-agents-4.1.0
rea-agents-4.0.1
rea-agents-4.0.0
rea-agents-3.2.1
rea-agents-3.2.0
rea-agents-3.1.0
rea-agents-3.0.0
rea-agents-2.7.0
rea-agents-2.6.0
rea-agents-2.5.1
rea-agents-2.5.0
rea-agents-2.4.0
rea-agents-2.3.0
rea-agents-2.2.0
rea-agents-2.1.0
rea-agents-2.0.0
rea-agents-1.7.0
rea-agents-1.6.0
rea-agents-1.5.0
rea-agents-1.4.0
rea-agents-1.3.0
rea-agents-1.2.0
rea-agents-1.1.0
rea-agents-1.0.0
rea-agents-0.5.0
rea-agents-0.4.0
rea-agents-0.3.0
rea-0.2.1
rea-0.2.0
Labels
Clear labels
area: bridge
area: bridge
area: build
area: build
area: build
area: cli
area: domain
area: evidence
area: mcp
area: native
area: providers
area: runtime
area: server
area: setup
area: tests
bug
design
documentation
enhancement
enhancement
enhancement
experiment
help wanted
i18n
invalid
P0: critical
P1: high
P2: medium
P2: medium
P2: medium
P3: low
performance
provider-request
pull-request
Mirrored from GitHub Pull Request
question
roadmap
triage
No labels
area: bridge
area: bridge
area: build
area: build
area: build
area: cli
area: domain
area: evidence
area: mcp
area: native
area: providers
area: runtime
area: server
area: setup
area: tests
bug
design
documentation
enhancement
enhancement
enhancement
experiment
help wanted
i18n
invalid
P0: critical
P1: high
P2: medium
P2: medium
P2: medium
P3: low
performance
provider-request
pull-request
question
roadmap
triage
Milestone
Clear milestone
No items
No milestone
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".
No due date set.
Dependencies
No dependencies set.
Reference
morluto/rea#6275
Loading…
Add table
Add a link
Reference in a new issue
No description provided.
Delete branch "%!s()"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
📋 Pull Request Information
Original PR: https://github.com/morluto/rea/pull/4499
Author: @N0zoM1z0
Created: 10/16/2026
Status: ✅ Merged
Merged: 10/16/2026
Merged by: @N0zoM1z0
Base:
main← Head:fix/cutter-discovery-cancel-3946📝 Commits (3)
1b0eb1bfix(cutter): cancel discovery probes and queued work0a4e6b9fix(cutter): retain requests until socket closurec68e401fix(cutter): retain completed observations on late cancellation📊 Changes
8 files changed (+421 additions, -38 deletions)
View changed files
📝
src/cli/cutterCommands.ts(+5 -2)📝
src/cutter/CutterBridgeClient.ts(+41 -16)📝
src/cutter/CutterBridgeService.ts(+45 -4)📝
src/server/registerCutterTools.ts(+17 -14)📝
tests/boundary/cli/cutterCommands.test.ts(+71 -1)📝
tests/boundary/mcp/cutterCancellationMcp.test.ts(+102 -0)📝
tests/boundary/providers/CutterBridgeClient.test.ts(+102 -1)📝
tests/boundary/providers/CutterBridgeService.test.ts(+38 -0)📄 Description
Summary
Fixes #3946. Cancelling Cutter discovery now closes its active socket probes and stops queued probes, rather than continuing discovery after the caller stops waiting. CLI SIGINT returns typed
cancelledJSON and exit 130.Problem and expected behavior
Nine private descriptors with silent loopback peers reproduce the bug: eight probes remain connected after MCP abort, then the ninth starts roughly 25 seconds later. Cancellation should reach those probes and prevent further admission; ordinary authenticated discovery must remain usable.
Change and scope
CLI and MCP pass the caller signal through the shared service to the client. The bounded worker queue stops admission and drains admitted workers before propagating failure. Each terminal bridge request now settles only after its owned socket emits
close, so Promise settlement represents completed transport cleanup. The service returns the existing taggedResult/AnalysisCancelledError, preserving the abort reason rather than reporting cancellation as no live sessions. No cache or new concurrency limit is introduced.Ordinary fix within existing Cutter discovery authority; no new execution, injection, mutation, or protection-recovery capability. A separate maintainer scope decision is not applicable.
Contract and boundary impact
Expected effects:
Network contact here is the existing authenticated loopback bridge status request. The native verification fixture launches its own GUI; discovery does not.
Evidence and regression coverage
Clean-base stdio reproduction: all eight sockets still active 503 ms after abort; ninth admitted at 24,989 ms. Its natural completion was not observed; the fixture cleaned it up.
Final head stdio: eight sockets close within 6 ms; zero active after 503 ms; no ninth admission; authenticated rediscovery succeeds on the same connection. Both runs finish with verified empty owned process lineage.
Durable MCP regression inspects actual TCP peer closure, queued admission and connection reuse. It fails on the affected base. CLI regression sends SIGINT to an owned CLI child and asserts typed
cancelled, exit 130, peer closure and no queued ninth probe.Review regression: an observer on a real TCP client proved typed cancellation previously returned before local
close; the new test fails before the terminal-close fix and passes after it. Setup failure paths now enter cleanup before opening test listeners.Late cancellation regression: abort from the actual command socket close callback previously produced success. The shared service now returns typed cancellation with the confirmed-complete Evidence and original reason. An actual CLI child interrupted during final receipt acknowledgement returned exit 130,
code: "cancelled", anddetails.partial_observation.normalized_result.output: {"answer":42}. Confirmed completion does not acquire a false pending-native-work ledger.Shared service tests cover pre-abort and abort after a port returns, including opaque EACCES/cleanup-shaped reasons without false cleanup ownership. Successful discovery retains its original object identity.
Official Cutter 2.5.0 Qt5 AppImage: two CLI and three stdio MCP calls read the same controlled ELF on clean base and final head; source bytes unchanged, MCP disconnect preserves the GUI, fixture-owned cleanup verified. Native GUI cancellation is not claimed.
Separate native metadata defects are tracked in #4497 and #4498. Qt6 rejects even the official sample Python plugin (upstream rizinorg/cutter#3659); no REA workaround is included. Existing descriptor-open/FIFO work belongs to #4471 / #4486.
Observed, derived, and inferred claims remain distinguishable.
Artifact identity, source provenance, and failed attempts remain preserved.
Unsupported, incomplete, unavailable, or uncertain outcomes remain visible.
Validation performed
On final head
c68e401153528cc50e25e3bf772e0664d0cf874c, rebased onto180ba03bfddd5916251e81e97a500b1ede7a9eea:npm run test:focused --the 10 relevant Cutter CLI/MCP/provider and mutation-config/workflow files — 66 passed.npm run check:ci— passed, including typecheck, lint, format, Knip, configuration and architecture guards.npm run docs:check— passed.Equivalent healthy native task, three fresh-process workflows per revision, additional runs alternated, two CPU cores: base → fix medians wall 8.18 → 8.29 s, CPU 10.18 → 10.33 s, sampled process-family peak 1.049 → 1.055 GiB. First MCP discovery 43.7 → 44.9 ms, subsequent discovery 6.5 → 6.9 ms. Wall ranges 8.00–8.52 / 8.10–8.95 s. Shared host, uncontrolled OS caches/frequency: these are observations, not a speedup or stable cold-cache claim. Static checks ran serially below the 8 GiB total budget.
First completed task's whole captured wire plus CLI JSON serialized with
o200k_base: 835,210 → 835,264 token proxy, including the exactly unchanged 829,341-token full catalog. Named two-tool definitions plus calls/CLI proxy: 8,517 → 8,571. These are serialization estimates, not model input or billing; differences include run-specific identities. No new response fields or extra calls are introduced. SDK output validation stayed enabled using the supported per-call tool definition.Compatibility, safety, and release
/tmp/rea-3946-cutter-discovery-20261016/(not a portable CI artifact; essential results are inline above).Author readiness
Human owner: @N0zoM1z0
Recorded at the human owner's explicit instruction in this session to complete readiness declarations and request review. Diff review and checks described above were performed by the assistant; this does not claim an independent manual human review.
Before merge
type(scope): outcome.🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.