mirror of
https://github.com/morluto/rea.git
synced 2026-11-05 07:47:29 +00:00
[PR #4511] [MERGED] fix(source): retain CommonJS requires spelled as exact no-substitution templates #6279
Closed
opened 2026-10-31 01:13:14 +00:00 by bsakaguchi
·
0 comments
No Branch/Tag specified
main
release-please--branches--main--components--rea-agents
release-please--branches--main--components--rea-agents--release-notes
codex/procedure-reference-stacked
codex/kuna-independent-retry
codex/byte-search-overlay-coverage
codex/open-failure-target-receipt
codex/kuna-xref-evidence
codex/ghidra-ambiguous-procedure-recovery
codex/function-source-bundle
codex/trace-function-integration-prototype
codex/snapshot-source-closure
codex/recorded-evidence-array-pages
codex/evidence-recovery-redesign
codex/trace-feature-address-scope
codex/call-discovery-scope
codex/ghidra-literal-candidate-evidence
codex/decompile-directory-independent-retry
codex/retry-provenance-base
codex/value-flow-capability-experiment
codex/ghidra-containing-instruction
cursor/readme-discord-button-ef9f
dependabot/github_actions/actions/setup-node-7.1.0
dependabot/github_actions/actions/upload-artifact-7.0.2
dependabot/npm_and_yarn/npm-minor-and-patch-d8d97ce6df
codex/kuna-1989
fix/8559-native-ui-fixture-ownership
fix/8555-go-verifier-mcp-ownership
codex/provider-capability-recovery
fix/8642-rizin-target-stdin
codex/ghidra-memory-effect-scope
codex/ghidra-annotation-entry-selector
codex/ghidra-readonly-recovery
codex/ghidra-regex-verifier-recovery
codex/evidence-discovery-view-guidance
fix/8545-bulk-append-overflow
fix/8428-navigation-refusal-alternatives
codex/address-context-recovery
codex/matching-member-limitations
codex/unknown-scope-contract
codex/evidence-view-guidance
feat/8373-native-trace-views
codex/ghidra-snapshot-verifier-binding
codex/elf-export-visibility
codex/evidence-view-recovery
codex/native-reference-cli-help
codex/provider-candidate-observation-scope
codex/kuna-session-verification
codex/ghidra-switch-lifetime-guidance
codex/pseudocode-paging-discovery
codex/clarify-evidence-view-support
codex/kuna-xrefs-selector-recovery
codex/context-capacity-recovery
codex/evidence-closure-large-links
codex/same-function-evidence-identity
codex/ghidra-verifier-inspected-jdk
codex/audit-guided-workflows
codex/crash-prompt-retained-dossiers
codex/analysis-view-error-recovery
codex/kuna-verifier-target-selection
codex/ghidra-selected-project-call-coverage
codex/docs-native-analysis-scope
codex/ghidra-java-socket-boundary
codex/ghidra-retained-snapshot-verifier
codex/ghidra-search-inventory-facts
fix/8284-zero-argument-parameter-bindings
fix/8198-ui-action-handler-offset
fix/8257-elf-entry-label-identity
fix/8304-deferred-output-schema-projection
fix/8277-call-path-computed-target-uncertainty
fix/pr-8089-conflicts
fix/ci-static-duplicate-export
dependabot/npm_and_yarn/lint-staged-17.6.0
dependabot/github_actions/actions/download-artifact-8.0.2
dependabot/npm_and_yarn/write-file-atomic-8.0.0
dependabot/npm_and_yarn/canonicalize-5.1.0
dependabot/github_actions/actions/cache/restore-6.1.0
dependabot/npm_and_yarn/toon-format/toon-4.4.0
dependabot/github_actions/actions/deploy-pages-5.0.1
codex/review-fixes-pr-2403
codex/review-fixes-pr-2400
codex/process-terminal-width
codex/test-brittleness-cleanup
verify/7167-browser-connect-macos
fix/7167-browser-connect
feat/native-matching-allowance-setting
feat/browser-scenario-dry-run
test/managed-caller-parameters-20261024
codex/parser-fortythird-boundaries
fix/6926-pinvoke-platform-decorations-20261023
fix/6889-har-body-encoding-20261023
fix/6888-sqlite-schema-budget-20261023
fix/dependency-security-gates-6708
cursor/evidence-overwrite-rebase-b4ac
feat/4057-verify-native-exports
fix/windows-acl-observer-overhead-20261022
cursor/erlang-beam-restack-4476
cursor/pe-certificate-review-bf32
fix/6116-javascript-application-fs-errors
fix/6061-unmapped-runtime-script-unknown
feat/browser-scenario-summary
fix/pe-certificates
codex/verify-3407
cursor/rebase-5699
cursor/rebase-5352
cursor/rebase-5600
cursor/fix-cli-schema-omission-10a8
codex/audit-hopper-shutdown-reasons-20261021
fix/demangle-swift-omitted-record
fix/nib-boolean-value-types
cursor/cancellation-partial-observation-a5ac
fix/ib-object-limit-reasons
fix/electron-fuse-limit-advice
fix/kuna-doctor-dangling-cache
fix/fixed-budget-refusal-advice
fix/js-ipc-listener-dedup
fix/js-return-member-provenance
fix/dmg-integrity-retry-advice
fix/ida-doctor-readiness
fix/kuna-version-probe-output-drain
fix/legacy-swift-runtime-name-matching
fix/dylib-lazy-load-commands
fix/browser-scenario-startup-cancel
fix/swift-nested-punycode-classification
fix/compare-unselected-scopes
fix/objc-method-budget-coverage
fix/dmg-mounted-root-observations
audit/ci-tests-20261019-round2
release/6.7.0
fix/wabt-cleanup-retry-resolution
fix/electron-fuse-elf-pe-architecture
fix/native-plist-descriptor-ownership
fix/kuna-caller-cleanup-ownership
experiment/atomic-codemode-20261016
review/first-contributor-3776
fix/call-resolution-full-read-cycles
fix/member-mutation-selection-repeat
experiment/atomic-re-tools-20261015
perf/member-mutation-lazy-origins
perf/static-network-mutation-index
fix/hopper-startup-lifecycle
audit/3050-windows-proof-20261015
feat/windows-window-capture-2183
audit/3049-windows-proof-20261015
audit/3735-macos-fixtures-20261015
fix/batch-decompile-null-pseudocode
fix/kuna-inventory-honors-jobs
experiment/browser-codemode-tool-design-20261015
fix/hopper-clean-runtime-argv
codex/review-2049-27f1b367
review-fixes/pr-2787-routing
fix/3360-scoped-this-emitters
fix/3367-replaced-global-effects
fix/3838-compact-any-value-items
test/hopper-download-probe-20261015
codex/windows-runtime-creation-red-green-20261015
codex/windows-readonly-root-red-green-20261015
codex/windows-root-share-red-green-20261015
codex/exp-1685-win-mcp-startup
codex/bug-sweep-20261015
investigate/2190-windows-package-phases
investigate/3543-macos-cli-deadline
perf/3281-reverse-tools-feedback-quality
fix/3406-hopper-doctor-fixture
fix/3341-wrapper-require-test-context
fix/3301-owned-uninstall-fixtures
fix/3164-compiler-input-ownership
fix/pcap-cleanup-stdout-newline-20261014
perf/interface-builder-summary
codex/review-fixes-pr-1977
fix/ghidra-effective-jvm-platform
fix/docs-turkish-rust-link-20261013
fix/main-maintenance-ci-20261010
fix/recover-binary-session-process-effects
codex/review-fixes-pr-2457
codex/ci-required-cancellation-gate
fix/main-format-baseline-20261013
fix/setup-preserve-entry-fields
cursor/restore-main-checks-1ffc
fix/ghidra-bridge-hashmap-import
codex/shared-ci-jadx-json-default-20261013
codex/shared-ci-ghidra-test-groups-20261013
codex/shared-ci-java-fixture-format-20261013
codex/fix-intrinsic-invocation-boundaries
test/release-preflight-reusable-jobs
test/js-parameter-provenance-expectation
fix/linux-hopper-verification-current
test/2419-ghidra-elf-probe-size
followup/pr-1544-native-ida
codex/fold-pr-2230-contribution
docs/readme-responsible-use
fix/issue-2064
fix/issue-2050
fix/issue-2053
fix/issue-1968
fix/issue-1945
experiment/codemode-bridge-20261011
fix/tool-effects-negative-wording-1904-20261012
fix/1842-electron-interop-provenance
feat/recover-javascript-multi-input
refactor/website-i18n-prep
fix/nativeaot-pe-virtual-extent
fix/browser-verifier-ci-hang
fix/pe-resources-input-selection
docs/beginner-friendly-guides
docs/beginner-setup-guide
fix/javascript-analysis-worker-1563
fix/1649-ghidra-duplicate-names
fix/javascript-export-keys-integration-1369
test/maintenance-boundary-contracts-20261011
review/javascript-export-keys-1369
review/process-live-progress-1483
test/javascript-1495-growth-ratio
fix/ci-escape-timing
docs/normalized-terminal-geometry-1450
release/6.3.0
archive/release-6.3.0-pr1381
release/6.2.0
fix/electron-preload-dynamic-override
fix/javascript-self-referential-bundler-edges
release/6.1.0
cursor/grok-client-cherry-pick-0b56
feat/signature-posture
feat/dyld-shared-cache
feat/artifact-integrity-policy
feat/pkg-inventory
release/6.0.0
chore/sync-release-5.0.0
release/5.0.0
cursor/cloud-agent-node-787e
fix/javascript-xhr-open-endpoints
review/pr-711-realpath-fallback-wording
cleanup/replay-confinement
codex/test-suite-performance
codex/issue-foundations
codex/address-open-issues-2026-07-20
agent/javascript-vite-rollup-esbuild-adapters
agent/process-cleanup
agent/triage-integration
agent/unknown-commands-registry
feat/mcp-identity-metadata
morlvps/issue_cleanup
codex/installer-redesign
morl/roadmap-investigation-core
morl/roadmap-investigation-docs
release-please--branches--main--components--rea
rea-agents-6.8.0
rea-agents-6.7.0
rea-agents-6.6.0
experiment/atomic-codemode-wait-runtime-20261016
rea-agents-6.5.0
rea-agents-6.4.0
rea-agents-6.3.0
rea-agents-6.2.0
rea-agents-6.1.0
rea-agents-6.0.0
rea-agents-5.0.0
rea-agents-4.1.0
rea-agents-4.0.1
rea-agents-4.0.0
rea-agents-3.2.1
rea-agents-3.2.0
rea-agents-3.1.0
rea-agents-3.0.0
rea-agents-2.7.0
rea-agents-2.6.0
rea-agents-2.5.1
rea-agents-2.5.0
rea-agents-2.4.0
rea-agents-2.3.0
rea-agents-2.2.0
rea-agents-2.1.0
rea-agents-2.0.0
rea-agents-1.7.0
rea-agents-1.6.0
rea-agents-1.5.0
rea-agents-1.4.0
rea-agents-1.3.0
rea-agents-1.2.0
rea-agents-1.1.0
rea-agents-1.0.0
rea-agents-0.5.0
rea-agents-0.4.0
rea-agents-0.3.0
rea-0.2.1
rea-0.2.0
Labels
Clear labels
area: bridge
area: bridge
area: build
area: build
area: build
area: cli
area: domain
area: evidence
area: mcp
area: native
area: providers
area: runtime
area: server
area: setup
area: tests
bug
design
documentation
enhancement
enhancement
enhancement
experiment
help wanted
i18n
invalid
P0: critical
P1: high
P2: medium
P2: medium
P2: medium
P3: low
performance
provider-request
pull-request
Mirrored from GitHub Pull Request
question
roadmap
triage
No labels
area: bridge
area: bridge
area: build
area: build
area: build
area: cli
area: domain
area: evidence
area: mcp
area: native
area: providers
area: runtime
area: server
area: setup
area: tests
bug
design
documentation
enhancement
enhancement
enhancement
experiment
help wanted
i18n
invalid
P0: critical
P1: high
P2: medium
P2: medium
P2: medium
P3: low
performance
provider-request
pull-request
question
roadmap
triage
Milestone
Clear milestone
No items
No milestone
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".
No due date set.
Dependencies
No dependencies set.
Reference
morluto/rea#6279
Loading…
Add table
Add a link
Reference in a new issue
No description provided.
Delete branch "%!s()"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
📋 Pull Request Information
Original PR: https://github.com/morluto/rea/pull/4511
Author: @hemv-857
Created: 10/16/2026
Status: ✅ Merged
Merged: 10/21/2026
Merged by: @morluto
Base:
main← Head:fix-4382-template-require📝 Commits (2)
c60dea6fix(source): retain CommonJS requires spelled as exact no-substitution templatesc09ab40fix(source): admit TypeScript-wrapped exact require arguments via the shared literal reader📊 Changes
3 files changed (+113 additions, -7 deletions)
View changed files
📝
src/domain/referenceSourceImportParsing.ts(+9 -7)📝
tests/boundary/filesystem/referenceSourceComputedRequire.test.ts(+7 -0)➕
tests/boundary/filesystem/referenceSourceTemplateRequire.test.ts(+97 -0)📄 Description
Summary
Fixes #4382. The historical-source graph producer silently drops CommonJS dependencies spelled as exact no-substitution templates:
require(`mod`)yields{relationships: [], parse_failures: [], limitations: []}whilerequire("mod")yields a parsedrequiresedge.Problem and expected behavior
Smallest trigger: a
.cjssource file containingrequire(`mod`). Violated invariant: the supported historical-source CommonJS parser retains a dependency for an unshadowed loader called with an exact string, and an expression-free template supplies one exact string.Root cause (source-inspected): in
src/domain/referenceSourceImportParsing.ts, the require branch is gated byisModuleExpression, which narrows toStringLiteral | CallExpression. A no-substitutionTemplateLiteralpasses the callee and unshadowed-binding checks, then is filtered at that gate beforemoduleSpecifierFromExpressioncan run, so it exits with no relationship, no parse failure, and no limitation. The extractor andsafeModuleNameare likewise StringLiteral-only.Change and scope
TemplateLiteralarguments at the CommonJS require gate (isExactTemplateExpression).readExactJavaScriptLiteral(src/domain/javascript/javascriptAstValues.ts), which already treats zero-expression templates as exact strings.c09ab40fd): the require-branch gate matched the outer AST node while the reader unwraps runtime-transparent TS wrappers, sorequire(pkgas const)andrequire(pkg!)were still omitted. The gate was removed; the shared reader alone owns argument exactness, which also retains TS-wrapped quoted requires (same root cause, superset of the typed outcome).Intentionally not included, per the issue's typed outcome:
import()keeps the explicit<dynamic-import>partial with no invented target (template or computed).require(`./${name}.js`)) stay silent rather than guessing a target.safeModuleNameandImportExpressionhandling are untouched.Contribution scope: not applicable — ordinary fix within existing domain boundaries; no provider, capability, or maintainer scope decision involved.
Contract and boundary impact
src/domain/referenceSourceImportParsing.ts(domain graph producer); earliest changed stage is reference-source relationship emission during artifact/evidence registration.requiresedge for exact-template spellings (relationship sets can gain entries relative to 6.5.0).docs/public/product-catalog.json), package, or installation impact: none; no generated files touched.Expected effects:
Evidence and regression coverage
tests/boundary/filesystem/referenceSourceTemplateRequire.test.ts(template + quoted controls, computed require and computed dynamic-import controls);tests/boundary/filesystem/referenceSourceComputedRequire.test.tsgains the now-correctrequire(`./dep.js`)edge inunknown.cjs(previously encoded the silent omission this issue reports; member-callee variants remain gated by mutation indexing and produce no new edges).templatedassertion only (quoted control passes, all four issue controls pass), matching the issue's probe output. The issue's probe asserts the pre-fix omission, so the fixed behavior was verified by asserting its typed outcome instead (below).For evidence-bearing changes:
Validation performed
npm ci— locked dependency installation refreshed (main's lockfile addedtsx).npm run test:focused -- tests/boundary/filesystem/referenceSourceTemplateRequire.test.ts— RED before fix (template edge missing, quoted control passing), 1/1 pass after.npm run test:focused -- tests/boundary/filesystem/referenceSourceTemplateRequire.test.ts tests/boundary/filesystem/referenceSourceComputedRequire.test.ts tests/boundary/filesystem/referenceSourceDynamicImports.test.ts tests/boundary/filesystem/referenceSourceShadowedRequire.test.ts tests/boundary/cli/referenceSourceDirectoryImports.test.ts tests/boundary/filesystem/referenceSourceImport.test.ts— 6 files, 26/26 pass after updating the staleunknown.cjsexpectation.tsx,parseReferenceSourceImportsonfixture.cjs):require(\mod`)returns{to: "mod", kind: "requires", resolution: "external", parse_state: "parsed", resolutionStrategy: "runtime-require"}; computed require returns no relationship;import(`mod`)stayspartial;import(`./${name}.js`)stays resolutionunknown`; static ESM template import/export still report parse failures — all issue controls asserted, exit 0.tsx):require(pkgas const),require("pkg" as const),require(pkg!), andrequire(pkgsatisfies string)each returnto: "pkg",parse_state: "parsed";require(a${x}cas const)stays silent;import(pkgas const)stays<dynamic-import>partial.npm run test:focusedafter review fix (c09ab40fd) — 6 files, 27/27 pass (adds.ts+createRequireboundary coverage: plain,as const,!, wrapped-string all retained; computed wrapped template silent).npm run check:fast— typecheck + lint, 2/2 tasks successful (rerun after review fix).Compatibility, safety, and release
requiresentries for template spellings relative to earlier releases.Author readiness
Human owner: @hemv-857
Before merge
type(scope): outcome.Maintainer blocker verification
The require-wrapper finding is already fixed at the producing parser: exactness delegates to readExactJavaScriptLiteral through moduleSpecifierFromExpression rather than an AST-kind gate. On this exact head, the focused referenceSourceTemplateRequire and referenceSourceComputedRequire suites passed 3/3, including as-const/non-null wrappers and unresolved computed-template controls. No additional source edit was needed.
🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.