[PR #4535] [CLOSED] fix(rizin): disable color by default for one-shot commands #6292

New issue

Closed

opened 2026-10-31 01:13:20 +00:00 by bsakaguchi · 0 comments

bsakaguchi commented

2026-10-31 01:13:20 +00:00

Owner

📋 Pull Request Information

Original PR: https://github.com/morluto/rea/pull/4535
Author: @shoyann
Created: 10/16/2026
Status: ❌ Closed

Base: main ← Head: fix/rizin-default-color

📝 Commits (3)

142f434 fix(rizin): disable color by default for one-shot commands
564bf35 chore: sync main into Rizin color fix
3f3fd76 chore: sync main CI repairs into Rizin color fix

📊 Changes

7 files changed (+69 additions, -3 deletions)

View changed files

📝 docs/reverse-engineering-tools.md (+1 -1)
📝 docs/testing.md (+7 -0)
📝 src/contracts/reverseEngineeringToolContracts.ts (+1 -1)
📝 src/rizin/RizinCommand.ts (+2 -0)
📝 tests/boundary/mcp/reverseEngineeringEnvironmentMcp.test.ts (+55 -0)
📝 tests/boundary/providers/RizinDebugSessionCoverage.part1.test.ts (+2 -0)
📝 tests/composition/reverseEngineering.test.ts (+1 -1)

📄 Description

Summary

Fixes #4488. One-shot Rizin disassembly can include terminal color escapes in CLI/MCP Evidence. Pass -e scr.color=0 before the caller's command to default to plain output. Explicit e scr.color=1; ... still enables color, and raw and normalized Evidence retain the exact provider text.

The existing rizinCommand profile owns this default. Update its tool description, documentation, argument regressions, and real-provider MCP comparisons. Persistent debugger startup already passes -0, which disables color; the input/output schemas and command authority are unchanged.

Evidence and validation

Latest synchronization: 3f3fd762 merges main b83b9caf, including the upstream CI repairs. The Rizin patch remains seven files, +69/-3.

Executed on this merged tree with WSL Ubuntu x86-64, Node 24.18.0, npm 11.16.0, and Rizin 0.9.1:

Six relevant CLI/MCP/composition/provider files: 43 passed, with the three optional real-engine cases skipped when REA_RIZIN_COMMAND was unset.
The documented MCP file run separately with the real engine: 6 passed, including default disassembly, explicit color, and JSON bytes. These runs cover 46 distinct tests; the real cases compare recorded arguments and raw/normalized output against direct Rizin execution.
npm run check, npm run docs:check (including five README consistency tests), and git diff --check passed. Normal pre-commit formatting/lint and pre-push check:fast hooks passed; the committed tree matches the tested tree.

Original reproduction on base 6c06f406 used the same real Rizin version: default disassembly returned ANSI-colored output, and all three new MCP cases rejected the missing recorded startup option. Explicit-color and JSON controls otherwise matched. This is historical baseline evidence, not a new run on current main.

Real Windows/macOS engine workflows and a live debugger session were not exercised. The full deterministic suite and coverage are left to CI; no performance or token-cost improvement is claimed.

Author readiness

Human owner: @shoyann

I reviewed the final diff and relevant existing code, understand the change and its edge cases, and take responsibility for the complete PR, including AI-assisted work.
I checked the evidence above, confirmed it supports the current change, and recorded meaningful validation gaps.
I declare this PR ready for initial maintainer review.

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/morluto/rea/pull/4535 **Author:** [@shoyann](https://github.com/shoyann) **Created:** 10/16/2026 **Status:** ❌ Closed **Base:** `main` ← **Head:** `fix/rizin-default-color` --- ### 📝 Commits (3) - [`142f434`](https://github.com/morluto/rea/commit/142f43493a9e28adcfb3bb14d345b8abb434e19a) fix(rizin): disable color by default for one-shot commands - [`564bf35`](https://github.com/morluto/rea/commit/564bf35515f76be83f80148ac3957b3f8a71ce9b) chore: sync main into Rizin color fix - [`3f3fd76`](https://github.com/morluto/rea/commit/3f3fd76282c6cf4fcd4304fcfd8a27aa27a3ceb3) chore: sync main CI repairs into Rizin color fix ### 📊 Changes **7 files changed** (+69 additions, -3 deletions) <details> <summary>View changed files</summary> 📝 `docs/reverse-engineering-tools.md` (+1 -1) 📝 `docs/testing.md` (+7 -0) 📝 `src/contracts/reverseEngineeringToolContracts.ts` (+1 -1) 📝 `src/rizin/RizinCommand.ts` (+2 -0) 📝 `tests/boundary/mcp/reverseEngineeringEnvironmentMcp.test.ts` (+55 -0) 📝 `tests/boundary/providers/RizinDebugSessionCoverage.part1.test.ts` (+2 -0) 📝 `tests/composition/reverseEngineering.test.ts` (+1 -1) </details> ### 📄 Description ## Summary Fixes #4488. One-shot Rizin disassembly can include terminal color escapes in CLI/MCP Evidence. Pass `-e scr.color=0` before the caller's command to default to plain output. Explicit `e scr.color=1; ...` still enables color, and raw and normalized Evidence retain the exact provider text. The existing `rizinCommand` profile owns this default. Update its tool description, documentation, argument regressions, and real-provider MCP comparisons. Persistent debugger startup already passes `-0`, which disables color; the input/output schemas and command authority are unchanged. ## Evidence and validation Latest synchronization: `3f3fd762` merges main `b83b9caf`, including the upstream CI repairs. The Rizin patch remains seven files, +69/-3. Executed on this merged tree with WSL Ubuntu x86-64, Node 24.18.0, npm 11.16.0, and Rizin 0.9.1: - Six relevant CLI/MCP/composition/provider files: **43 passed**, with the three optional real-engine cases skipped when `REA_RIZIN_COMMAND` was unset. - The documented MCP file run separately with the real engine: **6 passed**, including default disassembly, explicit color, and JSON bytes. These runs cover **46 distinct tests**; the real cases compare recorded arguments and raw/normalized output against direct Rizin execution. - `npm run check`, `npm run docs:check` (including five README consistency tests), and `git diff --check` passed. Normal pre-commit formatting/lint and pre-push `check:fast` hooks passed; the committed tree matches the tested tree. Original reproduction on base `6c06f406` used the same real Rizin version: default disassembly returned ANSI-colored output, and all three new MCP cases rejected the missing recorded startup option. Explicit-color and JSON controls otherwise matched. This is historical baseline evidence, not a new run on current main. Real Windows/macOS engine workflows and a live debugger session were not exercised. The full deterministic suite and coverage are left to CI; no performance or token-cost improvement is claimed. ## Author readiness Human owner: @shoyann - [x] I reviewed the final diff and relevant existing code, understand the change and its edge cases, and take responsibility for the complete PR, including AI-assisted work. - [x] I checked the evidence above, confirmed it supports the current change, and recorded meaningful validation gaps. - [x] I declare this PR ready for initial maintainer review. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>

bsakaguchi

2026-10-31 01:13:20 +00:00