mirror of
https://github.com/morluto/rea.git
synced 2026-11-05 06:45:22 +00:00
[PR #4565] [MERGED] fix(javascript): drop built-in effects for visibly replaced globals #6310
Closed
opened 2026-10-31 01:13:28 +00:00 by bsakaguchi
·
0 comments
No Branch/Tag specified
main
codex/procedure-reference-stacked
release-please--branches--main--components--rea-agents
release-please--branches--main--components--rea-agents--release-notes
codex/kuna-independent-retry
codex/byte-search-overlay-coverage
codex/open-failure-target-receipt
codex/kuna-xref-evidence
codex/ghidra-ambiguous-procedure-recovery
codex/function-source-bundle
codex/trace-function-integration-prototype
codex/snapshot-source-closure
codex/recorded-evidence-array-pages
codex/evidence-recovery-redesign
codex/trace-feature-address-scope
codex/call-discovery-scope
codex/ghidra-literal-candidate-evidence
codex/decompile-directory-independent-retry
codex/retry-provenance-base
codex/value-flow-capability-experiment
codex/ghidra-containing-instruction
cursor/readme-discord-button-ef9f
dependabot/github_actions/actions/setup-node-7.1.0
dependabot/github_actions/actions/upload-artifact-7.0.2
dependabot/npm_and_yarn/npm-minor-and-patch-d8d97ce6df
codex/kuna-1989
fix/8559-native-ui-fixture-ownership
fix/8555-go-verifier-mcp-ownership
codex/provider-capability-recovery
fix/8642-rizin-target-stdin
codex/ghidra-memory-effect-scope
codex/ghidra-annotation-entry-selector
codex/ghidra-readonly-recovery
codex/ghidra-regex-verifier-recovery
codex/evidence-discovery-view-guidance
fix/8545-bulk-append-overflow
fix/8428-navigation-refusal-alternatives
codex/address-context-recovery
codex/matching-member-limitations
codex/unknown-scope-contract
codex/evidence-view-guidance
feat/8373-native-trace-views
codex/ghidra-snapshot-verifier-binding
codex/elf-export-visibility
codex/evidence-view-recovery
codex/native-reference-cli-help
codex/provider-candidate-observation-scope
codex/kuna-session-verification
codex/ghidra-switch-lifetime-guidance
codex/pseudocode-paging-discovery
codex/clarify-evidence-view-support
codex/kuna-xrefs-selector-recovery
codex/context-capacity-recovery
codex/evidence-closure-large-links
codex/same-function-evidence-identity
codex/ghidra-verifier-inspected-jdk
codex/audit-guided-workflows
codex/crash-prompt-retained-dossiers
codex/analysis-view-error-recovery
codex/kuna-verifier-target-selection
codex/ghidra-selected-project-call-coverage
codex/docs-native-analysis-scope
codex/ghidra-java-socket-boundary
codex/ghidra-retained-snapshot-verifier
codex/ghidra-search-inventory-facts
fix/8284-zero-argument-parameter-bindings
fix/8198-ui-action-handler-offset
fix/8257-elf-entry-label-identity
fix/8304-deferred-output-schema-projection
fix/8277-call-path-computed-target-uncertainty
fix/pr-8089-conflicts
fix/ci-static-duplicate-export
dependabot/npm_and_yarn/lint-staged-17.6.0
dependabot/github_actions/actions/download-artifact-8.0.2
dependabot/npm_and_yarn/write-file-atomic-8.0.0
dependabot/npm_and_yarn/canonicalize-5.1.0
dependabot/github_actions/actions/cache/restore-6.1.0
dependabot/npm_and_yarn/toon-format/toon-4.4.0
dependabot/github_actions/actions/deploy-pages-5.0.1
codex/review-fixes-pr-2403
codex/review-fixes-pr-2400
codex/process-terminal-width
codex/test-brittleness-cleanup
verify/7167-browser-connect-macos
fix/7167-browser-connect
feat/native-matching-allowance-setting
feat/browser-scenario-dry-run
test/managed-caller-parameters-20261024
codex/parser-fortythird-boundaries
fix/6926-pinvoke-platform-decorations-20261023
fix/6889-har-body-encoding-20261023
fix/6888-sqlite-schema-budget-20261023
fix/dependency-security-gates-6708
cursor/evidence-overwrite-rebase-b4ac
feat/4057-verify-native-exports
fix/windows-acl-observer-overhead-20261022
cursor/erlang-beam-restack-4476
cursor/pe-certificate-review-bf32
fix/6116-javascript-application-fs-errors
fix/6061-unmapped-runtime-script-unknown
feat/browser-scenario-summary
fix/pe-certificates
codex/verify-3407
cursor/rebase-5699
cursor/rebase-5352
cursor/rebase-5600
cursor/fix-cli-schema-omission-10a8
codex/audit-hopper-shutdown-reasons-20261021
fix/demangle-swift-omitted-record
fix/nib-boolean-value-types
cursor/cancellation-partial-observation-a5ac
fix/ib-object-limit-reasons
fix/electron-fuse-limit-advice
fix/kuna-doctor-dangling-cache
fix/fixed-budget-refusal-advice
fix/js-ipc-listener-dedup
fix/js-return-member-provenance
fix/dmg-integrity-retry-advice
fix/ida-doctor-readiness
fix/kuna-version-probe-output-drain
fix/legacy-swift-runtime-name-matching
fix/dylib-lazy-load-commands
fix/browser-scenario-startup-cancel
fix/swift-nested-punycode-classification
fix/compare-unselected-scopes
fix/objc-method-budget-coverage
fix/dmg-mounted-root-observations
audit/ci-tests-20261019-round2
release/6.7.0
fix/wabt-cleanup-retry-resolution
fix/electron-fuse-elf-pe-architecture
fix/native-plist-descriptor-ownership
fix/kuna-caller-cleanup-ownership
experiment/atomic-codemode-20261016
review/first-contributor-3776
fix/call-resolution-full-read-cycles
fix/member-mutation-selection-repeat
experiment/atomic-re-tools-20261015
perf/member-mutation-lazy-origins
perf/static-network-mutation-index
fix/hopper-startup-lifecycle
audit/3050-windows-proof-20261015
feat/windows-window-capture-2183
audit/3049-windows-proof-20261015
audit/3735-macos-fixtures-20261015
fix/batch-decompile-null-pseudocode
fix/kuna-inventory-honors-jobs
experiment/browser-codemode-tool-design-20261015
fix/hopper-clean-runtime-argv
codex/review-2049-27f1b367
review-fixes/pr-2787-routing
fix/3360-scoped-this-emitters
fix/3367-replaced-global-effects
fix/3838-compact-any-value-items
test/hopper-download-probe-20261015
codex/windows-runtime-creation-red-green-20261015
codex/windows-readonly-root-red-green-20261015
codex/windows-root-share-red-green-20261015
codex/exp-1685-win-mcp-startup
codex/bug-sweep-20261015
investigate/2190-windows-package-phases
investigate/3543-macos-cli-deadline
perf/3281-reverse-tools-feedback-quality
fix/3406-hopper-doctor-fixture
fix/3341-wrapper-require-test-context
fix/3301-owned-uninstall-fixtures
fix/3164-compiler-input-ownership
fix/pcap-cleanup-stdout-newline-20261014
perf/interface-builder-summary
codex/review-fixes-pr-1977
fix/ghidra-effective-jvm-platform
fix/docs-turkish-rust-link-20261013
fix/main-maintenance-ci-20261010
fix/recover-binary-session-process-effects
codex/review-fixes-pr-2457
codex/ci-required-cancellation-gate
fix/main-format-baseline-20261013
fix/setup-preserve-entry-fields
cursor/restore-main-checks-1ffc
fix/ghidra-bridge-hashmap-import
codex/shared-ci-jadx-json-default-20261013
codex/shared-ci-ghidra-test-groups-20261013
codex/shared-ci-java-fixture-format-20261013
codex/fix-intrinsic-invocation-boundaries
test/release-preflight-reusable-jobs
test/js-parameter-provenance-expectation
fix/linux-hopper-verification-current
test/2419-ghidra-elf-probe-size
followup/pr-1544-native-ida
codex/fold-pr-2230-contribution
docs/readme-responsible-use
fix/issue-2064
fix/issue-2050
fix/issue-2053
fix/issue-1968
fix/issue-1945
experiment/codemode-bridge-20261011
fix/tool-effects-negative-wording-1904-20261012
fix/1842-electron-interop-provenance
feat/recover-javascript-multi-input
refactor/website-i18n-prep
fix/nativeaot-pe-virtual-extent
fix/browser-verifier-ci-hang
fix/pe-resources-input-selection
docs/beginner-friendly-guides
docs/beginner-setup-guide
fix/javascript-analysis-worker-1563
fix/1649-ghidra-duplicate-names
fix/javascript-export-keys-integration-1369
test/maintenance-boundary-contracts-20261011
review/javascript-export-keys-1369
review/process-live-progress-1483
test/javascript-1495-growth-ratio
fix/ci-escape-timing
docs/normalized-terminal-geometry-1450
release/6.3.0
archive/release-6.3.0-pr1381
release/6.2.0
fix/electron-preload-dynamic-override
fix/javascript-self-referential-bundler-edges
release/6.1.0
cursor/grok-client-cherry-pick-0b56
feat/signature-posture
feat/dyld-shared-cache
feat/artifact-integrity-policy
feat/pkg-inventory
release/6.0.0
chore/sync-release-5.0.0
release/5.0.0
cursor/cloud-agent-node-787e
fix/javascript-xhr-open-endpoints
review/pr-711-realpath-fallback-wording
cleanup/replay-confinement
codex/test-suite-performance
codex/issue-foundations
codex/address-open-issues-2026-07-20
agent/javascript-vite-rollup-esbuild-adapters
agent/process-cleanup
agent/triage-integration
agent/unknown-commands-registry
feat/mcp-identity-metadata
morlvps/issue_cleanup
codex/installer-redesign
morl/roadmap-investigation-core
morl/roadmap-investigation-docs
release-please--branches--main--components--rea
rea-agents-6.8.0
rea-agents-6.7.0
rea-agents-6.6.0
experiment/atomic-codemode-wait-runtime-20261016
rea-agents-6.5.0
rea-agents-6.4.0
rea-agents-6.3.0
rea-agents-6.2.0
rea-agents-6.1.0
rea-agents-6.0.0
rea-agents-5.0.0
rea-agents-4.1.0
rea-agents-4.0.1
rea-agents-4.0.0
rea-agents-3.2.1
rea-agents-3.2.0
rea-agents-3.1.0
rea-agents-3.0.0
rea-agents-2.7.0
rea-agents-2.6.0
rea-agents-2.5.1
rea-agents-2.5.0
rea-agents-2.4.0
rea-agents-2.3.0
rea-agents-2.2.0
rea-agents-2.1.0
rea-agents-2.0.0
rea-agents-1.7.0
rea-agents-1.6.0
rea-agents-1.5.0
rea-agents-1.4.0
rea-agents-1.3.0
rea-agents-1.2.0
rea-agents-1.1.0
rea-agents-1.0.0
rea-agents-0.5.0
rea-agents-0.4.0
rea-agents-0.3.0
rea-0.2.1
rea-0.2.0
Labels
Clear labels
area: bridge
area: bridge
area: build
area: build
area: build
area: cli
area: domain
area: evidence
area: mcp
area: native
area: providers
area: runtime
area: server
area: setup
area: tests
bug
design
documentation
enhancement
enhancement
enhancement
experiment
help wanted
i18n
invalid
P0: critical
P1: high
P2: medium
P2: medium
P2: medium
P3: low
performance
provider-request
pull-request
Mirrored from GitHub Pull Request
question
roadmap
triage
No labels
area: bridge
area: bridge
area: build
area: build
area: build
area: cli
area: domain
area: evidence
area: mcp
area: native
area: providers
area: runtime
area: server
area: setup
area: tests
bug
design
documentation
enhancement
enhancement
enhancement
experiment
help wanted
i18n
invalid
P0: critical
P1: high
P2: medium
P2: medium
P2: medium
P3: low
performance
provider-request
pull-request
question
roadmap
triage
Milestone
Clear milestone
No items
No milestone
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".
No due date set.
Dependencies
No dependencies set.
Reference
morluto/rea#6310
Loading…
Add table
Add a link
Reference in a new issue
No description provided.
Delete branch "%!s()"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
📋 Pull Request Information
Original PR: https://github.com/morluto/rea/pull/4565
Author: @amyanger
Created: 10/16/2026
Status: ✅ Merged
Merged: 10/22/2026
Merged by: @morluto
Base:
main← Head:fix/3367-replaced-global-builtins📝 Commits (1)
bde517ffix(javascript): drop built-in effects for visibly replaced globals📊 Changes
5 files changed (+150 additions, -6 deletions)
View changed files
📝
docs/javascript-application-workflows.md(+5 -0)📝
src/domain/javascript/javascriptSemanticAnalysis.runtime_boundaries.test.ts(+58 -0)📝
src/domain/javascript/javascriptSemanticAsyncEffects.ts(+3 -1)📝
src/domain/javascript/javascriptSemanticDataEffects.ts(+14 -5)➕
tests/acceptance/applications/javascriptReplacedGlobalEffectsCli.test.ts(+70 -0)📄 Description
Summary
Fixes #3367.
analyze-javascript-applicationkept resolved Node timer,fetchrequest andJSON.parseboundary effects after the source visibly replaced those globals, for examplesetTimeout = () => null; setTimeout(work, 100). The semantic collectors now require the global to have no visible source-local write before admitting the built-in effect, so a replaced global no longer produces a resolved built-in effect. Unmodified built-ins keep their effects.Problem and expected behavior
Smallest trigger, from the issue:
On base this produced resolved
schedules-timer,constructs-requestandparsesrelations, identical to a control without the three assignments. That violates the documented rule that resolved relationships name uniquely identified admitted static targets. Expected: no resolved built-in effect after a visible replacement, and explicit uncertainty if a speculative classification remains.Change and scope
timerMethod(javascriptSemanticAsyncEffects.ts), andboundaryDetailsandrequestMethod(javascriptSemanticDataEffects.ts) now also call the existingisUnmodifiedGlobalReferenceguard fromjavascriptSemanticAmbientWrites.tsfor setTimeout/setInterval and their cancel functions,fetch,WebSocket,JSON.parseand the global coercions (String,Number,Boolean,parseInt,parseFloat). The guard reads the ambient-write index, whichanalyzeParsedJavaScriptSemanticsStepsalways builds before these collectors run.This follows the static analyzer, which already guards
fetch,WebSocket,EventSource,URLandWorkerwith the same helper (javascriptStaticAnalysisCalls.ts:506-512,:173,:207). The existing binding and resolution-blocked checks stay in place, so the change only narrows admission and never admits a new form such asglobalThis.JSON.parse(...). Name filters run before the guard, so unrelated unbound calls do not pay for it.Resulting shapes:
fetch,WebSocketor coercion produces no built-in operation. The call stays visible as an existingcall-flowunknown ("Unresolved call target fetch"). This matches the existing "does not treat shadowed timer globals as Node timers" behavior.JSON.parsefalls through to the existing generic.parserule: aparsesrelation withcandidateresolution plus the boundary unknown "Static parse boundary kind is a candidate."Precision trade-off (accepted by the human owner after measurement): the guard follows the documented "a visible possible write is sufficient" rule and does not evaluate order or reachability. A computed write through a global object (
globalThis[k] = x), a guarded polyfill (if (!globalThis.fetch) globalThis.fetch = poly) or a write after the call also removes the resolved effect for that file. Measured cost on real code is below.docs/javascript-application-workflows.mdnow states this.Not included:
Promisehas the same gap (isUnshadowedGlobalPromiseinjavascriptSemanticPromises.tsdoes not consult ambient writes). It is outside this issue and left for a follow-up. Folding the ambient-write check into a shared unshadowed-global helper was also left out, because the ambient-write indexer usesisUnshadowedGlobalto build the index itself.Prior attempt: #3849 (closed by its author, unmerged) added a three-state classification that kept computed-key writes as "possibly replaced" partial effects. Its automated review found that the extra state could treat writes through unknown targets as exact replacements and could leak partial
fetchidentity into confirmed response consumers. This PR keeps the existing fail-closed guard instead, so a suppressedfetchalso removes its response consumers rather than reporting them as confirmed.Scope decision: not applicable. This is an ordinary fix inside the existing static analysis boundary.
Contract and boundary impact
src/domain/javascript), before graph projection.JSON.parse, gain a candidate relation and boundary unknown. Function fingerprintcomponents.effectscan change for affected functions, so cross-version comparisons of such files will show effect differences.Expected effects:
Evidence and regression coverage
tests/acceptance/applications/javascriptReplacedGlobalEffectsCli.test.ts(new): the issue's fixture extended withWebSocketandString, through both the CLI and stdio MCP viacliTestandanalyzeJavaScriptDirectory, with a control without the replacements.src/domain/javascript/javascriptSemanticAnalysis.runtime_boundaries.test.ts: a newreplaced built-in globalsblock with 7 replacement cases (setTimeout,globalThis.setTimeout,fetch,WebSocket,JSON.parse,JSON,String) and a control showing unrelated writes (JSON.stringify = x,other.setTimeout = x) keep every effect.8116dc065, public CLI with the issue's fixture and an isolated HOME): replaced fixture printedconstructs-request resolved,schedules-timer resolved,parses resolved, no effect unknowns. The control printed the same three. On the branch the replaced fixture printed onlyparses candidatewith the boundary unknown, and the control was unchanged.npm run test:focused -- <both files>: 9 failed, 6 passed. All 7 replacement module cases and both acceptance surfaces fail, while the controls and existing cases pass.npm run test:local): replacing each of the 4 guards (timer, coercion, request,JSON.parse) with a constant made 2, 1, 2 and 2 new tests fail respectively. The unmutated tree passed 13 of 13.node_modules, matching assignment-like patterns plus random effect-bearing files: 0 changed. 12 had effects, 81 effect relations in all.globalThis,windoworself(Algolia UMD builds, pino browser, Playwright, Vitest chunks): 29 unchanged, 1 changed. Invitest/dist/chunks/source-map.*.js,globalThis[SAFE_TIMERS_SYMBOL] = {...}turned one resolvedJSON.parseinto a candidate. Totals across those 30 files: timers 39 to 39, coercions 30 to 30, resolved parses 47 to 46.constructs-request:resolved, parses:resolved, schedules-timer:resolvedtoparses:candidate.Promisereplacement is not covered. Large minified real-world application bundles beyond the 74 files above were not measured.For evidence-bearing changes:
Validation performed
All on macOS with the
.nvmrcNode. Work was done on upstream8116dc065, then rebased ontoae07d1517(two Ghidra-only commits); the focused set andtest:changedwere rerun after the rebase with the results below.npm run test:focused -- src/domain/javascript/javascriptSemanticAnalysis.runtime_boundaries.test.ts tests/acceptance/applications/javascriptReplacedGlobalEffectsCli.test.ts src/domain/javascript/javascriptSemanticAnalysis.builtin_defaults.test.ts src/domain/javascript/javascriptSemanticAmbientWrites.test.ts tests/acceptance/applications/javascriptBuiltinDefaultsCli.test.ts tests/acceptance/applications/javascriptEventPayload.test.ts tests/acceptance/applications/javascriptTimerWritesCli.test.ts: 7 files, 131 tests passed, before and after the rebasenpm run check:fast: passednpm run test:changed -- --base ae07d151704bac5f0129985cedb92546d2d5411e(after rebase): 120 files, 2901 tests passed. Before the rebase, against8116dc065: same resultnpm run check: passed, 6 of 6 tasks, module boundaries and architecture guards passednpm run docs:check: passednpm run verify:test-discovery: discovered all 1440 test files exactly oncenpm run test:localover 61 semantic, application and static analysis test files (src/domain/javascript/javascriptSemantic*.test.ts,javascriptApplication*.test.ts,javascriptStaticAnalysis*.test.ts,src/application/javascript/JavaScriptSemanticGraph*.test.ts), run by an independent reviewer: 1303 tests passedReview:
fetchdisappear with it./code-review high, findings and actions:JSON.parsebecomes a candidate: kept. The candidate comes from the pre-existing generic.parserule, and suppressed calls stay visible ascall-flowunknowns.isUnshadowedGlobalalso admits CommonJS wrapper bindings and the member form would admit new callee shapes.WebSocket/String: fixed, now usescliTeston both surfaces with all five globals.Compatibility, safety, and release
Author readiness
Human owner: @amyanger
Before merge
type(scope): outcome.🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.