[PR #4583] [CLOSED] fix(ghidra): discover Homebrew keg-only openjdk candidates on macOS (#4556) #6321

New issue

Closed

opened 2026-10-31 01:13:34 +00:00 by bsakaguchi · 0 comments

bsakaguchi commented

2026-10-31 01:13:34 +00:00

Owner

📋 Pull Request Information

Original PR: https://github.com/morluto/rea/pull/4583
Author: @rudrakshagarwal4200-ai
Created: 10/16/2026
Status: ❌ Closed

Base: main ← Head: rudrakshagarwal4200-ai-patch-1

📝 Commits (1)

ef49fe5 Refactor Java command selection logic

📊 Changes

1 file changed (+17 additions, -8 deletions)

View changed files

📝 src/ghidra/GhidraInstallation.ts (+17 -8)

📄 Description

Summary

Fixes #4556.

On macOS, Homebrew's openjdk formula is keg-only and is not symlinked into /opt/homebrew/bin or standard system PATH. When JAVA_HOME is unset, Ghidra prerequisite checks fail even when a supported JDK is installed via Homebrew.

Fix

Added /opt/homebrew/opt/openjdk/libexec/openjdk.jdk/Contents/Home/bin/java (Apple Silicon) and /usr/local/opt/openjdk/libexec/openjdk.jdk/Contents/Home/bin/java (Intel) to javaCandidates fallback order when options.javaHome is undefined, preserving "java" as the first candidate.

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/morluto/rea/pull/4583 **Author:** [@rudrakshagarwal4200-ai](https://github.com/rudrakshagarwal4200-ai) **Created:** 10/16/2026 **Status:** ❌ Closed **Base:** `main` ← **Head:** `rudrakshagarwal4200-ai-patch-1` --- ### 📝 Commits (1) - [`ef49fe5`](https://github.com/morluto/rea/commit/ef49fe516852a2471385de9823092d990ed04128) Refactor Java command selection logic ### 📊 Changes **1 file changed** (+17 additions, -8 deletions) <details> <summary>View changed files</summary> 📝 `src/ghidra/GhidraInstallation.ts` (+17 -8) </details> ### 📄 Description ### Summary Fixes #4556. On macOS, Homebrew's `openjdk` formula is keg-only and is not symlinked into `/opt/homebrew/bin` or standard system PATH. When `JAVA_HOME` is unset, Ghidra prerequisite checks fail even when a supported JDK is installed via Homebrew. ### Fix Added `/opt/homebrew/opt/openjdk/libexec/openjdk.jdk/Contents/Home/bin/java` (Apple Silicon) and `/usr/local/opt/openjdk/libexec/openjdk.jdk/Contents/Home/bin/java` (Intel) to `javaCandidates` fallback order when `options.javaHome` is undefined, preserving `"java"` as the first candidate. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>

bsakaguchi

2026-10-31 01:13:34 +00:00

closed this issue
added the
pull-request
label

bsakaguchi referenced this issue

2026-11-01 21:46:44 +00:00

[PR #6321] [MERGED] fix(reconstruction): classify residual graph failures as invalid input #7280

No milestone

No project

No assignees

1 participant

Notifications

Due date

The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference

morluto/rea#6321

No description provided.

Rows
Columns