morluto/rea

Fork 0

mirror of https://github.com/morluto/rea.git synced 2026-11-05 06:45:22 +00:00

[PR #4587] [CLOSED] fix(process): handle disappearing symlinks during filesystem snapshot (#4575) #6324

New issue

Closed

opened 2026-10-31 01:13:34 +00:00 by bsakaguchi · 0 comments

bsakaguchi commented

2026-10-31 01:13:34 +00:00

Owner

📋 Pull Request Information

Original PR: https://github.com/morluto/rea/pull/4587
Author: @rudrakshagarwal4200-ai
Created: 10/16/2026
Status: ❌ Closed

Base: main ← Head: rudrakshagarwal4200-ai-patch-2

📝 Commits (1)

fae4e25 Improve error handling for symbolic links

📊 Changes

1 file changed (+17 additions, -2 deletions)

View changed files

📝 src/process/capture/FilesystemSnapshot.ts (+17 -2)

📄 Description

Summary

Fixes #4575.

In src/process/capture/FilesystemSnapshot.ts, when a symlink is removed by the target process after entry lookup (lstatIfPresent) but before the follow-up readlink or lstat, the uncaught ENOENT error propagated to abort the entire capture-process command.

Fix

Wrapped the follow-up readlink(path) and lstat(path) in a try/catch block that catches ENOENT, marks the snapshot as truncated = true, and records "identity_changed" in enumerationReasons, matching the existing concurrent modification semantics without throwing an unhandled exception.

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/morluto/rea/pull/4587 **Author:** [@rudrakshagarwal4200-ai](https://github.com/rudrakshagarwal4200-ai) **Created:** 10/16/2026 **Status:** ❌ Closed **Base:** `main` ← **Head:** `rudrakshagarwal4200-ai-patch-2` --- ### 📝 Commits (1) - [`fae4e25`](https://github.com/morluto/rea/commit/fae4e25539969671c82a4d56cfb0b50761b833a3) Improve error handling for symbolic links ### 📊 Changes **1 file changed** (+17 additions, -2 deletions) <details> <summary>View changed files</summary> 📝 `src/process/capture/FilesystemSnapshot.ts` (+17 -2) </details> ### 📄 Description ### Summary Fixes #4575. In `src/process/capture/FilesystemSnapshot.ts`, when a symlink is removed by the target process after entry lookup (`lstatIfPresent`) but before the follow-up `readlink` or `lstat`, the uncaught `ENOENT` error propagated to abort the entire `capture-process` command. ### Fix Wrapped the follow-up `readlink(path)` and `lstat(path)` in a `try/catch` block that catches `ENOENT`, marks the snapshot as `truncated = true`, and records `"identity_changed"` in `enumerationReasons`, matching the existing concurrent modification semantics without throwing an unhandled exception. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>

bsakaguchi

2026-10-31 01:13:34 +00:00

closed this issue
added the
pull-request
label

bsakaguchi referenced this issue

2026-11-01 21:11:07 +00:00

[GH-ISSUE #5654] [Tracker] Open PRs that can't merge yet: conflicts and red CI (October 2026) #3425

bsakaguchi referenced this issue

2026-11-01 21:46:45 +00:00

[PR #6324] [CLOSED] Fix snapshot replay tests for unknown question assertions #7284

bsakaguchi changed title from ~~[PR #4587] [CLOSED] fix(process): handle disappearing symlinks during filesystem snapshot (#4575)~~ to [PR #4587] fix(process): handle disappearing symlinks during filesystem snapshot (#4575)

2026-11-03 13:32:45 +00:00

bsakaguchi changed title from ~~[PR #4587] fix(process): handle disappearing symlinks during filesystem snapshot (#4575)~~ to [PR #4587] [CLOSED] fix(process): handle disappearing symlinks during filesystem snapshot (#4575)

2026-11-03 14:34:31 +00:00

No milestone

No project

No assignees

1 participant

Notifications

Due date

The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference

morluto/rea#6324

No description provided.

Rows
Columns