[PR #4649] [CLOSED] docs(omp): distinguish configuration root and agent override paths #6342

New issue

Closed

opened 2026-10-31 01:13:43 +00:00 by bsakaguchi · 0 comments

bsakaguchi commented

2026-10-31 01:13:43 +00:00

Owner

📋 Pull Request Information

Original PR: https://github.com/morluto/rea/pull/4649
Author: @Shreyansh1729
Created: 10/17/2026
Status: ❌ Closed

Base: main ← Head: contrib/omp-path-documentation

📝 Commits (1)

14e52a5 docs(omp): distinguish configuration root and agent override paths

📊 Changes

2 files changed (+15 additions, -4 deletions)

View changed files

📝 docs/client-configuration.md (+13 -3)
📝 src/application/SupportedClients.ts (+2 -1)

📄 Description

Summary

Fixes #4625.

The OMP guide grouped two path overrides beside one working-directory parenthetical. Explain that PI_CONFIG_DIR is joined to home, while a relative default-profile PI_CODING_AGENT_DIR resolves from the setup working directory. Include examples, named-profile behavior and profile precedence.

Change and scope

Documentation and the matching resolver comment only; no executable resolver behavior changes. Existing provider, setup approval, backup, configuration and installation contracts remain unchanged.

Routine correction within existing contribution boundaries; a new maintainer scope decision is not applicable. No new provider or target execution capability is introduced.

Evidence and regression coverage

Ran four isolated public CLI setup dry runs covering a relative config root, a relative agent override, a named profile ignoring that override, and an empty OMP_PROFILE overriding PI_PROFILE. All selected the documented paths, applied no actions and created no mcp.json files.

Validation performed

Rebased onto current main 150e996a86f2bec4982ba87f37bf502a8d5e8214.

npm run check — passed on the combined final working tree: typecheck, lint, formatting, unused-code detection, metadata, module boundaries and architecture guards.
npm run test:focused -- tests/boundary/cli/fridaCli.test.ts tests/boundary/mcp/fridaMcp.test.ts tests/boundary/mcp/promptMcp.test.ts tests/boundary/mcp/promptCompletion.test.ts tests/boundary/filesystem/ompClientConfiguration.test.ts — 40 tests passed across five files after rebasing.
npm run docs:check — passed after rebasing, including 5 README consistency tests.
npm run verify:test-discovery — all 1,460 test files discovered exactly once on the original working tree; no test files were added or moved.

The independent branches touch disjoint files. Checks above ran against their combined final contents using Node v24.18.0 and npm 11.16.0 on macOS arm64.

Four isolated public CLI setup dry runs also matched the documented paths, applied no actions and created no mcp.json files.

Compatibility and remaining coverage

Native OMP and other operating systems were not executed. Existing OMP filesystem regressions validate REA configuration behavior.

No package version, generated catalog, dependency, or installation changes.

Author readiness

Human owner: @Shreyansh1729

I reviewed the final diff and relevant existing code, understand the change and its edge cases, and take responsibility for the complete PR, including AI-assisted work.
I checked the evidence above, confirmed it supports the current change, and recorded meaningful validation gaps.
I declare this PR ready for initial maintainer review.

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/morluto/rea/pull/4649 **Author:** [@Shreyansh1729](https://github.com/Shreyansh1729) **Created:** 10/17/2026 **Status:** ❌ Closed **Base:** `main` ← **Head:** `contrib/omp-path-documentation` --- ### 📝 Commits (1) - [`14e52a5`](https://github.com/morluto/rea/commit/14e52a525de748af558f3cdd8fd03d52577b1a67) docs(omp): distinguish configuration root and agent override paths ### 📊 Changes **2 files changed** (+15 additions, -4 deletions) <details> <summary>View changed files</summary> 📝 `docs/client-configuration.md` (+13 -3) 📝 `src/application/SupportedClients.ts` (+2 -1) </details> ### 📄 Description ## Summary Fixes #4625. The OMP guide grouped two path overrides beside one working-directory parenthetical. Explain that `PI_CONFIG_DIR` is joined to home, while a relative default-profile `PI_CODING_AGENT_DIR` resolves from the setup working directory. Include examples, named-profile behavior and profile precedence. ## Change and scope Documentation and the matching resolver comment only; no executable resolver behavior changes. Existing provider, setup approval, backup, configuration and installation contracts remain unchanged. Routine correction within existing contribution boundaries; a new maintainer scope decision is not applicable. No new provider or target execution capability is introduced. ## Evidence and regression coverage Ran four isolated public CLI setup dry runs covering a relative config root, a relative agent override, a named profile ignoring that override, and an empty OMP_PROFILE overriding PI_PROFILE. All selected the documented paths, applied no actions and created no mcp.json files. ## Validation performed Rebased onto current main `150e996a86f2bec4982ba87f37bf502a8d5e8214`. - `npm run check` — passed on the combined final working tree: typecheck, lint, formatting, unused-code detection, metadata, module boundaries and architecture guards. - `npm run test:focused -- tests/boundary/cli/fridaCli.test.ts tests/boundary/mcp/fridaMcp.test.ts tests/boundary/mcp/promptMcp.test.ts tests/boundary/mcp/promptCompletion.test.ts tests/boundary/filesystem/ompClientConfiguration.test.ts` — 40 tests passed across five files after rebasing. - `npm run docs:check` — passed after rebasing, including 5 README consistency tests. - `npm run verify:test-discovery` — all 1,460 test files discovered exactly once on the original working tree; no test files were added or moved. The independent branches touch disjoint files. Checks above ran against their combined final contents using Node v24.18.0 and npm 11.16.0 on macOS arm64. Four isolated public CLI setup dry runs also matched the documented paths, applied no actions and created no mcp.json files. ## Compatibility and remaining coverage Native OMP and other operating systems were not executed. Existing OMP filesystem regressions validate REA configuration behavior. No package version, generated catalog, dependency, or installation changes. ## Author readiness Human owner: @Shreyansh1729 - [ ] I reviewed the final diff and relevant existing code, understand the change and its edge cases, and take responsibility for the complete PR, including AI-assisted work. - [ ] I checked the evidence above, confirmed it supports the current change, and recorded meaningful validation gaps. - [ ] I declare this PR ready for initial maintainer review. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>

bsakaguchi

2026-10-31 01:13:43 +00:00