mirror of
https://github.com/morluto/rea.git
synced 2026-11-05 06:45:22 +00:00
[PR #4836] [CLOSED] fix(process): gate PTY launch on cancellation after executable sampling (#4512) #6435
Closed
opened 2026-10-31 01:14:26 +00:00 by bsakaguchi
·
0 comments
No Branch/Tag specified
main
codex/procedure-reference-stacked
release-please--branches--main--components--rea-agents
release-please--branches--main--components--rea-agents--release-notes
codex/kuna-independent-retry
codex/byte-search-overlay-coverage
codex/open-failure-target-receipt
codex/kuna-xref-evidence
codex/ghidra-ambiguous-procedure-recovery
codex/function-source-bundle
codex/trace-function-integration-prototype
codex/snapshot-source-closure
codex/recorded-evidence-array-pages
codex/evidence-recovery-redesign
codex/trace-feature-address-scope
codex/call-discovery-scope
codex/ghidra-literal-candidate-evidence
codex/decompile-directory-independent-retry
codex/retry-provenance-base
codex/value-flow-capability-experiment
codex/ghidra-containing-instruction
cursor/readme-discord-button-ef9f
dependabot/github_actions/actions/setup-node-7.1.0
dependabot/github_actions/actions/upload-artifact-7.0.2
dependabot/npm_and_yarn/npm-minor-and-patch-d8d97ce6df
codex/kuna-1989
fix/8559-native-ui-fixture-ownership
fix/8555-go-verifier-mcp-ownership
codex/provider-capability-recovery
fix/8642-rizin-target-stdin
codex/ghidra-memory-effect-scope
codex/ghidra-annotation-entry-selector
codex/ghidra-readonly-recovery
codex/ghidra-regex-verifier-recovery
codex/evidence-discovery-view-guidance
fix/8545-bulk-append-overflow
fix/8428-navigation-refusal-alternatives
codex/address-context-recovery
codex/matching-member-limitations
codex/unknown-scope-contract
codex/evidence-view-guidance
feat/8373-native-trace-views
codex/ghidra-snapshot-verifier-binding
codex/elf-export-visibility
codex/evidence-view-recovery
codex/native-reference-cli-help
codex/provider-candidate-observation-scope
codex/kuna-session-verification
codex/ghidra-switch-lifetime-guidance
codex/pseudocode-paging-discovery
codex/clarify-evidence-view-support
codex/kuna-xrefs-selector-recovery
codex/context-capacity-recovery
codex/evidence-closure-large-links
codex/same-function-evidence-identity
codex/ghidra-verifier-inspected-jdk
codex/audit-guided-workflows
codex/crash-prompt-retained-dossiers
codex/analysis-view-error-recovery
codex/kuna-verifier-target-selection
codex/ghidra-selected-project-call-coverage
codex/docs-native-analysis-scope
codex/ghidra-java-socket-boundary
codex/ghidra-retained-snapshot-verifier
codex/ghidra-search-inventory-facts
fix/8284-zero-argument-parameter-bindings
fix/8198-ui-action-handler-offset
fix/8257-elf-entry-label-identity
fix/8304-deferred-output-schema-projection
fix/8277-call-path-computed-target-uncertainty
fix/pr-8089-conflicts
fix/ci-static-duplicate-export
dependabot/npm_and_yarn/lint-staged-17.6.0
dependabot/github_actions/actions/download-artifact-8.0.2
dependabot/npm_and_yarn/write-file-atomic-8.0.0
dependabot/npm_and_yarn/canonicalize-5.1.0
dependabot/github_actions/actions/cache/restore-6.1.0
dependabot/npm_and_yarn/toon-format/toon-4.4.0
dependabot/github_actions/actions/deploy-pages-5.0.1
codex/review-fixes-pr-2403
codex/review-fixes-pr-2400
codex/process-terminal-width
codex/test-brittleness-cleanup
verify/7167-browser-connect-macos
fix/7167-browser-connect
feat/native-matching-allowance-setting
feat/browser-scenario-dry-run
test/managed-caller-parameters-20261024
codex/parser-fortythird-boundaries
fix/6926-pinvoke-platform-decorations-20261023
fix/6889-har-body-encoding-20261023
fix/6888-sqlite-schema-budget-20261023
fix/dependency-security-gates-6708
cursor/evidence-overwrite-rebase-b4ac
feat/4057-verify-native-exports
fix/windows-acl-observer-overhead-20261022
cursor/erlang-beam-restack-4476
cursor/pe-certificate-review-bf32
fix/6116-javascript-application-fs-errors
fix/6061-unmapped-runtime-script-unknown
feat/browser-scenario-summary
fix/pe-certificates
codex/verify-3407
cursor/rebase-5699
cursor/rebase-5352
cursor/rebase-5600
cursor/fix-cli-schema-omission-10a8
codex/audit-hopper-shutdown-reasons-20261021
fix/demangle-swift-omitted-record
fix/nib-boolean-value-types
cursor/cancellation-partial-observation-a5ac
fix/ib-object-limit-reasons
fix/electron-fuse-limit-advice
fix/kuna-doctor-dangling-cache
fix/fixed-budget-refusal-advice
fix/js-ipc-listener-dedup
fix/js-return-member-provenance
fix/dmg-integrity-retry-advice
fix/ida-doctor-readiness
fix/kuna-version-probe-output-drain
fix/legacy-swift-runtime-name-matching
fix/dylib-lazy-load-commands
fix/browser-scenario-startup-cancel
fix/swift-nested-punycode-classification
fix/compare-unselected-scopes
fix/objc-method-budget-coverage
fix/dmg-mounted-root-observations
audit/ci-tests-20261019-round2
release/6.7.0
fix/wabt-cleanup-retry-resolution
fix/electron-fuse-elf-pe-architecture
fix/native-plist-descriptor-ownership
fix/kuna-caller-cleanup-ownership
experiment/atomic-codemode-20261016
review/first-contributor-3776
fix/call-resolution-full-read-cycles
fix/member-mutation-selection-repeat
experiment/atomic-re-tools-20261015
perf/member-mutation-lazy-origins
perf/static-network-mutation-index
fix/hopper-startup-lifecycle
audit/3050-windows-proof-20261015
feat/windows-window-capture-2183
audit/3049-windows-proof-20261015
audit/3735-macos-fixtures-20261015
fix/batch-decompile-null-pseudocode
fix/kuna-inventory-honors-jobs
experiment/browser-codemode-tool-design-20261015
fix/hopper-clean-runtime-argv
codex/review-2049-27f1b367
review-fixes/pr-2787-routing
fix/3360-scoped-this-emitters
fix/3367-replaced-global-effects
fix/3838-compact-any-value-items
test/hopper-download-probe-20261015
codex/windows-runtime-creation-red-green-20261015
codex/windows-readonly-root-red-green-20261015
codex/windows-root-share-red-green-20261015
codex/exp-1685-win-mcp-startup
codex/bug-sweep-20261015
investigate/2190-windows-package-phases
investigate/3543-macos-cli-deadline
perf/3281-reverse-tools-feedback-quality
fix/3406-hopper-doctor-fixture
fix/3341-wrapper-require-test-context
fix/3301-owned-uninstall-fixtures
fix/3164-compiler-input-ownership
fix/pcap-cleanup-stdout-newline-20261014
perf/interface-builder-summary
codex/review-fixes-pr-1977
fix/ghidra-effective-jvm-platform
fix/docs-turkish-rust-link-20261013
fix/main-maintenance-ci-20261010
fix/recover-binary-session-process-effects
codex/review-fixes-pr-2457
codex/ci-required-cancellation-gate
fix/main-format-baseline-20261013
fix/setup-preserve-entry-fields
cursor/restore-main-checks-1ffc
fix/ghidra-bridge-hashmap-import
codex/shared-ci-jadx-json-default-20261013
codex/shared-ci-ghidra-test-groups-20261013
codex/shared-ci-java-fixture-format-20261013
codex/fix-intrinsic-invocation-boundaries
test/release-preflight-reusable-jobs
test/js-parameter-provenance-expectation
fix/linux-hopper-verification-current
test/2419-ghidra-elf-probe-size
followup/pr-1544-native-ida
codex/fold-pr-2230-contribution
docs/readme-responsible-use
fix/issue-2064
fix/issue-2050
fix/issue-2053
fix/issue-1968
fix/issue-1945
experiment/codemode-bridge-20261011
fix/tool-effects-negative-wording-1904-20261012
fix/1842-electron-interop-provenance
feat/recover-javascript-multi-input
refactor/website-i18n-prep
fix/nativeaot-pe-virtual-extent
fix/browser-verifier-ci-hang
fix/pe-resources-input-selection
docs/beginner-friendly-guides
docs/beginner-setup-guide
fix/javascript-analysis-worker-1563
fix/1649-ghidra-duplicate-names
fix/javascript-export-keys-integration-1369
test/maintenance-boundary-contracts-20261011
review/javascript-export-keys-1369
review/process-live-progress-1483
test/javascript-1495-growth-ratio
fix/ci-escape-timing
docs/normalized-terminal-geometry-1450
release/6.3.0
archive/release-6.3.0-pr1381
release/6.2.0
fix/electron-preload-dynamic-override
fix/javascript-self-referential-bundler-edges
release/6.1.0
cursor/grok-client-cherry-pick-0b56
feat/signature-posture
feat/dyld-shared-cache
feat/artifact-integrity-policy
feat/pkg-inventory
release/6.0.0
chore/sync-release-5.0.0
release/5.0.0
cursor/cloud-agent-node-787e
fix/javascript-xhr-open-endpoints
review/pr-711-realpath-fallback-wording
cleanup/replay-confinement
codex/test-suite-performance
codex/issue-foundations
codex/address-open-issues-2026-07-20
agent/javascript-vite-rollup-esbuild-adapters
agent/process-cleanup
agent/triage-integration
agent/unknown-commands-registry
feat/mcp-identity-metadata
morlvps/issue_cleanup
codex/installer-redesign
morl/roadmap-investigation-core
morl/roadmap-investigation-docs
release-please--branches--main--components--rea
rea-agents-6.8.0
rea-agents-6.7.0
rea-agents-6.6.0
experiment/atomic-codemode-wait-runtime-20261016
rea-agents-6.5.0
rea-agents-6.4.0
rea-agents-6.3.0
rea-agents-6.2.0
rea-agents-6.1.0
rea-agents-6.0.0
rea-agents-5.0.0
rea-agents-4.1.0
rea-agents-4.0.1
rea-agents-4.0.0
rea-agents-3.2.1
rea-agents-3.2.0
rea-agents-3.1.0
rea-agents-3.0.0
rea-agents-2.7.0
rea-agents-2.6.0
rea-agents-2.5.1
rea-agents-2.5.0
rea-agents-2.4.0
rea-agents-2.3.0
rea-agents-2.2.0
rea-agents-2.1.0
rea-agents-2.0.0
rea-agents-1.7.0
rea-agents-1.6.0
rea-agents-1.5.0
rea-agents-1.4.0
rea-agents-1.3.0
rea-agents-1.2.0
rea-agents-1.1.0
rea-agents-1.0.0
rea-agents-0.5.0
rea-agents-0.4.0
rea-agents-0.3.0
rea-0.2.1
rea-0.2.0
Labels
Clear labels
area: bridge
area: bridge
area: build
area: build
area: build
area: cli
area: domain
area: evidence
area: mcp
area: native
area: providers
area: runtime
area: server
area: setup
area: tests
bug
design
documentation
enhancement
enhancement
enhancement
experiment
help wanted
i18n
invalid
P0: critical
P1: high
P2: medium
P2: medium
P2: medium
P3: low
performance
provider-request
pull-request
Mirrored from GitHub Pull Request
question
roadmap
triage
No labels
area: bridge
area: bridge
area: build
area: build
area: build
area: cli
area: domain
area: evidence
area: mcp
area: native
area: providers
area: runtime
area: server
area: setup
area: tests
bug
design
documentation
enhancement
enhancement
enhancement
experiment
help wanted
i18n
invalid
P0: critical
P1: high
P2: medium
P2: medium
P2: medium
P3: low
performance
provider-request
pull-request
question
roadmap
triage
Milestone
Clear milestone
No items
No milestone
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".
No due date set.
Dependencies
No dependencies set.
Reference
morluto/rea#6435
Loading…
Add table
Add a link
Reference in a new issue
No description provided.
Delete branch "%!s()"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
📋 Pull Request Information
Original PR: https://github.com/morluto/rea/pull/4836
Author: @DeryFerd
Created: 10/17/2026
Status: ❌ Closed
Base:
main← Head:fix/4512-prelaunch-cancellation📝 Commits (1)
014afa3fix(process): gate PTY launch on cancellation after executable sampling📊 Changes
2 files changed (+117 additions, -0 deletions)
View changed files
📝
src/process/capture/ProcessHarness.ts(+5 -0)➕
tests/process-global/processPrelaunchCancellation.test.ts(+112 -0)📄 Description
Summary
Fixes #4512. Process capture could reach its PTY launch after the caller had already cancelled during the final executable metadata read or descriptor close. The sampler still returned a complete digest, and the caller consumed it and started the target anyway. The launch boundary now rechecks the caller's signal after the sample settles, so a cancelled request takes the existing typed cancellation path and makes zero launch attempts.
Problem and expected behavior
The smallest trigger is a cancellation that lands in the last awaited step of executable sampling.
startCaptureRuntimeinsrc/process/capture/ProcessHarness.tsawaitsobserveSelectedExecutableat line 271 and callsspawnat line 293 with nothing in between that reads the signal. Inside the sampler (src/process/capture/ProcessCaptureLifecycle.ts:512), the last internal check runs before the finalhandle.stat({ bigint: true })at line 552, and thefinallyblock then awaitshandle?.close()at line 572. Either await can settle after the caller aborts.I split that window into two schedules and measured each one against a real
node:fs/promiseshandle onmain. Aborting after the final descriptorstatstill rejects withcancelled, because the sampler's own check runs afterwards. Aborting inside the descriptorclosedoes not, because no check follows it. That second schedule resolved with a complete digest andsignal.aborted === true, which is the exact state the caller then treated as permission to launch.The violated invariant is in
docs/tool-design.md#own-the-lifecycle: target admission, active execution, and resource release stay separate, and a completed prerequisite establishes only its own fact. A finished executable sample proves the file's bytes and identity. It does not authorize starting that program for an operation that has already been cancelled. The expected behavior is a typed cancellation, the existing startup cleanup, and no PTY launch.Change and scope
One statement at the consuming boundary.
assertNotCancelled(options.signal)now runs immediately afterobserveSelectedExecutableresolves, before the terminal renderer, sampler, and PTY are constructed. The helper already existed in this file's imports (src/process/capture/ProcessScenarioRuntimeValidation.ts:121) and throws the sameprocessCaptureCancelled()error that every other startup check uses, so the failure reaches the existing cancellation and cleanup paths without a new error type.The sampler is unchanged. It still returns the complete digest and identity it observed, still closes its descriptor, and still rejects when cancellation arrives before its last check. I deliberately did not move the check into the sampler or change its return value, because completed file observations remain valid evidence and discarding them would lose facts the caller can still report.
Not included: cancellation delivery from individual CLI or MCP adapters. This change covers the shared harness both surfaces call. Adapter-specific signal forwarding is a separate concern and was not tested here.
Ordinary defect fix within existing process-capture ownership. A new provider or protection-recovery scope decision is not applicable.
Contract and boundary impact
src/process/capture/ProcessHarness.ts; the earliest changed stage is the launch decision after executable sampling settles.ProcessCaptureErrorit already returned for earlier cancellation points.AbortSignal. Native Windows capture remains unavailable for the reason already documented inProcessCaptureCapability.ts.cleanupFailedStartupandreleaseProcessResourcesexactly as before.Expected effects (check known effects; use documentation-only on its own). Unchecked items do not establish absence; leave uncertainties visible.
Evidence and regression coverage
Tests added or updated:
tests/process-global/processPrelaunchCancellation.test.tsadds two cases against the exportedcaptureProcessScenarioboundary. The first aborts inside the real descriptorcloseduring executable sampling, replaces the native PTY entry point with a throwing sentinel, and asserts the sentinel was never called and the result is a typed cancellation. The second is the non-aborted control and asserts the sentinel is reached exactly once, which proves the test would notice a harness that never launches anything.The fixture keeps real
open,stat, andclosecalls and wraps only the returned handle to synchronize the abort with that one boundary. Nothing reproduces launch logic in a helper. The native module is mocked at@lydell/node-ptyso the sentinel throws before any child exists.Base reproduction or other evidence: on the unpatched base the first case fails with
expected 1 to be +0, meaning the launch sentinel was called once for an already-cancelled request. The control passes on the same base, so the failure is specific to the cancellation schedule and not to the fixture. With the check added, both cases pass.User-visible CLI/MCP output: none observed directly. The practical effect is that a cancelled
capture_process_scenarioreturns the existing cancellation error instead of starting the selected program and discovering the cancellation during later monitoring.Remaining proof gaps: I did not run a native PTY capture on Linux or macOS, and I did not exercise public CLI or MCP cancellation delivery. This host is Windows, where native process capture is unavailable by design, so the portable startup logic runs against the controlled
"linux"platform seam while the filesystem calls stay real. The frequency of this interleaving under normal filesystem timing is unknown; the regression pins the ordering rather than a timing distribution.For evidence-bearing changes:
Validation performed
Host: Windows 11 x64, Node 24.21.0, npm 11.9.0. This checkout lacks the packaged Windows native addon, so native capture lanes are unavailable here.
npx vitest run --project process-global tests/process-global/processPrelaunchCancellation.test.ts— 2 passed.expected 1 to be +0; restoring it makes both cases pass. The control passes in both states.npx vitest run --project process-boundary --project process-global tests/boundary/process/processCaptureLifecycle.test.ts tests/boundary/process/selectedExecutableCancellation.test.ts tests/boundary/process/processPreparation.test.ts tests/process-global/processPrelaunchCancellation.test.ts— 5 passed, 24 skipped (the PTY-dependent cases skip on this host).npm run check:fast— typecheck and lint passed, 2 of 2 tasks.git diff --check— no whitespace errors.Compatibility, safety, and release
Author readiness
Human owner: @DeryFerd
Before merge
type(scope): outcome.🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.