morluto/rea

Fork

You've already forked rea

mirror of https://github.com/morluto/rea.git synced 2026-11-05 07:47:29 +00:00

Code Issues 1.3k Projects Packages Wiki Activity

[PR #4861] [CLOSED] fix(native): retain methods around empty Objective-C selectors #6445

New issue

Closed

opened 2026-10-31 01:14:30 +00:00 by bsakaguchi · 0 comments

bsakaguchi commented

2026-10-31 01:14:30 +00:00

Owner

Copy link

📋 Pull Request Information

Original PR: https://github.com/morluto/rea/pull/4861
Author: @Abdooo2235
Created: 10/17/2026
Status: ❌ Closed

Base: main ← Head: fix/objc-method-entry-recovery

📝 Commits (1)

ed2cc8e fix(native): retain methods around empty Objective-C selectors

📊 Changes

3 files changed (+140 additions, -9 deletions)

View changed files

📝 src/native/AppleDispatchMetadata.test.ts (+101 -1)
📝 src/native/AppleObjcDispatchFacets.ts (+15 -3)
📝 tests/boundary/filesystem/appleDispatchMetadataStrings.test.ts (+24 -5)

📄 Description

Summary

Fixes #4534. Skip an empty Objective-C method selector without discarding its class or category, the valid methods on either side, or independent metadata.

Problem and expected behavior

The existing empty-selector guard prevents invalid records from reaching schema validation, but throws out of the entire method list. A valid/empty/valid list consequently loses its owner and the last method. Empty selectors should produce partial coverage while the remaining records stay available.

Change and scope

Record the failure at the method entry and continue the bounded list scan, following the existing protocol-selector recovery pattern. Class methods report through class coverage; category methods report through category coverage. Keep the existing handling of unreadable pointers and unsupported list layouts.

This builds on the validation already present on main; it does not replace that guard or broaden supported metadata formats.

Contract and boundary impact

Semantic owner and earliest changed stage: decodeObjcDispatchFacets, while decoding a binary method-list entry.
Contribution scope fit and linked maintainer decision: ordinary read-only recovery fix within an existing parser; no new scope decision required.
CLI and MCP/tool-catalog contract: existing result schemas and operation arguments are unchanged.
Provider, bridge, target-format, or platform compatibility: no additional provider or format support.
Evidence, artifact, provenance, or reconstruction contract: retain valid records and their locations/provenance; report the malformed entry's owner, method type, index and address in the affected coverage facet.
Target selection, authority, upstream behavior, and cleanup: existing target selection, record budget and resource ownership are preserved.
Generated metadata, package, or installation impact: none.
Read existing files or captured data.

Evidence and regression coverage

On base 3ad1032b, all four new class/category and absolute/relative recovery cases failed; the other 52 tests passed. With the fix, all 56 pass. The tests assert retained owner method arrays, implementation records, ivars, protocols and properties, as well as precise diagnostics and unchanged independent coverage.

A file-backed regression also retains a valid method following an empty selector, preserves the input bytes and digest, and reports partial class coverage. Existing UTF-8 identity and resource-cleanup controls continue to pass.

Representative result: the owner's methods remain earlier: and later:; coverage identifies method 1 as having an empty selector instead of losing the owner.

Observed, derived, and inferred claims remain distinguishable.
Artifact identity, source provenance, and failed attempts remain preserved.
Unsupported, incomplete, unavailable, or uncertain outcomes remain visible.

Validation performed

Windows x64, pinned Node 24.18.0 and npm 11.16.0:

npm run test:focused -- src/native/AppleDispatchMetadata.test.ts tests/boundary/filesystem/appleDispatchMetadataStrings.test.ts tests/boundary/providers/native/nativeDispatchMetadataFileCleanup.test.ts — 64 tests passed across three files.
npm run check — passed, including typecheck, lint, formatting, knip, module boundaries and architecture guards.
npm run docs:check — passed, including generated-document checks and five README conformance tests.
git diff --check — passed.
GitHub CI on ed2cc8e3 — completed successfully, including all five test shards, source/static checks, package build, Linux package baseline and Real Apple artifact CLI/MCP E2E. All four required checks passed.

Compatibility, safety, and release

No breaking change, migration, dependency or package change. This change reads captured Mach-O bytes only. Local verification used Windows; GitHub's real Apple artifact CLI/MCP E2E lane passed on this revision. No real-world malformed binary was examined; the regression uses synthetic bytes through the production decoder and file-backed inspection boundary. The full repository suite was not run locally.

Author readiness

Human owner: @Abdooo2235

I reviewed the final diff and relevant existing code, understand the change and its edge cases, and take responsibility for the complete PR, including AI-assisted work.
I checked the evidence above, confirmed it supports the current change, and recorded meaningful validation gaps.
I declare this PR ready for initial maintainer review.

Before merge

This PR addresses a concrete problem within the existing contribution scope.
The PR has one focused outcome and links the related issue.
Tests cover changed behavior and meaningful failure paths.
The final diff was checked for unrelated changes and unsupported claims.
Human readiness and required CI/review checks are complete.

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/morluto/rea/pull/4861 **Author:** [@Abdooo2235](https://github.com/Abdooo2235) **Created:** 10/17/2026 **Status:** ❌ Closed **Base:** `main` ← **Head:** `fix/objc-method-entry-recovery` --- ### 📝 Commits (1) - [`ed2cc8e`](https://github.com/morluto/rea/commit/ed2cc8e30814546724a8193aba8aca888dd2b241) fix(native): retain methods around empty Objective-C selectors ### 📊 Changes **3 files changed** (+140 additions, -9 deletions) <details> <summary>View changed files</summary> 📝 `src/native/AppleDispatchMetadata.test.ts` (+101 -1) 📝 `src/native/AppleObjcDispatchFacets.ts` (+15 -3) 📝 `tests/boundary/filesystem/appleDispatchMetadataStrings.test.ts` (+24 -5) </details> ### 📄 Description ## Summary Fixes #4534. Skip an empty Objective-C method selector without discarding its class or category, the valid methods on either side, or independent metadata. ## Problem and expected behavior The existing empty-selector guard prevents invalid records from reaching schema validation, but throws out of the entire method list. A valid/empty/valid list consequently loses its owner and the last method. Empty selectors should produce partial coverage while the remaining records stay available. ## Change and scope Record the failure at the method entry and continue the bounded list scan, following the existing protocol-selector recovery pattern. Class methods report through class coverage; category methods report through category coverage. Keep the existing handling of unreadable pointers and unsupported list layouts. This builds on the validation already present on `main`; it does not replace that guard or broaden supported metadata formats. ## Contract and boundary impact - Semantic owner and earliest changed stage: `decodeObjcDispatchFacets`, while decoding a binary method-list entry. - Contribution scope fit and linked maintainer decision: ordinary read-only recovery fix within an existing parser; no new scope decision required. - CLI and MCP/tool-catalog contract: existing result schemas and operation arguments are unchanged. - Provider, bridge, target-format, or platform compatibility: no additional provider or format support. - Evidence, artifact, provenance, or reconstruction contract: retain valid records and their locations/provenance; report the malformed entry's owner, method type, index and address in the affected coverage facet. - Target selection, authority, upstream behavior, and cleanup: existing target selection, record budget and resource ownership are preserved. - Generated metadata, package, or installation impact: none. - [x] Read existing files or captured data. ## Evidence and regression coverage On base `3ad1032b`, all four new class/category and absolute/relative recovery cases failed; the other 52 tests passed. With the fix, all 56 pass. The tests assert retained owner method arrays, implementation records, ivars, protocols and properties, as well as precise diagnostics and unchanged independent coverage. A file-backed regression also retains a valid method following an empty selector, preserves the input bytes and digest, and reports partial class coverage. Existing UTF-8 identity and resource-cleanup controls continue to pass. Representative result: the owner's methods remain `earlier:` and `later:`; coverage identifies method 1 as having an empty selector instead of losing the owner. - [x] Observed, derived, and inferred claims remain distinguishable. - [x] Artifact identity, source provenance, and failed attempts remain preserved. - [x] Unsupported, incomplete, unavailable, or uncertain outcomes remain visible. ## Validation performed Windows x64, pinned Node 24.18.0 and npm 11.16.0: - `npm run test:focused -- src/native/AppleDispatchMetadata.test.ts tests/boundary/filesystem/appleDispatchMetadataStrings.test.ts tests/boundary/providers/native/nativeDispatchMetadataFileCleanup.test.ts` — 64 tests passed across three files. - `npm run check` — passed, including typecheck, lint, formatting, knip, module boundaries and architecture guards. - `npm run docs:check` — passed, including generated-document checks and five README conformance tests. - `git diff --check` — passed. - [GitHub CI on `ed2cc8e3`](https://github.com/morluto/rea/actions/runs/39058407826) — completed successfully, including all five test shards, source/static checks, package build, Linux package baseline and `Real Apple artifact CLI/MCP E2E`. All four required checks passed. ## Compatibility, safety, and release No breaking change, migration, dependency or package change. This change reads captured Mach-O bytes only. Local verification used Windows; GitHub's real Apple artifact CLI/MCP E2E lane passed on this revision. No real-world malformed binary was examined; the regression uses synthetic bytes through the production decoder and file-backed inspection boundary. The full repository suite was not run locally. ## Author readiness Human owner: @Abdooo2235 - [x] I reviewed the final diff and relevant existing code, understand the change and its edge cases, and take responsibility for the complete PR, including AI-assisted work. - [x] I checked the evidence above, confirmed it supports the current change, and recorded meaningful validation gaps. - [x] I declare this PR ready for initial maintainer review. ## Before merge - [x] This PR addresses a concrete problem within the existing contribution scope. - [x] The PR has one focused outcome and links the related issue. - [x] Tests cover changed behavior and meaningful failure paths. - [x] The final diff was checked for unrelated changes and unsupported claims. - [x] Human readiness and required CI/review checks are complete. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>

bsakaguchi

2026-10-31 01:14:30 +00:00

closed this issue
added the
pull-request
label

bsakaguchi referenced this issue

2026-11-01 21:47:21 +00:00

[PR #6486] [MERGED] fix(process): record no normal exit code for signal-terminated targets #7365

No Branch/Tag specified

main

release-please--branches--main--components--rea-agents

release-please--branches--main--components--rea-agents--release-notes

codex/procedure-reference-stacked

codex/kuna-independent-retry

codex/byte-search-overlay-coverage

codex/open-failure-target-receipt

codex/kuna-xref-evidence

codex/ghidra-ambiguous-procedure-recovery

codex/function-source-bundle

codex/trace-function-integration-prototype

codex/snapshot-source-closure

codex/recorded-evidence-array-pages

codex/evidence-recovery-redesign

codex/trace-feature-address-scope

codex/call-discovery-scope

codex/ghidra-literal-candidate-evidence

codex/decompile-directory-independent-retry

codex/retry-provenance-base

codex/value-flow-capability-experiment

codex/ghidra-containing-instruction

cursor/readme-discord-button-ef9f

dependabot/github_actions/actions/setup-node-7.1.0

dependabot/github_actions/actions/upload-artifact-7.0.2

dependabot/npm_and_yarn/npm-minor-and-patch-d8d97ce6df

codex/kuna-1989

fix/8559-native-ui-fixture-ownership

fix/8555-go-verifier-mcp-ownership

codex/provider-capability-recovery

fix/8642-rizin-target-stdin

codex/ghidra-memory-effect-scope

codex/ghidra-annotation-entry-selector

codex/ghidra-readonly-recovery

codex/ghidra-regex-verifier-recovery

codex/evidence-discovery-view-guidance

fix/8545-bulk-append-overflow

fix/8428-navigation-refusal-alternatives

codex/address-context-recovery

codex/matching-member-limitations

codex/unknown-scope-contract

codex/evidence-view-guidance

feat/8373-native-trace-views

codex/ghidra-snapshot-verifier-binding

codex/elf-export-visibility

codex/evidence-view-recovery

codex/native-reference-cli-help

codex/provider-candidate-observation-scope

codex/kuna-session-verification

codex/ghidra-switch-lifetime-guidance

codex/pseudocode-paging-discovery

codex/clarify-evidence-view-support

codex/kuna-xrefs-selector-recovery

codex/context-capacity-recovery

codex/evidence-closure-large-links

codex/same-function-evidence-identity

codex/ghidra-verifier-inspected-jdk

codex/audit-guided-workflows

codex/crash-prompt-retained-dossiers

codex/analysis-view-error-recovery

codex/kuna-verifier-target-selection

codex/ghidra-selected-project-call-coverage

codex/docs-native-analysis-scope

codex/ghidra-java-socket-boundary

codex/ghidra-retained-snapshot-verifier

codex/ghidra-search-inventory-facts

fix/8284-zero-argument-parameter-bindings

fix/8198-ui-action-handler-offset

fix/8257-elf-entry-label-identity

fix/8304-deferred-output-schema-projection

fix/8277-call-path-computed-target-uncertainty

fix/pr-8089-conflicts

fix/ci-static-duplicate-export

dependabot/npm_and_yarn/lint-staged-17.6.0

dependabot/github_actions/actions/download-artifact-8.0.2

dependabot/npm_and_yarn/write-file-atomic-8.0.0

dependabot/npm_and_yarn/canonicalize-5.1.0

dependabot/github_actions/actions/cache/restore-6.1.0

dependabot/npm_and_yarn/toon-format/toon-4.4.0

dependabot/github_actions/actions/deploy-pages-5.0.1

codex/review-fixes-pr-2403

codex/review-fixes-pr-2400

codex/process-terminal-width

codex/test-brittleness-cleanup

verify/7167-browser-connect-macos

fix/7167-browser-connect

feat/native-matching-allowance-setting

feat/browser-scenario-dry-run

test/managed-caller-parameters-20261024

codex/parser-fortythird-boundaries

fix/6926-pinvoke-platform-decorations-20261023

fix/6889-har-body-encoding-20261023

fix/6888-sqlite-schema-budget-20261023

fix/dependency-security-gates-6708

cursor/evidence-overwrite-rebase-b4ac

feat/4057-verify-native-exports

fix/windows-acl-observer-overhead-20261022

cursor/erlang-beam-restack-4476

cursor/pe-certificate-review-bf32

fix/6116-javascript-application-fs-errors

fix/6061-unmapped-runtime-script-unknown

feat/browser-scenario-summary

fix/pe-certificates

codex/verify-3407

cursor/rebase-5699

cursor/rebase-5352

cursor/rebase-5600

cursor/fix-cli-schema-omission-10a8

codex/audit-hopper-shutdown-reasons-20261021

fix/demangle-swift-omitted-record

fix/nib-boolean-value-types

cursor/cancellation-partial-observation-a5ac

fix/ib-object-limit-reasons

fix/electron-fuse-limit-advice

fix/kuna-doctor-dangling-cache

fix/fixed-budget-refusal-advice

fix/js-ipc-listener-dedup

fix/js-return-member-provenance

fix/dmg-integrity-retry-advice

fix/ida-doctor-readiness

fix/kuna-version-probe-output-drain

fix/legacy-swift-runtime-name-matching

fix/dylib-lazy-load-commands

fix/browser-scenario-startup-cancel

fix/swift-nested-punycode-classification

fix/compare-unselected-scopes

fix/objc-method-budget-coverage

fix/dmg-mounted-root-observations

audit/ci-tests-20261019-round2

release/6.7.0

fix/wabt-cleanup-retry-resolution

fix/electron-fuse-elf-pe-architecture

fix/native-plist-descriptor-ownership

fix/kuna-caller-cleanup-ownership

experiment/atomic-codemode-20261016

review/first-contributor-3776

fix/call-resolution-full-read-cycles

fix/member-mutation-selection-repeat

experiment/atomic-re-tools-20261015

perf/member-mutation-lazy-origins

perf/static-network-mutation-index

fix/hopper-startup-lifecycle

audit/3050-windows-proof-20261015

feat/windows-window-capture-2183

audit/3049-windows-proof-20261015

audit/3735-macos-fixtures-20261015

fix/batch-decompile-null-pseudocode

fix/kuna-inventory-honors-jobs

experiment/browser-codemode-tool-design-20261015

fix/hopper-clean-runtime-argv

codex/review-2049-27f1b367

review-fixes/pr-2787-routing

fix/3360-scoped-this-emitters

fix/3367-replaced-global-effects

fix/3838-compact-any-value-items

test/hopper-download-probe-20261015

codex/windows-runtime-creation-red-green-20261015

codex/windows-readonly-root-red-green-20261015

codex/windows-root-share-red-green-20261015

codex/exp-1685-win-mcp-startup

codex/bug-sweep-20261015

investigate/2190-windows-package-phases

investigate/3543-macos-cli-deadline

perf/3281-reverse-tools-feedback-quality

fix/3406-hopper-doctor-fixture

fix/3341-wrapper-require-test-context

fix/3301-owned-uninstall-fixtures

fix/3164-compiler-input-ownership

fix/pcap-cleanup-stdout-newline-20261014

perf/interface-builder-summary

codex/review-fixes-pr-1977

fix/ghidra-effective-jvm-platform

fix/docs-turkish-rust-link-20261013

fix/main-maintenance-ci-20261010

fix/recover-binary-session-process-effects

codex/review-fixes-pr-2457

codex/ci-required-cancellation-gate

fix/main-format-baseline-20261013

fix/setup-preserve-entry-fields

cursor/restore-main-checks-1ffc

fix/ghidra-bridge-hashmap-import

codex/shared-ci-jadx-json-default-20261013

codex/shared-ci-ghidra-test-groups-20261013

codex/shared-ci-java-fixture-format-20261013

codex/fix-intrinsic-invocation-boundaries

test/release-preflight-reusable-jobs

test/js-parameter-provenance-expectation

fix/linux-hopper-verification-current

test/2419-ghidra-elf-probe-size

followup/pr-1544-native-ida

codex/fold-pr-2230-contribution

docs/readme-responsible-use

fix/issue-2064

fix/issue-2050

fix/issue-2053

fix/issue-1968

fix/issue-1945

experiment/codemode-bridge-20261011

fix/tool-effects-negative-wording-1904-20261012

fix/1842-electron-interop-provenance

feat/recover-javascript-multi-input

refactor/website-i18n-prep

fix/nativeaot-pe-virtual-extent

fix/browser-verifier-ci-hang

fix/pe-resources-input-selection

docs/beginner-friendly-guides

docs/beginner-setup-guide

fix/javascript-analysis-worker-1563

fix/1649-ghidra-duplicate-names

fix/javascript-export-keys-integration-1369

test/maintenance-boundary-contracts-20261011

review/javascript-export-keys-1369

review/process-live-progress-1483

test/javascript-1495-growth-ratio

fix/ci-escape-timing

docs/normalized-terminal-geometry-1450

release/6.3.0

archive/release-6.3.0-pr1381

release/6.2.0

fix/electron-preload-dynamic-override

fix/javascript-self-referential-bundler-edges

release/6.1.0

cursor/grok-client-cherry-pick-0b56

feat/signature-posture

feat/dyld-shared-cache

feat/artifact-integrity-policy

feat/pkg-inventory

release/6.0.0

chore/sync-release-5.0.0

release/5.0.0

cursor/cloud-agent-node-787e

fix/javascript-xhr-open-endpoints

review/pr-711-realpath-fallback-wording

cleanup/replay-confinement

codex/test-suite-performance

codex/issue-foundations

codex/address-open-issues-2026-07-20

agent/javascript-vite-rollup-esbuild-adapters

agent/process-cleanup

agent/triage-integration

agent/unknown-commands-registry

feat/mcp-identity-metadata

morlvps/issue_cleanup

codex/installer-redesign

morl/roadmap-investigation-core

morl/roadmap-investigation-docs

release-please--branches--main--components--rea

rea-agents-6.8.0

rea-agents-6.7.0

rea-agents-6.6.0

experiment/atomic-codemode-wait-runtime-20261016

rea-agents-6.5.0

rea-agents-6.4.0

rea-agents-6.3.0

rea-agents-6.2.0

rea-agents-6.1.0

rea-agents-6.0.0

rea-agents-5.0.0

rea-agents-4.1.0

rea-agents-4.0.1

rea-agents-4.0.0

rea-agents-3.2.1

rea-agents-3.2.0

rea-agents-3.1.0

rea-agents-3.0.0

rea-agents-2.7.0

rea-agents-2.6.0

rea-agents-2.5.1

rea-agents-2.5.0

rea-agents-2.4.0

rea-agents-2.3.0

rea-agents-2.2.0

rea-agents-2.1.0

rea-agents-2.0.0

rea-agents-1.7.0

rea-agents-1.6.0

rea-agents-1.5.0

rea-agents-1.4.0

rea-agents-1.3.0

rea-agents-1.2.0

rea-agents-1.1.0

rea-agents-1.0.0

rea-agents-0.5.0

rea-agents-0.4.0

rea-agents-0.3.0

rea-0.2.1

rea-0.2.0

Labels

Clear labels

Mirrored from GitHub Pull Request

No labels

Milestone

Clear milestone

No items

No milestone

Projects

Clear projects

No items

No project

Assignees

Clear assignees

No assignees

1 participant

Notifications

Due date

The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference

morluto/rea#6445

Reference in a new issue

Repository

morluto/rea

Title

Body

No description provided.

Delete branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?

Rows
Columns