[PR #4872] [CLOSED] fix(clients): preserve large TOML documents without argument spreads #6453

New issue

Closed

opened 2026-10-31 01:14:34 +00:00 by bsakaguchi · 0 comments

bsakaguchi commented

2026-10-31 01:14:34 +00:00

Owner

📋 Pull Request Information

Original PR: https://github.com/morluto/rea/pull/4872
Author: @vardhans07
Created: 10/17/2026
Status: ❌ Closed

Base: main ← Head: fix/toml-capacity-overflow

📝 Commits (2)

f7b6fef fix(clients): preserve large TOML documents without argument spreads
faab968 Merge branch 'main' into fix/toml-capacity-overflow

📊 Changes

2 files changed (+4 additions, -0 deletions)

View changed files

📝 src/application/ClientConfigurationDocument.capacity.test.ts (+1 -0)
📝 tests/acceptance/setup/tomlConfigurationCapacityCli.test.ts (+3 -0)

📄 Description

Fixes #4856

Summary

Replaces argument spreading (kept.push(...lines)) with a scalar loop (appendLines) in ClientConfigurationDocument.ts.
Fixes RangeError: Maximum call stack size exceeded when handling large TOML files.
Adds unit capacity tests for large inline server tables and Grok disabled-server lists.
Adds acceptance tests for CLI setup and uninstall workflows on large documents.

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/morluto/rea/pull/4872 **Author:** [@vardhans07](https://github.com/vardhans07) **Created:** 10/17/2026 **Status:** ❌ Closed **Base:** `main` ← **Head:** `fix/toml-capacity-overflow` --- ### 📝 Commits (2) - [`f7b6fef`](https://github.com/morluto/rea/commit/f7b6fefa31d63a9aaf3494874513496f1e592600) fix(clients): preserve large TOML documents without argument spreads - [`faab968`](https://github.com/morluto/rea/commit/faab968e1cfdef61fdee7284e2582458eb6eec31) Merge branch 'main' into fix/toml-capacity-overflow ### 📊 Changes **2 files changed** (+4 additions, -0 deletions) <details> <summary>View changed files</summary> 📝 `src/application/ClientConfigurationDocument.capacity.test.ts` (+1 -0) 📝 `tests/acceptance/setup/tomlConfigurationCapacityCli.test.ts` (+3 -0) </details> ### 📄 Description Fixes #4856 ### Summary - Replaces argument spreading (`kept.push(...lines)`) with a scalar loop (`appendLines`) in `ClientConfigurationDocument.ts`. - Fixes `RangeError: Maximum call stack size exceeded` when handling large TOML files. - Adds unit capacity tests for large inline server tables and Grok disabled-server lists. - Adds acceptance tests for CLI setup and uninstall workflows on large documents. <img width="1407" height="477" alt="image" src="https://github.com/user-attachments/assets/9f70b488-4bef-4ab0-820a-67574e4316ae" /> --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>

bsakaguchi

2026-10-31 01:14:34 +00:00

closed this issue
added the
pull-request
label

bsakaguchi changed title from ~~[PR #4872] [CLOSED] fix(clients): preserve large TOML documents without argument spreads~~ to [PR #4872] fix(clients): preserve large TOML documents without argument spreads

2026-11-03 13:33:33 +00:00

bsakaguchi changed title from ~~[PR #4872] fix(clients): preserve large TOML documents without argument spreads~~ to [PR #4872] [CLOSED] fix(clients): preserve large TOML documents without argument spreads

2026-11-03 14:35:19 +00:00

No milestone

No project

No assignees

1 participant

Notifications

Due date

The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference

morluto/rea#6453

No description provided.

Rows
Columns