mirror of
https://github.com/morluto/rea.git
synced 2026-11-05 07:47:29 +00:00
[PR #4909] [CLOSED] fix(pcap): report capture instants in UTC instead of host-local time #6670
Closed
opened 2026-11-01 21:42:12 +00:00 by bsakaguchi
·
0 comments
No Branch/Tag specified
main
release-please--branches--main--components--rea-agents
release-please--branches--main--components--rea-agents--release-notes
codex/procedure-reference-stacked
codex/kuna-independent-retry
codex/byte-search-overlay-coverage
codex/open-failure-target-receipt
codex/kuna-xref-evidence
codex/ghidra-ambiguous-procedure-recovery
codex/function-source-bundle
codex/trace-function-integration-prototype
codex/snapshot-source-closure
codex/recorded-evidence-array-pages
codex/evidence-recovery-redesign
codex/trace-feature-address-scope
codex/call-discovery-scope
codex/ghidra-literal-candidate-evidence
codex/decompile-directory-independent-retry
codex/retry-provenance-base
codex/value-flow-capability-experiment
codex/ghidra-containing-instruction
cursor/readme-discord-button-ef9f
dependabot/github_actions/actions/setup-node-7.1.0
dependabot/github_actions/actions/upload-artifact-7.0.2
dependabot/npm_and_yarn/npm-minor-and-patch-d8d97ce6df
codex/kuna-1989
fix/8559-native-ui-fixture-ownership
fix/8555-go-verifier-mcp-ownership
codex/provider-capability-recovery
fix/8642-rizin-target-stdin
codex/ghidra-memory-effect-scope
codex/ghidra-annotation-entry-selector
codex/ghidra-readonly-recovery
codex/ghidra-regex-verifier-recovery
codex/evidence-discovery-view-guidance
fix/8545-bulk-append-overflow
fix/8428-navigation-refusal-alternatives
codex/address-context-recovery
codex/matching-member-limitations
codex/unknown-scope-contract
codex/evidence-view-guidance
feat/8373-native-trace-views
codex/ghidra-snapshot-verifier-binding
codex/elf-export-visibility
codex/evidence-view-recovery
codex/native-reference-cli-help
codex/provider-candidate-observation-scope
codex/kuna-session-verification
codex/ghidra-switch-lifetime-guidance
codex/pseudocode-paging-discovery
codex/clarify-evidence-view-support
codex/kuna-xrefs-selector-recovery
codex/context-capacity-recovery
codex/evidence-closure-large-links
codex/same-function-evidence-identity
codex/ghidra-verifier-inspected-jdk
codex/audit-guided-workflows
codex/crash-prompt-retained-dossiers
codex/analysis-view-error-recovery
codex/kuna-verifier-target-selection
codex/ghidra-selected-project-call-coverage
codex/docs-native-analysis-scope
codex/ghidra-java-socket-boundary
codex/ghidra-retained-snapshot-verifier
codex/ghidra-search-inventory-facts
fix/8284-zero-argument-parameter-bindings
fix/8198-ui-action-handler-offset
fix/8257-elf-entry-label-identity
fix/8304-deferred-output-schema-projection
fix/8277-call-path-computed-target-uncertainty
fix/pr-8089-conflicts
fix/ci-static-duplicate-export
dependabot/npm_and_yarn/lint-staged-17.6.0
dependabot/github_actions/actions/download-artifact-8.0.2
dependabot/npm_and_yarn/write-file-atomic-8.0.0
dependabot/npm_and_yarn/canonicalize-5.1.0
dependabot/github_actions/actions/cache/restore-6.1.0
dependabot/npm_and_yarn/toon-format/toon-4.4.0
dependabot/github_actions/actions/deploy-pages-5.0.1
codex/review-fixes-pr-2403
codex/review-fixes-pr-2400
codex/process-terminal-width
codex/test-brittleness-cleanup
verify/7167-browser-connect-macos
fix/7167-browser-connect
feat/native-matching-allowance-setting
feat/browser-scenario-dry-run
test/managed-caller-parameters-20261024
codex/parser-fortythird-boundaries
fix/6926-pinvoke-platform-decorations-20261023
fix/6889-har-body-encoding-20261023
fix/6888-sqlite-schema-budget-20261023
fix/dependency-security-gates-6708
cursor/evidence-overwrite-rebase-b4ac
feat/4057-verify-native-exports
fix/windows-acl-observer-overhead-20261022
cursor/erlang-beam-restack-4476
cursor/pe-certificate-review-bf32
fix/6116-javascript-application-fs-errors
fix/6061-unmapped-runtime-script-unknown
feat/browser-scenario-summary
fix/pe-certificates
codex/verify-3407
cursor/rebase-5699
cursor/rebase-5352
cursor/rebase-5600
cursor/fix-cli-schema-omission-10a8
codex/audit-hopper-shutdown-reasons-20261021
fix/demangle-swift-omitted-record
fix/nib-boolean-value-types
cursor/cancellation-partial-observation-a5ac
fix/ib-object-limit-reasons
fix/electron-fuse-limit-advice
fix/kuna-doctor-dangling-cache
fix/fixed-budget-refusal-advice
fix/js-ipc-listener-dedup
fix/js-return-member-provenance
fix/dmg-integrity-retry-advice
fix/ida-doctor-readiness
fix/kuna-version-probe-output-drain
fix/legacy-swift-runtime-name-matching
fix/dylib-lazy-load-commands
fix/browser-scenario-startup-cancel
fix/swift-nested-punycode-classification
fix/compare-unselected-scopes
fix/objc-method-budget-coverage
fix/dmg-mounted-root-observations
audit/ci-tests-20261019-round2
release/6.7.0
fix/wabt-cleanup-retry-resolution
fix/electron-fuse-elf-pe-architecture
fix/native-plist-descriptor-ownership
fix/kuna-caller-cleanup-ownership
experiment/atomic-codemode-20261016
review/first-contributor-3776
fix/call-resolution-full-read-cycles
fix/member-mutation-selection-repeat
experiment/atomic-re-tools-20261015
perf/member-mutation-lazy-origins
perf/static-network-mutation-index
fix/hopper-startup-lifecycle
audit/3050-windows-proof-20261015
feat/windows-window-capture-2183
audit/3049-windows-proof-20261015
audit/3735-macos-fixtures-20261015
fix/batch-decompile-null-pseudocode
fix/kuna-inventory-honors-jobs
experiment/browser-codemode-tool-design-20261015
fix/hopper-clean-runtime-argv
codex/review-2049-27f1b367
review-fixes/pr-2787-routing
fix/3360-scoped-this-emitters
fix/3367-replaced-global-effects
fix/3838-compact-any-value-items
test/hopper-download-probe-20261015
codex/windows-runtime-creation-red-green-20261015
codex/windows-readonly-root-red-green-20261015
codex/windows-root-share-red-green-20261015
codex/exp-1685-win-mcp-startup
codex/bug-sweep-20261015
investigate/2190-windows-package-phases
investigate/3543-macos-cli-deadline
perf/3281-reverse-tools-feedback-quality
fix/3406-hopper-doctor-fixture
fix/3341-wrapper-require-test-context
fix/3301-owned-uninstall-fixtures
fix/3164-compiler-input-ownership
fix/pcap-cleanup-stdout-newline-20261014
perf/interface-builder-summary
codex/review-fixes-pr-1977
fix/ghidra-effective-jvm-platform
fix/docs-turkish-rust-link-20261013
fix/main-maintenance-ci-20261010
fix/recover-binary-session-process-effects
codex/review-fixes-pr-2457
codex/ci-required-cancellation-gate
fix/main-format-baseline-20261013
fix/setup-preserve-entry-fields
cursor/restore-main-checks-1ffc
fix/ghidra-bridge-hashmap-import
codex/shared-ci-jadx-json-default-20261013
codex/shared-ci-ghidra-test-groups-20261013
codex/shared-ci-java-fixture-format-20261013
codex/fix-intrinsic-invocation-boundaries
test/release-preflight-reusable-jobs
test/js-parameter-provenance-expectation
fix/linux-hopper-verification-current
test/2419-ghidra-elf-probe-size
followup/pr-1544-native-ida
codex/fold-pr-2230-contribution
docs/readme-responsible-use
fix/issue-2064
fix/issue-2050
fix/issue-2053
fix/issue-1968
fix/issue-1945
experiment/codemode-bridge-20261011
fix/tool-effects-negative-wording-1904-20261012
fix/1842-electron-interop-provenance
feat/recover-javascript-multi-input
refactor/website-i18n-prep
fix/nativeaot-pe-virtual-extent
fix/browser-verifier-ci-hang
fix/pe-resources-input-selection
docs/beginner-friendly-guides
docs/beginner-setup-guide
fix/javascript-analysis-worker-1563
fix/1649-ghidra-duplicate-names
fix/javascript-export-keys-integration-1369
test/maintenance-boundary-contracts-20261011
review/javascript-export-keys-1369
review/process-live-progress-1483
test/javascript-1495-growth-ratio
fix/ci-escape-timing
docs/normalized-terminal-geometry-1450
release/6.3.0
archive/release-6.3.0-pr1381
release/6.2.0
fix/electron-preload-dynamic-override
fix/javascript-self-referential-bundler-edges
release/6.1.0
cursor/grok-client-cherry-pick-0b56
feat/signature-posture
feat/dyld-shared-cache
feat/artifact-integrity-policy
feat/pkg-inventory
release/6.0.0
chore/sync-release-5.0.0
release/5.0.0
cursor/cloud-agent-node-787e
fix/javascript-xhr-open-endpoints
review/pr-711-realpath-fallback-wording
cleanup/replay-confinement
codex/test-suite-performance
codex/issue-foundations
codex/address-open-issues-2026-07-20
agent/javascript-vite-rollup-esbuild-adapters
agent/process-cleanup
agent/triage-integration
agent/unknown-commands-registry
feat/mcp-identity-metadata
morlvps/issue_cleanup
codex/installer-redesign
morl/roadmap-investigation-core
morl/roadmap-investigation-docs
release-please--branches--main--components--rea
rea-agents-6.8.0
rea-agents-6.7.0
rea-agents-6.6.0
experiment/atomic-codemode-wait-runtime-20261016
rea-agents-6.5.0
rea-agents-6.4.0
rea-agents-6.3.0
rea-agents-6.2.0
rea-agents-6.1.0
rea-agents-6.0.0
rea-agents-5.0.0
rea-agents-4.1.0
rea-agents-4.0.1
rea-agents-4.0.0
rea-agents-3.2.1
rea-agents-3.2.0
rea-agents-3.1.0
rea-agents-3.0.0
rea-agents-2.7.0
rea-agents-2.6.0
rea-agents-2.5.1
rea-agents-2.5.0
rea-agents-2.4.0
rea-agents-2.3.0
rea-agents-2.2.0
rea-agents-2.1.0
rea-agents-2.0.0
rea-agents-1.7.0
rea-agents-1.6.0
rea-agents-1.5.0
rea-agents-1.4.0
rea-agents-1.3.0
rea-agents-1.2.0
rea-agents-1.1.0
rea-agents-1.0.0
rea-agents-0.5.0
rea-agents-0.4.0
rea-agents-0.3.0
rea-0.2.1
rea-0.2.0
Labels
Clear labels
area: bridge
area: bridge
area: build
area: build
area: build
area: cli
area: domain
area: evidence
area: mcp
area: native
area: providers
area: runtime
area: server
area: setup
area: tests
bug
design
documentation
enhancement
enhancement
enhancement
experiment
help wanted
i18n
invalid
P0: critical
P1: high
P2: medium
P2: medium
P2: medium
P3: low
performance
provider-request
pull-request
Mirrored from GitHub Pull Request
question
roadmap
triage
No labels
area: bridge
area: bridge
area: build
area: build
area: build
area: cli
area: domain
area: evidence
area: mcp
area: native
area: providers
area: runtime
area: server
area: setup
area: tests
bug
design
documentation
enhancement
enhancement
enhancement
experiment
help wanted
i18n
invalid
P0: critical
P1: high
P2: medium
P2: medium
P2: medium
P3: low
performance
provider-request
pull-request
question
roadmap
triage
Milestone
Clear milestone
No items
No milestone
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".
No due date set.
Dependencies
No dependencies set.
Reference
morluto/rea#6670
Loading…
Add table
Add a link
Reference in a new issue
No description provided.
Delete branch "%!s()"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
📋 Pull Request Information
Original PR: https://github.com/morluto/rea/pull/4909
Author: @mertkayacs
Created: 10/17/2026
Status: ❌ Closed
Base:
main← Head:fix/pcap-utc-capture-instants📝 Commits (4)
82bc2f5test(pcap): expect capture instants as UTC from epoch capinfos timestampsdf3bd2dfix(pcap): report capture instants in UTC instead of host-local time9c57278fix(pcap): keep pre-epoch capture instants exact4dac658test(pcap): read the real capinfos oracle from epoch seconds📊 Changes
9 files changed (+111 additions, -24 deletions)
View changed files
📝
scripts/verify-packet-capture.mjs(+15 -5)📝
src/pcap/PcapConfiguration.test.ts(+39 -6)📝
src/pcap/PcapOutput.ts(+39 -6)📝
src/pcap/PcapProvider.ts(+1 -1)📝
tests/boundary/mcp/pcapMcp.test.ts(+2 -2)📝
tests/boundary/pcap/pcapProvider.test.ts(+5 -1)📝
tests/boundary/pcap/pcapProviderCrossPlatform.test.ts(+2 -0)📝
tests/fixtures/pcap/capinfos-stub.cmd(+5 -2)📝
tests/fixtures/pcap/capinfos-stub.sh(+3 -1)📄 Description
Summary
inspect_pcap_capturereportscapture_startandcapture_endas the text capinfos prints by default, which is the packet time in the host's local time zone with no zone marker. The same capture therefore reads2026-10-11 14:13:40.608505on one host and2026-10-11 16:13:40.608505on another, and neither string names an instant. This change runs capinfos with-S, which prints exact epoch seconds, and projects that value to an RFC 3339 UTC instant that keeps every fractional digit (2026-10-11T14:13:40.608505Z). Fixes #4907.Problem and expected behavior
Trigger:
rea inspect-pcap-capture <file> --jsonon any capture with at least one packet, on a host whoseTZis not UTC. REA runscapinfos -M -- <file>withLC_ALL=Cbut inheritsTZ. capinfos formatsEarliest packet timewithformat_nstime_as_iso8601(..., local = true, ...), which useslocaltimeand appends noZor offset (wsutil/to_str.c,format_nstime_as_iso8601; capinfos.c,absolute_time_string). With-Sthe same function path callsdisplay_epoch_time, which prints thenstimeseconds and the capture's fractional precision verbatim (capinfos.ctime_as_secs, wsutil/to_str.cdisplay_signed_time).Violated invariant: a reported timestamp must identify one instant independently of the analyzing host. REA's own timestamp contracts require an explicit UTC offset (
offsetDateTimeSchema), and AGENTS.md asks that identity values stay separate from display formatting. A zone-less local string is a display spelling of the host, not an identity of the capture.Expected:
capture_startandcapture_endare the same bytes for the same capture on every host, carry an explicit zone, and keep the producer's exact precision.Change and scope
PcapProviderrunscapinfos -M -S -- <snapshot>.parseCapinfosOutputprojects[-]<seconds>[.<fraction>]toYYYY-MM-DDTHH:MM:SS[.<fraction>]Zfrom the integer seconds and the fraction digits, so nothing is rounded or extended; a pre-epoch value (capinfos prints a leading minus) borrows from the next whole second so the instant stays exact (-1.250000is1969-12-31T23:59:58.750000Z).n/a(empty capture), a wall-clock spelling from a capinfos run without-S, and a value outside years 0000 to 9999 staynull, which the schema already allows.scripts/verify-packet-capture.mjs(the real-TShark job) reads its capinfos oracle with-Stoo and projects the epoch text independently of the product before comparing.capture_duration_secondspath (already a plain number), tshark field selection, and any change to the result schema types.Contribution scope: ordinary fix inside the existing capinfos read boundary; not applicable.
Contract and boundary impact
src/pcap/PcapOutput.ts(parseCapinfosOutput), the capinfos metadata owner; transport or result projection.capture_startandcapture_endkeep theirstring | nulltype. Their value changes from a host-local, zone-less spelling to an RFC 3339 UTC instant. Consumers that parsed the old spelling as local time of the analyzing host need to read the new one as UTC.-Sexists in every Wireshark 3.x and 4.x capinfos (documented in the capinfos man page). The Windows and POSIX stubs undertests/fixtures/pcap/were updated to accept it.nullinstead of being reported as observed text.Expected effects:
Evidence and regression coverage
Tests added or updated:
src/pcap/PcapConfiguration.test.ts(real-output fixture now uses-Sspellings; new case covers a fraction-less value, a fraction with trailing zeros,n/aand a wall-clock spelling),tests/boundary/pcap/pcapProvider.test.tsandpcapProviderCrossPlatform.test.ts(stub capinfos rejects a call without-S, and the projectedcapture_start/capture_endare asserted end to end through the provider),tests/boundary/mcp/pcapMcp.test.ts(fixture values),tests/fixtures/pcap/capinfos-stub.{sh,cmd}.Base reproduction or other evidence: executed with capinfos 4.2.2 on a two-packet capture (output in #4907): the default spelling is
2026-10-11 17:13:40.608505underTZ=Europe/Istanbuland2026-10-11 14:13:40.608505underTZ=UTC, with no marker;-Sprints1791728020.608505under both. This matches Wiresharkcapinfos.candwsutil/to_str.cas cited above;src/pcap/PcapCommand.tssetsLC_ALL/LANGbut notTZ. On the base revision2fb5e204a35723f6f843d56ca47b0db94d8fcc44the test commit alone fails:PcapConfiguration.test.ts3 failed / 6 passed in itsparseCapinfosOutputblock, and the focused boundary run 12 failed / 18 passed / 1 skipped, because the stub refuses the-M -- <path>argument list and the old spelling is reported.User-visible CLI/MCP output:
"capture_start": "2026-10-11T14:13:40.608505Z"instead of"capture_start": "2026-10-11 14:13:40.608505".Remaining proof gaps: the Windows
.cmdstub path was not executed here (Linux only).Observed, derived, and inferred claims remain distinguishable.
Artifact identity, source provenance, and failed attempts remain preserved.
Unsupported, incomplete, unavailable, or uncertain outcomes remain visible.
Validation performed
npm run test:local -- src/pcap/PcapConfiguration.test.ts src/pcap/PcapOutput.test.ts— 26 passed (on the test-only commit: 3 failed inparseCapinfosOutput, 17 of 20 passed in that file).npm run test:focused -- tests/boundary/pcap/pcapProvider.test.ts tests/boundary/pcap/pcapProviderCrossPlatform.test.ts tests/boundary/mcp/pcapMcp.test.ts— 30 passed, 1 skipped (on the test-only commit: 12 failed, 18 passed, 1 skipped).npm run check:fast— typecheck and lint successful (2 tasks).npx prettier --checkon the six touched TypeScript files — clean.d0253c99d;npm run test:local -- src/pcap/PcapConfiguration.test.ts src/pcap/PcapOutput.test.tsthere — 26 passed.npm run test:localon the same two files — 26 passed;npm run test:focusedon the three boundary files — 30 passed, 1 skipped;npm run check:fast— passed;npm run build:cachedthenREA_TSHARK_COMMAND=/usr/bin/tshark node scripts/verify-packet-capture.mjswith TShark and capinfos 4.2.2 on Linux x64 — passed (exit 0), so the product and the oracle agree on real capinfos output.Compatibility, safety, and release
scripts/verify-packet-capture.mjs; no other provider involved.Author readiness
Human owner: @mertkayacs
Before merge
type(scope): outcome.🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.