mirror of
https://github.com/morluto/rea.git
synced 2026-11-05 06:45:22 +00:00
[PR #4918] [CLOSED] fix(apktool): select three-digit regions through the b+ locale table #6674
Closed
opened 2026-11-01 21:42:13 +00:00 by bsakaguchi
·
0 comments
No Branch/Tag specified
main
codex/procedure-reference-stacked
release-please--branches--main--components--rea-agents
release-please--branches--main--components--rea-agents--release-notes
codex/kuna-independent-retry
codex/byte-search-overlay-coverage
codex/open-failure-target-receipt
codex/kuna-xref-evidence
codex/ghidra-ambiguous-procedure-recovery
codex/function-source-bundle
codex/trace-function-integration-prototype
codex/snapshot-source-closure
codex/recorded-evidence-array-pages
codex/evidence-recovery-redesign
codex/trace-feature-address-scope
codex/call-discovery-scope
codex/ghidra-literal-candidate-evidence
codex/decompile-directory-independent-retry
codex/retry-provenance-base
codex/value-flow-capability-experiment
codex/ghidra-containing-instruction
cursor/readme-discord-button-ef9f
dependabot/github_actions/actions/setup-node-7.1.0
dependabot/github_actions/actions/upload-artifact-7.0.2
dependabot/npm_and_yarn/npm-minor-and-patch-d8d97ce6df
codex/kuna-1989
fix/8559-native-ui-fixture-ownership
fix/8555-go-verifier-mcp-ownership
codex/provider-capability-recovery
fix/8642-rizin-target-stdin
codex/ghidra-memory-effect-scope
codex/ghidra-annotation-entry-selector
codex/ghidra-readonly-recovery
codex/ghidra-regex-verifier-recovery
codex/evidence-discovery-view-guidance
fix/8545-bulk-append-overflow
fix/8428-navigation-refusal-alternatives
codex/address-context-recovery
codex/matching-member-limitations
codex/unknown-scope-contract
codex/evidence-view-guidance
feat/8373-native-trace-views
codex/ghidra-snapshot-verifier-binding
codex/elf-export-visibility
codex/evidence-view-recovery
codex/native-reference-cli-help
codex/provider-candidate-observation-scope
codex/kuna-session-verification
codex/ghidra-switch-lifetime-guidance
codex/pseudocode-paging-discovery
codex/clarify-evidence-view-support
codex/kuna-xrefs-selector-recovery
codex/context-capacity-recovery
codex/evidence-closure-large-links
codex/same-function-evidence-identity
codex/ghidra-verifier-inspected-jdk
codex/audit-guided-workflows
codex/crash-prompt-retained-dossiers
codex/analysis-view-error-recovery
codex/kuna-verifier-target-selection
codex/ghidra-selected-project-call-coverage
codex/docs-native-analysis-scope
codex/ghidra-java-socket-boundary
codex/ghidra-retained-snapshot-verifier
codex/ghidra-search-inventory-facts
fix/8284-zero-argument-parameter-bindings
fix/8198-ui-action-handler-offset
fix/8257-elf-entry-label-identity
fix/8304-deferred-output-schema-projection
fix/8277-call-path-computed-target-uncertainty
fix/pr-8089-conflicts
fix/ci-static-duplicate-export
dependabot/npm_and_yarn/lint-staged-17.6.0
dependabot/github_actions/actions/download-artifact-8.0.2
dependabot/npm_and_yarn/write-file-atomic-8.0.0
dependabot/npm_and_yarn/canonicalize-5.1.0
dependabot/github_actions/actions/cache/restore-6.1.0
dependabot/npm_and_yarn/toon-format/toon-4.4.0
dependabot/github_actions/actions/deploy-pages-5.0.1
codex/review-fixes-pr-2403
codex/review-fixes-pr-2400
codex/process-terminal-width
codex/test-brittleness-cleanup
verify/7167-browser-connect-macos
fix/7167-browser-connect
feat/native-matching-allowance-setting
feat/browser-scenario-dry-run
test/managed-caller-parameters-20261024
codex/parser-fortythird-boundaries
fix/6926-pinvoke-platform-decorations-20261023
fix/6889-har-body-encoding-20261023
fix/6888-sqlite-schema-budget-20261023
fix/dependency-security-gates-6708
cursor/evidence-overwrite-rebase-b4ac
feat/4057-verify-native-exports
fix/windows-acl-observer-overhead-20261022
cursor/erlang-beam-restack-4476
cursor/pe-certificate-review-bf32
fix/6116-javascript-application-fs-errors
fix/6061-unmapped-runtime-script-unknown
feat/browser-scenario-summary
fix/pe-certificates
codex/verify-3407
cursor/rebase-5699
cursor/rebase-5352
cursor/rebase-5600
cursor/fix-cli-schema-omission-10a8
codex/audit-hopper-shutdown-reasons-20261021
fix/demangle-swift-omitted-record
fix/nib-boolean-value-types
cursor/cancellation-partial-observation-a5ac
fix/ib-object-limit-reasons
fix/electron-fuse-limit-advice
fix/kuna-doctor-dangling-cache
fix/fixed-budget-refusal-advice
fix/js-ipc-listener-dedup
fix/js-return-member-provenance
fix/dmg-integrity-retry-advice
fix/ida-doctor-readiness
fix/kuna-version-probe-output-drain
fix/legacy-swift-runtime-name-matching
fix/dylib-lazy-load-commands
fix/browser-scenario-startup-cancel
fix/swift-nested-punycode-classification
fix/compare-unselected-scopes
fix/objc-method-budget-coverage
fix/dmg-mounted-root-observations
audit/ci-tests-20261019-round2
release/6.7.0
fix/wabt-cleanup-retry-resolution
fix/electron-fuse-elf-pe-architecture
fix/native-plist-descriptor-ownership
fix/kuna-caller-cleanup-ownership
experiment/atomic-codemode-20261016
review/first-contributor-3776
fix/call-resolution-full-read-cycles
fix/member-mutation-selection-repeat
experiment/atomic-re-tools-20261015
perf/member-mutation-lazy-origins
perf/static-network-mutation-index
fix/hopper-startup-lifecycle
audit/3050-windows-proof-20261015
feat/windows-window-capture-2183
audit/3049-windows-proof-20261015
audit/3735-macos-fixtures-20261015
fix/batch-decompile-null-pseudocode
fix/kuna-inventory-honors-jobs
experiment/browser-codemode-tool-design-20261015
fix/hopper-clean-runtime-argv
codex/review-2049-27f1b367
review-fixes/pr-2787-routing
fix/3360-scoped-this-emitters
fix/3367-replaced-global-effects
fix/3838-compact-any-value-items
test/hopper-download-probe-20261015
codex/windows-runtime-creation-red-green-20261015
codex/windows-readonly-root-red-green-20261015
codex/windows-root-share-red-green-20261015
codex/exp-1685-win-mcp-startup
codex/bug-sweep-20261015
investigate/2190-windows-package-phases
investigate/3543-macos-cli-deadline
perf/3281-reverse-tools-feedback-quality
fix/3406-hopper-doctor-fixture
fix/3341-wrapper-require-test-context
fix/3301-owned-uninstall-fixtures
fix/3164-compiler-input-ownership
fix/pcap-cleanup-stdout-newline-20261014
perf/interface-builder-summary
codex/review-fixes-pr-1977
fix/ghidra-effective-jvm-platform
fix/docs-turkish-rust-link-20261013
fix/main-maintenance-ci-20261010
fix/recover-binary-session-process-effects
codex/review-fixes-pr-2457
codex/ci-required-cancellation-gate
fix/main-format-baseline-20261013
fix/setup-preserve-entry-fields
cursor/restore-main-checks-1ffc
fix/ghidra-bridge-hashmap-import
codex/shared-ci-jadx-json-default-20261013
codex/shared-ci-ghidra-test-groups-20261013
codex/shared-ci-java-fixture-format-20261013
codex/fix-intrinsic-invocation-boundaries
test/release-preflight-reusable-jobs
test/js-parameter-provenance-expectation
fix/linux-hopper-verification-current
test/2419-ghidra-elf-probe-size
followup/pr-1544-native-ida
codex/fold-pr-2230-contribution
docs/readme-responsible-use
fix/issue-2064
fix/issue-2050
fix/issue-2053
fix/issue-1968
fix/issue-1945
experiment/codemode-bridge-20261011
fix/tool-effects-negative-wording-1904-20261012
fix/1842-electron-interop-provenance
feat/recover-javascript-multi-input
refactor/website-i18n-prep
fix/nativeaot-pe-virtual-extent
fix/browser-verifier-ci-hang
fix/pe-resources-input-selection
docs/beginner-friendly-guides
docs/beginner-setup-guide
fix/javascript-analysis-worker-1563
fix/1649-ghidra-duplicate-names
fix/javascript-export-keys-integration-1369
test/maintenance-boundary-contracts-20261011
review/javascript-export-keys-1369
review/process-live-progress-1483
test/javascript-1495-growth-ratio
fix/ci-escape-timing
docs/normalized-terminal-geometry-1450
release/6.3.0
archive/release-6.3.0-pr1381
release/6.2.0
fix/electron-preload-dynamic-override
fix/javascript-self-referential-bundler-edges
release/6.1.0
cursor/grok-client-cherry-pick-0b56
feat/signature-posture
feat/dyld-shared-cache
feat/artifact-integrity-policy
feat/pkg-inventory
release/6.0.0
chore/sync-release-5.0.0
release/5.0.0
cursor/cloud-agent-node-787e
fix/javascript-xhr-open-endpoints
review/pr-711-realpath-fallback-wording
cleanup/replay-confinement
codex/test-suite-performance
codex/issue-foundations
codex/address-open-issues-2026-07-20
agent/javascript-vite-rollup-esbuild-adapters
agent/process-cleanup
agent/triage-integration
agent/unknown-commands-registry
feat/mcp-identity-metadata
morlvps/issue_cleanup
codex/installer-redesign
morl/roadmap-investigation-core
morl/roadmap-investigation-docs
release-please--branches--main--components--rea
rea-agents-6.8.0
rea-agents-6.7.0
rea-agents-6.6.0
experiment/atomic-codemode-wait-runtime-20261016
rea-agents-6.5.0
rea-agents-6.4.0
rea-agents-6.3.0
rea-agents-6.2.0
rea-agents-6.1.0
rea-agents-6.0.0
rea-agents-5.0.0
rea-agents-4.1.0
rea-agents-4.0.1
rea-agents-4.0.0
rea-agents-3.2.1
rea-agents-3.2.0
rea-agents-3.1.0
rea-agents-3.0.0
rea-agents-2.7.0
rea-agents-2.6.0
rea-agents-2.5.1
rea-agents-2.5.0
rea-agents-2.4.0
rea-agents-2.3.0
rea-agents-2.2.0
rea-agents-2.1.0
rea-agents-2.0.0
rea-agents-1.7.0
rea-agents-1.6.0
rea-agents-1.5.0
rea-agents-1.4.0
rea-agents-1.3.0
rea-agents-1.2.0
rea-agents-1.1.0
rea-agents-1.0.0
rea-agents-0.5.0
rea-agents-0.4.0
rea-agents-0.3.0
rea-0.2.1
rea-0.2.0
Labels
Clear labels
area: bridge
area: bridge
area: build
area: build
area: build
area: cli
area: domain
area: evidence
area: mcp
area: native
area: providers
area: runtime
area: server
area: setup
area: tests
bug
design
documentation
enhancement
enhancement
enhancement
experiment
help wanted
i18n
invalid
P0: critical
P1: high
P2: medium
P2: medium
P2: medium
P3: low
performance
provider-request
pull-request
Mirrored from GitHub Pull Request
question
roadmap
triage
No labels
area: bridge
area: bridge
area: build
area: build
area: build
area: cli
area: domain
area: evidence
area: mcp
area: native
area: providers
area: runtime
area: server
area: setup
area: tests
bug
design
documentation
enhancement
enhancement
enhancement
experiment
help wanted
i18n
invalid
P0: critical
P1: high
P2: medium
P2: medium
P2: medium
P3: low
performance
provider-request
pull-request
question
roadmap
triage
Milestone
Clear milestone
No items
No milestone
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".
No due date set.
Dependencies
No dependencies set.
Reference
morluto/rea#6674
Loading…
Add table
Add a link
Reference in a new issue
No description provided.
Delete branch "%!s()"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
📋 Pull Request Information
Original PR: https://github.com/morluto/rea/pull/4918
Author: @mertkayacs
Created: 10/17/2026
Status: ❌ Closed
Base:
main← Head:fix/apktool-numeric-region-locale📝 Commits (6)
7e39288test(apktool): select three-digit regions through the b+ locale table1299b4bfix(apktool): select three-digit regions through the b+ locale table631ae5btest(apktool): cover more three-digit regions and the rejected r-form spelling5924e23docs(apktool): name the Apktool versions behind the b+ region rule1450f8etest(apktool): keep the string table describe blocks under the lint limitfacf1d0docs(apktool): split the locale spelling sentence into short sentences📊 Changes
5 files changed (+95 additions, -8 deletions)
View changed files
📝
docs/apktool-resource-analysis.md(+3 -2)📝
src/apktool/ApktoolStringTables.test.ts(+37 -1)📝
src/domain/apktool/apktoolResourceAnalysis.test.ts(+20 -2)📝
src/domain/apktool/apktoolResourceAnalysis.ts(+10 -3)📝
tests/boundary/cli/apktoolLocaleOption.test.ts(+25 -0)📄 Description
Summary
decode_android_resourcesnormalizes a regional locale alias at the selection owner, sopt-BRreadsres/values-pt-rBR/strings.xml. The same alias rule turned a three-digit region into-rform:es-419selectedres/values-es-r419/strings.xml. Apktool never writes that directory. For a region of three digits it writes only the BCP 47 form,values-b+es+419, so the request came backmissingwhile the table existed under its real name.es-419now selectsvalues-b+es+419, and the hybrid spellinges-r419, which names no table, is no longer admitted. Fixes #4916.Problem and expected behavior
Trigger:
rea decode-android-resources <apk> --locale es-419 --jsonon an APK whose resources carry Latin American Spanish, which Apktool decodes tores/values-b+es+419/strings.xml. Before this change the result reports the tablemissingand namesvalues-es-r419in the limitation.Violated invariant: the alias must select the directory the producer writes. Every Apktool REA supports writes a three-digit region in the
b+form. At the documented floor, v2.7.0,ResConfigFlags.getLocaleString(brut.apktool/apktool-lib/src/main/java/brut/androlib/res/data/ResConfigFlags.java, lines 440-470) takes the legacy-<lang>[-r<REGION>]branch only whenregion.length != 3, andARSCDecoder.unpackLanguageOrRegion(lines 512-524) expands a packed region to three characters; v2.11.1 keeps the same rule (lines 594-630) and v2.12.1 states it asmRegion.length() == 2(generateQualifiers, lines 275-285). On 3.x the rule lives inResConfig.computeQualifiers(brut/androlib/res/table/ResConfig.java, v3.0.3 lines 275-295): legacy form only when the script is empty, the variant is empty and the region is empty or two characters; any other locale, a three-digit region included, is written as-b+<lang>[+<script>][+<region>][+<variant>]. aapt2's directory parser agrees from the other side:LocaleValue::InitFromParts(libs/androidfw/Locale.cpp) takes a legacy region part only when it isrfollowed by two characters, sovalues-es-r419is not a resource directory aapt2 accepts either. The-r419spelling has one source,ResTable_config::appendDirLocaleinResourceTypes.cpp, which prints a config without a script that way; that is a runtime printer, not the decoder that lays out the workspace REA reads.Expected:
es-419andb+es+419are two aliases of one physical table, read once, both reportedpresent;es-r419is refused by the locale grammar like any other spelling that cannot name a table.Change and scope
androidLocaleDirectorySuffixmaps<lang>-<DDD>tob+<lang>+<DDD>;<lang>-<RR>still maps to<lang>-r<RR>.<lang>-<DDD>as an admitted alias and drops<lang>-r<DDD>, which no Android resource directory carries. The grammar's message now listses-419among its examples.docs/apktool-resource-analysis.mdstates the three-digit mapping next to the existingpt-BRsentence.Contribution scope: ordinary fix within the existing read-only Apktool decode boundary; not applicable.
Contract and boundary impact
androidLocaleDirectorySuffixandandroidLocaleQualifierSchemainsrc/domain/apktool/apktoolResourceAnalysis.ts; request parsing and table selection.localeandlocaleskeep their grammar for every spelling except<lang>-r<DDD>, which is now refused with the owner's message. Thelocaleslisting is unchanged:b+<lang>+<DDD>directories were already advertised asb+…, and<lang>-r<DDD>directories do not occur.presentfor the alias instead ofmissing; nothing else changes shape.Expected effects:
Evidence and regression coverage
src/domain/apktool/apktoolResourceAnalysis.test.ts(aliasesen-419,en-001,ar-015andfil-419normalize to theb+form;b+es+419,b+en+001andb+ar+015are selectable tables;es-r419,en-r001andar-r015are refused with the message that nameses-419;pt-BRstill maps topt-rBR),src/apktool/ApktoolStringTables.test.ts(es-419,en-001andar-015each read theirvalues-b+<lang>+<DDD>/strings.xmlonce alongside theb+alias and both arepresent; the existingpt-BRandpt-rBRcase still readsvalues-pt-rBRonce),tests/boundary/cli/apktoolLocaleOption.test.ts(the public CLI refuses--locale en-r419and--locale es-r419withcode: VALIDATION_ERRORand alocalefield error carrying the grammar message).7e39288e4) ona25eb5fbb,npm run test:localon the two unit files reports 5 failed / 39 passed, andnpm run test:focused -- tests/boundary/cli/apktoolLocaleOption.test.tsreports 1 failed / 5 passed. The producer behavior is source-derived from ApktoolResConfig.computeQualifiersand androidfwLocaleValue::InitFromParts, cited above.--locale es-419,string_tables[0](and the legacystringsfield) now carry the entries ofvalues-b+es+419/strings.xmlwithstatus: "present"instead ofstatus: "missing"and the limitationNo strings.xml was found for locale es-419.--locale en-r419now exits with the grammar messageLocale must look like de, pt-BR, pt-rBR, es-419, or b+zh+Hans+CN.For evidence-bearing changes:
Validation performed
npm run test:local -- src/domain/apktool/apktoolResourceAnalysis.test.ts src/apktool/ApktoolStringTables.test.tsat7e39288e4(tests only) — 5 failed, 39 passed.npm run test:focused -- tests/boundary/cli/apktoolLocaleOption.test.tsat7e39288e4— 1 failed, 5 passed.npm run test:local -- src/domain/apktool/apktoolResourceAnalysis.test.ts src/apktool/ApktoolStringTables.test.ts src/apktool/ApktoolProvider.test.ts src/apktool/ApktoolDecodeOutput.test.ts src/application/apktool/ApktoolResourceAnalysisService.test.tsat1299b4bd4— 152 passed.npm run test:focused -- tests/boundary/cli/apktoolLocaleOption.test.ts tests/boundary/cli/apktoolCli.test.ts tests/boundary/mcp/apktoolMcp.test.tsat1299b4bd4— 11 passed.npm run check:fast— 2 tasks successful.npm run docs:check— generated-doc checks passed;tests/conformance/readmeConsistency.test.tspassed.npx oxfmt --checkon the four touched TypeScript files — all formatted.631ae5b37and5924e2372), then rebased ontoa25eb5fbbwith the string table describe block split in two (1450f8e51) so the merged file stays under the lint limit, and the docs sentence split (facf1d0a2):npm run test:localon all ninesrc/apktool/*.test.tsandsrc/domain/apktool/*.test.tsfiles — 253 passed;npm run test:focused -- tests/boundary/cli/apktoolLocaleOption.test.ts tests/boundary/cli/apktoolCli.test.ts tests/boundary/mcp/apktoolMcp.test.ts tests/boundary/cli/cliInputSchemaRequired.test.ts— 17 passed;npm run check:fast— 2 tasks successful;npm run docs:checkandtests/conformance/readmeConsistency.test.ts— passed;npx oxfmt --checkon the touched files — all formatted. Node 24.18.0, Linux x64.Compatibility, safety, and release
<lang>-r<DDD>is now refused instead of receivingmissing;<lang>-<DDD>orb+<lang>+<DDD>selects the table.Author readiness
Human owner: @mertkayacs
Before merge
type(scope): outcome.🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.