mirror of
https://github.com/morluto/rea.git
synced 2026-11-05 07:47:29 +00:00
[PR #4956] [CLOSED] fix(analysis): preserve evidence and identity across recovery paths #6693
Closed
opened 2026-11-01 21:42:20 +00:00 by bsakaguchi
·
0 comments
No Branch/Tag specified
main
release-please--branches--main--components--rea-agents
release-please--branches--main--components--rea-agents--release-notes
codex/procedure-reference-stacked
codex/kuna-independent-retry
codex/byte-search-overlay-coverage
codex/open-failure-target-receipt
codex/kuna-xref-evidence
codex/ghidra-ambiguous-procedure-recovery
codex/function-source-bundle
codex/trace-function-integration-prototype
codex/snapshot-source-closure
codex/recorded-evidence-array-pages
codex/evidence-recovery-redesign
codex/trace-feature-address-scope
codex/call-discovery-scope
codex/ghidra-literal-candidate-evidence
codex/decompile-directory-independent-retry
codex/retry-provenance-base
codex/value-flow-capability-experiment
codex/ghidra-containing-instruction
cursor/readme-discord-button-ef9f
dependabot/github_actions/actions/setup-node-7.1.0
dependabot/github_actions/actions/upload-artifact-7.0.2
dependabot/npm_and_yarn/npm-minor-and-patch-d8d97ce6df
codex/kuna-1989
fix/8559-native-ui-fixture-ownership
fix/8555-go-verifier-mcp-ownership
codex/provider-capability-recovery
fix/8642-rizin-target-stdin
codex/ghidra-memory-effect-scope
codex/ghidra-annotation-entry-selector
codex/ghidra-readonly-recovery
codex/ghidra-regex-verifier-recovery
codex/evidence-discovery-view-guidance
fix/8545-bulk-append-overflow
fix/8428-navigation-refusal-alternatives
codex/address-context-recovery
codex/matching-member-limitations
codex/unknown-scope-contract
codex/evidence-view-guidance
feat/8373-native-trace-views
codex/ghidra-snapshot-verifier-binding
codex/elf-export-visibility
codex/evidence-view-recovery
codex/native-reference-cli-help
codex/provider-candidate-observation-scope
codex/kuna-session-verification
codex/ghidra-switch-lifetime-guidance
codex/pseudocode-paging-discovery
codex/clarify-evidence-view-support
codex/kuna-xrefs-selector-recovery
codex/context-capacity-recovery
codex/evidence-closure-large-links
codex/same-function-evidence-identity
codex/ghidra-verifier-inspected-jdk
codex/audit-guided-workflows
codex/crash-prompt-retained-dossiers
codex/analysis-view-error-recovery
codex/kuna-verifier-target-selection
codex/ghidra-selected-project-call-coverage
codex/docs-native-analysis-scope
codex/ghidra-java-socket-boundary
codex/ghidra-retained-snapshot-verifier
codex/ghidra-search-inventory-facts
fix/8284-zero-argument-parameter-bindings
fix/8198-ui-action-handler-offset
fix/8257-elf-entry-label-identity
fix/8304-deferred-output-schema-projection
fix/8277-call-path-computed-target-uncertainty
fix/pr-8089-conflicts
fix/ci-static-duplicate-export
dependabot/npm_and_yarn/lint-staged-17.6.0
dependabot/github_actions/actions/download-artifact-8.0.2
dependabot/npm_and_yarn/write-file-atomic-8.0.0
dependabot/npm_and_yarn/canonicalize-5.1.0
dependabot/github_actions/actions/cache/restore-6.1.0
dependabot/npm_and_yarn/toon-format/toon-4.4.0
dependabot/github_actions/actions/deploy-pages-5.0.1
codex/review-fixes-pr-2403
codex/review-fixes-pr-2400
codex/process-terminal-width
codex/test-brittleness-cleanup
verify/7167-browser-connect-macos
fix/7167-browser-connect
feat/native-matching-allowance-setting
feat/browser-scenario-dry-run
test/managed-caller-parameters-20261024
codex/parser-fortythird-boundaries
fix/6926-pinvoke-platform-decorations-20261023
fix/6889-har-body-encoding-20261023
fix/6888-sqlite-schema-budget-20261023
fix/dependency-security-gates-6708
cursor/evidence-overwrite-rebase-b4ac
feat/4057-verify-native-exports
fix/windows-acl-observer-overhead-20261022
cursor/erlang-beam-restack-4476
cursor/pe-certificate-review-bf32
fix/6116-javascript-application-fs-errors
fix/6061-unmapped-runtime-script-unknown
feat/browser-scenario-summary
fix/pe-certificates
codex/verify-3407
cursor/rebase-5699
cursor/rebase-5352
cursor/rebase-5600
cursor/fix-cli-schema-omission-10a8
codex/audit-hopper-shutdown-reasons-20261021
fix/demangle-swift-omitted-record
fix/nib-boolean-value-types
cursor/cancellation-partial-observation-a5ac
fix/ib-object-limit-reasons
fix/electron-fuse-limit-advice
fix/kuna-doctor-dangling-cache
fix/fixed-budget-refusal-advice
fix/js-ipc-listener-dedup
fix/js-return-member-provenance
fix/dmg-integrity-retry-advice
fix/ida-doctor-readiness
fix/kuna-version-probe-output-drain
fix/legacy-swift-runtime-name-matching
fix/dylib-lazy-load-commands
fix/browser-scenario-startup-cancel
fix/swift-nested-punycode-classification
fix/compare-unselected-scopes
fix/objc-method-budget-coverage
fix/dmg-mounted-root-observations
audit/ci-tests-20261019-round2
release/6.7.0
fix/wabt-cleanup-retry-resolution
fix/electron-fuse-elf-pe-architecture
fix/native-plist-descriptor-ownership
fix/kuna-caller-cleanup-ownership
experiment/atomic-codemode-20261016
review/first-contributor-3776
fix/call-resolution-full-read-cycles
fix/member-mutation-selection-repeat
experiment/atomic-re-tools-20261015
perf/member-mutation-lazy-origins
perf/static-network-mutation-index
fix/hopper-startup-lifecycle
audit/3050-windows-proof-20261015
feat/windows-window-capture-2183
audit/3049-windows-proof-20261015
audit/3735-macos-fixtures-20261015
fix/batch-decompile-null-pseudocode
fix/kuna-inventory-honors-jobs
experiment/browser-codemode-tool-design-20261015
fix/hopper-clean-runtime-argv
codex/review-2049-27f1b367
review-fixes/pr-2787-routing
fix/3360-scoped-this-emitters
fix/3367-replaced-global-effects
fix/3838-compact-any-value-items
test/hopper-download-probe-20261015
codex/windows-runtime-creation-red-green-20261015
codex/windows-readonly-root-red-green-20261015
codex/windows-root-share-red-green-20261015
codex/exp-1685-win-mcp-startup
codex/bug-sweep-20261015
investigate/2190-windows-package-phases
investigate/3543-macos-cli-deadline
perf/3281-reverse-tools-feedback-quality
fix/3406-hopper-doctor-fixture
fix/3341-wrapper-require-test-context
fix/3301-owned-uninstall-fixtures
fix/3164-compiler-input-ownership
fix/pcap-cleanup-stdout-newline-20261014
perf/interface-builder-summary
codex/review-fixes-pr-1977
fix/ghidra-effective-jvm-platform
fix/docs-turkish-rust-link-20261013
fix/main-maintenance-ci-20261010
fix/recover-binary-session-process-effects
codex/review-fixes-pr-2457
codex/ci-required-cancellation-gate
fix/main-format-baseline-20261013
fix/setup-preserve-entry-fields
cursor/restore-main-checks-1ffc
fix/ghidra-bridge-hashmap-import
codex/shared-ci-jadx-json-default-20261013
codex/shared-ci-ghidra-test-groups-20261013
codex/shared-ci-java-fixture-format-20261013
codex/fix-intrinsic-invocation-boundaries
test/release-preflight-reusable-jobs
test/js-parameter-provenance-expectation
fix/linux-hopper-verification-current
test/2419-ghidra-elf-probe-size
followup/pr-1544-native-ida
codex/fold-pr-2230-contribution
docs/readme-responsible-use
fix/issue-2064
fix/issue-2050
fix/issue-2053
fix/issue-1968
fix/issue-1945
experiment/codemode-bridge-20261011
fix/tool-effects-negative-wording-1904-20261012
fix/1842-electron-interop-provenance
feat/recover-javascript-multi-input
refactor/website-i18n-prep
fix/nativeaot-pe-virtual-extent
fix/browser-verifier-ci-hang
fix/pe-resources-input-selection
docs/beginner-friendly-guides
docs/beginner-setup-guide
fix/javascript-analysis-worker-1563
fix/1649-ghidra-duplicate-names
fix/javascript-export-keys-integration-1369
test/maintenance-boundary-contracts-20261011
review/javascript-export-keys-1369
review/process-live-progress-1483
test/javascript-1495-growth-ratio
fix/ci-escape-timing
docs/normalized-terminal-geometry-1450
release/6.3.0
archive/release-6.3.0-pr1381
release/6.2.0
fix/electron-preload-dynamic-override
fix/javascript-self-referential-bundler-edges
release/6.1.0
cursor/grok-client-cherry-pick-0b56
feat/signature-posture
feat/dyld-shared-cache
feat/artifact-integrity-policy
feat/pkg-inventory
release/6.0.0
chore/sync-release-5.0.0
release/5.0.0
cursor/cloud-agent-node-787e
fix/javascript-xhr-open-endpoints
review/pr-711-realpath-fallback-wording
cleanup/replay-confinement
codex/test-suite-performance
codex/issue-foundations
codex/address-open-issues-2026-07-20
agent/javascript-vite-rollup-esbuild-adapters
agent/process-cleanup
agent/triage-integration
agent/unknown-commands-registry
feat/mcp-identity-metadata
morlvps/issue_cleanup
codex/installer-redesign
morl/roadmap-investigation-core
morl/roadmap-investigation-docs
release-please--branches--main--components--rea
rea-agents-6.8.0
rea-agents-6.7.0
rea-agents-6.6.0
experiment/atomic-codemode-wait-runtime-20261016
rea-agents-6.5.0
rea-agents-6.4.0
rea-agents-6.3.0
rea-agents-6.2.0
rea-agents-6.1.0
rea-agents-6.0.0
rea-agents-5.0.0
rea-agents-4.1.0
rea-agents-4.0.1
rea-agents-4.0.0
rea-agents-3.2.1
rea-agents-3.2.0
rea-agents-3.1.0
rea-agents-3.0.0
rea-agents-2.7.0
rea-agents-2.6.0
rea-agents-2.5.1
rea-agents-2.5.0
rea-agents-2.4.0
rea-agents-2.3.0
rea-agents-2.2.0
rea-agents-2.1.0
rea-agents-2.0.0
rea-agents-1.7.0
rea-agents-1.6.0
rea-agents-1.5.0
rea-agents-1.4.0
rea-agents-1.3.0
rea-agents-1.2.0
rea-agents-1.1.0
rea-agents-1.0.0
rea-agents-0.5.0
rea-agents-0.4.0
rea-agents-0.3.0
rea-0.2.1
rea-0.2.0
Labels
Clear labels
area: bridge
area: bridge
area: build
area: build
area: build
area: cli
area: domain
area: evidence
area: mcp
area: native
area: providers
area: runtime
area: server
area: setup
area: tests
bug
design
documentation
enhancement
enhancement
enhancement
experiment
help wanted
i18n
invalid
P0: critical
P1: high
P2: medium
P2: medium
P2: medium
P3: low
performance
provider-request
pull-request
Mirrored from GitHub Pull Request
question
roadmap
triage
No labels
area: bridge
area: bridge
area: build
area: build
area: build
area: cli
area: domain
area: evidence
area: mcp
area: native
area: providers
area: runtime
area: server
area: setup
area: tests
bug
design
documentation
enhancement
enhancement
enhancement
experiment
help wanted
i18n
invalid
P0: critical
P1: high
P2: medium
P2: medium
P2: medium
P3: low
performance
provider-request
pull-request
question
roadmap
triage
Milestone
Clear milestone
No items
No milestone
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".
No due date set.
Dependencies
No dependencies set.
Reference
morluto/rea#6693
Loading…
Add table
Add a link
Reference in a new issue
No description provided.
Delete branch "%!s()"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
📋 Pull Request Information
Original PR: https://github.com/morluto/rea/pull/4956
Author: @whitebaphomet1-star
Created: 10/18/2026
Status: ❌ Closed
Base:
main← Head:qualification/rea-engine-repairs-20261017📝 Commits (3)
2eea800fix(javascript): retain uncertainty in esbuild wrapper recoverya1cd2cdfix(reverse): preserve process ownership preflight diagnosticsd9ac7c6fix(browser): bind storage principals and verify viewport stability📊 Changes
19 files changed (+1273 additions, -71 deletions)
View changed files
📝
docs/javascript-artifact-reconstruction.md(+12 -0)📝
scripts/lib/browser-screenshot-e2e.mjs(+27 -4)📝
scripts/lib/browser-socket-e2e.mjs(+7 -1)📝
scripts/verify-real-browser.mjs(+137 -11)📝
src/application/javascript/JavaScriptArtifactGraphBundlers.ts(+136 -33)📝
src/application/javascript/JavaScriptArtifactGraphContext.ts(+16 -0)📝
src/application/javascript/JavaScriptArtifactGraphFindings.ts(+129 -10)➕
src/application/javascript/JavaScriptEsbuildCandidateEvidence.test.ts(+223 -0)📝
src/application/reverse/ReverseEngineeringService.ts(+10 -0)📝
src/browser/CdpScreenshot.ts(+57 -1)📝
src/browser/PlaywrightScenarioStorage.test.ts(+135 -2)📝
src/browser/PlaywrightScenarioStorage.ts(+53 -9)➕
src/domain/javascript/javascriptEsbuildCandidateContract.test.ts(+67 -0)📝
src/domain/javascript/javascriptStaticAnalysisBundler.ts(+1 -0)📝
src/domain/javascript/javascriptStaticAnalysisTypes.ts(+9 -0)📝
src/javascript/analysis/JavaScriptAnalysisWorkerSchemas.ts(+1 -0)📝
tests/boundary/browser/cdpScreenshotDocumentIdentity.test.ts(+129 -0)➕
tests/composition/reverseEngineeringOwnershipPreflight.test.ts(+115 -0)📝
tests/fixtures/fakeCdpBrowserResults.ts(+9 -0)📄 Description
Closed: this draft targeted the wrong repository. The corrected delivery is Theory OS MCP draft PR #270, which carries the engine registration, qualified source patch and evidence. No changes were merged from this draft.
Summary
Preserve uncertainty and runtime identity when REA recovers JavaScript structure, prepares owned reverse-engineering processes, and observes browser state.
This draft contains three commits and 19 authored files. No issue is linked: these failures were found in a local source audit and real CLI/MCP qualification campaign.
Problem and expected behavior
__commonJSor__esmtable establishes observable syntax, but its helper name does not prove esbuild origin. Candidate nodes, containment and module-derived relationships must retain inferred/low-confidence evidence and the helper-origin limitation, including summary output and older records.process-ownershipprovider identity,prepare_owned_processoperation and remediation must survive the service boundary; an already-aborted caller must retain cancellation precedence.Change and scope
The existing application services, evidence model and browser owners retain responsibility. The patch adds candidate-interpretation propagation, preserves the existing ownership error, verifies the storage principal before injection, and compares CSS visual viewport geometry before/after screenshot capture.
The real-browser verifier now selects a committed owned document, closes only its stale owned startup pages, and disconnects fixture setup before production attachment. Its large-PNG fixture uses native window bounds while retaining the exact 2048×1536 assertions. Its script oracle checks exact retained identities and hashes while preserving global
unknownwhen the only gaps are explicit unattributed-origin omissions. The production comparator is unchanged.Contribution-scope decision: not applicable to routine corrections within existing static-analysis, owned-process and browser boundaries. No new provider, execution authority, bypass behavior or public operation is introduced. Local engine installations, host-specific launcher configuration and Theory OS workspace deployment are qualification context, not changes in this PR.
Contract and boundary impact
Expected effects of the affected existing workflows and their regression fixtures:
Evidence and regression coverage
target_changedwithout an image. Removing only the post-capture geometry comparison returns pixels, causing the same public canary assertion to fail.Representative real verifier output, abbreviated without changing claim scope:
The broad verifier includes additional direct production-provider integration checks; those are not substitutes for its public CLI/MCP tests. Declared fixture inputs and isolated ablation runtimes are controls, not fabricated production evidence. Long raw receipts remain local and are not uploaded in this draft.
Remaining proof gaps: upstream CI and the full local
check/docs:checkgates are pending. The merge-tree check against upstream main2c4338db1found no conflicts, but that does not qualify the merged tree. No universal browser/DPR parity, platform-wide or scientific-validity claim is made.For evidence-bearing changes:
Validation performed
At head
d9ac7c623787c7277b21ed78939462be3c3b524f:vitest run src/application/javascript/JavaScriptEsbuildCandidateEvidence.test.ts src/domain/javascript/javascriptEsbuildCandidateContract.test.ts tests/composition/reverseEngineeringOwnershipPreflight.test.ts src/browser/PlaywrightScenarioStorage.test.ts tests/boundary/browser/cdpScreenshotDocumentIdentity.test.ts— 50/50 tests passed across five files.npm run check:fast— typecheck and lint passed, two successful tasks.npm run verify:browser— full real workflow passed, with the public CLI/MCP results above and zero owned descendants at completion.npm run verify:browser:runtime— eight real public cases passed.npm run verify:inspector— eight real Inspector cases passed; unverifiable-file-location cases retain their explicit uncertainty.npm run verify:frida— real local spawn/script marker passed;cleanup_errorwas null.git diff --checkpassed.npm run check,npm run docs:check, cross-platform coverage and upstream CI — not claimed as passing; pending for this draft.Compatibility, safety, and release
Author readiness
Human owner: @whitebaphomet1-star (draft; human review and readiness declarations pending)
Before merge
type(scope): outcome.🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.