[PR #5065] [CLOSED] test(process): reduce macOS wall-clock capture test flakiness #6765

New issue

Closed

opened 2026-11-01 21:42:54 +00:00 by bsakaguchi · 0 comments

bsakaguchi commented

2026-11-01 21:42:54 +00:00

Owner

📋 Pull Request Information

Original PR: https://github.com/morluto/rea/pull/5065
Author: @ashukumar-tech
Created: 10/18/2026
Status: ❌ Closed

Base: main ← Head: fix/5050-macos-capture-deadline-test

📝 Commits (1)

d269997 test(process): extend wall-clock capture guard and surface failures

📊 Changes

1 file changed (+2 additions, -2 deletions)

View changed files

📝 tests/boundary/process/processCaptureLifecycle.test.ts (+2 -2)

📄 Description

Summary

Refs #5050.

The wall-clock rewind process-capture regression test has a 1,500 ms emergency abort guard. The linked issue records two macOS CI failures after about 1.5–1.8 seconds, while healthy hosted macOS runs sometimes approach the original guard. The guard can cancel a healthy capture before the assertion checks the intended monotonic deadline behavior.

Changes

Increase only this test's emergency abort guard from 1,500 ms to 5,000 ms. The existing 10,000 ms Vitest timeout stays unchanged; the 100 ms process timeout and 60-second wall-clock rewind are unchanged.
Throw result.error before the result.ok assertion so any unexpected process failure reports its actual cause instead of only expected false to be true.

No runtime, provider, or production behavior changes.

Verification

Source/diff review completed: compared fork main against this branch using GitHub; exactly one test file changed, with two line replacements (2 additions, 2 deletions).
Issue evidence: #5050 reports two historical macOS CI failures and historical successful runtimes. Those observations are from the issue report, not measurements I reproduced.
Not run: Vitest/process-capture test or macOS CI. The connected environment has no local checkout/dependencies or macOS runner. This draft needs the human owner to review and run focused validation and/or examine CI results.

Suggested focused check: npm run test:local -- tests/boundary/process/processCaptureLifecycle.test.ts (confirm the repository-supported invocation before use).

Author readiness

Human owner has reviewed the complete diff and confirms responsibility for this AI-assisted contribution.
Human owner has verified appropriate tests or documented real verification gaps.
Human owner confirms this PR is ready for maintainer review.

Validation status: No test run or CI success is claimed here; workflow approval and maintainer review remain pending.

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/morluto/rea/pull/5065 **Author:** [@ashukumar-tech](https://github.com/ashukumar-tech) **Created:** 10/18/2026 **Status:** ❌ Closed **Base:** `main` ← **Head:** `fix/5050-macos-capture-deadline-test` --- ### 📝 Commits (1) - [`d269997`](https://github.com/morluto/rea/commit/d269997ca12df3435dc85b9f569f9e17d7d511fe) test(process): extend wall-clock capture guard and surface failures ### 📊 Changes **1 file changed** (+2 additions, -2 deletions) <details> <summary>View changed files</summary> 📝 `tests/boundary/process/processCaptureLifecycle.test.ts` (+2 -2) </details> ### 📄 Description ## Summary Refs #5050. The wall-clock rewind process-capture regression test has a 1,500 ms emergency abort guard. The linked issue records two macOS CI failures after about 1.5–1.8 seconds, while healthy hosted macOS runs sometimes approach the original guard. The guard can cancel a healthy capture before the assertion checks the intended monotonic deadline behavior. ## Changes - Increase only this test's emergency abort guard from 1,500 ms to 5,000 ms. The existing 10,000 ms Vitest timeout stays unchanged; the 100 ms process timeout and 60-second wall-clock rewind are unchanged. - Throw `result.error` before the `result.ok` assertion so any unexpected process failure reports its actual cause instead of only `expected false to be true`. No runtime, provider, or production behavior changes. ## Verification - **Source/diff review completed:** compared fork `main` against this branch using GitHub; exactly one test file changed, with two line replacements (2 additions, 2 deletions). - **Issue evidence:** #5050 reports two historical macOS CI failures and historical successful runtimes. Those observations are from the issue report, **not** measurements I reproduced. - **Not run:** Vitest/process-capture test or macOS CI. The connected environment has no local checkout/dependencies or macOS runner. This draft needs the human owner to review and run focused validation and/or examine CI results. Suggested focused check: `npm run test:local -- tests/boundary/process/processCaptureLifecycle.test.ts` (confirm the repository-supported invocation before use). ## Author readiness - [x] **Human owner has reviewed the complete diff and confirms responsibility for this AI-assisted contribution.** - [x] **Human owner has verified appropriate tests or documented real verification gaps.** - [x] **Human owner confirms this PR is ready for maintainer review.** **Validation status:** No test run or CI success is claimed here; workflow approval and maintainer review remain pending. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>

bsakaguchi

2026-11-01 21:42:54 +00:00

closed this issue
added the
pull-request
label

No milestone

No project

No assignees

1 participant

Notifications

Due date

The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference

morluto/rea#6765

No description provided.

Rows
Columns