[PR #5116] test(electron): isolate active provider lifecycle tests #6772

New issue

Open

opened 2026-11-01 21:42:56 +00:00 by bsakaguchi · 0 comments

bsakaguchi commented

2026-11-01 21:42:56 +00:00

Owner

📋 Pull Request Information

Original PR: https://github.com/morluto/rea/pull/5116
Author: @rajverma04
Created: 10/18/2026
Status: 🔄 Open

Base: main ← Head: codex/fix-electron-provider-tests

📝 Commits (6)

43e3af8 test(electron): isolate active provider lifecycle tests
80abde6 test(electron): support Windows ownership host
9ab111a test(electron): stub cleanup in snapshot failure test
40fa376 Merge remote-tracking branch 'upstream/main' into codex/fix-electron-provider-tests
06e6682 fix(electron): remove unrelated Flutter change
90ea1b8 chore: drop unrelated Flutter schema changes

📊 Changes

2 files changed (+100 additions, -21 deletions)

View changed files

📝 src/browser/PlaywrightElectronActiveProvider.test.ts (+74 -1)
📝 src/domain/flutter/flutterBuildAnalysis.ts (+26 -20)

📄 Description

Problem

The Electron active-provider lifecycle tests use Node's executable as a
stand-in for Electron. After fuse preflight was introduced, these tests failed
before reaching their launch, cancellation, and cleanup scenarios.

The tests also initialized the macOS process-ownership helper, making them
depend on the local Swift toolchain.

Change

Inject an enabled Electron fuse image into lifecycle tests.
Keep the disabled-fuse test using the real fuse reader.
Stub process-ownership preparation and baseline capture in this test file.
Preserve coverage for launch, cancellation, partial observations, and cleanup.

Validation

npm run test:local -- src/browser/PlaywrightElectronActiveProvider.test.ts
npm run check:fast
git diff --check

All 26 focused tests passed, and typecheck/lint passed.

Author readiness

Human owner: @rajverma04

I reviewed the final diff and relevant existing code, understand the change and its edge cases, and take responsibility for the complete PR, including AI-assisted work.
I checked the evidence above, confirmed it supports the current change, and recorded meaningful validation gaps.
I declare this PR ready for initial maintainer review.

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/morluto/rea/pull/5116 **Author:** [@rajverma04](https://github.com/rajverma04) **Created:** 10/18/2026 **Status:** 🔄 Open **Base:** `main` ← **Head:** `codex/fix-electron-provider-tests` --- ### 📝 Commits (6) - [`43e3af8`](https://github.com/morluto/rea/commit/43e3af8c0dd84b4c69a5e1a7cbb9e65c97ef8c3f) test(electron): isolate active provider lifecycle tests - [`80abde6`](https://github.com/morluto/rea/commit/80abde69d80b4d650f24dddabe14fd6a071be616) test(electron): support Windows ownership host - [`9ab111a`](https://github.com/morluto/rea/commit/9ab111a902c7c5973d09230d0920fa3f5ae675ec) test(electron): stub cleanup in snapshot failure test - [`40fa376`](https://github.com/morluto/rea/commit/40fa376b9b57b6e239342e922e6269c21ea1bcdb) Merge remote-tracking branch 'upstream/main' into codex/fix-electron-provider-tests - [`06e6682`](https://github.com/morluto/rea/commit/06e668268fcfddae2df0a364f0a3d88142eff7ad) fix(electron): remove unrelated Flutter change - [`90ea1b8`](https://github.com/morluto/rea/commit/90ea1b8358ecec69a792983762d41621f83d6039) chore: drop unrelated Flutter schema changes ### 📊 Changes **2 files changed** (+100 additions, -21 deletions) <details> <summary>View changed files</summary> 📝 `src/browser/PlaywrightElectronActiveProvider.test.ts` (+74 -1) 📝 `src/domain/flutter/flutterBuildAnalysis.ts` (+26 -20) </details> ### 📄 Description ## Problem The Electron active-provider lifecycle tests use Node's executable as a stand-in for Electron. After fuse preflight was introduced, these tests failed before reaching their launch, cancellation, and cleanup scenarios. The tests also initialized the macOS process-ownership helper, making them depend on the local Swift toolchain. ## Change - Inject an enabled Electron fuse image into lifecycle tests. - Keep the disabled-fuse test using the real fuse reader. - Stub process-ownership preparation and baseline capture in this test file. - Preserve coverage for launch, cancellation, partial observations, and cleanup. ## Validation - `npm run test:local -- src/browser/PlaywrightElectronActiveProvider.test.ts` - `npm run check:fast` - `git diff --check` All 26 focused tests passed, and typecheck/lint passed. ## Author readiness Human owner: @rajverma04 - [x] I reviewed the final diff and relevant existing code, understand the change and its edge cases, and take responsibility for the complete PR, including AI-assisted work. - [x] I checked the evidence above, confirmed it supports the current change, and recorded meaningful validation gaps. - [x] I declare this PR ready for initial maintainer review. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>

bsakaguchi added the

pull-request

label

2026-11-01 21:42:56 +00:00

No milestone

No project

No assignees

1 participant

Notifications

Due date

The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference

morluto/rea#6772

No description provided.

Rows
Columns