[PR #5157] [CLOSED] fix(evm): preserve advertised detail schema metadata #6791

New issue

Closed

opened 2026-11-01 21:43:04 +00:00 by bsakaguchi · 0 comments

bsakaguchi commented

2026-11-01 21:43:04 +00:00

Owner

📋 Pull Request Information

Original PR: https://github.com/morluto/rea/pull/5157
Author: @AdityaKharmaleGoat7
Created: 10/19/2026
Status: ❌ Closed

Base: main ← Head: fix/evm-detail-schema-metadata

📝 Commits (4)

ca2fb6c fix(evm): preserve detail schema metadata
9df70f0 test(evm): cover advertised detail metadata
f24e029 style(evm): format MCP detail schema test
2e18f96 Merge branch 'main' into fix/evm-detail-schema-metadata

📊 Changes

2 files changed (+52 additions, -1 deletions)

View changed files

📝 src/contracts/evm/evmToolContracts.ts (+1 -1)
➕ tests/boundary/mcp/evmDetailSchemaMcp.test.ts (+51 -0)

📄 Description

Fixes #5088.

Summary

Preserve the shared detail field guidance and advertised default: "complete" for inspect_evm_interface.

Problem

The EVM contract currently builds detail with analysisDetailSchema.unwrap().optional(). Unwrapping removes the wrapper that owns the shared description and default metadata, so MCP discovery advertises only the enum values.

Change

use analysisDetailSchema directly in the EVM input contract, matching other retained-analysis contracts
add a focused MCP discovery regression test that asserts the advertised enum, default, and shared description

Runtime behavior is unchanged: omitting detail still selects complete delivery, and explicit summary still selects retained summary delivery.

Scope

This is limited to MCP/tool-schema metadata for the existing EVM inspection input. No provider behavior, target interaction, Evidence format, or output schema changes.

Validation

The branch is based directly on upstream main at dfe8378cf5a727e3d93d47a5986233175c6ef898, is 0 commits behind that base, and changes only the EVM contract plus one focused MCP regression test.

Local repository tests were not executed in this environment; CI is the authoritative validation.

Author readiness

Human owner: @AdityaKharmaleGoat7

I reviewed the final diff and relevant existing code, understand the change and its edge cases, and take responsibility for the complete PR, including AI-assisted work.
I checked the evidence above, confirmed it supports the current change, and recorded meaningful validation gaps.
I declare this PR ready for initial maintainer review.

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/morluto/rea/pull/5157 **Author:** [@AdityaKharmaleGoat7](https://github.com/AdityaKharmaleGoat7) **Created:** 10/19/2026 **Status:** ❌ Closed **Base:** `main` ← **Head:** `fix/evm-detail-schema-metadata` --- ### 📝 Commits (4) - [`ca2fb6c`](https://github.com/morluto/rea/commit/ca2fb6ce37a4fe7658be6ae4717468a15ec3e802) fix(evm): preserve detail schema metadata - [`9df70f0`](https://github.com/morluto/rea/commit/9df70f0ad63bbd445dadd3ea806dcbc45eb7bc24) test(evm): cover advertised detail metadata - [`f24e029`](https://github.com/morluto/rea/commit/f24e029e0f3fed3071052b4f9a24c37af89e9f8b) style(evm): format MCP detail schema test - [`2e18f96`](https://github.com/morluto/rea/commit/2e18f9637917cb492a44fa729743fc1cdb7f660e) Merge branch 'main' into fix/evm-detail-schema-metadata ### 📊 Changes **2 files changed** (+52 additions, -1 deletions) <details> <summary>View changed files</summary> 📝 `src/contracts/evm/evmToolContracts.ts` (+1 -1) ➕ `tests/boundary/mcp/evmDetailSchemaMcp.test.ts` (+51 -0) </details> ### 📄 Description Fixes #5088. ## Summary Preserve the shared `detail` field guidance and advertised `default: "complete"` for `inspect_evm_interface`. ## Problem The EVM contract currently builds `detail` with `analysisDetailSchema.unwrap().optional()`. Unwrapping removes the wrapper that owns the shared description and default metadata, so MCP discovery advertises only the enum values. ## Change - use `analysisDetailSchema` directly in the EVM input contract, matching other retained-analysis contracts - add a focused MCP discovery regression test that asserts the advertised enum, default, and shared description Runtime behavior is unchanged: omitting `detail` still selects complete delivery, and explicit `summary` still selects retained summary delivery. ## Scope This is limited to MCP/tool-schema metadata for the existing EVM inspection input. No provider behavior, target interaction, Evidence format, or output schema changes. ## Validation The branch is based directly on upstream `main` at `dfe8378cf5a727e3d93d47a5986233175c6ef898`, is 0 commits behind that base, and changes only the EVM contract plus one focused MCP regression test. Local repository tests were not executed in this environment; CI is the authoritative validation. ## Author readiness Human owner: @AdityaKharmaleGoat7 - [x] I reviewed the final diff and relevant existing code, understand the change and its edge cases, and take responsibility for the complete PR, including AI-assisted work. - [x] I checked the evidence above, confirmed it supports the current change, and recorded meaningful validation gaps. - [x] I declare this PR ready for initial maintainer review. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>

bsakaguchi

2026-11-01 21:43:04 +00:00