morluto/rea
1
0
Fork 0
mirror of https://github.com/morluto/rea.git synced 2026-11-05 06:45:22 +00:00
Code Issues 1.3k Projects Packages Wiki Activity

[PR #5214] [MERGED] fix(hopper): preserve an explicit display number zero in the X11 helper #6819

New issue
Closed
opened 2026-11-01 21:43:15 +00:00 by bsakaguchi · 0 comments
bsakaguchi commented 2026-11-01 21:43:15 +00:00
Owner
Copy link

📋 Pull Request Information

Original PR: https://github.com/morluto/rea/pull/5214
Author: @musaraza004
Created: 10/19/2026
Status: ✅ Merged
Merged: 10/22/2026
Merged by: @morluto

Base: main ← Head: fix/hopper-explicit-display-zero

📝 Commits (1)

  • 0a5bc95 fix(hopper): preserve an explicit display number zero in the X11 helper

📊 Changes

3 files changed (+114 additions, -1 deletions)

View changed files

📝 scripts/hopper-demo-x11.py (+5 -1)
📝 tests/boundary/providers/hopper/linuxPrivateDisplay.test.ts (+40 -0)
➕ tests/fixtures/hopperDisplaySelection.py (+69 -0)

📄 Description

Summary

Fixes #5189.

The packaged scripts/hopper-demo-x11.py helper accepted --display-number 0 but swapped it for a random display, because start_xvfb read the option's truthiness. Now an explicit zero goes through the same selection, collision check and authorization as any other explicit display.

Problem and expected behavior

  • Trigger: --display-number 0.
  • Before: args.display_number or (100 + secrets.randbelow(900)) treated 0 as omitted. The helper checked and authorized a random display such as :123. If that random display was occupied, it raised address_collision without ever checking X0. Because the later guards use args.display_number is not None, that random collision was then treated as an explicit-display failure.
  • Expected: the helper picks a random display only when the option is omitted. An explicit 0 checks /tmp/.X11-unix/X0 and /tmp/.X0-lock, then authorizes :0.

Change and scope

The random display is now chosen only when args.display_number is None. This matches the is not None checks the function already uses for collisions. The normal Node probe and launch wrappers don't pass this option, so their behavior is unchanged. Contribution scope decision: not applicable (an ordinary fix within existing boundaries).

Contract and boundary impact

  • Semantic owner and earliest changed stage: start_xvfb display selection in scripts/hopper-demo-x11.py.
  • Contribution scope fit and linked maintainer decision: ordinary fix, not applicable.
  • CLI and MCP/tool-catalog contract: none.
  • Provider, bridge, target-format, or platform compatibility: Linux Hopper demo helper only. Explicit --display-number 0 now targets :0.
  • Evidence, artifact, provenance, or reconstruction contract: none.
  • Target selection, authority, upstream behavior, and cleanup details: the explicit display is honored. Collision handling for explicit displays is unchanged (fail without retry).
  • Generated metadata, package, or installation impact: none.

Expected effects:

  • Read existing files or captured data.
  • Launch or attach to a process. (This helper launches Xvfb. The change only affects which display it picks.)
  • Inject instrumentation or run scripts/code.
  • Change process memory, registers, files, or configuration.
  • Contact network services.
  • Recover protected code or work around protections.
  • Documentation or usability only; no target interaction.
  • Not sure yet; investigation or maintainer guidance needed.

Evidence and regression coverage

  • Tests added or updated: new fixture tests/fixtures/hopperDisplaySelection.py, plus a Linux-only case in tests/boundary/providers/hopper/linuxPrivateDisplay.test.ts that follows the existing Python-fixture pattern. The fixture loads the real helper and fakes Path.exists, secrets.randbelow (fixed at 23, giving :123) and authorize_display. The fake authorize_display raises xauth_failed so the run stops before Xvfb. The fixture covers five cases: explicit zero, explicit zero with only X123 occupied, explicit zero with X0 occupied, explicit one, and omitted.

  • Base reproduction (executed against the unfixed helper): the fixture reproduced the issue exactly.

    • Explicit zero: authorized [":123"], random_calls 1.
    • Explicit zero with X123 occupied: address_collision, only X123 checked.
    • Explicit zero with X0 occupied: still authorized :123.

    The new test fails on the base revision.

  • After the fix:

    • Explicit zero authorizes :0 and checks X0 and .X0-lock, with 0 random calls.
    • Explicit zero with X0 occupied returns address_collision.
    • Explicit one and omitted are unchanged.

  • Remaining proof gaps: real Hopper, Xvfb and xauth were not run. I ran the fixture directly but didn't run vitest locally.

Validation performed

  • python tests/fixtures/hopperDisplaySelection.py scripts/hopper-demo-x11.py (Windows, Python 3.14), before the fix: reproduced the issue's output. After the fix: output matches the test's expected JSON.
  • python3 tests/fixtures/hopperDisplaySelection.py scripts/hopper-demo-x11.py (WSL Linux) after the fix: exit 0, output matches the test's expected JSON.
  • Not run: vitest (dependencies not installed locally). Relying on CI for the boundary test.

Compatibility, safety, and release

  • Breaking changes or migration steps: none. An explicit --display-number 0 now means :0, which is what it was documented to mean.
  • Real Hopper/Ghidra, browser, or OS coverage: none. The fixture uses simulated paths and commands.
  • Package or release metadata impact: none.
  • Security, privacy, process, or containment review: none. The collision check still runs before authorization.

Author readiness

Human owner: @musaraza004

  • I reviewed the final diff and relevant existing code, understand the change and its edge cases, and take responsibility for the complete PR, including AI-assisted work.
  • I checked the evidence above, confirmed it supports the current change, and recorded meaningful validation gaps.
  • I declare this PR ready for initial maintainer review.

Before merge

  • This PR addresses a concrete problem or an agreed enhancement.
  • Material scope and authority questions are resolved, and any required maintainer scope decision covers the final diff.
  • The PR has one focused outcome and the title follows type(scope): outcome.
  • Related issue is linked, or the reason for not linking one is stated above.
  • Tests cover changed observable behavior and meaningful failure paths.
  • Owning docs, contracts, and generated metadata are updated where needed.
  • User-visible CLI/MCP changes include representative output.
  • I checked the final diff for secrets, unrelated cleanup, and unsupported claims.

🤖 Generated with Claude Code

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/morluto/rea/pull/5214 **Author:** [@musaraza004](https://github.com/musaraza004) **Created:** 10/19/2026 **Status:** ✅ Merged **Merged:** 10/22/2026 **Merged by:** [@morluto](https://github.com/morluto) **Base:** `main` ← **Head:** `fix/hopper-explicit-display-zero` --- ### 📝 Commits (1) - [`0a5bc95`](https://github.com/morluto/rea/commit/0a5bc95ffe5d36ed8f1c2ff094479317c970ec5e) fix(hopper): preserve an explicit display number zero in the X11 helper ### 📊 Changes **3 files changed** (+114 additions, -1 deletions) <details> <summary>View changed files</summary> 📝 `scripts/hopper-demo-x11.py` (+5 -1) 📝 `tests/boundary/providers/hopper/linuxPrivateDisplay.test.ts` (+40 -0) ➕ `tests/fixtures/hopperDisplaySelection.py` (+69 -0) </details> ### 📄 Description ## Summary Fixes #5189. The packaged `scripts/hopper-demo-x11.py` helper accepted `--display-number 0` but swapped it for a random display, because `start_xvfb` read the option's truthiness. Now an explicit zero goes through the same selection, collision check and authorization as any other explicit display. ## Problem and expected behavior - Trigger: `--display-number 0`. - Before: `args.display_number or (100 + secrets.randbelow(900))` treated `0` as omitted. The helper checked and authorized a random display such as `:123`. If that random display was occupied, it raised `address_collision` without ever checking `X0`. Because the later guards use `args.display_number is not None`, that random collision was then treated as an explicit-display failure. - Expected: the helper picks a random display only when the option is omitted. An explicit `0` checks `/tmp/.X11-unix/X0` and `/tmp/.X0-lock`, then authorizes `:0`. ## Change and scope The random display is now chosen only when `args.display_number is None`. This matches the `is not None` checks the function already uses for collisions. The normal Node probe and launch wrappers don't pass this option, so their behavior is unchanged. Contribution scope decision: not applicable (an ordinary fix within existing boundaries). ## Contract and boundary impact - Semantic owner and earliest changed stage: `start_xvfb` display selection in `scripts/hopper-demo-x11.py`. - Contribution scope fit and linked maintainer decision: ordinary fix, not applicable. - CLI and MCP/tool-catalog contract: none. - Provider, bridge, target-format, or platform compatibility: Linux Hopper demo helper only. Explicit `--display-number 0` now targets `:0`. - Evidence, artifact, provenance, or reconstruction contract: none. - Target selection, authority, upstream behavior, and cleanup details: the explicit display is honored. Collision handling for explicit displays is unchanged (fail without retry). - Generated metadata, package, or installation impact: none. Expected effects: - [ ] Read existing files or captured data. - [x] Launch or attach to a process. (This helper launches Xvfb. The change only affects which display it picks.) - [ ] Inject instrumentation or run scripts/code. - [ ] Change process memory, registers, files, or configuration. - [ ] Contact network services. - [ ] Recover protected code or work around protections. - [ ] Documentation or usability only; no target interaction. - [ ] Not sure yet; investigation or maintainer guidance needed. ## Evidence and regression coverage - Tests added or updated: new fixture `tests/fixtures/hopperDisplaySelection.py`, plus a Linux-only case in `tests/boundary/providers/hopper/linuxPrivateDisplay.test.ts` that follows the existing Python-fixture pattern. The fixture loads the real helper and fakes `Path.exists`, `secrets.randbelow` (fixed at 23, giving `:123`) and `authorize_display`. The fake `authorize_display` raises `xauth_failed` so the run stops before Xvfb. The fixture covers five cases: explicit zero, explicit zero with only `X123` occupied, explicit zero with `X0` occupied, explicit one, and omitted. - Base reproduction (executed against the unfixed helper): the fixture reproduced the issue exactly. - Explicit zero: `authorized [":123"]`, `random_calls 1`. - Explicit zero with `X123` occupied: `address_collision`, only `X123` checked. - Explicit zero with `X0` occupied: still authorized `:123`. The new test fails on the base revision. - After the fix: - Explicit zero authorizes `:0` and checks `X0` and `.X0-lock`, with 0 random calls. - Explicit zero with `X0` occupied returns `address_collision`. - Explicit one and omitted are unchanged. - Remaining proof gaps: real Hopper, Xvfb and xauth were not run. I ran the fixture directly but didn't run vitest locally. ## Validation performed - `python tests/fixtures/hopperDisplaySelection.py scripts/hopper-demo-x11.py` (Windows, Python 3.14), before the fix: reproduced the issue's output. After the fix: output matches the test's expected JSON. - `python3 tests/fixtures/hopperDisplaySelection.py scripts/hopper-demo-x11.py` (WSL Linux) after the fix: exit 0, output matches the test's expected JSON. - Not run: `vitest` (dependencies not installed locally). Relying on CI for the boundary test. ## Compatibility, safety, and release - Breaking changes or migration steps: none. An explicit `--display-number 0` now means `:0`, which is what it was documented to mean. - Real Hopper/Ghidra, browser, or OS coverage: none. The fixture uses simulated paths and commands. - Package or release metadata impact: none. - Security, privacy, process, or containment review: none. The collision check still runs before authorization. ## Author readiness Human owner: @musaraza004 - [x] I reviewed the final diff and relevant existing code, understand the change and its edge cases, and take responsibility for the complete PR, including AI-assisted work. - [x] I checked the evidence above, confirmed it supports the current change, and recorded meaningful validation gaps. - [x] I declare this PR ready for initial maintainer review. ## Before merge - [x] This PR addresses a concrete problem or an agreed enhancement. - [x] Material scope and authority questions are resolved, and any required maintainer scope decision covers the final diff. - [x] The PR has one focused outcome and the title follows `type(scope): outcome`. - [x] Related issue is linked, or the reason for not linking one is stated above. - [x] Tests cover changed observable behavior and meaningful failure paths. - [x] Owning docs, contracts, and generated metadata are updated where needed. - [x] User-visible CLI/MCP changes include representative output. - [x] I checked the final diff for secrets, unrelated cleanup, and unsupported claims. 🤖 Generated with [Claude Code](https://claude.com/claude-code) --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
bsakaguchi 2026-11-01 21:43:15 +00:00
Sign in to join this conversation.
No Branch/Tag specified
Branches Tags
main
codex/procedure-reference-stacked
release-please--branches--main--components--rea-agents
release-please--branches--main--components--rea-agents--release-notes
codex/kuna-independent-retry
codex/byte-search-overlay-coverage
codex/open-failure-target-receipt
codex/kuna-xref-evidence
codex/ghidra-ambiguous-procedure-recovery
codex/function-source-bundle
codex/trace-function-integration-prototype
codex/snapshot-source-closure
codex/recorded-evidence-array-pages
codex/evidence-recovery-redesign
codex/trace-feature-address-scope
codex/call-discovery-scope
codex/ghidra-literal-candidate-evidence
codex/decompile-directory-independent-retry
codex/retry-provenance-base
codex/value-flow-capability-experiment
codex/ghidra-containing-instruction
cursor/readme-discord-button-ef9f
dependabot/github_actions/actions/setup-node-7.1.0
dependabot/github_actions/actions/upload-artifact-7.0.2
dependabot/npm_and_yarn/npm-minor-and-patch-d8d97ce6df
codex/kuna-1989
fix/8559-native-ui-fixture-ownership
fix/8555-go-verifier-mcp-ownership
codex/provider-capability-recovery
fix/8642-rizin-target-stdin
codex/ghidra-memory-effect-scope
codex/ghidra-annotation-entry-selector
codex/ghidra-readonly-recovery
codex/ghidra-regex-verifier-recovery
codex/evidence-discovery-view-guidance
fix/8545-bulk-append-overflow
fix/8428-navigation-refusal-alternatives
codex/address-context-recovery
codex/matching-member-limitations
codex/unknown-scope-contract
codex/evidence-view-guidance
feat/8373-native-trace-views
codex/ghidra-snapshot-verifier-binding
codex/elf-export-visibility
codex/evidence-view-recovery
codex/native-reference-cli-help
codex/provider-candidate-observation-scope
codex/kuna-session-verification
codex/ghidra-switch-lifetime-guidance
codex/pseudocode-paging-discovery
codex/clarify-evidence-view-support
codex/kuna-xrefs-selector-recovery
codex/context-capacity-recovery
codex/evidence-closure-large-links
codex/same-function-evidence-identity
codex/ghidra-verifier-inspected-jdk
codex/audit-guided-workflows
codex/crash-prompt-retained-dossiers
codex/analysis-view-error-recovery
codex/kuna-verifier-target-selection
codex/ghidra-selected-project-call-coverage
codex/docs-native-analysis-scope
codex/ghidra-java-socket-boundary
codex/ghidra-retained-snapshot-verifier
codex/ghidra-search-inventory-facts
fix/8284-zero-argument-parameter-bindings
fix/8198-ui-action-handler-offset
fix/8257-elf-entry-label-identity
fix/8304-deferred-output-schema-projection
fix/8277-call-path-computed-target-uncertainty
fix/pr-8089-conflicts
fix/ci-static-duplicate-export
dependabot/npm_and_yarn/lint-staged-17.6.0
dependabot/github_actions/actions/download-artifact-8.0.2
dependabot/npm_and_yarn/write-file-atomic-8.0.0
dependabot/npm_and_yarn/canonicalize-5.1.0
dependabot/github_actions/actions/cache/restore-6.1.0
dependabot/npm_and_yarn/toon-format/toon-4.4.0
dependabot/github_actions/actions/deploy-pages-5.0.1
codex/review-fixes-pr-2403
codex/review-fixes-pr-2400
codex/process-terminal-width
codex/test-brittleness-cleanup
verify/7167-browser-connect-macos
fix/7167-browser-connect
feat/native-matching-allowance-setting
feat/browser-scenario-dry-run
test/managed-caller-parameters-20261024
codex/parser-fortythird-boundaries
fix/6926-pinvoke-platform-decorations-20261023
fix/6889-har-body-encoding-20261023
fix/6888-sqlite-schema-budget-20261023
fix/dependency-security-gates-6708
cursor/evidence-overwrite-rebase-b4ac
feat/4057-verify-native-exports
fix/windows-acl-observer-overhead-20261022
cursor/erlang-beam-restack-4476
cursor/pe-certificate-review-bf32
fix/6116-javascript-application-fs-errors
fix/6061-unmapped-runtime-script-unknown
feat/browser-scenario-summary
fix/pe-certificates
codex/verify-3407
cursor/rebase-5699
cursor/rebase-5352
cursor/rebase-5600
cursor/fix-cli-schema-omission-10a8
codex/audit-hopper-shutdown-reasons-20261021
fix/demangle-swift-omitted-record
fix/nib-boolean-value-types
cursor/cancellation-partial-observation-a5ac
fix/ib-object-limit-reasons
fix/electron-fuse-limit-advice
fix/kuna-doctor-dangling-cache
fix/fixed-budget-refusal-advice
fix/js-ipc-listener-dedup
fix/js-return-member-provenance
fix/dmg-integrity-retry-advice
fix/ida-doctor-readiness
fix/kuna-version-probe-output-drain
fix/legacy-swift-runtime-name-matching
fix/dylib-lazy-load-commands
fix/browser-scenario-startup-cancel
fix/swift-nested-punycode-classification
fix/compare-unselected-scopes
fix/objc-method-budget-coverage
fix/dmg-mounted-root-observations
audit/ci-tests-20261019-round2
release/6.7.0
fix/wabt-cleanup-retry-resolution
fix/electron-fuse-elf-pe-architecture
fix/native-plist-descriptor-ownership
fix/kuna-caller-cleanup-ownership
experiment/atomic-codemode-20261016
review/first-contributor-3776
fix/call-resolution-full-read-cycles
fix/member-mutation-selection-repeat
experiment/atomic-re-tools-20261015
perf/member-mutation-lazy-origins
perf/static-network-mutation-index
fix/hopper-startup-lifecycle
audit/3050-windows-proof-20261015
feat/windows-window-capture-2183
audit/3049-windows-proof-20261015
audit/3735-macos-fixtures-20261015
fix/batch-decompile-null-pseudocode
fix/kuna-inventory-honors-jobs
experiment/browser-codemode-tool-design-20261015
fix/hopper-clean-runtime-argv
codex/review-2049-27f1b367
review-fixes/pr-2787-routing
fix/3360-scoped-this-emitters
fix/3367-replaced-global-effects
fix/3838-compact-any-value-items
test/hopper-download-probe-20261015
codex/windows-runtime-creation-red-green-20261015
codex/windows-readonly-root-red-green-20261015
codex/windows-root-share-red-green-20261015
codex/exp-1685-win-mcp-startup
codex/bug-sweep-20261015
investigate/2190-windows-package-phases
investigate/3543-macos-cli-deadline
perf/3281-reverse-tools-feedback-quality
fix/3406-hopper-doctor-fixture
fix/3341-wrapper-require-test-context
fix/3301-owned-uninstall-fixtures
fix/3164-compiler-input-ownership
fix/pcap-cleanup-stdout-newline-20261014
perf/interface-builder-summary
codex/review-fixes-pr-1977
fix/ghidra-effective-jvm-platform
fix/docs-turkish-rust-link-20261013
fix/main-maintenance-ci-20261010
fix/recover-binary-session-process-effects
codex/review-fixes-pr-2457
codex/ci-required-cancellation-gate
fix/main-format-baseline-20261013
fix/setup-preserve-entry-fields
cursor/restore-main-checks-1ffc
fix/ghidra-bridge-hashmap-import
codex/shared-ci-jadx-json-default-20261013
codex/shared-ci-ghidra-test-groups-20261013
codex/shared-ci-java-fixture-format-20261013
codex/fix-intrinsic-invocation-boundaries
test/release-preflight-reusable-jobs
test/js-parameter-provenance-expectation
fix/linux-hopper-verification-current
test/2419-ghidra-elf-probe-size
followup/pr-1544-native-ida
codex/fold-pr-2230-contribution
docs/readme-responsible-use
fix/issue-2064
fix/issue-2050
fix/issue-2053
fix/issue-1968
fix/issue-1945
experiment/codemode-bridge-20261011
fix/tool-effects-negative-wording-1904-20261012
fix/1842-electron-interop-provenance
feat/recover-javascript-multi-input
refactor/website-i18n-prep
fix/nativeaot-pe-virtual-extent
fix/browser-verifier-ci-hang
fix/pe-resources-input-selection
docs/beginner-friendly-guides
docs/beginner-setup-guide
fix/javascript-analysis-worker-1563
fix/1649-ghidra-duplicate-names
fix/javascript-export-keys-integration-1369
test/maintenance-boundary-contracts-20261011
review/javascript-export-keys-1369
review/process-live-progress-1483
test/javascript-1495-growth-ratio
fix/ci-escape-timing
docs/normalized-terminal-geometry-1450
release/6.3.0
archive/release-6.3.0-pr1381
release/6.2.0
fix/electron-preload-dynamic-override
fix/javascript-self-referential-bundler-edges
release/6.1.0
cursor/grok-client-cherry-pick-0b56
feat/signature-posture
feat/dyld-shared-cache
feat/artifact-integrity-policy
feat/pkg-inventory
release/6.0.0
chore/sync-release-5.0.0
release/5.0.0
cursor/cloud-agent-node-787e
fix/javascript-xhr-open-endpoints
review/pr-711-realpath-fallback-wording
cleanup/replay-confinement
codex/test-suite-performance
codex/issue-foundations
codex/address-open-issues-2026-07-20
agent/javascript-vite-rollup-esbuild-adapters
agent/process-cleanup
agent/triage-integration
agent/unknown-commands-registry
feat/mcp-identity-metadata
morlvps/issue_cleanup
codex/installer-redesign
morl/roadmap-investigation-core
morl/roadmap-investigation-docs
release-please--branches--main--components--rea
rea-agents-6.8.0
rea-agents-6.7.0
rea-agents-6.6.0
experiment/atomic-codemode-wait-runtime-20261016
rea-agents-6.5.0
rea-agents-6.4.0
rea-agents-6.3.0
rea-agents-6.2.0
rea-agents-6.1.0
rea-agents-6.0.0
rea-agents-5.0.0
rea-agents-4.1.0
rea-agents-4.0.1
rea-agents-4.0.0
rea-agents-3.2.1
rea-agents-3.2.0
rea-agents-3.1.0
rea-agents-3.0.0
rea-agents-2.7.0
rea-agents-2.6.0
rea-agents-2.5.1
rea-agents-2.5.0
rea-agents-2.4.0
rea-agents-2.3.0
rea-agents-2.2.0
rea-agents-2.1.0
rea-agents-2.0.0
rea-agents-1.7.0
rea-agents-1.6.0
rea-agents-1.5.0
rea-agents-1.4.0
rea-agents-1.3.0
rea-agents-1.2.0
rea-agents-1.1.0
rea-agents-1.0.0
rea-agents-0.5.0
rea-agents-0.4.0
rea-agents-0.3.0
rea-0.2.1
rea-0.2.0
Labels
Clear labels   
area: bridge

   
area: bridge

   
area: build

   
area: build

   
area: build

   
area: cli

   
area: domain

   
area: evidence

   
area: mcp

   
area: native

   
area: providers

   
area: runtime

   
area: server

   
area: setup

   
area: tests

   
bug

   
design

   
documentation

   
enhancement

   
enhancement

   
enhancement

   
experiment

   
help wanted

   
i18n

   
invalid

   
P0: critical

   
P1: high

   
P2: medium

   
P2: medium

   
P2: medium

   
P3: low

   
performance

   
provider-request

   
pull-request
Mirrored from GitHub Pull Request

  
question

   
roadmap

   
triage
No labels
area: bridge
area: bridge
area: build
area: build
area: build
area: cli
area: domain
area: evidence
area: mcp
area: native
area: providers
area: runtime
area: server
area: setup
area: tests
bug
design
documentation
enhancement
enhancement
enhancement
experiment
help wanted
i18n
invalid
P0: critical
P1: high
P2: medium
P2: medium
P2: medium
P3: low
performance
provider-request
pull-request
question
roadmap
triage
Milestone
Clear milestone
No items
No milestone
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference
morluto/rea#6819
No description provided.