morluto/rea

Fork 0

mirror of https://github.com/morluto/rea.git synced 2026-11-05 06:45:22 +00:00

[PR #5226] [CLOSED] docs: describe AOT image buffer as declared size plus one byte #6823

New issue

Closed

opened 2026-11-01 21:43:17 +00:00 by bsakaguchi · 0 comments

bsakaguchi commented

2026-11-01 21:43:17 +00:00

Owner

📋 Pull Request Information

Original PR: https://github.com/morluto/rea/pull/5226
Author: @vanshsharma3777
Created: 10/19/2026
Status: ❌ Closed

Base: main ← Head: docs/aot-buffer-size

📝 Commits (4)

8677912 docs: describe AOT image buffer as declared size plus one byte
89d3884 chore: retrigger PR readiness
3124293 changed commit message
b637a34 changed commit message

📊 Changes

1 file changed (+3 additions, -2 deletions)

View changed files

📝 docs/flutter-analysis.md (+3 -2)

📄 Description

Summary

Fixes #5221

The Flutter analysis guide (Limits / Bounded reads) said the AOT image buffer is allocated at exactly the declared size before reading. FlutterBuildProvider.inspectDartAot actually allocates Buffer.alloc(declared + 1).

This PR updates the guide to say the buffer is allocated at the declared size plus one byte, and that only the bytes actually read are analysed (the code slices the buffer to the bytes read before analysis).

Changes

docs/flutter-analysis.md: reworded one sentence in Limits / Bounded reads (+3 / -2 lines).

No source files were changed.

Scope notes

This is a docs-only change. It does not change any behavior.
The issue does not establish why the extra byte exists, so the guide only states the fact and gives no reason. I did not change the code or the code comment.

Testing

Docs-only change, so no tests were run.
Checked git diff and confirmed only docs/flutter-analysis.md is modified.
Searched the docs for other occurrences of "exactly the declared size" and found none.

Author readiness

Human owner: @vanshsharma3777

Checklist

Linked the issue (Fixes #5221)
Change is limited to the documentation
No credentials, tokens, private paths or sensitive target data included
Tests run (N/A, docs-only change)

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/morluto/rea/pull/5226 **Author:** [@vanshsharma3777](https://github.com/vanshsharma3777) **Created:** 10/19/2026 **Status:** ❌ Closed **Base:** `main` ← **Head:** `docs/aot-buffer-size` --- ### 📝 Commits (4) - [`8677912`](https://github.com/morluto/rea/commit/8677912bdb8eab0be7ec69adbe31b085ddeacd2a) docs: describe AOT image buffer as declared size plus one byte - [`89d3884`](https://github.com/morluto/rea/commit/89d3884b6f03cbb54ca9f9f1d5d7804f9853620c) chore: retrigger PR readiness - [`3124293`](https://github.com/morluto/rea/commit/31242934e2f12cfc812c7fdf33bb90fbdbccc2f5) changed commit message - [`b637a34`](https://github.com/morluto/rea/commit/b637a344806ab700cc608617c75a44e6d3908c6c) changed commit message ### 📊 Changes **1 file changed** (+3 additions, -2 deletions) <details> <summary>View changed files</summary> 📝 `docs/flutter-analysis.md` (+3 -2) </details> ### 📄 Description ## Summary Fixes #5221 The Flutter analysis guide (Limits / Bounded reads) said the AOT image buffer is allocated at exactly the declared size before reading. `FlutterBuildProvider.inspectDartAot` actually allocates `Buffer.alloc(declared + 1)`. This PR updates the guide to say the buffer is allocated at the declared size plus one byte, and that only the bytes actually read are analysed (the code slices the buffer to the bytes read before analysis). ## Changes - `docs/flutter-analysis.md`: reworded one sentence in Limits / Bounded reads (+3 / -2 lines). No source files were changed. ## Scope notes - This is a docs-only change. It does not change any behavior. - The issue does not establish why the extra byte exists, so the guide only states the fact and gives no reason. I did not change the code or the code comment. ## Testing - Docs-only change, so no tests were run. - Checked `git diff` and confirmed only `docs/flutter-analysis.md` is modified. - Searched the docs for other occurrences of "exactly the declared size" and found none. ## Author readiness Human owner: @vanshsharma3777 ## Checklist - [x] Linked the issue (`Fixes #5221`) - [x] Change is limited to the documentation - [x] No credentials, tokens, private paths or sensitive target data included - [ ] Tests run (N/A, docs-only change) --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>

bsakaguchi

2026-11-01 21:43:17 +00:00

closed this issue
added the
pull-request
label

No milestone

No project

No assignees

1 participant

Notifications

Due date

The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference

morluto/rea#6823

No description provided.

Rows
Columns