mirror of
https://github.com/morluto/rea.git
synced 2026-11-05 06:45:22 +00:00
[PR #5235] [MERGED] fix(windows): align path handling across Hopper, Electron, and ADB #6829
Closed
opened 2026-11-01 21:43:20 +00:00 by bsakaguchi
·
0 comments
No Branch/Tag specified
main
codex/procedure-reference-stacked
release-please--branches--main--components--rea-agents
release-please--branches--main--components--rea-agents--release-notes
codex/kuna-independent-retry
codex/byte-search-overlay-coverage
codex/open-failure-target-receipt
codex/kuna-xref-evidence
codex/ghidra-ambiguous-procedure-recovery
codex/function-source-bundle
codex/trace-function-integration-prototype
codex/snapshot-source-closure
codex/recorded-evidence-array-pages
codex/evidence-recovery-redesign
codex/trace-feature-address-scope
codex/call-discovery-scope
codex/ghidra-literal-candidate-evidence
codex/decompile-directory-independent-retry
codex/retry-provenance-base
codex/value-flow-capability-experiment
codex/ghidra-containing-instruction
cursor/readme-discord-button-ef9f
dependabot/github_actions/actions/setup-node-7.1.0
dependabot/github_actions/actions/upload-artifact-7.0.2
dependabot/npm_and_yarn/npm-minor-and-patch-d8d97ce6df
codex/kuna-1989
fix/8559-native-ui-fixture-ownership
fix/8555-go-verifier-mcp-ownership
codex/provider-capability-recovery
fix/8642-rizin-target-stdin
codex/ghidra-memory-effect-scope
codex/ghidra-annotation-entry-selector
codex/ghidra-readonly-recovery
codex/ghidra-regex-verifier-recovery
codex/evidence-discovery-view-guidance
fix/8545-bulk-append-overflow
fix/8428-navigation-refusal-alternatives
codex/address-context-recovery
codex/matching-member-limitations
codex/unknown-scope-contract
codex/evidence-view-guidance
feat/8373-native-trace-views
codex/ghidra-snapshot-verifier-binding
codex/elf-export-visibility
codex/evidence-view-recovery
codex/native-reference-cli-help
codex/provider-candidate-observation-scope
codex/kuna-session-verification
codex/ghidra-switch-lifetime-guidance
codex/pseudocode-paging-discovery
codex/clarify-evidence-view-support
codex/kuna-xrefs-selector-recovery
codex/context-capacity-recovery
codex/evidence-closure-large-links
codex/same-function-evidence-identity
codex/ghidra-verifier-inspected-jdk
codex/audit-guided-workflows
codex/crash-prompt-retained-dossiers
codex/analysis-view-error-recovery
codex/kuna-verifier-target-selection
codex/ghidra-selected-project-call-coverage
codex/docs-native-analysis-scope
codex/ghidra-java-socket-boundary
codex/ghidra-retained-snapshot-verifier
codex/ghidra-search-inventory-facts
fix/8284-zero-argument-parameter-bindings
fix/8198-ui-action-handler-offset
fix/8257-elf-entry-label-identity
fix/8304-deferred-output-schema-projection
fix/8277-call-path-computed-target-uncertainty
fix/pr-8089-conflicts
fix/ci-static-duplicate-export
dependabot/npm_and_yarn/lint-staged-17.6.0
dependabot/github_actions/actions/download-artifact-8.0.2
dependabot/npm_and_yarn/write-file-atomic-8.0.0
dependabot/npm_and_yarn/canonicalize-5.1.0
dependabot/github_actions/actions/cache/restore-6.1.0
dependabot/npm_and_yarn/toon-format/toon-4.4.0
dependabot/github_actions/actions/deploy-pages-5.0.1
codex/review-fixes-pr-2403
codex/review-fixes-pr-2400
codex/process-terminal-width
codex/test-brittleness-cleanup
verify/7167-browser-connect-macos
fix/7167-browser-connect
feat/native-matching-allowance-setting
feat/browser-scenario-dry-run
test/managed-caller-parameters-20261024
codex/parser-fortythird-boundaries
fix/6926-pinvoke-platform-decorations-20261023
fix/6889-har-body-encoding-20261023
fix/6888-sqlite-schema-budget-20261023
fix/dependency-security-gates-6708
cursor/evidence-overwrite-rebase-b4ac
feat/4057-verify-native-exports
fix/windows-acl-observer-overhead-20261022
cursor/erlang-beam-restack-4476
cursor/pe-certificate-review-bf32
fix/6116-javascript-application-fs-errors
fix/6061-unmapped-runtime-script-unknown
feat/browser-scenario-summary
fix/pe-certificates
codex/verify-3407
cursor/rebase-5699
cursor/rebase-5352
cursor/rebase-5600
cursor/fix-cli-schema-omission-10a8
codex/audit-hopper-shutdown-reasons-20261021
fix/demangle-swift-omitted-record
fix/nib-boolean-value-types
cursor/cancellation-partial-observation-a5ac
fix/ib-object-limit-reasons
fix/electron-fuse-limit-advice
fix/kuna-doctor-dangling-cache
fix/fixed-budget-refusal-advice
fix/js-ipc-listener-dedup
fix/js-return-member-provenance
fix/dmg-integrity-retry-advice
fix/ida-doctor-readiness
fix/kuna-version-probe-output-drain
fix/legacy-swift-runtime-name-matching
fix/dylib-lazy-load-commands
fix/browser-scenario-startup-cancel
fix/swift-nested-punycode-classification
fix/compare-unselected-scopes
fix/objc-method-budget-coverage
fix/dmg-mounted-root-observations
audit/ci-tests-20261019-round2
release/6.7.0
fix/wabt-cleanup-retry-resolution
fix/electron-fuse-elf-pe-architecture
fix/native-plist-descriptor-ownership
fix/kuna-caller-cleanup-ownership
experiment/atomic-codemode-20261016
review/first-contributor-3776
fix/call-resolution-full-read-cycles
fix/member-mutation-selection-repeat
experiment/atomic-re-tools-20261015
perf/member-mutation-lazy-origins
perf/static-network-mutation-index
fix/hopper-startup-lifecycle
audit/3050-windows-proof-20261015
feat/windows-window-capture-2183
audit/3049-windows-proof-20261015
audit/3735-macos-fixtures-20261015
fix/batch-decompile-null-pseudocode
fix/kuna-inventory-honors-jobs
experiment/browser-codemode-tool-design-20261015
fix/hopper-clean-runtime-argv
codex/review-2049-27f1b367
review-fixes/pr-2787-routing
fix/3360-scoped-this-emitters
fix/3367-replaced-global-effects
fix/3838-compact-any-value-items
test/hopper-download-probe-20261015
codex/windows-runtime-creation-red-green-20261015
codex/windows-readonly-root-red-green-20261015
codex/windows-root-share-red-green-20261015
codex/exp-1685-win-mcp-startup
codex/bug-sweep-20261015
investigate/2190-windows-package-phases
investigate/3543-macos-cli-deadline
perf/3281-reverse-tools-feedback-quality
fix/3406-hopper-doctor-fixture
fix/3341-wrapper-require-test-context
fix/3301-owned-uninstall-fixtures
fix/3164-compiler-input-ownership
fix/pcap-cleanup-stdout-newline-20261014
perf/interface-builder-summary
codex/review-fixes-pr-1977
fix/ghidra-effective-jvm-platform
fix/docs-turkish-rust-link-20261013
fix/main-maintenance-ci-20261010
fix/recover-binary-session-process-effects
codex/review-fixes-pr-2457
codex/ci-required-cancellation-gate
fix/main-format-baseline-20261013
fix/setup-preserve-entry-fields
cursor/restore-main-checks-1ffc
fix/ghidra-bridge-hashmap-import
codex/shared-ci-jadx-json-default-20261013
codex/shared-ci-ghidra-test-groups-20261013
codex/shared-ci-java-fixture-format-20261013
codex/fix-intrinsic-invocation-boundaries
test/release-preflight-reusable-jobs
test/js-parameter-provenance-expectation
fix/linux-hopper-verification-current
test/2419-ghidra-elf-probe-size
followup/pr-1544-native-ida
codex/fold-pr-2230-contribution
docs/readme-responsible-use
fix/issue-2064
fix/issue-2050
fix/issue-2053
fix/issue-1968
fix/issue-1945
experiment/codemode-bridge-20261011
fix/tool-effects-negative-wording-1904-20261012
fix/1842-electron-interop-provenance
feat/recover-javascript-multi-input
refactor/website-i18n-prep
fix/nativeaot-pe-virtual-extent
fix/browser-verifier-ci-hang
fix/pe-resources-input-selection
docs/beginner-friendly-guides
docs/beginner-setup-guide
fix/javascript-analysis-worker-1563
fix/1649-ghidra-duplicate-names
fix/javascript-export-keys-integration-1369
test/maintenance-boundary-contracts-20261011
review/javascript-export-keys-1369
review/process-live-progress-1483
test/javascript-1495-growth-ratio
fix/ci-escape-timing
docs/normalized-terminal-geometry-1450
release/6.3.0
archive/release-6.3.0-pr1381
release/6.2.0
fix/electron-preload-dynamic-override
fix/javascript-self-referential-bundler-edges
release/6.1.0
cursor/grok-client-cherry-pick-0b56
feat/signature-posture
feat/dyld-shared-cache
feat/artifact-integrity-policy
feat/pkg-inventory
release/6.0.0
chore/sync-release-5.0.0
release/5.0.0
cursor/cloud-agent-node-787e
fix/javascript-xhr-open-endpoints
review/pr-711-realpath-fallback-wording
cleanup/replay-confinement
codex/test-suite-performance
codex/issue-foundations
codex/address-open-issues-2026-07-20
agent/javascript-vite-rollup-esbuild-adapters
agent/process-cleanup
agent/triage-integration
agent/unknown-commands-registry
feat/mcp-identity-metadata
morlvps/issue_cleanup
codex/installer-redesign
morl/roadmap-investigation-core
morl/roadmap-investigation-docs
release-please--branches--main--components--rea
rea-agents-6.8.0
rea-agents-6.7.0
rea-agents-6.6.0
experiment/atomic-codemode-wait-runtime-20261016
rea-agents-6.5.0
rea-agents-6.4.0
rea-agents-6.3.0
rea-agents-6.2.0
rea-agents-6.1.0
rea-agents-6.0.0
rea-agents-5.0.0
rea-agents-4.1.0
rea-agents-4.0.1
rea-agents-4.0.0
rea-agents-3.2.1
rea-agents-3.2.0
rea-agents-3.1.0
rea-agents-3.0.0
rea-agents-2.7.0
rea-agents-2.6.0
rea-agents-2.5.1
rea-agents-2.5.0
rea-agents-2.4.0
rea-agents-2.3.0
rea-agents-2.2.0
rea-agents-2.1.0
rea-agents-2.0.0
rea-agents-1.7.0
rea-agents-1.6.0
rea-agents-1.5.0
rea-agents-1.4.0
rea-agents-1.3.0
rea-agents-1.2.0
rea-agents-1.1.0
rea-agents-1.0.0
rea-agents-0.5.0
rea-agents-0.4.0
rea-agents-0.3.0
rea-0.2.1
rea-0.2.0
Labels
Clear labels
area: bridge
area: bridge
area: build
area: build
area: build
area: cli
area: domain
area: evidence
area: mcp
area: native
area: providers
area: runtime
area: server
area: setup
area: tests
bug
design
documentation
enhancement
enhancement
enhancement
experiment
help wanted
i18n
invalid
P0: critical
P1: high
P2: medium
P2: medium
P2: medium
P3: low
performance
provider-request
pull-request
Mirrored from GitHub Pull Request
question
roadmap
triage
No labels
area: bridge
area: bridge
area: build
area: build
area: build
area: cli
area: domain
area: evidence
area: mcp
area: native
area: providers
area: runtime
area: server
area: setup
area: tests
bug
design
documentation
enhancement
enhancement
enhancement
experiment
help wanted
i18n
invalid
P0: critical
P1: high
P2: medium
P2: medium
P2: medium
P3: low
performance
provider-request
pull-request
question
roadmap
triage
Milestone
Clear milestone
No items
No milestone
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".
No due date set.
Dependencies
No dependencies set.
Reference
morluto/rea#6829
Loading…
Add table
Add a link
Reference in a new issue
No description provided.
Delete branch "%!s()"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
📋 Pull Request Information
Original PR: https://github.com/morluto/rea/pull/5235
Author: @reynold-hu
Created: 10/19/2026
Status: ✅ Merged
Merged: 10/22/2026
Merged by: @morluto
Base:
main← Head:fix/windows-cross-platform📝 Commits (8)
717c280fix(hopper): keep macOS and Linux launcher paths POSIXc333fa4fix(hopper): keep Linux and macOS bundle paths POSIX1f6ec02fix(electron): follow Windows symlink targets with native separatorsa8da99ftest(windows): align host-specific path and lifecycle expectations9bbe846test(windows): close review coverage gaps9139658Merge origin/main into fix/windows-cross-platform6683a3dMerge origin/main into fix/windows-cross-platform646e23afix(windows): retain fixture ownership while reconciling main📊 Changes
18 files changed (+403 additions, -163 deletions)
View changed files
📝
src/adb/AdbDeviceOutput.test.ts(+1 -0)📝
src/adb/AdbDeviceOutput.ts(+2 -1)📝
src/adb/AdbHostFileName.test.ts(+4 -1)📝
src/application/LinuxHopper.ts(+7 -2)📝
src/application/MacHopper.ts(+13 -11)📝
src/application/MacHopperPaths.test.ts(+17 -4)📝
src/application/MacHopperPaths.ts(+9 -6)📝
src/application/Setup.planning.test.ts(+7 -3)📝
src/artifacts/inventory/ArtifactOccurrenceIdentity.test.ts(+25 -22)📝
src/electron/ElectronFusePath.ts(+7 -3)📝
src/electron/ElectronFuseProvider.test.ts(+39 -2)📝
src/ghidra/GhidraLanguageOverride.test.ts(+14 -3)📝
src/ghidra/GhidraPowerPcProfile.test.ts(+17 -5)📝
src/ghidra/GhidraSnapshotCache.test.ts(+62 -3)📝
src/hopper/HopperProviderDiscovery.test.ts(+51 -34)📝
src/hopper/HopperTargetLease.test.ts(+34 -26)📝
src/wasm/WabtArtifactProvider.test.ts(+89 -32)📝
tests/composition/reverseEngineering.test.ts(+5 -5)📄 Description
Summary
Windows x64 source runs exposed three host-dependent path and separator assumptions that make target-platform paths wrong or weaken symlink containment:
path.join, so a Windows test host produced backslash-separated paths for those targets.readlinktargets only on/, but Windows returns\-separated relative targets. A nested link was treated as one component and a relative escaping target could pass the framework-root check without being walked.This PR builds macOS/Linux target paths with
path.posix, follows Windows symlink targets using native separators, and letsparsePmPathOutputtake an explicit platform for validation. Affected tests now compare against native joins, POSIX-only cases are skipped on Windows with explicit Windows assertions where behavior differs, and a regression covers an escaping Windows symlink target.No linked issue: found while running the source suite on Windows x64.
Problem and expected behavior
On Windows:
defaultHopperLauncherPath("linux" | "darwin", ...)returned\fixture\home\...instead of/fixture/home/....readlinkreturned..\..\Other; splitting only on/left it as one component, so containment was not established by walking.parsePmPathOutputvalidated/data/local/tmp/...against Windows filename rules.Expected: paths that describe a macOS/Linux target stay POSIX on any host; Windows symlink targets are walked with Windows separator semantics; ADB tests can select the validation platform explicitly.
Change and scope
Production changes:
src/application/MacHopperPaths.ts,src/application/MacHopper.ts,src/application/LinuxHopper.ts: usepath.posixfor macOS/Linux launcher, bundle, staging, and archive paths.src/electron/ElectronFusePath.ts: split relative link targets on\and/on Windows, preserving the existing./..walk and escape checks.src/adb/AdbDeviceOutput.ts: add an optionalplatformparameter toparsePmPathOutput, defaulting toprocess.platform; pass it toadbHostFileName.Test changes align native path joins, bind ADB tests to explicit platforms, prepare simulated POSIX Ghidra roots on Windows, cover the Windows Ghidra native-source admission step before snapshot replay, and skip POSIX-only Hopper lease, permission-bit, and symlink-parent cases on Windows. Windows still asserts the unsupported Hopper state.
Review follow-up (
9bbe846):nested\subdirlink target; a plain..\..\..\Othertarget was already rejected lexically before the separator splitter ran.TEMPon another drive cannot redirect writes away from the owned directory.diagnostics.primary_error; the Mach-O occurrence group now runs on Windows withexecutable: falseinstead of being skipped.Not included: no native Windows Job Object build, no new provider, no target execution/injection, and no change to POSIX behavior (
path.posixmatches the host on macOS/Linux).Contract and boundary impact
docs/public/product-catalog.json), package, or installation impact: none.Expected effects:
Evidence and regression coverage
tests/composition/reverseEngineering.test.ts.23f984b(Windows x64),npm run test:local -- src/config.test.ts src/application/MacHopperPaths.test.tsfailed 4 tests because nativepath.joinproduced backslashes for macOS/Linux paths.nested\subdirtarget that reaches an outside directory is rejected as escaping; the link target needs per-component walking to expose it.unsupported_hostassertion; the Mach-O occurrence group now runs on Windows.rea-agents@6.7.0tarball (source checkouts do not ship it and cannot build it on Windows). Fullcheck:pris not a Windows gate here because it includes unavailable real-provider and POSIX-only lanes; it was stopped before completion.Validation performed
a8da99f(owner verification comment): 609 files passed / 7 skipped; 9,924 tests passed / 218 skipped.npm run test:local -- <6 review-affected test files>on9bbe846— 105 passed, 1 skipped (the remaining skip is the POSIX permission-change case).npm run test:focused -- tests/composition/reverseEngineering.test.ts— 14 passed.npm run check:fast— 2 tasks successful.npm run build:cached— 3 tasks successful after restoring the packaged Windows native artifact.npm run check— 6 tasks successful; architecture guards passed across 1506 source files.npm run check:pr— attempted on Windows x64 but stopped before completion; it includes real-provider and POSIX-only lanes that are unavailable on this host, so it is not used as a Windows gate.Compatibility, safety, and release
Merge/review follow-up at
646e23aa7: integrated maine83e3cead, preserving in-root absolute Electron links and Windows component-by-component symlink walking. The MacHopper scan fixture now keeps its native owned path for filesystem I/O and cleanup and uses a checkout-relative POSIX home on Windows, avoiding UNC-prefix collapse. Verified the existing nested-link regression and drive-safe Ghidra fixture corrections; all three formerly open review threads now have implementation/validation replies and are resolved. The 13-file focused batch passed 246 tests with 2 Windows-only skips on macOS;check:ci:fastpassed all five tasks. Native Windows/UNC and real-provider behavior were not run locally. Hosted checks remain pending.Author readiness
Human owner: @reynold-hu
Before merge
type(scope): outcome.🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.