morluto/rea

Fork

You've already forked rea

mirror of https://github.com/morluto/rea.git synced 2026-11-05 06:45:22 +00:00

Code Issues 1.3k Projects Packages Wiki Activity

[PR #5268] [CLOSED] fix(browser): bound the start navigation with a provider-owned deadline #6848

New issue

Closed

opened 2026-11-01 21:43:29 +00:00 by bsakaguchi · 0 comments

bsakaguchi commented

2026-11-01 21:43:29 +00:00

Owner

Copy link

📋 Pull Request Information

Original PR: https://github.com/morluto/rea/pull/5268
Author: @sx4im
Created: 10/19/2026
Status: ❌ Closed

Base: main ← Head: fix/5266-browser-start-navigation-deadline

📝 Commits (1)

37e0991 fix(browser): bound the start navigation with a provider-owned deadline

📊 Changes

2 files changed (+29 additions, -2 deletions)

View changed files

📝 src/browser/PlaywrightScenarioSession.test.ts (+24 -1)
📝 src/browser/PlaywrightScenarioSession.ts (+5 -1)

📄 Description

Summary

Fixes #5266. Opening a browser scenario waited for the start page's load event with no deadline of its own, so a page whose script navigates away early to a host that never answers held the scenario open indefinitely. The start navigation now runs under a fixed 60s provider-owned deadline.

Problem and expected behavior

PlaywrightScenarioSession.open called page.goto(start_url, { waitUntil: "load", timeout: 0 }) inside withPlaywrightExecutionBoundary(..., undefined, signal). With Playwright timeouts disabled by design (the context sets both default timeouts to 0), only the caller's signal could end that wait. If the start page's script starts a navigation before load and that navigation never commits, goto never settles, so nothing reaches assertBlocked, storage.settle, or the first step. docs/browser-scenario-contract.md says navigation timeouts stay fixed provider-owned liveness limits, but the start navigation had none.

Change and scope

Pass a new fixed constant, PLAYWRIGHT_SCENARIO_START_NAVIGATION_TIMEOUT_MS (60s), to the execution boundary around the start navigation, instead of undefined. The boundary's AnalysisTimeoutError flows through the existing failed-open path: the session closes, cleanup runs, and the open fails with a typed timeout error. Two files changed, nothing else touched. 60s lines up with the provider's other startup-scale bounds (browser devtools startup, electron startup) since the start navigation waits for a full load of a real target page.

Not included: per-action goto navigations keep their caller-supplied timeout_ms behavior, untouched.

Contract and boundary impact

Semantic owner and earliest changed stage: browser scenario provider, scenario open/start navigation.
Contribution scope fit and linked maintainer decision: ordinary fix within existing boundaries; not applicable.
CLI and MCP/tool-catalog contract: none.
Provider, bridge, target-format, or platform compatibility: none.
Evidence, artifact, provenance, or reconstruction contract: the timeout error carries the existing partial-observation record (start origin, limits, and the "Scenario navigation failed before the initial state was captured" limitation).
Target selection, authority, upstream behavior, and cleanup details: the failed-open path already closes the session and releases the browser; unchanged.
Generated metadata, package, or installation impact: none.

Expected effects: none of the listed effects are new; the change only bounds an existing provider-side wait. The failed-open cleanup that terminates the browser session already existed for other failures.

Evidence and regression coverage

Tests added or updated: src/browser/PlaywrightScenarioSession.test.ts gains "bounds a never-settling start navigation with the provider-owned deadline". The mocked page's goto never settles, fake timers advance past the 60s deadline, and the test asserts open rejects with _tag: "AnalysisTimeoutError", timeoutMs: 60000, and that browser cleanup ran once.
Base reproduction or other evidence: executed, not source-only. On the base revision the same test hangs and the runner times it out at 30s, which is the reported behavior. With the fix, open fails exactly at the deadline.
User-visible CLI/MCP output: none.
Remaining proof gaps: no real-browser run of a redirect-to-dead-host page in this PR (no Chrome on the build host). The reporter verified the underlying Playwright behavior in #5266 with a standalone script on playwright-core 1.58.2, the version this repo pins.

For evidence-bearing changes:

Observed, derived, and inferred claims remain distinguishable.
Artifact identity, source provenance, and failed attempts remain preserved.
Unsupported, incomplete, unavailable, or uncertain outcomes remain visible.

Validation performed

npx vitest run src/browser/PlaywrightScenarioSession.test.ts — 26/26 pass (new test fails on base via 30s hang timeout, passes with fix in 133ms under fake timers).
npm run test:local -- src/browser/PlaywrightScenarioBrowser.test.ts src/browser/PlaywrightBrowserScenarioProvider.test.ts — 48/48 pass.
npm run check:fast — typecheck and lint, 2/2 tasks successful.
npm run verify:test-discovery — all 1666 test files discovered exactly once.

Compatibility, safety, and release

Breaking changes or migration steps: none. A start navigation that previously hung forever now fails after 60s; that is the fix.
Real Hopper/Ghidra, browser, or OS coverage: no real-browser run; see proof gaps above.
Package or release metadata impact: none.
Security, privacy, process, or containment review: no new process or network effects. A previously unbounded wait now terminates, which reduces resource retention.

Author readiness

Human owner:

I reviewed the final diff and relevant existing code, understand the change and its edge cases, and take responsibility for the complete PR, including AI-assisted work.
I checked the evidence above, confirmed it supports the current change, and recorded meaningful validation gaps.
I declare this PR ready for initial maintainer review.

Before merge

This PR addresses a concrete problem or an agreed enhancement.
Material scope and authority questions are resolved, and any required maintainer scope decision covers the final diff.
The PR has one focused outcome and the title follows type(scope): outcome.
Related issue is linked, or the reason for not linking one is stated above.
Tests cover changed observable behavior and meaningful failure paths.
Owning docs, contracts, and generated metadata are updated where needed.
User-visible CLI/MCP changes include representative output.
I checked the final diff for secrets, unrelated cleanup, and unsupported claims.

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/morluto/rea/pull/5268 **Author:** [@sx4im](https://github.com/sx4im) **Created:** 10/19/2026 **Status:** ❌ Closed **Base:** `main` ← **Head:** `fix/5266-browser-start-navigation-deadline` --- ### 📝 Commits (1) - [`37e0991`](https://github.com/morluto/rea/commit/37e0991bde2731d7765458a454bb8777546ea0e3) fix(browser): bound the start navigation with a provider-owned deadline ### 📊 Changes **2 files changed** (+29 additions, -2 deletions) <details> <summary>View changed files</summary> 📝 `src/browser/PlaywrightScenarioSession.test.ts` (+24 -1) 📝 `src/browser/PlaywrightScenarioSession.ts` (+5 -1) </details> ### 📄 Description ## Summary Fixes #5266. Opening a browser scenario waited for the start page's `load` event with no deadline of its own, so a page whose script navigates away early to a host that never answers held the scenario open indefinitely. The start navigation now runs under a fixed 60s provider-owned deadline. ## Problem and expected behavior `PlaywrightScenarioSession.open` called `page.goto(start_url, { waitUntil: "load", timeout: 0 })` inside `withPlaywrightExecutionBoundary(..., undefined, signal)`. With Playwright timeouts disabled by design (the context sets both default timeouts to 0), only the caller's signal could end that wait. If the start page's script starts a navigation before `load` and that navigation never commits, `goto` never settles, so nothing reaches `assertBlocked`, `storage.settle`, or the first step. `docs/browser-scenario-contract.md` says navigation timeouts stay fixed provider-owned liveness limits, but the start navigation had none. ## Change and scope Pass a new fixed constant, `PLAYWRIGHT_SCENARIO_START_NAVIGATION_TIMEOUT_MS` (60s), to the execution boundary around the start navigation, instead of `undefined`. The boundary's `AnalysisTimeoutError` flows through the existing failed-open path: the session closes, cleanup runs, and the open fails with a typed timeout error. Two files changed, nothing else touched. 60s lines up with the provider's other startup-scale bounds (browser devtools startup, electron startup) since the start navigation waits for a full `load` of a real target page. Not included: per-action `goto` navigations keep their caller-supplied `timeout_ms` behavior, untouched. ## Contract and boundary impact - Semantic owner and earliest changed stage: browser scenario provider, scenario open/start navigation. - Contribution scope fit and linked maintainer decision: ordinary fix within existing boundaries; not applicable. - CLI and MCP/tool-catalog contract: none. - Provider, bridge, target-format, or platform compatibility: none. - Evidence, artifact, provenance, or reconstruction contract: the timeout error carries the existing partial-observation record (start origin, limits, and the "Scenario navigation failed before the initial state was captured" limitation). - Target selection, authority, upstream behavior, and cleanup details: the failed-open path already closes the session and releases the browser; unchanged. - Generated metadata, package, or installation impact: none. Expected effects: none of the listed effects are new; the change only bounds an existing provider-side wait. The failed-open cleanup that terminates the browser session already existed for other failures. ## Evidence and regression coverage - Tests added or updated: `src/browser/PlaywrightScenarioSession.test.ts` gains "bounds a never-settling start navigation with the provider-owned deadline". The mocked page's `goto` never settles, fake timers advance past the 60s deadline, and the test asserts `open` rejects with `_tag: "AnalysisTimeoutError"`, `timeoutMs: 60000`, and that browser cleanup ran once. - Base reproduction or other evidence: executed, not source-only. On the base revision the same test hangs and the runner times it out at 30s, which is the reported behavior. With the fix, `open` fails exactly at the deadline. - User-visible CLI/MCP output: none. - Remaining proof gaps: no real-browser run of a redirect-to-dead-host page in this PR (no Chrome on the build host). The reporter verified the underlying Playwright behavior in #5266 with a standalone script on playwright-core 1.58.2, the version this repo pins. For evidence-bearing changes: - [x] Observed, derived, and inferred claims remain distinguishable. - [x] Artifact identity, source provenance, and failed attempts remain preserved. - [x] Unsupported, incomplete, unavailable, or uncertain outcomes remain visible. ## Validation performed - `npx vitest run src/browser/PlaywrightScenarioSession.test.ts` — 26/26 pass (new test fails on base via 30s hang timeout, passes with fix in 133ms under fake timers). - `npm run test:local -- src/browser/PlaywrightScenarioBrowser.test.ts src/browser/PlaywrightBrowserScenarioProvider.test.ts` — 48/48 pass. - `npm run check:fast` — typecheck and lint, 2/2 tasks successful. - `npm run verify:test-discovery` — all 1666 test files discovered exactly once. ## Compatibility, safety, and release - Breaking changes or migration steps: none. A start navigation that previously hung forever now fails after 60s; that is the fix. - Real Hopper/Ghidra, browser, or OS coverage: no real-browser run; see proof gaps above. - Package or release metadata impact: none. - Security, privacy, process, or containment review: no new process or network effects. A previously unbounded wait now terminates, which reduces resource retention. ## Author readiness Human owner:  - [ ] I reviewed the final diff and relevant existing code, understand the change and its edge cases, and take responsibility for the complete PR, including AI-assisted work. - [ ] I checked the evidence above, confirmed it supports the current change, and recorded meaningful validation gaps. - [ ] I declare this PR ready for initial maintainer review. ## Before merge - [ ] This PR addresses a concrete problem or an agreed enhancement. - [ ] Material scope and authority questions are resolved, and any required maintainer scope decision covers the final diff. - [ ] The PR has one focused outcome and the title follows `type(scope): outcome`. - [ ] Related issue is linked, or the reason for not linking one is stated above. - [ ] Tests cover changed observable behavior and meaningful failure paths. - [ ] Owning docs, contracts, and generated metadata are updated where needed. - [ ] User-visible CLI/MCP changes include representative output. - [ ] I checked the final diff for secrets, unrelated cleanup, and unsupported claims. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>

bsakaguchi

2026-11-01 21:43:29 +00:00

closed this issue
added the
pull-request
label

No Branch/Tag specified

main

codex/procedure-reference-stacked

release-please--branches--main--components--rea-agents

release-please--branches--main--components--rea-agents--release-notes

codex/kuna-independent-retry

codex/byte-search-overlay-coverage

codex/open-failure-target-receipt

codex/kuna-xref-evidence

codex/ghidra-ambiguous-procedure-recovery

codex/function-source-bundle

codex/trace-function-integration-prototype

codex/snapshot-source-closure

codex/recorded-evidence-array-pages

codex/evidence-recovery-redesign

codex/trace-feature-address-scope

codex/call-discovery-scope

codex/ghidra-literal-candidate-evidence

codex/decompile-directory-independent-retry

codex/retry-provenance-base

codex/value-flow-capability-experiment

codex/ghidra-containing-instruction

cursor/readme-discord-button-ef9f

dependabot/github_actions/actions/setup-node-7.1.0

dependabot/github_actions/actions/upload-artifact-7.0.2

dependabot/npm_and_yarn/npm-minor-and-patch-d8d97ce6df

codex/kuna-1989

fix/8559-native-ui-fixture-ownership

fix/8555-go-verifier-mcp-ownership

codex/provider-capability-recovery

fix/8642-rizin-target-stdin

codex/ghidra-memory-effect-scope

codex/ghidra-annotation-entry-selector

codex/ghidra-readonly-recovery

codex/ghidra-regex-verifier-recovery

codex/evidence-discovery-view-guidance

fix/8545-bulk-append-overflow

fix/8428-navigation-refusal-alternatives

codex/address-context-recovery

codex/matching-member-limitations

codex/unknown-scope-contract

codex/evidence-view-guidance

feat/8373-native-trace-views

codex/ghidra-snapshot-verifier-binding

codex/elf-export-visibility

codex/evidence-view-recovery

codex/native-reference-cli-help

codex/provider-candidate-observation-scope

codex/kuna-session-verification

codex/ghidra-switch-lifetime-guidance

codex/pseudocode-paging-discovery

codex/clarify-evidence-view-support

codex/kuna-xrefs-selector-recovery

codex/context-capacity-recovery

codex/evidence-closure-large-links

codex/same-function-evidence-identity

codex/ghidra-verifier-inspected-jdk

codex/audit-guided-workflows

codex/crash-prompt-retained-dossiers

codex/analysis-view-error-recovery

codex/kuna-verifier-target-selection

codex/ghidra-selected-project-call-coverage

codex/docs-native-analysis-scope

codex/ghidra-java-socket-boundary

codex/ghidra-retained-snapshot-verifier

codex/ghidra-search-inventory-facts

fix/8284-zero-argument-parameter-bindings

fix/8198-ui-action-handler-offset

fix/8257-elf-entry-label-identity

fix/8304-deferred-output-schema-projection

fix/8277-call-path-computed-target-uncertainty

fix/pr-8089-conflicts

fix/ci-static-duplicate-export

dependabot/npm_and_yarn/lint-staged-17.6.0

dependabot/github_actions/actions/download-artifact-8.0.2

dependabot/npm_and_yarn/write-file-atomic-8.0.0

dependabot/npm_and_yarn/canonicalize-5.1.0

dependabot/github_actions/actions/cache/restore-6.1.0

dependabot/npm_and_yarn/toon-format/toon-4.4.0

dependabot/github_actions/actions/deploy-pages-5.0.1

codex/review-fixes-pr-2403

codex/review-fixes-pr-2400

codex/process-terminal-width

codex/test-brittleness-cleanup

verify/7167-browser-connect-macos

fix/7167-browser-connect

feat/native-matching-allowance-setting

feat/browser-scenario-dry-run

test/managed-caller-parameters-20261024

codex/parser-fortythird-boundaries

fix/6926-pinvoke-platform-decorations-20261023

fix/6889-har-body-encoding-20261023

fix/6888-sqlite-schema-budget-20261023

fix/dependency-security-gates-6708

cursor/evidence-overwrite-rebase-b4ac

feat/4057-verify-native-exports

fix/windows-acl-observer-overhead-20261022

cursor/erlang-beam-restack-4476

cursor/pe-certificate-review-bf32

fix/6116-javascript-application-fs-errors

fix/6061-unmapped-runtime-script-unknown

feat/browser-scenario-summary

fix/pe-certificates

codex/verify-3407

cursor/rebase-5699

cursor/rebase-5352

cursor/rebase-5600

cursor/fix-cli-schema-omission-10a8

codex/audit-hopper-shutdown-reasons-20261021

fix/demangle-swift-omitted-record

fix/nib-boolean-value-types

cursor/cancellation-partial-observation-a5ac

fix/ib-object-limit-reasons

fix/electron-fuse-limit-advice

fix/kuna-doctor-dangling-cache

fix/fixed-budget-refusal-advice

fix/js-ipc-listener-dedup

fix/js-return-member-provenance

fix/dmg-integrity-retry-advice

fix/ida-doctor-readiness

fix/kuna-version-probe-output-drain

fix/legacy-swift-runtime-name-matching

fix/dylib-lazy-load-commands

fix/browser-scenario-startup-cancel

fix/swift-nested-punycode-classification

fix/compare-unselected-scopes

fix/objc-method-budget-coverage

fix/dmg-mounted-root-observations

audit/ci-tests-20261019-round2

release/6.7.0

fix/wabt-cleanup-retry-resolution

fix/electron-fuse-elf-pe-architecture

fix/native-plist-descriptor-ownership

fix/kuna-caller-cleanup-ownership

experiment/atomic-codemode-20261016

review/first-contributor-3776

fix/call-resolution-full-read-cycles

fix/member-mutation-selection-repeat

experiment/atomic-re-tools-20261015

perf/member-mutation-lazy-origins

perf/static-network-mutation-index

fix/hopper-startup-lifecycle

audit/3050-windows-proof-20261015

feat/windows-window-capture-2183

audit/3049-windows-proof-20261015

audit/3735-macos-fixtures-20261015

fix/batch-decompile-null-pseudocode

fix/kuna-inventory-honors-jobs

experiment/browser-codemode-tool-design-20261015

fix/hopper-clean-runtime-argv

codex/review-2049-27f1b367

review-fixes/pr-2787-routing

fix/3360-scoped-this-emitters

fix/3367-replaced-global-effects

fix/3838-compact-any-value-items

test/hopper-download-probe-20261015

codex/windows-runtime-creation-red-green-20261015

codex/windows-readonly-root-red-green-20261015

codex/windows-root-share-red-green-20261015

codex/exp-1685-win-mcp-startup

codex/bug-sweep-20261015

investigate/2190-windows-package-phases

investigate/3543-macos-cli-deadline

perf/3281-reverse-tools-feedback-quality

fix/3406-hopper-doctor-fixture

fix/3341-wrapper-require-test-context

fix/3301-owned-uninstall-fixtures

fix/3164-compiler-input-ownership

fix/pcap-cleanup-stdout-newline-20261014

perf/interface-builder-summary

codex/review-fixes-pr-1977

fix/ghidra-effective-jvm-platform

fix/docs-turkish-rust-link-20261013

fix/main-maintenance-ci-20261010

fix/recover-binary-session-process-effects

codex/review-fixes-pr-2457

codex/ci-required-cancellation-gate

fix/main-format-baseline-20261013

fix/setup-preserve-entry-fields

cursor/restore-main-checks-1ffc

fix/ghidra-bridge-hashmap-import

codex/shared-ci-jadx-json-default-20261013

codex/shared-ci-ghidra-test-groups-20261013

codex/shared-ci-java-fixture-format-20261013

codex/fix-intrinsic-invocation-boundaries

test/release-preflight-reusable-jobs

test/js-parameter-provenance-expectation

fix/linux-hopper-verification-current

test/2419-ghidra-elf-probe-size

followup/pr-1544-native-ida

codex/fold-pr-2230-contribution

docs/readme-responsible-use

fix/issue-2064

fix/issue-2050

fix/issue-2053

fix/issue-1968

fix/issue-1945

experiment/codemode-bridge-20261011

fix/tool-effects-negative-wording-1904-20261012

fix/1842-electron-interop-provenance

feat/recover-javascript-multi-input

refactor/website-i18n-prep

fix/nativeaot-pe-virtual-extent

fix/browser-verifier-ci-hang

fix/pe-resources-input-selection

docs/beginner-friendly-guides

docs/beginner-setup-guide

fix/javascript-analysis-worker-1563

fix/1649-ghidra-duplicate-names

fix/javascript-export-keys-integration-1369

test/maintenance-boundary-contracts-20261011

review/javascript-export-keys-1369

review/process-live-progress-1483

test/javascript-1495-growth-ratio

fix/ci-escape-timing

docs/normalized-terminal-geometry-1450

release/6.3.0

archive/release-6.3.0-pr1381

release/6.2.0

fix/electron-preload-dynamic-override

fix/javascript-self-referential-bundler-edges

release/6.1.0

cursor/grok-client-cherry-pick-0b56

feat/signature-posture

feat/dyld-shared-cache

feat/artifact-integrity-policy

feat/pkg-inventory

release/6.0.0

chore/sync-release-5.0.0

release/5.0.0

cursor/cloud-agent-node-787e

fix/javascript-xhr-open-endpoints

review/pr-711-realpath-fallback-wording

cleanup/replay-confinement

codex/test-suite-performance

codex/issue-foundations

codex/address-open-issues-2026-07-20

agent/javascript-vite-rollup-esbuild-adapters

agent/process-cleanup

agent/triage-integration

agent/unknown-commands-registry

feat/mcp-identity-metadata

morlvps/issue_cleanup

codex/installer-redesign

morl/roadmap-investigation-core

morl/roadmap-investigation-docs

release-please--branches--main--components--rea

rea-agents-6.8.0

rea-agents-6.7.0

rea-agents-6.6.0

experiment/atomic-codemode-wait-runtime-20261016

rea-agents-6.5.0

rea-agents-6.4.0

rea-agents-6.3.0

rea-agents-6.2.0

rea-agents-6.1.0

rea-agents-6.0.0

rea-agents-5.0.0

rea-agents-4.1.0

rea-agents-4.0.1

rea-agents-4.0.0

rea-agents-3.2.1

rea-agents-3.2.0

rea-agents-3.1.0

rea-agents-3.0.0

rea-agents-2.7.0

rea-agents-2.6.0

rea-agents-2.5.1

rea-agents-2.5.0

rea-agents-2.4.0

rea-agents-2.3.0

rea-agents-2.2.0

rea-agents-2.1.0

rea-agents-2.0.0

rea-agents-1.7.0

rea-agents-1.6.0

rea-agents-1.5.0

rea-agents-1.4.0

rea-agents-1.3.0

rea-agents-1.2.0

rea-agents-1.1.0

rea-agents-1.0.0

rea-agents-0.5.0

rea-agents-0.4.0

rea-agents-0.3.0

rea-0.2.1

rea-0.2.0

Labels

Clear labels

Mirrored from GitHub Pull Request

No labels

Milestone

Clear milestone

No items

No milestone

Projects

Clear projects

No items

No project

Assignees

Clear assignees

No assignees

1 participant

Notifications

Due date

The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference

morluto/rea#6848

Reference in a new issue

Repository

morluto/rea

Title

Body

No description provided.

Delete branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?

Rows
Columns