[PR #5281] [MERGED] fix(rizin): accept proven inferior exit after detach #6856

New issue

Closed

opened 2026-11-01 21:43:34 +00:00 by bsakaguchi · 0 comments

bsakaguchi commented 2026-11-01 21:43:34 +00:00

Owner

Copy link

📋 Pull Request Information

Original PR: https://github.com/morluto/rea/pull/5281
Author: @gensokyo-dev
Created: 10/19/2026
Status: ✅ Merged
Merged: 10/19/2026
Merged by: @gensokyo-dev

Base: main ← Head: fix/5277-rizin-inferior-exit-close

---

📝 Commits (2)

• efff408 fix(rizin): accept proven inferior exit after detach
• 6879e1a chore(rizin): integrate latest process lifecycle fixes

📊 Changes

5 files changed (+231 additions, -82 deletions)

View changed files

📝 docs/reverse-engineering-tools.md (+1 -1)
📝 src/process/ownedDebuggerSession.ts (+4 -1)
📝 src/rizin/RizinDebugSessionManager.ts (+56 -68)
➕ tests/boundary/providers/RizinInferiorExit.test.ts (+166 -0)
📝 tests/boundary/providers/RizinInferiorTty.test.ts (+4 -12)

📄 Description

Follow-up: the post-detach ambiguous-readback P1 was corrected in #5290 (909b9f7b6), with a demonstrated failing-before regression, 207 passing checks and actual merged-main Rizin/CLI verification. The validation below records the original normal-workflow checks.

Summary

Fixes #5277. On Linux, starting /usr/bin/true and closing its Rizin session returned cleanup_incomplete when the detached inferior exited before /proc verification; the CLI exited 1 despite complete command Evidence.

Close now succeeds after proving the original identified inferior ended. A live process with mismatched output routing still fails closed and keeps the debugger owned.

Change and scope

Reuse the shared Linux PID/start-time reader; remove Rizin's duplicate /proc/stat parser and its redundant parser tests. Preserve the original identity throughout detach instead of recapturing it. Only consider process-end proof after a correlated native olj read confirms no remaining inferior descriptor. Startup, protocol ambiguity, permissions, PID identity and live-target TTY checks remain required.

Add deterministic exit-during-detach and live-output-redirect regressions using owned process supervision and condition-based synchronization. Document the verified-exit case. No new capability, execution authority, dependency, schema, cache or installer change.

Contract and boundary impact

Owner: Rizin cleanup uses the existing process identity owner. Shared CLI/MCP behavior and existing close result shape are preserved. This is an ordinary bug fix within existing provider boundaries; no new maintainer scope decision is required.

Expected effects (existing workflow):

• Read existing files or captured data.
• Launch or attach to a process.
• Inject instrumentation or run scripts/code.
• Change process memory, registers, files, or configuration.
• Contact network services.
• Recover protected code or work around protections.

The patch changes owned-debugger cleanup; real verification launched controlled targets through existing operations.

Evidence and regression coverage

• npm run test:focused -- 16 Rizin/process files: 206 passed, 1 skipped. The existing optional Rizin 0.7.4 lane was unavailable; the real 0.9.1 checks below ran separately.
• npm run check and npm run docs:check passed, including architecture guards and five README tests.
• Actual SDK stdio MCP + official Rizin 0.9.1 Linux x86-64: two baseline first-close failures recovered by explicit retry; two fixed runs closed on the first call. Both revisions preserved stdout/stderr from a live, source-controlled program after debugger close to the selected durable PTY. Actual debug-with-rizin /usr/bin/true dr CLI: exit 1 → 0, complete command Evidence retained.
• Target digests unchanged; owned process-family cleanup verified; OOM kills 0. CPU1, one heavy job at a time, at most 8 GiB hard limit (public proofs 2 GiB); largest validation peak 4.61 GiB. Counters observed at payload exit with the observer alive, not final whole-scope counters.

Validation performed

ABBA fresh SDK sessions on base 1c2c2f1e7 and tested head 6879e1af8, warm OS file cache: elapsed 4.068–4.474 → 3.867–4.064 s, CPU 3.357–3.833 → 3.220–3.340 s, peak 315.5–319.8 → 320.8–320.9 MiB. This small sample establishes no general speed or memory improvement.

The known-name workflow needed 3 → 2 MCP calls. Recorded request/reply estimates (tiktoken 0.12.0, cl100k_base): 485–495 → 215–218 tokens. No explicit discovery was performed; initialization/protocol/catalog costs and actual model usage are unmeasured. This is lifecycle conformance, not a complex-software investigation benchmark.

Compatibility, safety, and release

No breaking API, package metadata or generated-file change. Linux/Rizin 0.9.1 verified; other engine versions and platforms remain unverified here. Unidentified, unreadable or still-live mismatched processes are not treated as absent. The new fixtures retain ownership and files when cleanup fails.

Author readiness

Human owner: @gensokyo-dev

The owner explicitly authorized ready submission and merging, including CI bypass, in this session. Implementation, technical review and executed validation are recorded above; manual human-review declarations remain for the owner.

• I reviewed the final diff and relevant existing code, understand the change and its edge cases, and take responsibility for the complete PR, including AI-assisted work.
• I checked the evidence above, confirmed it supports the current change, and recorded meaningful validation gaps.
• I declare this PR ready for initial maintainer review.

Before merge

• This PR addresses a concrete problem or an agreed enhancement.
• Material scope and authority questions are resolved, and any required maintainer scope decision covers the final diff.
• The PR has one focused outcome and the title follows type(scope): outcome.
• Related issue is linked, or the reason for not linking one is stated above.
• Tests cover changed observable behavior and meaningful failure paths.
• Owning docs, contracts, and generated metadata are updated where needed.
• User-visible CLI/MCP changes include representative output.
• I checked the final diff for secrets, unrelated cleanup, and unsupported claims.

---

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/morluto/rea/pull/5281 **Author:** [@gensokyo-dev](https://github.com/gensokyo-dev) **Created:** 10/19/2026 **Status:** ✅ Merged **Merged:** 10/19/2026 **Merged by:** [@gensokyo-dev](https://github.com/gensokyo-dev) **Base:** `main` ← **Head:** `fix/5277-rizin-inferior-exit-close` --- ### 📝 Commits (2) - [`efff408`](https://github.com/morluto/rea/commit/efff408a19ab6127310be88ae5b814190d46dbb4) fix(rizin): accept proven inferior exit after detach - [`6879e1a`](https://github.com/morluto/rea/commit/6879e1af82ebcbb0c41da02ca9e94530b357f495) chore(rizin): integrate latest process lifecycle fixes ### 📊 Changes **5 files changed** (+231 additions, -82 deletions) <details> <summary>View changed files</summary> 📝 `docs/reverse-engineering-tools.md` (+1 -1) 📝 `src/process/ownedDebuggerSession.ts` (+4 -1) 📝 `src/rizin/RizinDebugSessionManager.ts` (+56 -68) ➕ `tests/boundary/providers/RizinInferiorExit.test.ts` (+166 -0) 📝 `tests/boundary/providers/RizinInferiorTty.test.ts` (+4 -12) </details> ### 📄 Description Follow-up: the post-detach ambiguous-readback P1 was corrected in #5290 (`909b9f7b6`), with a demonstrated failing-before regression, 207 passing checks and actual merged-main Rizin/CLI verification. The validation below records the original normal-workflow checks. ## Summary Fixes #5277. On Linux, starting `/usr/bin/true` and closing its Rizin session returned `cleanup_incomplete` when the detached inferior exited before `/proc` verification; the CLI exited 1 despite complete command Evidence. Close now succeeds after proving the original identified inferior ended. A live process with mismatched output routing still fails closed and keeps the debugger owned. ## Change and scope Reuse the shared Linux PID/start-time reader; remove Rizin's duplicate `/proc/stat` parser and its redundant parser tests. Preserve the original identity throughout detach instead of recapturing it. Only consider process-end proof after a correlated native `olj` read confirms no remaining inferior descriptor. Startup, protocol ambiguity, permissions, PID identity and live-target TTY checks remain required. Add deterministic exit-during-detach and live-output-redirect regressions using owned process supervision and condition-based synchronization. Document the verified-exit case. No new capability, execution authority, dependency, schema, cache or installer change. ## Contract and boundary impact Owner: Rizin cleanup uses the existing process identity owner. Shared CLI/MCP behavior and existing close result shape are preserved. This is an ordinary bug fix within existing provider boundaries; no new maintainer scope decision is required. Expected effects (existing workflow): - [x] Read existing files or captured data. - [x] Launch or attach to a process. - [ ] Inject instrumentation or run scripts/code. - [ ] Change process memory, registers, files, or configuration. - [ ] Contact network services. - [ ] Recover protected code or work around protections. The patch changes owned-debugger cleanup; real verification launched controlled targets through existing operations. ## Evidence and regression coverage - `npm run test:focused --` 16 Rizin/process files: **206 passed, 1 skipped**. The existing optional Rizin 0.7.4 lane was unavailable; the real 0.9.1 checks below ran separately. - `npm run check` and `npm run docs:check` passed, including architecture guards and five README tests. - Actual SDK stdio MCP + official Rizin 0.9.1 Linux x86-64: two baseline first-close failures recovered by explicit retry; two fixed runs closed on the first call. Both revisions preserved stdout/stderr from a live, source-controlled program after debugger close to the selected durable PTY. Actual `debug-with-rizin /usr/bin/true dr` CLI: exit **1 → 0**, complete command Evidence retained. - Target digests unchanged; owned process-family cleanup verified; OOM kills 0. CPU1, one heavy job at a time, at most 8 GiB hard limit (public proofs 2 GiB); largest validation peak **4.61 GiB**. Counters observed at payload exit with the observer alive, not final whole-scope counters. ## Validation performed ABBA fresh SDK sessions on base `1c2c2f1e7` and tested head `6879e1af8`, warm OS file cache: elapsed **4.068–4.474 → 3.867–4.064 s**, CPU **3.357–3.833 → 3.220–3.340 s**, peak **315.5–319.8 → 320.8–320.9 MiB**. This small sample establishes no general speed or memory improvement. The known-name workflow needed **3 → 2** MCP calls. Recorded request/reply estimates (`tiktoken 0.12.0`, `cl100k_base`): **485–495 → 215–218** tokens. No explicit discovery was performed; initialization/protocol/catalog costs and actual model usage are unmeasured. This is lifecycle conformance, not a complex-software investigation benchmark. ## Compatibility, safety, and release No breaking API, package metadata or generated-file change. Linux/Rizin 0.9.1 verified; other engine versions and platforms remain unverified here. Unidentified, unreadable or still-live mismatched processes are not treated as absent. The new fixtures retain ownership and files when cleanup fails. ## Author readiness Human owner: @gensokyo-dev The owner explicitly authorized ready submission and merging, including CI bypass, in this session. Implementation, technical review and executed validation are recorded above; manual human-review declarations remain for the owner. - [ ] I reviewed the final diff and relevant existing code, understand the change and its edge cases, and take responsibility for the complete PR, including AI-assisted work. - [ ] I checked the evidence above, confirmed it supports the current change, and recorded meaningful validation gaps. - [ ] I declare this PR ready for initial maintainer review. ## Before merge - [x] This PR addresses a concrete problem or an agreed enhancement. - [x] Material scope and authority questions are resolved, and any required maintainer scope decision covers the final diff. - [x] The PR has one focused outcome and the title follows `type(scope): outcome`. - [x] Related issue is linked, or the reason for not linking one is stated above. - [x] Tests cover changed observable behavior and meaningful failure paths. - [x] Owning docs, contracts, and generated metadata are updated where needed. - [x] User-visible CLI/MCP changes include representative output. - [x] I checked the final diff for secrets, unrelated cleanup, and unsupported claims. --- _{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

bsakaguchi 2026-11-01 21:43:34 +00:00

• closed this issue
• added the
  pull-request
  label

bsakaguchi referenced this issue 2026-11-01 21:47:47 +00:00

[PR #6856] fix(comparison): reject blank function names #7426

bsakaguchi referenced this issue 2026-11-03 00:29:28 +00:00

[GH-ISSUE #3582] [Tracker] Ready to close or merge: issues and pull requests (October 2026) #1330

bsakaguchi referenced this issue 2026-11-03 00:29:36 +00:00

[GH-ISSUE #5654] [Tracker] Open PRs that can't merge yet: conflicts and red CI (October 2026) #3425

Sign in to join this conversation.

No Branch/Tag specified

Branches Tags

main

codex/procedure-reference-stacked

release-please--branches--main--components--rea-agents

release-please--branches--main--components--rea-agents--release-notes

codex/kuna-independent-retry

codex/byte-search-overlay-coverage

codex/open-failure-target-receipt

codex/kuna-xref-evidence

codex/ghidra-ambiguous-procedure-recovery

codex/function-source-bundle

codex/trace-function-integration-prototype

codex/snapshot-source-closure

codex/recorded-evidence-array-pages

codex/evidence-recovery-redesign

codex/trace-feature-address-scope

codex/call-discovery-scope

codex/ghidra-literal-candidate-evidence

codex/decompile-directory-independent-retry

codex/retry-provenance-base

codex/value-flow-capability-experiment

codex/ghidra-containing-instruction

cursor/readme-discord-button-ef9f

dependabot/github_actions/actions/setup-node-7.1.0

dependabot/github_actions/actions/upload-artifact-7.0.2

dependabot/npm_and_yarn/npm-minor-and-patch-d8d97ce6df

codex/kuna-1989

fix/8559-native-ui-fixture-ownership

fix/8555-go-verifier-mcp-ownership

codex/provider-capability-recovery

fix/8642-rizin-target-stdin

codex/ghidra-memory-effect-scope

codex/ghidra-annotation-entry-selector

codex/ghidra-readonly-recovery

codex/ghidra-regex-verifier-recovery

codex/evidence-discovery-view-guidance

fix/8545-bulk-append-overflow

fix/8428-navigation-refusal-alternatives

codex/address-context-recovery

codex/matching-member-limitations

codex/unknown-scope-contract

codex/evidence-view-guidance

feat/8373-native-trace-views

codex/ghidra-snapshot-verifier-binding

codex/elf-export-visibility

codex/evidence-view-recovery

codex/native-reference-cli-help

codex/provider-candidate-observation-scope

codex/kuna-session-verification

codex/ghidra-switch-lifetime-guidance

codex/pseudocode-paging-discovery

codex/clarify-evidence-view-support

codex/kuna-xrefs-selector-recovery

codex/context-capacity-recovery

codex/evidence-closure-large-links

codex/same-function-evidence-identity

codex/ghidra-verifier-inspected-jdk

codex/audit-guided-workflows

codex/crash-prompt-retained-dossiers

codex/analysis-view-error-recovery

codex/kuna-verifier-target-selection

codex/ghidra-selected-project-call-coverage

codex/docs-native-analysis-scope

codex/ghidra-java-socket-boundary

codex/ghidra-retained-snapshot-verifier

codex/ghidra-search-inventory-facts

fix/8284-zero-argument-parameter-bindings

fix/8198-ui-action-handler-offset

fix/8257-elf-entry-label-identity

fix/8304-deferred-output-schema-projection

fix/8277-call-path-computed-target-uncertainty

fix/pr-8089-conflicts

fix/ci-static-duplicate-export

dependabot/npm_and_yarn/lint-staged-17.6.0

dependabot/github_actions/actions/download-artifact-8.0.2

dependabot/npm_and_yarn/write-file-atomic-8.0.0

dependabot/npm_and_yarn/canonicalize-5.1.0

dependabot/github_actions/actions/cache/restore-6.1.0

dependabot/npm_and_yarn/toon-format/toon-4.4.0

dependabot/github_actions/actions/deploy-pages-5.0.1

codex/review-fixes-pr-2403

codex/review-fixes-pr-2400

codex/process-terminal-width

codex/test-brittleness-cleanup

verify/7167-browser-connect-macos

fix/7167-browser-connect

feat/native-matching-allowance-setting

feat/browser-scenario-dry-run

test/managed-caller-parameters-20261024

codex/parser-fortythird-boundaries

fix/6926-pinvoke-platform-decorations-20261023

fix/6889-har-body-encoding-20261023

fix/6888-sqlite-schema-budget-20261023

fix/dependency-security-gates-6708

cursor/evidence-overwrite-rebase-b4ac

feat/4057-verify-native-exports

fix/windows-acl-observer-overhead-20261022

cursor/erlang-beam-restack-4476

cursor/pe-certificate-review-bf32

fix/6116-javascript-application-fs-errors

fix/6061-unmapped-runtime-script-unknown

feat/browser-scenario-summary

fix/pe-certificates

codex/verify-3407

cursor/rebase-5699

cursor/rebase-5352

cursor/rebase-5600

cursor/fix-cli-schema-omission-10a8

codex/audit-hopper-shutdown-reasons-20261021

fix/demangle-swift-omitted-record

fix/nib-boolean-value-types

cursor/cancellation-partial-observation-a5ac

fix/ib-object-limit-reasons

fix/electron-fuse-limit-advice

fix/kuna-doctor-dangling-cache

fix/fixed-budget-refusal-advice

fix/js-ipc-listener-dedup

fix/js-return-member-provenance

fix/dmg-integrity-retry-advice

fix/ida-doctor-readiness

fix/kuna-version-probe-output-drain

fix/legacy-swift-runtime-name-matching

fix/dylib-lazy-load-commands

fix/browser-scenario-startup-cancel

fix/swift-nested-punycode-classification

fix/compare-unselected-scopes

fix/objc-method-budget-coverage

fix/dmg-mounted-root-observations

audit/ci-tests-20261019-round2

release/6.7.0

fix/wabt-cleanup-retry-resolution

fix/electron-fuse-elf-pe-architecture

fix/native-plist-descriptor-ownership

fix/kuna-caller-cleanup-ownership

experiment/atomic-codemode-20261016

review/first-contributor-3776

fix/call-resolution-full-read-cycles

fix/member-mutation-selection-repeat

experiment/atomic-re-tools-20261015

perf/member-mutation-lazy-origins

perf/static-network-mutation-index

fix/hopper-startup-lifecycle

audit/3050-windows-proof-20261015

feat/windows-window-capture-2183

audit/3049-windows-proof-20261015

audit/3735-macos-fixtures-20261015

fix/batch-decompile-null-pseudocode

fix/kuna-inventory-honors-jobs

experiment/browser-codemode-tool-design-20261015

fix/hopper-clean-runtime-argv

codex/review-2049-27f1b367

review-fixes/pr-2787-routing

fix/3360-scoped-this-emitters

fix/3367-replaced-global-effects

fix/3838-compact-any-value-items

test/hopper-download-probe-20261015

codex/windows-runtime-creation-red-green-20261015

codex/windows-readonly-root-red-green-20261015

codex/windows-root-share-red-green-20261015

codex/exp-1685-win-mcp-startup

codex/bug-sweep-20261015

investigate/2190-windows-package-phases

investigate/3543-macos-cli-deadline

perf/3281-reverse-tools-feedback-quality

fix/3406-hopper-doctor-fixture

fix/3341-wrapper-require-test-context

fix/3301-owned-uninstall-fixtures

fix/3164-compiler-input-ownership

fix/pcap-cleanup-stdout-newline-20261014

perf/interface-builder-summary

codex/review-fixes-pr-1977

fix/ghidra-effective-jvm-platform

fix/docs-turkish-rust-link-20261013

fix/main-maintenance-ci-20261010

fix/recover-binary-session-process-effects

codex/review-fixes-pr-2457

codex/ci-required-cancellation-gate

fix/main-format-baseline-20261013

fix/setup-preserve-entry-fields

cursor/restore-main-checks-1ffc

fix/ghidra-bridge-hashmap-import

codex/shared-ci-jadx-json-default-20261013

codex/shared-ci-ghidra-test-groups-20261013

codex/shared-ci-java-fixture-format-20261013

codex/fix-intrinsic-invocation-boundaries

test/release-preflight-reusable-jobs

test/js-parameter-provenance-expectation

fix/linux-hopper-verification-current

test/2419-ghidra-elf-probe-size

followup/pr-1544-native-ida

codex/fold-pr-2230-contribution

docs/readme-responsible-use

fix/issue-2064

fix/issue-2050

fix/issue-2053

fix/issue-1968

fix/issue-1945

experiment/codemode-bridge-20261011

fix/tool-effects-negative-wording-1904-20261012

fix/1842-electron-interop-provenance

feat/recover-javascript-multi-input

refactor/website-i18n-prep

fix/nativeaot-pe-virtual-extent

fix/browser-verifier-ci-hang

fix/pe-resources-input-selection

docs/beginner-friendly-guides

docs/beginner-setup-guide

fix/javascript-analysis-worker-1563

fix/1649-ghidra-duplicate-names

fix/javascript-export-keys-integration-1369

test/maintenance-boundary-contracts-20261011

review/javascript-export-keys-1369

review/process-live-progress-1483

test/javascript-1495-growth-ratio

fix/ci-escape-timing

docs/normalized-terminal-geometry-1450

release/6.3.0

archive/release-6.3.0-pr1381

release/6.2.0

fix/electron-preload-dynamic-override

fix/javascript-self-referential-bundler-edges

release/6.1.0

cursor/grok-client-cherry-pick-0b56

feat/signature-posture

feat/dyld-shared-cache

feat/artifact-integrity-policy

feat/pkg-inventory

release/6.0.0

chore/sync-release-5.0.0

release/5.0.0

cursor/cloud-agent-node-787e

fix/javascript-xhr-open-endpoints

review/pr-711-realpath-fallback-wording

cleanup/replay-confinement

codex/test-suite-performance

codex/issue-foundations

codex/address-open-issues-2026-07-20

agent/javascript-vite-rollup-esbuild-adapters

agent/process-cleanup

agent/triage-integration

agent/unknown-commands-registry

feat/mcp-identity-metadata

morlvps/issue_cleanup

codex/installer-redesign

morl/roadmap-investigation-core

morl/roadmap-investigation-docs

release-please--branches--main--components--rea

rea-agents-6.8.0

rea-agents-6.7.0

rea-agents-6.6.0

experiment/atomic-codemode-wait-runtime-20261016

rea-agents-6.5.0

rea-agents-6.4.0

rea-agents-6.3.0

rea-agents-6.2.0

rea-agents-6.1.0

rea-agents-6.0.0

rea-agents-5.0.0

rea-agents-4.1.0

rea-agents-4.0.1

rea-agents-4.0.0

rea-agents-3.2.1

rea-agents-3.2.0

rea-agents-3.1.0

rea-agents-3.0.0

rea-agents-2.7.0

rea-agents-2.6.0

rea-agents-2.5.1

rea-agents-2.5.0

rea-agents-2.4.0

rea-agents-2.3.0

rea-agents-2.2.0

rea-agents-2.1.0

rea-agents-2.0.0

rea-agents-1.7.0

rea-agents-1.6.0

rea-agents-1.5.0

rea-agents-1.4.0

rea-agents-1.3.0

rea-agents-1.2.0

rea-agents-1.1.0

rea-agents-1.0.0

rea-agents-0.5.0

rea-agents-0.4.0

rea-agents-0.3.0

rea-0.2.1

rea-0.2.0

Labels

Clear labels   

area: bridge

  

area: bridge

  

area: build

  

area: build

  

area: build

  

area: cli

  

area: domain

  

area: evidence

  

area: mcp

  

area: native

  

area: providers

  

area: runtime

  

area: server

  

area: setup

  

area: tests

  

bug

  

design

  

documentation

  

enhancement

  

enhancement

  

enhancement

  

experiment

  

help wanted

  

i18n

  

invalid

  

P0: critical

  

P1: high

  

P2: medium

  

P2: medium

  

P2: medium

  

P3: low

  

performance

  

provider-request

  

pull-request

Mirrored from GitHub Pull Request

  

question

  

roadmap

  

triage

No labels

area: bridge

area: bridge

area: build

area: build

area: build

area: cli

area: domain

area: evidence

area: mcp

area: native

area: providers

area: runtime

area: server

area: setup

area: tests

bug

design

documentation

enhancement

enhancement

enhancement

experiment

help wanted

i18n

invalid

P0: critical

P1: high

P2: medium

P2: medium

P2: medium

P3: low

performance

provider-request

pull-request

question

roadmap

triage

Milestone

Clear milestone

No items

No milestone

Projects

Clear projects

No items

No project

Assignees

Clear assignees

No assignees

1 participant

Notifications

Subscribe

Due date

The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference

morluto/rea#6856

No description provided.