[PR #5305] [CLOSED] docs: add WSL2 fallback hint for ELF targets on Windows Ghidra P0 (#5243) #6869

Closed
opened 2026-11-01 21:43:40 +00:00 by bsakaguchi · 0 comments
Owner

📋 Pull Request Information

Original PR: https://github.com/morluto/rea/pull/5305
Author: @uyg7x
Created: 10/19/2026
Status: ❌ Closed

Base: main ← Head: fix/5243-windows-ghidra-elf-hint


📝 Commits (1)

  • fdc8c2f docs: add WSL2 fallback hint for ELF targets on Windows Ghidra P0 (#5243)

📊 Changes

2 files changed (+17 additions, -1 deletions)

View changed files

📝 docs/windows-ghidra-p0.md (+16 -0)
📝 src/ghidra/GhidraProvider.ts (+1 -1)

📄 Description

Summary

Addresses #5243 by implementing a safe, documentation-first approach to the Windows ELF target gap.

Instead of immediately altering the native DACL security boundaries, this PR:

  1. Updates the target_format_unsupported error message in GhidraProvider.ts to explicitly suggest the WSL2 Ghidra fallback when a user attempts to load an ELF file (like an Android libapp.so) on Windows.
  2. Adds a clear, step-by-step "ELF Targets on Windows" workaround section to docs/windows-ghidra-p0.md.

Why this approach?

As noted in the issue, extending the P0 boundary to ELF requires careful design discussion around native sandboxing. This change provides immediate, actionable value to Windows users hitting this wall, without risking the established security model.

Testing

  • Verified that the TypeScript build completes without errors (npm run build).
  • The new error hint only triggers when target.format === "elf", keeping the error message clean for other unsupported formats.

Let me know if the maintainers would prefer to explore extending the DACL verification to ELF (Option 1) instead, and I am happy to pivot and investigate that path!

Author readiness

Human owner: @uyg7x

  • I reviewed the final diff and relevant existing code, understand the change and its edge cases, and take responsibility for the complete PR, including AI-assisted work.
  • I checked the evidence above, confirmed it supports the current change, and recorded meaningful validation gaps.
  • I declare this PR ready for initial maintainer review.

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/morluto/rea/pull/5305 **Author:** [@uyg7x](https://github.com/uyg7x) **Created:** 10/19/2026 **Status:** ❌ Closed **Base:** `main` ← **Head:** `fix/5243-windows-ghidra-elf-hint` --- ### 📝 Commits (1) - [`fdc8c2f`](https://github.com/morluto/rea/commit/fdc8c2ffc110330f8341f3067aa7c546f2392cc3) docs: add WSL2 fallback hint for ELF targets on Windows Ghidra P0 (#5243) ### 📊 Changes **2 files changed** (+17 additions, -1 deletions) <details> <summary>View changed files</summary> 📝 `docs/windows-ghidra-p0.md` (+16 -0) 📝 `src/ghidra/GhidraProvider.ts` (+1 -1) </details> ### 📄 Description ## Summary Addresses #5243 by implementing a safe, documentation-first approach to the Windows ELF target gap. Instead of immediately altering the native DACL security boundaries, this PR: 1. Updates the `target_format_unsupported` error message in `GhidraProvider.ts` to explicitly suggest the WSL2 Ghidra fallback when a user attempts to load an ELF file (like an Android `libapp.so`) on Windows. 2. Adds a clear, step-by-step "ELF Targets on Windows" workaround section to `docs/windows-ghidra-p0.md`. ## Why this approach? As noted in the issue, extending the P0 boundary to ELF requires careful design discussion around native sandboxing. This change provides immediate, actionable value to Windows users hitting this wall, without risking the established security model. ## Testing - Verified that the TypeScript build completes without errors (`npm run build`). - The new error hint only triggers when `target.format === "elf"`, keeping the error message clean for other unsupported formats. Let me know if the maintainers would prefer to explore extending the DACL verification to ELF (Option 1) instead, and I am happy to pivot and investigate that path! ## Author readiness Human owner: @uyg7x - [x] I reviewed the final diff and relevant existing code, understand the change and its edge cases, and take responsibility for the complete PR, including AI-assisted work. - [x] I checked the evidence above, confirmed it supports the current change, and recorded meaningful validation gaps. - [x] I declare this PR ready for initial maintainer review. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
bsakaguchi 2026-11-01 21:43:40 +00:00
Sign in to join this conversation.
No milestone
No project
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference
morluto/rea#6869
No description provided.