morluto/rea

Fork

You've already forked rea

mirror of https://github.com/morluto/rea.git synced 2026-11-05 06:45:22 +00:00

Code Issues 1.3k Projects Packages Wiki Activity

[PR #5378] [MERGED] feat(analysis-view): add native inventory summaries and pages #6909

New issue

Closed

opened 2026-11-01 21:43:58 +00:00 by bsakaguchi · 0 comments

bsakaguchi commented

2026-11-01 21:43:58 +00:00

Owner

Copy link

📋 Pull Request Information

Original PR: https://github.com/morluto/rea/pull/5378
Author: @gensokyo-dev
Created: 10/20/2026
Status: ✅ Merged
Merged: 10/20/2026
Merged by: @gensokyo-dev

Base: main ← Head: perf/4249-native-inventory-views-20261020

📝 Commits (1)

59bd2d2 feat(analysis-view): add native inventory summaries and pages

📊 Changes

26 files changed (+2545 additions, -217 deletions)

View changed files

📝 .agents/skills/reverse-engineer-anything/references/evidence-workflows.md (+11 -0)
📝 docs/mcp-contracts.md (+42 -0)
📝 experiments/analysis-efficiency/README.md (+5 -0)
➕ experiments/analysis-efficiency/native-inventory-costs.py (+115 -0)
➕ experiments/analysis-efficiency/native-inventory-portable.mjs (+231 -0)
➕ experiments/analysis-efficiency/native-inventory-views.json (+647 -0)
➕ experiments/analysis-efficiency/native-inventory-views.md (+201 -0)
➕ experiments/analysis-efficiency/native-inventory-views.mjs (+374 -0)
📝 src/application/XrefsAddressResolution.ts (+2 -2)
📝 src/application/analysisView/AnalysisViewService.ts (+5 -3)
📝 src/application/native/NativeDispatchMetadataInspection.ts (+3 -3)
📝 src/cli/analysisViewCommands.ts (+1 -1)
📝 src/contracts/analysisViewToolContracts.ts (+17 -1)
📝 src/contracts/officialToolContracts.ts (+19 -10)
📝 src/contracts/toolOutputSchemaGroups.ts (+32 -7)
📝 src/contracts/toolOutputSchemaPrimitives.ts (+0 -28)
📝 src/domain/analysisView/analysisView.ts (+53 -19)
➕ src/domain/analysisView/nativeInventoryView.test.ts (+170 -0)
➕ src/domain/analysisView/nativeInventoryView.ts (+192 -0)
➕ src/domain/native/nativeInventory.ts (+57 -0)

...and 6 more files

📄 Description

Summary

Fixes #4249. Native procedure/name/string inventories can exceed the MCP response budget or flood context when only counts and a few rows are needed. Five existing tools now accept opt-in summaries; inspect_analysis_view returns selected fields and stable pages while preserving complete source Evidence.

Change and scope

Canonical native row semantics live in domain; CLI/MCP share the projector and existing Evidence registration/retention layer.
Default complete responses and original Evidence identities are preserved. Row identity uses parent ID plus source index, including duplicate addresses. String value selection retains decoding qualifications; source/provider/profile/query and unknown discovery coverage remain explicit.
Validated immutable sources reuse format validation without a second retained graph. Oversized complete responses provide a working retained-page continuation.
Existing read-only analysis scope; no new provider, target-execution, injection, mutation or protection-recovery capability. Additional maintainer scope decision is not applicable.

Evidence and validation

Real Ghidra 12.1.4 on Debian true and official jq 1.8.2 completed the count/first-four-row question through production stdio MCP. Actual old Evidence was imported, every row reconstructed, original records reexported unchanged, and 20 actual CLI file-source/MCP comparisons returned identical Evidence. Source artifacts stayed unchanged.

In the frozen 58d-based pairs, including discovery, arguments, replies, retries and export recovery, the cl100k serialization proxy changes 306,496→208,002 (true) and 590,032→208,302 (jq). These are estimates, not actual model usage. The catalog grows ~30 KB and selected delivery adds RPCs. jq warm task time regresses 2.521→6.916 s; both family peaks increase. No general latency/CPU/memory improvement is claimed.

The small pair's complete original Evidence matches exactly. Independent jq analyses vary alias-primary/generated-label observations, so the large pair compares requested facts; old-source full-page equivalence is verified separately. Failed/guard-stopped attempts and resource/coverage limits remain in the measurement record.

npm run test:focused -- … — 24 files / 305 tests passed; exact executed paths are in the receipt.
npm run check — passed, including module/architecture guards.
npm run docs:check — passed.
Post-rebase: 28 files / 325 tests passed, final field-selection rerun 2 files / 9 tests passed; final npm run check and npm run docs:check passed. Both actual old-source CLI/MCP full-page verifiers passed again against the final build.

Final main adds Protobuf schemas: its observed complete 209-tool catalog is 3,317,414 bytes. Earlier fixed-runtime performance samples retain their original pins; final-main timing/token pairs were not rerun.

Linux x86-64 Ghidra metadata workflows are qualified here. Other providers/platforms, actual model-host gains and complete application reconstruction remain unverified. Complete source/export access and unknown-artifact semantics are preserved. Source contracts and authored packaged-skill guidance are updated; ignored generated catalogs/build outputs are not committed.

Latest main synchronization: preserved 4eaf3a117 oversized-error protocol framing. Three affected files/11 tests, real old-source CLI/MCP verification and npm run docs:check passed again. Latest-head pre-push typecheck/lint passed (two tasks).

Author readiness

Human owner: @gensokyo-dev

The owner explicitly dictated these readiness declarations and authorized publication and merge in the working session; they are not inferred from CI or automated review.

I reviewed the final diff and relevant existing code, understand the change and its edge cases, and take responsibility for the complete PR, including AI-assisted work.
I checked the evidence above, confirmed it supports the current change, and recorded meaningful validation gaps.
I declare this PR ready for initial maintainer review.

Before merge

This PR addresses a concrete problem or an agreed enhancement.
Material scope and authority questions are resolved, and any required maintainer scope decision covers the final diff.
The PR has one focused outcome and the title follows type(scope): outcome.
Related issue is linked, or the reason for not linking one is stated above.
Tests cover changed observable behavior and meaningful failure paths.
Owning docs, contracts, and generated metadata are updated where needed.
User-visible CLI/MCP changes include representative output.
I checked the final diff for secrets, unrelated cleanup, and unsupported claims.

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/morluto/rea/pull/5378 **Author:** [@gensokyo-dev](https://github.com/gensokyo-dev) **Created:** 10/20/2026 **Status:** ✅ Merged **Merged:** 10/20/2026 **Merged by:** [@gensokyo-dev](https://github.com/gensokyo-dev) **Base:** `main` ← **Head:** `perf/4249-native-inventory-views-20261020` --- ### 📝 Commits (1) - [`59bd2d2`](https://github.com/morluto/rea/commit/59bd2d2eef93de4ed9e0709f10fb05c52728ce8e) feat(analysis-view): add native inventory summaries and pages ### 📊 Changes **26 files changed** (+2545 additions, -217 deletions) <details> <summary>View changed files</summary> 📝 `.agents/skills/reverse-engineer-anything/references/evidence-workflows.md` (+11 -0) 📝 `docs/mcp-contracts.md` (+42 -0) 📝 `experiments/analysis-efficiency/README.md` (+5 -0) ➕ `experiments/analysis-efficiency/native-inventory-costs.py` (+115 -0) ➕ `experiments/analysis-efficiency/native-inventory-portable.mjs` (+231 -0) ➕ `experiments/analysis-efficiency/native-inventory-views.json` (+647 -0) ➕ `experiments/analysis-efficiency/native-inventory-views.md` (+201 -0) ➕ `experiments/analysis-efficiency/native-inventory-views.mjs` (+374 -0) 📝 `src/application/XrefsAddressResolution.ts` (+2 -2) 📝 `src/application/analysisView/AnalysisViewService.ts` (+5 -3) 📝 `src/application/native/NativeDispatchMetadataInspection.ts` (+3 -3) 📝 `src/cli/analysisViewCommands.ts` (+1 -1) 📝 `src/contracts/analysisViewToolContracts.ts` (+17 -1) 📝 `src/contracts/officialToolContracts.ts` (+19 -10) 📝 `src/contracts/toolOutputSchemaGroups.ts` (+32 -7) 📝 `src/contracts/toolOutputSchemaPrimitives.ts` (+0 -28) 📝 `src/domain/analysisView/analysisView.ts` (+53 -19) ➕ `src/domain/analysisView/nativeInventoryView.test.ts` (+170 -0) ➕ `src/domain/analysisView/nativeInventoryView.ts` (+192 -0) ➕ `src/domain/native/nativeInventory.ts` (+57 -0) _...and 6 more files_ </details> ### 📄 Description ## Summary Fixes #4249. Native procedure/name/string inventories can exceed the MCP response budget or flood context when only counts and a few rows are needed. Five existing tools now accept opt-in summaries; `inspect_analysis_view` returns selected fields and stable pages while preserving complete source Evidence. ## Change and scope - Canonical native row semantics live in domain; CLI/MCP share the projector and existing Evidence registration/retention layer. - Default complete responses and original Evidence identities are preserved. Row identity uses parent ID plus source index, including duplicate addresses. String value selection retains decoding qualifications; source/provider/profile/query and unknown discovery coverage remain explicit. - Validated immutable sources reuse format validation without a second retained graph. Oversized complete responses provide a working retained-page continuation. - Existing read-only analysis scope; no new provider, target-execution, injection, mutation or protection-recovery capability. Additional maintainer scope decision is not applicable. ## Evidence and validation Real Ghidra 12.1.4 on Debian `true` and official jq 1.8.2 completed the count/first-four-row question through production stdio MCP. Actual old Evidence was imported, every row reconstructed, original records reexported unchanged, and 20 actual CLI file-source/MCP comparisons returned identical Evidence. Source artifacts stayed unchanged. In the frozen 58d-based pairs, including discovery, arguments, replies, retries and export recovery, the cl100k serialization proxy changes **306,496→208,002** (`true`) and **590,032→208,302** (jq). These are estimates, not actual model usage. The catalog grows ~30 KB and selected delivery adds RPCs. jq warm task time regresses **2.521→6.916 s**; both family peaks increase. No general latency/CPU/memory improvement is claimed. The small pair's complete original Evidence matches exactly. Independent jq analyses vary alias-primary/generated-label observations, so the large pair compares requested facts; old-source full-page equivalence is verified separately. Failed/guard-stopped attempts and resource/coverage limits remain in the [measurement record](https://github.com/morluto/rea/blob/59bd2d2eef93de4ed9e0709f10fb05c52728ce8e/experiments/analysis-efficiency/native-inventory-views.md). - `npm run test:focused -- …` — 24 files / 305 tests passed; exact executed paths are in the receipt. - `npm run check` — passed, including module/architecture guards. - `npm run docs:check` — passed. - Post-rebase: 28 files / 325 tests passed, final field-selection rerun 2 files / 9 tests passed; final `npm run check` and `npm run docs:check` passed. Both actual old-source CLI/MCP full-page verifiers passed again against the final build. Final main adds Protobuf schemas: its observed complete 209-tool catalog is 3,317,414 bytes. Earlier fixed-runtime performance samples retain their original pins; final-main timing/token pairs were not rerun. Linux x86-64 Ghidra metadata workflows are qualified here. Other providers/platforms, actual model-host gains and complete application reconstruction remain unverified. Complete source/export access and unknown-artifact semantics are preserved. Source contracts and authored packaged-skill guidance are updated; ignored generated catalogs/build outputs are not committed. Latest main synchronization: preserved `4eaf3a117` oversized-error protocol framing. Three affected files/11 tests, real old-source CLI/MCP verification and `npm run docs:check` passed again. Latest-head pre-push typecheck/lint passed (two tasks). ## Author readiness Human owner: @gensokyo-dev The owner explicitly dictated these readiness declarations and authorized publication and merge in the working session; they are not inferred from CI or automated review. - [x] I reviewed the final diff and relevant existing code, understand the change and its edge cases, and take responsibility for the complete PR, including AI-assisted work. - [x] I checked the evidence above, confirmed it supports the current change, and recorded meaningful validation gaps. - [x] I declare this PR ready for initial maintainer review. ## Before merge - [x] This PR addresses a concrete problem or an agreed enhancement. - [x] Material scope and authority questions are resolved, and any required maintainer scope decision covers the final diff. - [x] The PR has one focused outcome and the title follows `type(scope): outcome`. - [x] Related issue is linked, or the reason for not linking one is stated above. - [x] Tests cover changed observable behavior and meaningful failure paths. - [x] Owning docs, contracts, and generated metadata are updated where needed. - [x] User-visible CLI/MCP changes include representative output. - [x] I checked the final diff for secrets, unrelated cleanup, and unsupported claims. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>

bsakaguchi

2026-11-01 21:43:58 +00:00

closed this issue
added the
pull-request
label

bsakaguchi referenced this issue

2026-11-01 21:47:53 +00:00

[PR #6909] [MERGED] docs(website): add dark-mode styles to the favicon and social card #7440

bsakaguchi referenced this issue

2026-11-01 21:47:55 +00:00

[PR #6915] [MERGED] docs(readme): show a dark showcase image on dark themes #7446

No Branch/Tag specified

main

codex/procedure-reference-stacked

release-please--branches--main--components--rea-agents

release-please--branches--main--components--rea-agents--release-notes

codex/kuna-independent-retry

codex/byte-search-overlay-coverage

codex/open-failure-target-receipt

codex/kuna-xref-evidence

codex/ghidra-ambiguous-procedure-recovery

codex/function-source-bundle

codex/trace-function-integration-prototype

codex/snapshot-source-closure

codex/recorded-evidence-array-pages

codex/evidence-recovery-redesign

codex/trace-feature-address-scope

codex/call-discovery-scope

codex/ghidra-literal-candidate-evidence

codex/decompile-directory-independent-retry

codex/retry-provenance-base

codex/value-flow-capability-experiment

codex/ghidra-containing-instruction

cursor/readme-discord-button-ef9f

dependabot/github_actions/actions/setup-node-7.1.0

dependabot/github_actions/actions/upload-artifact-7.0.2

dependabot/npm_and_yarn/npm-minor-and-patch-d8d97ce6df

codex/kuna-1989

fix/8559-native-ui-fixture-ownership

fix/8555-go-verifier-mcp-ownership

codex/provider-capability-recovery

fix/8642-rizin-target-stdin

codex/ghidra-memory-effect-scope

codex/ghidra-annotation-entry-selector

codex/ghidra-readonly-recovery

codex/ghidra-regex-verifier-recovery

codex/evidence-discovery-view-guidance

fix/8545-bulk-append-overflow

fix/8428-navigation-refusal-alternatives

codex/address-context-recovery

codex/matching-member-limitations

codex/unknown-scope-contract

codex/evidence-view-guidance

feat/8373-native-trace-views

codex/ghidra-snapshot-verifier-binding

codex/elf-export-visibility

codex/evidence-view-recovery

codex/native-reference-cli-help

codex/provider-candidate-observation-scope

codex/kuna-session-verification

codex/ghidra-switch-lifetime-guidance

codex/pseudocode-paging-discovery

codex/clarify-evidence-view-support

codex/kuna-xrefs-selector-recovery

codex/context-capacity-recovery

codex/evidence-closure-large-links

codex/same-function-evidence-identity

codex/ghidra-verifier-inspected-jdk

codex/audit-guided-workflows

codex/crash-prompt-retained-dossiers

codex/analysis-view-error-recovery

codex/kuna-verifier-target-selection

codex/ghidra-selected-project-call-coverage

codex/docs-native-analysis-scope

codex/ghidra-java-socket-boundary

codex/ghidra-retained-snapshot-verifier

codex/ghidra-search-inventory-facts

fix/8284-zero-argument-parameter-bindings

fix/8198-ui-action-handler-offset

fix/8257-elf-entry-label-identity

fix/8304-deferred-output-schema-projection

fix/8277-call-path-computed-target-uncertainty

fix/pr-8089-conflicts

fix/ci-static-duplicate-export

dependabot/npm_and_yarn/lint-staged-17.6.0

dependabot/github_actions/actions/download-artifact-8.0.2

dependabot/npm_and_yarn/write-file-atomic-8.0.0

dependabot/npm_and_yarn/canonicalize-5.1.0

dependabot/github_actions/actions/cache/restore-6.1.0

dependabot/npm_and_yarn/toon-format/toon-4.4.0

dependabot/github_actions/actions/deploy-pages-5.0.1

codex/review-fixes-pr-2403

codex/review-fixes-pr-2400

codex/process-terminal-width

codex/test-brittleness-cleanup

verify/7167-browser-connect-macos

fix/7167-browser-connect

feat/native-matching-allowance-setting

feat/browser-scenario-dry-run

test/managed-caller-parameters-20261024

codex/parser-fortythird-boundaries

fix/6926-pinvoke-platform-decorations-20261023

fix/6889-har-body-encoding-20261023

fix/6888-sqlite-schema-budget-20261023

fix/dependency-security-gates-6708

cursor/evidence-overwrite-rebase-b4ac

feat/4057-verify-native-exports

fix/windows-acl-observer-overhead-20261022

cursor/erlang-beam-restack-4476

cursor/pe-certificate-review-bf32

fix/6116-javascript-application-fs-errors

fix/6061-unmapped-runtime-script-unknown

feat/browser-scenario-summary

fix/pe-certificates

codex/verify-3407

cursor/rebase-5699

cursor/rebase-5352

cursor/rebase-5600

cursor/fix-cli-schema-omission-10a8

codex/audit-hopper-shutdown-reasons-20261021

fix/demangle-swift-omitted-record

fix/nib-boolean-value-types

cursor/cancellation-partial-observation-a5ac

fix/ib-object-limit-reasons

fix/electron-fuse-limit-advice

fix/kuna-doctor-dangling-cache

fix/fixed-budget-refusal-advice

fix/js-ipc-listener-dedup

fix/js-return-member-provenance

fix/dmg-integrity-retry-advice

fix/ida-doctor-readiness

fix/kuna-version-probe-output-drain

fix/legacy-swift-runtime-name-matching

fix/dylib-lazy-load-commands

fix/browser-scenario-startup-cancel

fix/swift-nested-punycode-classification

fix/compare-unselected-scopes

fix/objc-method-budget-coverage

fix/dmg-mounted-root-observations

audit/ci-tests-20261019-round2

release/6.7.0

fix/wabt-cleanup-retry-resolution

fix/electron-fuse-elf-pe-architecture

fix/native-plist-descriptor-ownership

fix/kuna-caller-cleanup-ownership

experiment/atomic-codemode-20261016

review/first-contributor-3776

fix/call-resolution-full-read-cycles

fix/member-mutation-selection-repeat

experiment/atomic-re-tools-20261015

perf/member-mutation-lazy-origins

perf/static-network-mutation-index

fix/hopper-startup-lifecycle

audit/3050-windows-proof-20261015

feat/windows-window-capture-2183

audit/3049-windows-proof-20261015

audit/3735-macos-fixtures-20261015

fix/batch-decompile-null-pseudocode

fix/kuna-inventory-honors-jobs

experiment/browser-codemode-tool-design-20261015

fix/hopper-clean-runtime-argv

codex/review-2049-27f1b367

review-fixes/pr-2787-routing

fix/3360-scoped-this-emitters

fix/3367-replaced-global-effects

fix/3838-compact-any-value-items

test/hopper-download-probe-20261015

codex/windows-runtime-creation-red-green-20261015

codex/windows-readonly-root-red-green-20261015

codex/windows-root-share-red-green-20261015

codex/exp-1685-win-mcp-startup

codex/bug-sweep-20261015

investigate/2190-windows-package-phases

investigate/3543-macos-cli-deadline

perf/3281-reverse-tools-feedback-quality

fix/3406-hopper-doctor-fixture

fix/3341-wrapper-require-test-context

fix/3301-owned-uninstall-fixtures

fix/3164-compiler-input-ownership

fix/pcap-cleanup-stdout-newline-20261014

perf/interface-builder-summary

codex/review-fixes-pr-1977

fix/ghidra-effective-jvm-platform

fix/docs-turkish-rust-link-20261013

fix/main-maintenance-ci-20261010

fix/recover-binary-session-process-effects

codex/review-fixes-pr-2457

codex/ci-required-cancellation-gate

fix/main-format-baseline-20261013

fix/setup-preserve-entry-fields

cursor/restore-main-checks-1ffc

fix/ghidra-bridge-hashmap-import

codex/shared-ci-jadx-json-default-20261013

codex/shared-ci-ghidra-test-groups-20261013

codex/shared-ci-java-fixture-format-20261013

codex/fix-intrinsic-invocation-boundaries

test/release-preflight-reusable-jobs

test/js-parameter-provenance-expectation

fix/linux-hopper-verification-current

test/2419-ghidra-elf-probe-size

followup/pr-1544-native-ida

codex/fold-pr-2230-contribution

docs/readme-responsible-use

fix/issue-2064

fix/issue-2050

fix/issue-2053

fix/issue-1968

fix/issue-1945

experiment/codemode-bridge-20261011

fix/tool-effects-negative-wording-1904-20261012

fix/1842-electron-interop-provenance

feat/recover-javascript-multi-input

refactor/website-i18n-prep

fix/nativeaot-pe-virtual-extent

fix/browser-verifier-ci-hang

fix/pe-resources-input-selection

docs/beginner-friendly-guides

docs/beginner-setup-guide

fix/javascript-analysis-worker-1563

fix/1649-ghidra-duplicate-names

fix/javascript-export-keys-integration-1369

test/maintenance-boundary-contracts-20261011

review/javascript-export-keys-1369

review/process-live-progress-1483

test/javascript-1495-growth-ratio

fix/ci-escape-timing

docs/normalized-terminal-geometry-1450

release/6.3.0

archive/release-6.3.0-pr1381

release/6.2.0

fix/electron-preload-dynamic-override

fix/javascript-self-referential-bundler-edges

release/6.1.0

cursor/grok-client-cherry-pick-0b56

feat/signature-posture

feat/dyld-shared-cache

feat/artifact-integrity-policy

feat/pkg-inventory

release/6.0.0

chore/sync-release-5.0.0

release/5.0.0

cursor/cloud-agent-node-787e

fix/javascript-xhr-open-endpoints

review/pr-711-realpath-fallback-wording

cleanup/replay-confinement

codex/test-suite-performance

codex/issue-foundations

codex/address-open-issues-2026-07-20

agent/javascript-vite-rollup-esbuild-adapters

agent/process-cleanup

agent/triage-integration

agent/unknown-commands-registry

feat/mcp-identity-metadata

morlvps/issue_cleanup

codex/installer-redesign

morl/roadmap-investigation-core

morl/roadmap-investigation-docs

release-please--branches--main--components--rea

rea-agents-6.8.0

rea-agents-6.7.0

rea-agents-6.6.0

experiment/atomic-codemode-wait-runtime-20261016

rea-agents-6.5.0

rea-agents-6.4.0

rea-agents-6.3.0

rea-agents-6.2.0

rea-agents-6.1.0

rea-agents-6.0.0

rea-agents-5.0.0

rea-agents-4.1.0

rea-agents-4.0.1

rea-agents-4.0.0

rea-agents-3.2.1

rea-agents-3.2.0

rea-agents-3.1.0

rea-agents-3.0.0

rea-agents-2.7.0

rea-agents-2.6.0

rea-agents-2.5.1

rea-agents-2.5.0

rea-agents-2.4.0

rea-agents-2.3.0

rea-agents-2.2.0

rea-agents-2.1.0

rea-agents-2.0.0

rea-agents-1.7.0

rea-agents-1.6.0

rea-agents-1.5.0

rea-agents-1.4.0

rea-agents-1.3.0

rea-agents-1.2.0

rea-agents-1.1.0

rea-agents-1.0.0

rea-agents-0.5.0

rea-agents-0.4.0

rea-agents-0.3.0

rea-0.2.1

rea-0.2.0

Labels

Clear labels

Mirrored from GitHub Pull Request

No labels

Milestone

Clear milestone

No items

No milestone

Projects

Clear projects

No items

No project

Assignees

Clear assignees

No assignees

1 participant

Notifications

Due date

The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference

morluto/rea#6909

Reference in a new issue

Repository

morluto/rea

Title

Body

No description provided.

Delete branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?

Rows
Columns