[PR #5410] [CLOSED] fix(objdump): scope debug-link caveat to DWARF #6922

Closed
opened 2026-11-01 21:44:05 +00:00 by bsakaguchi · 0 comments
Owner

📋 Pull Request Information

Original PR: https://github.com/morluto/rea/pull/5410
Author: @Tapraj-Pathak
Created: 10/20/2026
Status: ❌ Closed

Base: main ← Head: fix/objdump-dwarf-debug-link-warning


📝 Commits (3)

  • 969a7bb fix(objdump): scope debug-link warning to DWARF
  • 4024cbe Merge branch 'main' into fix/objdump-dwarf-debug-link-warning
  • bc2f32e fix(objdump): preserve symbol scope limitation

📊 Changes

2 files changed (+48 additions, -0 deletions)

View changed files

📝 src/application/reverse/ReverseEngineeringService.ts (+1 -0)
📝 tests/support/reverseEngineeringCompositionEdgeCases.ts (+47 -0)

📄 Description

Summary

Correct GNU objdump Evidence limitations: include the external debug-link identity caveat only for DWARF inspection when following links is enabled, while preserving the separate caveat for caller-selected symbol disassembly.

Problem and expected behavior

follow_debug_links applies to DWARF; enabling it for another objdump operation must not imply that operation used external debug-link files. A merge conflict also commented out the selected-symbol disassembly limitation. Symbol-specific disassembly examines only that symbol, so an empty result must not be presented as proof of artifact-wide absence.

This addresses the review thread on PR #5410; no separate issue is linked.

Change and scope

Keep the two Evidence limitation branches independent: the symbol caveat is conditioned on a selected symbol, and the debug-link caveat is conditioned on operation: "dwarf" and follow_debug_links: true. Existing regressions cover both conditions. Provider invocation, artifact identity, and CLI/MCP input and output contracts are unchanged.

Follow the contribution scope.
Unresolved scope, authority, side effects, or required verification block
integration. Link the required maintainer scope decision for new providers or
capabilities involving target execution, injection, mutation, or protection
recovery; ordinary fixes within existing boundaries may state "not applicable".
Draft PRs may leave the scope decision pending and the readiness and merge checklists
unchecked. Maintainers can help resolve open questions.

Contract and boundary impact

  • Semantic owner and earliest changed stage: ReverseEngineeringService when assembling objdump Evidence limitations.
  • Contribution scope fit and linked maintainer decision: Ordinary bug fix within the existing GNU objdump workflow; maintainer scope decision not applicable.
  • CLI and MCP/tool-catalog contract: No input schema, tool catalog, or output schema changes; limitation applicability is corrected.
  • Provider, bridge, target-format, or platform compatibility: GNU objdump command arguments and provider requirements are unchanged.
  • Evidence, artifact, provenance, or reconstruction contract: Preserve the selected-symbol caveat and report the debug-link identity caveat only for applicable DWARF output.
  • Target selection, authority, upstream behavior, and cleanup details (if applicable): The caller-selected artifact and existing provider process are unchanged; no target execution, injection, mutation, or protection recovery is added.
  • Generated metadata (docs/public/product-catalog.json), package, or installation impact (CI generates and validates ignored catalogs and skills/; edit authored instructions in .agents/skills/reverse-engineer-anything/ and never commit build outputs): None.

Expected effects (check known effects; use documentation-only on its own).
Unchecked items do not establish absence; leave uncertainties visible.

  • Read existing files or captured data.
  • Launch or attach to a process.
  • Inject instrumentation or run scripts/code.
  • Change process memory, registers, files, or configuration.
  • Contact network services.
  • Recover protected code or work around protections.
  • Documentation or usability only; no target interaction.
  • Not sure yet; investigation or maintainer guidance needed.

Evidence and regression coverage

  • Tests added or updated: The existing objdumpSelectedDisassembly.test.ts assertion checks the selected-symbol caveat. The parameterized reverseEngineeringCompositionEdgeCases.test.ts cases verify that six non-DWARF operations do not report the DWARF caveat when follow_debug_links is true.
  • Base reproduction or other evidence: On merge commit 4024cbea, the conflict markers commented out the symbol-warning branch and the DWARF condition was not limited to the dwarf operation. The prior CI run reported 11 failed tests, including the six non-DWARF cases.
  • User-visible CLI/MCP output (if applicable): No schema change. Selected-symbol Evidence retains “Disassembly is scoped to the caller-selected symbol using the provider's matching and symbol-boundary semantics; an empty match does not establish artifact-wide absence.” The debug-link caveat appears only for applicable DWARF Evidence.
  • Remaining proof gaps: No real GNU objdump run was performed. Hosted checks on the latest head were still running when last checked. Local TypeScript checks are blocked by missing @bufbuild/protobuf dependencies.

For evidence-bearing changes:

  • Observed, derived, and inferred claims remain distinguishable.
  • Artifact identity, source provenance, and failed attempts remain preserved.
  • Unsupported, incomplete, unavailable, or uncertain outcomes remain visible.

Validation performed

  • node_modules/.bin/vitest.cmd run --project composition tests/composition/objdumpSelectedDisassembly.test.ts tests/composition/reverseEngineeringEdgeCases.test.ts — passed; 97 tests across both files.
  • node_modules/.bin/oxfmt.cmd --check src/application/reverse/ReverseEngineeringService.ts — passed.
  • node_modules/.bin/tsc.cmd --noEmit — blocked by missing @bufbuild/protobuf imports in unrelated files.
  • git diff --check — passed.
  • Hosted checks for the latest PR head — in progress when last checked; author readiness still requires the human declaration below.

Compatibility, safety, and release

  • Breaking changes or migration steps: None.
  • Real Hopper/Ghidra, browser, or OS coverage: Not applicable; this is an objdump Evidence limitation fix. No real-provider run was performed.
  • Package or release metadata impact: None.
  • Security, privacy, process, or containment review: No authority or process behavior changes; the existing objdump workflow remains caller-selected and local.

Author readiness

Human owner:

Human owner:

  • I reviewed the final diff and relevant existing code, understand the change and its edge cases, and take responsibility for the complete PR, including AI-assisted work.
  • I checked the evidence above, confirmed it supports the current change, and recorded meaningful validation gaps.
  • I declare this PR ready for initial maintainer review.

Before merge

  • This PR addresses a concrete problem or an agreed enhancement.
  • Material scope and authority questions are resolved, and any required maintainer scope decision covers the final diff.
  • The PR has one focused outcome and the title follows type(scope): outcome.
  • Related issue is linked, or the reason for not linking one is stated above.
  • Tests cover changed observable behavior and meaningful failure paths.
  • Owning docs, contracts, and generated metadata are updated where needed.
  • User-visible CLI/MCP changes include representative output.
  • I checked the final diff for secrets, unrelated cleanup, and unsupported claims.

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/morluto/rea/pull/5410 **Author:** [@Tapraj-Pathak](https://github.com/Tapraj-Pathak) **Created:** 10/20/2026 **Status:** ❌ Closed **Base:** `main` ← **Head:** `fix/objdump-dwarf-debug-link-warning` --- ### 📝 Commits (3) - [`969a7bb`](https://github.com/morluto/rea/commit/969a7bb1b9f7951b88be505d5281e0cd6c7a91b2) fix(objdump): scope debug-link warning to DWARF - [`4024cbe`](https://github.com/morluto/rea/commit/4024cbea615af0fe66c59548c86922d0f78d846e) Merge branch 'main' into fix/objdump-dwarf-debug-link-warning - [`bc2f32e`](https://github.com/morluto/rea/commit/bc2f32ee12a68b920a925fabcfede2dc50138b9d) fix(objdump): preserve symbol scope limitation ### 📊 Changes **2 files changed** (+48 additions, -0 deletions) <details> <summary>View changed files</summary> 📝 `src/application/reverse/ReverseEngineeringService.ts` (+1 -0) 📝 `tests/support/reverseEngineeringCompositionEdgeCases.ts` (+47 -0) </details> ### 📄 Description <!-- PR title: type(optional-scope): imperative outcome The title becomes the squash-merge commit subject and generated changelog entry. --> ## Summary Correct GNU objdump Evidence limitations: include the external debug-link identity caveat only for DWARF inspection when following links is enabled, while preserving the separate caveat for caller-selected symbol disassembly. ## Problem and expected behavior `follow_debug_links` applies to DWARF; enabling it for another objdump operation must not imply that operation used external debug-link files. A merge conflict also commented out the selected-symbol disassembly limitation. Symbol-specific disassembly examines only that symbol, so an empty result must not be presented as proof of artifact-wide absence. This addresses the review thread on [PR #5410](https://github.com/morluto/rea/pull/5410#discussion_r4323699845); no separate issue is linked. ## Change and scope Keep the two Evidence limitation branches independent: the symbol caveat is conditioned on a selected symbol, and the debug-link caveat is conditioned on `operation: "dwarf"` and `follow_debug_links: true`. Existing regressions cover both conditions. Provider invocation, artifact identity, and CLI/MCP input and output contracts are unchanged. Follow the [contribution scope](https://github.com/morluto/rea/blob/main/CONTRIBUTING.md#contribution-scope). Unresolved scope, authority, side effects, or required verification block integration. Link the required maintainer scope decision for new providers or capabilities involving target execution, injection, mutation, or protection recovery; ordinary fixes within existing boundaries may state "not applicable". Draft PRs may leave the scope decision pending and the readiness and merge checklists unchecked. Maintainers can help resolve open questions. ## Contract and boundary impact <!-- Short answers are welcome. Complete applicable lines; mark unresolved facts as "unknown". Use "none" or "not applicable" only when established. --> - Semantic owner and earliest changed stage: `ReverseEngineeringService` when assembling objdump Evidence limitations. - Contribution scope fit and linked maintainer decision: Ordinary bug fix within the existing GNU objdump workflow; maintainer scope decision not applicable. - CLI and MCP/tool-catalog contract: No input schema, tool catalog, or output schema changes; limitation applicability is corrected. - Provider, bridge, target-format, or platform compatibility: GNU objdump command arguments and provider requirements are unchanged. - Evidence, artifact, provenance, or reconstruction contract: Preserve the selected-symbol caveat and report the debug-link identity caveat only for applicable DWARF output. - Target selection, authority, upstream behavior, and cleanup details (if applicable): The caller-selected artifact and existing provider process are unchanged; no target execution, injection, mutation, or protection recovery is added. - Generated metadata (`docs/public/product-catalog.json`), package, or installation impact (CI generates and validates ignored catalogs and `skills/`; edit authored instructions in `.agents/skills/reverse-engineer-anything/` and never commit build outputs): None. Expected effects (check known effects; use documentation-only on its own). Unchecked items do not establish absence; leave uncertainties visible. - [x] Read existing files or captured data. - [x] Launch or attach to a process. - [x] Inject instrumentation or run scripts/code. - [x] Change process memory, registers, files, or configuration. - [x] Contact network services. - [x] Recover protected code or work around protections. - [x] Documentation or usability only; no target interaction. - [x] Not sure yet; investigation or maintainer guidance needed. ## Evidence and regression coverage <!-- State whether evidence is executed, source-derived, or proposed. For fixes, show the original failure and explain how the regression would fail on the affected base revision when practical. Include the most useful proof inline; link long logs or artifacts, or put them in optional details. Documentation-only changes can use source, link, or rendered-document checks. --> - Tests added or updated: The existing `objdumpSelectedDisassembly.test.ts` assertion checks the selected-symbol caveat. The parameterized `reverseEngineeringCompositionEdgeCases.test.ts` cases verify that six non-DWARF operations do not report the DWARF caveat when `follow_debug_links` is true. - Base reproduction or other evidence: On merge commit `4024cbea`, the conflict markers commented out the symbol-warning branch and the DWARF condition was not limited to the `dwarf` operation. The prior CI run reported 11 failed tests, including the six non-DWARF cases. - User-visible CLI/MCP output (if applicable): No schema change. Selected-symbol Evidence retains “Disassembly is scoped to the caller-selected symbol using the provider's matching and symbol-boundary semantics; an empty match does not establish artifact-wide absence.” The debug-link caveat appears only for applicable DWARF Evidence. - Remaining proof gaps: No real GNU objdump run was performed. Hosted checks on the latest head were still running when last checked. Local TypeScript checks are blocked by missing `@bufbuild/protobuf` dependencies. For evidence-bearing changes: - [x] Observed, derived, and inferred claims remain distinguishable. - [x] Artifact identity, source provenance, and failed attempts remain preserved. - [x] Unsupported, incomplete, unavailable, or uncertain outcomes remain visible. ## Validation performed <!-- List only commands that actually ran, with observed results. Include the relevant real-provider or platform workflow, or explain why it was unavailable. Keep these results current after changes; a command without its result is incomplete. --> - `node_modules/.bin/vitest.cmd run --project composition tests/composition/objdumpSelectedDisassembly.test.ts tests/composition/reverseEngineeringEdgeCases.test.ts` — passed; 97 tests across both files. - `node_modules/.bin/oxfmt.cmd --check src/application/reverse/ReverseEngineeringService.ts` — passed. - `node_modules/.bin/tsc.cmd --noEmit` — blocked by missing `@bufbuild/protobuf` imports in unrelated files. - `git diff --check` — passed. - Hosted checks for the latest PR head — in progress when last checked; author readiness still requires the human declaration below. ## Compatibility, safety, and release <!-- Call out breaking changes, migrations, package effects, platform/provider limits, security/privacy/containment implications, and meaningful proof gaps. --> - Breaking changes or migration steps: None. <!-- For ! / BREAKING CHANGE: show a previously valid call/configuration, its new behavior and migration, and why compatibility/deprecation cannot preserve it. Every release increments minor, including breaking changes; keep breaking markers and migration notes so callers can assess compatibility. See docs/releasing.md. --> - Real Hopper/Ghidra, browser, or OS coverage: Not applicable; this is an objdump Evidence limitation fix. No real-provider run was performed. - Package or release metadata impact: None. - Security, privacy, process, or containment review: No authority or process behavior changes; the existing objdump workflow remains caller-selected and local. ## Author readiness Human owner: <!-- @Tapraj-Pathak --> <!-- The human owner completes these declarations before requesting review. The PR author is the owner by default. A different owner must explicitly accept ownership on this PR. AI agents must leave these declarations to a human to dictate to them or there could be catastrophic consequences for many users of REA. Draft PRs may leave them unchecked. These declarations record initial readiness when opening the PR for review; later pushes do not require a new human sign-off. Keep the description and validation evidence current as the work changes. See CONTRIBUTING.md#pull-request-ownership-and-readiness. --> Human owner: <!-- @Tapraj-Pathak --> - [x] I reviewed the final diff and relevant existing code, understand the change and its edge cases, and take responsibility for the complete PR, including AI-assisted work. - [x] I checked the evidence above, confirmed it supports the current change, and recorded meaningful validation gaps. - [x] I declare this PR ready for initial maintainer review. ## Before merge <!-- Draft PRs may leave pending items unchecked. Resolve material scope and authority questions before integration. --> - [x] This PR addresses a concrete problem or an agreed enhancement. - [x] Material scope and authority questions are resolved, and any required maintainer scope decision covers the final diff. - [x] The PR has one focused outcome and the title follows `type(scope): outcome`. - [x] Related issue is linked, or the reason for not linking one is stated above. - [x] Tests cover changed observable behavior and meaningful failure paths. - [x] Owning docs, contracts, and generated metadata are updated where needed. - [x] User-visible CLI/MCP changes include representative output. - [x] I checked the final diff for secrets, unrelated cleanup, and unsupported claims. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
bsakaguchi 2026-11-01 21:44:05 +00:00
Sign in to join this conversation.
No milestone
No project
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference
morluto/rea#6922
No description provided.