[PR #5478] [CLOSED] test(managed): retain repeated member-site coverage #6937

Closed
opened 2026-11-01 21:44:11 +00:00 by bsakaguchi · 0 comments
Owner

📋 Pull Request Information

Original PR: https://github.com/morluto/rea/pull/5478
Author: @xu91102
Created: 10/20/2026
Status: ❌ Closed

Base: main ← Head: codex/managed-cil-site-offsets


📝 Commits (10+)

  • 668c057 feat(managed): retain CIL offsets on member access sites
  • f248b0d chore(managed): integrate main and retain CIL site regressions
  • 4b58ece test(managed): retain member-site regressions after main adoption
  • b39b1c8 chore(managed): reverse incidental merge hook changes
  • 8e79e8e test(managed): retain reviewed member-site coverage
  • 84aa8a7 test(snapshot): use canonical native name inventory
  • 1130fc8 chore(managed): integrate main snapshot fixture
  • 6329bc8 test(native): use canonical XML for plist fixtures
  • 68c6ce1 chore(managed): integrate canonical main plist fixtures
  • b8da746 chore(managed): reverse incidental merge hook changes

📊 Changes

4 files changed (+70 additions, -0 deletions)

View changed files

📝 src/dotnet/ManagedMemberInspector.test.ts (+15 -0)
📝 tests/acceptance/managedCliOutput.test.ts (+50 -0)
📝 tests/boundary/cli/nativePlistCli.test.ts (+1 -0)
📝 tests/boundary/mcp/managedMcp.test.ts (+4 -0)

📄 Description

Summary

Fixes #5151 with regression coverage for repeated managed member sites. Main's producer and nullable offset schema remain authoritative. Three test files add69 lines for call offsets6/11, field offsets1/16, empty results and retained MCP pages; historical missing offsets stay null.

Preserve main's nominal identities, malformed-prefix handling, budgets, paging, partial results and cleanup. No parallel managed producer, schema or decoder is introduced.

Current CI repair

An ordinary local merge incorporates main d87e73f2db50be72d33a4b3c7199af35518b441c after GitHub reported the actual new Webpack-file conflict. This main differs from the preceding integrated b5c by exactly one test file: gensokyo-dev's #6951 executes the exact registered bundle and invokes its factory with the loader. Keep that complete canonical file, normally removing our redundant oracle implementation. All original Node/static keys and values, computed-name, alias, prototype, default and CLI/MCP equality assertions remain; production parameter-role guards and rebound-loader refusals are unchanged. Main's #6945 launcher/package/plist/unit fixes and Kaoru0822's authorship/history also remain. No own-source adoption credit is claimed.

Validation

  • The final changed public file freshly passes 37 tests on each worktree. Replace its previous37 within the preceding focused group, retaining all other byte-identical inputs: 555 PASS/24 distinct files/2 existing Windows skips, including the previous unchanged README9. This is a deduplicated total, not a fresh rerun of the whole group. Older groups, probes and runtime calls are not accumulated.
  • Fresh full check: 6 successful tasks/2 cached,0 errors. Previous docs/discovery/pack/installed-verifier results retain identical inputs; they were not rerun for this one-test-file merge. Discovery was 2332 files exactly once.
  • The preceding freshly integrated b5c package verifier observed 222 tools/6 prompts, exact update, verified lineage and awaited cleanup. Current/archive/installed 2296 product files and tarball 972c59dbb34e61d3647840a8256467ccad7de01b305bc972b43e864ca3ad1deb are rechecked byte-identical after this test-only merge, including the CLI environment owner.
  • Feature runtime on those same product bytes: four compiled/installed CLI controls and one installed stdio MCP session/five calls, verifying repeated offsets, retained pages, empty results, unchanged inputs and awaited cleanup. No new dedicated feature CLI/MCP/reader sessions were run after this final test-only change. Previous b5c runtime was fresh; old f326 runtime is not transferred.
  • Independent frozen Standards/Spec: PASS/PASS. Normal hooks and complete source/index/gitlink/evidence/package gates pass before push and after push. Current head 5ae4ed2671020d6c867a5738662fbc8e24c6be34.

Verification limits

New-head code CI and Codex are tracked separately; local acceptance is not remote approval. Full Hermes agent/model/stdio-client, external peers, CLR/ILSpy/native engines, real applications, full other-host local workflows and performance remain NOT RUN beyond named bounded controls. REA MCP/configuration reading is not complete Hermes-client execution. No performance improvement or new independent PR is claimed.

The initial5478 package-cleanup failure remains recorded with unknown cause and retained workspace. A later independent verifier PASS does not erase or resolve that original boundary.

Author readiness

Human owner: @xu91102

  • I reviewed the final diff and relevant existing code, understand the change and its edge cases, and take responsibility for the complete PR, including AI-assisted work.
  • I checked the evidence above, confirmed it supports the current change, and recorded meaningful validation gaps.
  • I declare this PR ready for initial maintainer review.

Before merge

  • This PR addresses a concrete problem or an agreed enhancement.
  • Material scope and authority questions are resolved, and any required maintainer scope decision covers the final diff.
  • The PR has one focused outcome and the title follows type(scope): outcome.
  • Related issue is linked, or the reason for not linking one is stated above.
  • Tests cover changed observable behavior and meaningful failure paths.
  • Owning docs, contracts, and generated metadata are updated where needed.
  • User-visible CLI/MCP changes include representative output.
  • I checked the final diff for secrets, unrelated cleanup, and unsupported claims.

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/morluto/rea/pull/5478 **Author:** [@xu91102](https://github.com/xu91102) **Created:** 10/20/2026 **Status:** ❌ Closed **Base:** `main` ← **Head:** `codex/managed-cil-site-offsets` --- ### 📝 Commits (10+) - [`668c057`](https://github.com/morluto/rea/commit/668c0574902a4f50f9b315de2ef89653288a3472) feat(managed): retain CIL offsets on member access sites - [`f248b0d`](https://github.com/morluto/rea/commit/f248b0d214b83e2018a95677051d678875255500) chore(managed): integrate main and retain CIL site regressions - [`4b58ece`](https://github.com/morluto/rea/commit/4b58ece1d250e466d79432ecd249d2b4cf51a3a5) test(managed): retain member-site regressions after main adoption - [`b39b1c8`](https://github.com/morluto/rea/commit/b39b1c89ee61fcdf0030bbd8b848aedea19567d1) chore(managed): reverse incidental merge hook changes - [`8e79e8e`](https://github.com/morluto/rea/commit/8e79e8eb14e1fbcc567ebe61d68566c8ab1c2c1c) test(managed): retain reviewed member-site coverage - [`84aa8a7`](https://github.com/morluto/rea/commit/84aa8a7bef8ca7e6879627d586e10d7008b331ed) test(snapshot): use canonical native name inventory - [`1130fc8`](https://github.com/morluto/rea/commit/1130fc801c5b6b785eb2a5b312117881bf8d10d3) chore(managed): integrate main snapshot fixture - [`6329bc8`](https://github.com/morluto/rea/commit/6329bc85413f1395df063a0035440316e301f65c) test(native): use canonical XML for plist fixtures - [`68c6ce1`](https://github.com/morluto/rea/commit/68c6ce1700dc97483c2b916cdb1e19a77ea23b89) chore(managed): integrate canonical main plist fixtures - [`b8da746`](https://github.com/morluto/rea/commit/b8da746b0e282d89a7e606c66152b3b757e1ebce) chore(managed): reverse incidental merge hook changes ### 📊 Changes **4 files changed** (+70 additions, -0 deletions) <details> <summary>View changed files</summary> 📝 `src/dotnet/ManagedMemberInspector.test.ts` (+15 -0) 📝 `tests/acceptance/managedCliOutput.test.ts` (+50 -0) 📝 `tests/boundary/cli/nativePlistCli.test.ts` (+1 -0) 📝 `tests/boundary/mcp/managedMcp.test.ts` (+4 -0) </details> ### 📄 Description ## Summary Fixes #5151 with regression coverage for repeated managed member sites. Main's producer and nullable offset schema remain authoritative. Three test files add69 lines for call offsets6/11, field offsets1/16, empty results and retained MCP pages; historical missing offsets stay null. Preserve main's nominal identities, malformed-prefix handling, budgets, paging, partial results and cleanup. No parallel managed producer, schema or decoder is introduced. ## Current CI repair An ordinary local merge incorporates main `d87e73f2db50be72d33a4b3c7199af35518b441c` after GitHub reported the actual new Webpack-file conflict. This main differs from the preceding integrated b5c by exactly one test file: gensokyo-dev's #6951 executes the exact registered bundle and invokes its factory with the loader. Keep that **complete canonical file**, normally removing our redundant oracle implementation. All original Node/static keys and values, computed-name, alias, prototype, default and CLI/MCP equality assertions remain; production parameter-role guards and rebound-loader refusals are unchanged. Main's #6945 launcher/package/plist/unit fixes and Kaoru0822's authorship/history also remain. No own-source adoption credit is claimed. ## Validation - The final changed public file freshly passes **37 tests on each worktree**. Replace its previous37 within the preceding focused group, retaining all other byte-identical inputs: **555 PASS/24 distinct files/2 existing Windows skips**, including the previous unchanged README9. This is a deduplicated total, **not a fresh rerun of the whole group**. Older groups, probes and runtime calls are not accumulated. - Fresh full check: 6 successful tasks/2 cached,0 errors. Previous docs/discovery/pack/installed-verifier results retain identical inputs; they were not rerun for this one-test-file merge. Discovery was 2332 files exactly once. - The preceding freshly integrated b5c package verifier observed **222 tools/6 prompts**, exact update, verified lineage and awaited cleanup. Current/archive/installed **2296 product files** and tarball `972c59dbb34e61d3647840a8256467ccad7de01b305bc972b43e864ca3ad1deb` are rechecked byte-identical after this test-only merge, including the CLI environment owner. - Feature runtime on those same product bytes: four compiled/installed CLI controls and one installed stdio MCP session/five calls, verifying repeated offsets, retained pages, empty results, unchanged inputs and awaited cleanup. No new dedicated feature CLI/MCP/reader sessions were run after this final test-only change. Previous b5c runtime was fresh; old f326 runtime is not transferred. - Independent frozen Standards/Spec: PASS/PASS. Normal hooks and complete source/index/gitlink/evidence/package gates pass before push and after push. Current head `5ae4ed2671020d6c867a5738662fbc8e24c6be34`. ## Verification limits New-head code CI and Codex are tracked separately; local acceptance is not remote approval. Full Hermes agent/model/stdio-client, external peers, CLR/ILSpy/native engines, real applications, full other-host local workflows and performance remain NOT RUN beyond named bounded controls. REA MCP/configuration reading is not complete Hermes-client execution. No performance improvement or new independent PR is claimed. The initial5478 package-cleanup failure remains recorded with unknown cause and retained workspace. A later independent verifier PASS does not erase or resolve that original boundary. ## Author readiness <!-- The human owner completes these declarations before requesting review. The PR author is the owner by default. A different owner must explicitly accept ownership on this PR. AI agents must leave these declarations to a human to dictate to them or there could be catastrophic consequences for many users of REA. Draft PRs may leave them unchecked. These declarations record initial readiness when opening the PR for review; later pushes do not require a new human sign-off. Keep the description and validation evidence current as the work changes. See CONTRIBUTING.md#pull-request-ownership-and-readiness. --> Human owner: @xu91102 - [x] I reviewed the final diff and relevant existing code, understand the change and its edge cases, and take responsibility for the complete PR, including AI-assisted work. - [x] I checked the evidence above, confirmed it supports the current change, and recorded meaningful validation gaps. - [x] I declare this PR ready for initial maintainer review. ## Before merge <!-- Draft PRs may leave pending items unchecked. Resolve material scope and authority questions before integration. --> - [ ] This PR addresses a concrete problem or an agreed enhancement. - [ ] Material scope and authority questions are resolved, and any required maintainer scope decision covers the final diff. - [ ] The PR has one focused outcome and the title follows `type(scope): outcome`. - [ ] Related issue is linked, or the reason for not linking one is stated above. - [ ] Tests cover changed observable behavior and meaningful failure paths. - [ ] Owning docs, contracts, and generated metadata are updated where needed. - [ ] User-visible CLI/MCP changes include representative output. - [ ] I checked the final diff for secrets, unrelated cleanup, and unsupported claims. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
bsakaguchi 2026-11-01 21:44:11 +00:00
Sign in to join this conversation.
No milestone
No project
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference
morluto/rea#6937
No description provided.