morluto/rea

Fork

You've already forked rea

mirror of https://github.com/morluto/rea.git synced 2026-11-05 06:45:22 +00:00

Code Issues 1.3k Projects Packages Wiki Activity

[PR #5497] [MERGED] test: stabilize worker cancellation and trailer regressions #6939

New issue

Closed

opened 2026-11-01 21:44:11 +00:00 by bsakaguchi · 0 comments

bsakaguchi commented

2026-11-01 21:44:11 +00:00

Owner

Copy link

📋 Pull Request Information

Original PR: https://github.com/morluto/rea/pull/5497
Author: @gensokyo-dev
Created: 10/20/2026
Status: ✅ Merged
Merged: 10/20/2026
Merged by: @gensokyo-dev

Base: main ← Head: audit/ci-tests-20261020-round5

📝 Commits (9)

6818ad7 test(browser): deduplicate attached session scenarios
4182fb2 chore: update CI recovery branch to latest main
d097c3e fix(evm): preserve cancellation after runtime-root cleanup
96cd237 fix(javascript): order initializers through export declarations
bf48de0 test: align path diagnostics and split trailer regressions
5ebeb58 test(javascript): make worker cancellation order deterministic
52219e7 chore: refresh CI recovery against current main
1360a90 chore: retain upstream fixes while refreshing the CI audit
086cb86 test(javascript): defer frame observers until runtime adoption

📊 Changes

5 files changed (+173 additions, -76 deletions)

View changed files

📝 src/cliJsonPaths.test.ts (+2 -0)
📝 tests/acceptance/applications/electronInvalidPaths.test.ts (+2 -0)
📝 tests/acceptance/tools/protobufCapture.test.ts (+69 -64)
📝 tests/boundary/filesystem/javascript-applications/javascriptApplicationTypeScript.test.ts (+35 -0)
📝 tests/boundary/javascript/workerOrderAudit.test.ts (+65 -12)

📄 Description

Summary

Stabilize cancellation and malformed-trailer regressions on main f5d1012fa while preserving their failure oracles.

Worker fixtures now cancel on schema-valid protocol frames before terminal admission, and send phase/failure frames together through the real child pipe. This removes process-close and 20 ms delivery races. The observer waits for runtime adoption before starting to read stdout, preserving buffered startup bytes; a regression proves the runtime receives the original bytes.
Split the 14 malformed gRPC-web trailer workflows into independent CLI/MCP cases. All framings, headers, status, partial facts and original-byte assertions remain, with the default deadline and file-owned MCP connection.
Retain explicit shared-schema format diagnostics for rejected URL paths and composed earlier/later exported-initializer controls.

The final diff changes five test files. Upstream independently integrated the EVM cleanup cancellation, export-position and browser deduplication fixes, so this branch retains those upstream implementations. No provider or tool capability is added; required maintainer scope decision is not applicable. Found in a latest-main CI audit; no separate issue.

Executed evidence

Latest integrated run on 086cb866f: 317 passed / 2 inapplicable host controls skipped, 15 files. This includes all 35 worker-order, 20 protobuf capture and 12 TypeScript graph cases, plus browser lifecycle, shared error projection, EVM boundaries and the upstream filtered-CLI regression fix.
npm run check:ci: 8 tasks passed, plus architecture/module guards. Duplication 3.4786%, below the unchanged 3.5% gate. npm run build:cached and git diff --check passed.
Restoring the eager observer makes the new startup-byte regression fail; fixed source was restored exactly. A separate controlled mutation that ignores caller cancellation makes the three cancellation controls fail while the success control passes; restored production source passed all four selected cases. No production worker change remains.
Current-head Codex review: no findings. Greptile review: 5/5, no actionable findings. The startup-reader thread is fixed and resolved with root cause, ownership change and counterfactual evidence.
Merged with the owner-authorized bypass as e52a71602 while PR CI was queued. The qualified preview used f5d1012fa; actual main had advanced through 7b2087e44 and 8443692e2, adding timer-overflow and Kuna fixture changes in four other files. All five PR files match the qualified head. Post-merge verification of the exact e52a71602 tree passed 333 tests / 2 existing host skips across 18 files, including both new upstream changes. Exact merged-main CI was superseded while pending by the next main push; latest main CI remains pending. The obsolete queued PR CI was cancelled after merge to avoid duplicate work. Complete remote portable-suite coverage is not claimed.
This change uses real CLI/MCP fixtures and controlled worker subprocesses. No new real-provider or Windows verification is claimed. Authored commits omit Co-authored-by.

Heavy local work uses two-CPU affinity and runs sequentially. Final integrated suites: 64.14 s wall / 112.23 s family CPU / 2,538.7 MiB sampled family RSS; final static gate: 170.72 s / 168.12 s / 4,990.6 MiB. RSS samples descendants every 100 ms and can double-count shared pages or miss short/reparented children; it is not a hard aggregate cap. No observed OOM. Whole-CI cost and agent tokens are unmeasured; no speedup claim.

Author readiness

Human owner: @gensokyo-dev

The owner explicitly delegated these declarations, authorized main-CI repairs and permitted bypass merge after verification in this session. Codex reviewed the final diff and evidence; independent human review was not observed. No CI policy or required-check configuration is changed.

I reviewed the final diff and relevant existing code, understand the change and its edge cases, and take responsibility for the complete PR, including AI-assisted work.
I checked the evidence above, confirmed it supports the current change, and recorded meaningful validation gaps.
I declare this PR ready for initial maintainer review.

Before merge

This PR addresses a concrete problem or an agreed enhancement.
Material scope and authority questions are resolved, and any required maintainer scope decision covers the final diff.
The PR has one focused outcome and the title follows type(scope): outcome.
Related issue is linked, or the reason for not linking one is stated above.
Tests cover changed observable behavior and meaningful failure paths.
Owning docs, contracts, and generated metadata are updated where needed.
User-visible CLI/MCP changes include representative output.
I checked the final diff for secrets, unrelated cleanup, and unsupported claims.

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/morluto/rea/pull/5497 **Author:** [@gensokyo-dev](https://github.com/gensokyo-dev) **Created:** 10/20/2026 **Status:** ✅ Merged **Merged:** 10/20/2026 **Merged by:** [@gensokyo-dev](https://github.com/gensokyo-dev) **Base:** `main` ← **Head:** `audit/ci-tests-20261020-round5` --- ### 📝 Commits (9) - [`6818ad7`](https://github.com/morluto/rea/commit/6818ad7febe396ef3000e26fef602643e24f025d) test(browser): deduplicate attached session scenarios - [`4182fb2`](https://github.com/morluto/rea/commit/4182fb26df3718b2231c0a681c4939220e2c1aa5) chore: update CI recovery branch to latest main - [`d097c3e`](https://github.com/morluto/rea/commit/d097c3e32d10ae8a8f65ae254749e65c80a3ce51) fix(evm): preserve cancellation after runtime-root cleanup - [`96cd237`](https://github.com/morluto/rea/commit/96cd237346b26b5c0f83876aaedb1640f4919c9f) fix(javascript): order initializers through export declarations - [`bf48de0`](https://github.com/morluto/rea/commit/bf48de0b8c61a14d4b083a48f99379b25d2d59c1) test: align path diagnostics and split trailer regressions - [`5ebeb58`](https://github.com/morluto/rea/commit/5ebeb5819511968b0c9c3d9c9a0d68754fbe185d) test(javascript): make worker cancellation order deterministic - [`52219e7`](https://github.com/morluto/rea/commit/52219e7e166729554a4a24c11d47c6901b1b606b) chore: refresh CI recovery against current main - [`1360a90`](https://github.com/morluto/rea/commit/1360a90ab89c7ade7a03e486e82214ab24cc93b7) chore: retain upstream fixes while refreshing the CI audit - [`086cb86`](https://github.com/morluto/rea/commit/086cb866fd805ec9a334c92cf7c838163c5a7b32) test(javascript): defer frame observers until runtime adoption ### 📊 Changes **5 files changed** (+173 additions, -76 deletions) <details> <summary>View changed files</summary> 📝 `src/cliJsonPaths.test.ts` (+2 -0) 📝 `tests/acceptance/applications/electronInvalidPaths.test.ts` (+2 -0) 📝 `tests/acceptance/tools/protobufCapture.test.ts` (+69 -64) 📝 `tests/boundary/filesystem/javascript-applications/javascriptApplicationTypeScript.test.ts` (+35 -0) 📝 `tests/boundary/javascript/workerOrderAudit.test.ts` (+65 -12) </details> ### 📄 Description ## Summary Stabilize cancellation and malformed-trailer regressions on main `f5d1012fa` while preserving their failure oracles. - Worker fixtures now cancel on schema-valid protocol frames before terminal admission, and send phase/failure frames together through the real child pipe. This removes process-close and 20 ms delivery races. The observer waits for runtime adoption before starting to read stdout, preserving buffered startup bytes; a regression proves the runtime receives the original bytes. - Split the 14 malformed gRPC-web trailer workflows into independent CLI/MCP cases. All framings, headers, status, partial facts and original-byte assertions remain, with the default deadline and file-owned MCP connection. - Retain explicit shared-schema format diagnostics for rejected URL paths and composed earlier/later exported-initializer controls. The final diff changes five test files. Upstream independently integrated the EVM cleanup cancellation, export-position and browser deduplication fixes, so this branch retains those upstream implementations. No provider or tool capability is added; required maintainer scope decision is not applicable. Found in a latest-main CI audit; no separate issue. ## Executed evidence - Latest integrated run on `086cb866f`: **317 passed / 2 inapplicable host controls skipped, 15 files**. This includes all **35 worker-order**, **20 protobuf capture** and **12 TypeScript graph** cases, plus browser lifecycle, shared error projection, EVM boundaries and the upstream filtered-CLI regression fix. - `npm run check:ci`: **8 tasks passed**, plus architecture/module guards. Duplication **3.4786%**, below the unchanged **3.5%** gate. `npm run build:cached` and `git diff --check` passed. - Restoring the eager observer makes the new startup-byte regression fail; fixed source was restored exactly. A separate controlled mutation that ignores caller cancellation makes the three cancellation controls fail while the success control passes; restored production source passed all four selected cases. No production worker change remains. - Current-head [Codex review](https://github.com/morluto/rea/pull/5497#issuecomment-6290214342): no findings. [Greptile review](https://github.com/morluto/rea/pull/5497#issuecomment-6290252889): **5/5**, no actionable findings. The startup-reader thread is fixed and resolved with root cause, ownership change and counterfactual evidence. - Merged with the owner-authorized bypass as `e52a71602` while [PR CI](https://github.com/morluto/rea/actions/runs/39443959597) was queued. The qualified preview used `f5d1012fa`; actual main had advanced through `7b2087e44` and `8443692e2`, adding timer-overflow and Kuna fixture changes in four other files. All five PR files match the qualified head. Post-merge verification of the exact `e52a71602` tree passed **333 tests / 2 existing host skips across 18 files**, including both new upstream changes. Exact merged-main CI was superseded while pending by the next main push; [latest main CI](https://github.com/morluto/rea/actions/runs/39445784441) remains pending. The obsolete queued PR CI was cancelled after merge to avoid duplicate work. Complete remote portable-suite coverage is not claimed. - This change uses real CLI/MCP fixtures and controlled worker subprocesses. No new real-provider or Windows verification is claimed. Authored commits omit `Co-authored-by`. Heavy local work uses two-CPU affinity and runs sequentially. Final integrated suites: **64.14 s wall / 112.23 s family CPU / 2,538.7 MiB sampled family RSS**; final static gate: **170.72 s / 168.12 s / 4,990.6 MiB**. RSS samples descendants every 100 ms and can double-count shared pages or miss short/reparented children; it is not a hard aggregate cap. No observed OOM. Whole-CI cost and agent tokens are unmeasured; no speedup claim. ## Author readiness Human owner: @gensokyo-dev The owner explicitly delegated these declarations, authorized main-CI repairs and permitted bypass merge after verification in this session. Codex reviewed the final diff and evidence; independent human review was not observed. No CI policy or required-check configuration is changed. - [x] I reviewed the final diff and relevant existing code, understand the change and its edge cases, and take responsibility for the complete PR, including AI-assisted work. - [x] I checked the evidence above, confirmed it supports the current change, and recorded meaningful validation gaps. - [x] I declare this PR ready for initial maintainer review. ## Before merge - [x] This PR addresses a concrete problem or an agreed enhancement. - [x] Material scope and authority questions are resolved, and any required maintainer scope decision covers the final diff. - [x] The PR has one focused outcome and the title follows `type(scope): outcome`. - [x] Related issue is linked, or the reason for not linking one is stated above. - [x] Tests cover changed observable behavior and meaningful failure paths. - [x] Owning docs, contracts, and generated metadata are updated where needed. - [x] User-visible CLI/MCP changes include representative output. - [x] I checked the final diff for secrets, unrelated cleanup, and unsupported claims. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>

bsakaguchi

2026-11-01 21:44:11 +00:00

closed this issue
added the
pull-request
label

bsakaguchi referenced this issue

2026-11-01 21:48:01 +00:00

[PR #6939] [CLOSED] Saving release notes #7461

No Branch/Tag specified

main

codex/procedure-reference-stacked

release-please--branches--main--components--rea-agents

release-please--branches--main--components--rea-agents--release-notes

codex/kuna-independent-retry

codex/byte-search-overlay-coverage

codex/open-failure-target-receipt

codex/kuna-xref-evidence

codex/ghidra-ambiguous-procedure-recovery

codex/function-source-bundle

codex/trace-function-integration-prototype

codex/snapshot-source-closure

codex/recorded-evidence-array-pages

codex/evidence-recovery-redesign

codex/trace-feature-address-scope

codex/call-discovery-scope

codex/ghidra-literal-candidate-evidence

codex/decompile-directory-independent-retry

codex/retry-provenance-base

codex/value-flow-capability-experiment

codex/ghidra-containing-instruction

cursor/readme-discord-button-ef9f

dependabot/github_actions/actions/setup-node-7.1.0

dependabot/github_actions/actions/upload-artifact-7.0.2

dependabot/npm_and_yarn/npm-minor-and-patch-d8d97ce6df

codex/kuna-1989

fix/8559-native-ui-fixture-ownership

fix/8555-go-verifier-mcp-ownership

codex/provider-capability-recovery

fix/8642-rizin-target-stdin

codex/ghidra-memory-effect-scope

codex/ghidra-annotation-entry-selector

codex/ghidra-readonly-recovery

codex/ghidra-regex-verifier-recovery

codex/evidence-discovery-view-guidance

fix/8545-bulk-append-overflow

fix/8428-navigation-refusal-alternatives

codex/address-context-recovery

codex/matching-member-limitations

codex/unknown-scope-contract

codex/evidence-view-guidance

feat/8373-native-trace-views

codex/ghidra-snapshot-verifier-binding

codex/elf-export-visibility

codex/evidence-view-recovery

codex/native-reference-cli-help

codex/provider-candidate-observation-scope

codex/kuna-session-verification

codex/ghidra-switch-lifetime-guidance

codex/pseudocode-paging-discovery

codex/clarify-evidence-view-support

codex/kuna-xrefs-selector-recovery

codex/context-capacity-recovery

codex/evidence-closure-large-links

codex/same-function-evidence-identity

codex/ghidra-verifier-inspected-jdk

codex/audit-guided-workflows

codex/crash-prompt-retained-dossiers

codex/analysis-view-error-recovery

codex/kuna-verifier-target-selection

codex/ghidra-selected-project-call-coverage

codex/docs-native-analysis-scope

codex/ghidra-java-socket-boundary

codex/ghidra-retained-snapshot-verifier

codex/ghidra-search-inventory-facts

fix/8284-zero-argument-parameter-bindings

fix/8198-ui-action-handler-offset

fix/8257-elf-entry-label-identity

fix/8304-deferred-output-schema-projection

fix/8277-call-path-computed-target-uncertainty

fix/pr-8089-conflicts

fix/ci-static-duplicate-export

dependabot/npm_and_yarn/lint-staged-17.6.0

dependabot/github_actions/actions/download-artifact-8.0.2

dependabot/npm_and_yarn/write-file-atomic-8.0.0

dependabot/npm_and_yarn/canonicalize-5.1.0

dependabot/github_actions/actions/cache/restore-6.1.0

dependabot/npm_and_yarn/toon-format/toon-4.4.0

dependabot/github_actions/actions/deploy-pages-5.0.1

codex/review-fixes-pr-2403

codex/review-fixes-pr-2400

codex/process-terminal-width

codex/test-brittleness-cleanup

verify/7167-browser-connect-macos

fix/7167-browser-connect

feat/native-matching-allowance-setting

feat/browser-scenario-dry-run

test/managed-caller-parameters-20261024

codex/parser-fortythird-boundaries

fix/6926-pinvoke-platform-decorations-20261023

fix/6889-har-body-encoding-20261023

fix/6888-sqlite-schema-budget-20261023

fix/dependency-security-gates-6708

cursor/evidence-overwrite-rebase-b4ac

feat/4057-verify-native-exports

fix/windows-acl-observer-overhead-20261022

cursor/erlang-beam-restack-4476

cursor/pe-certificate-review-bf32

fix/6116-javascript-application-fs-errors

fix/6061-unmapped-runtime-script-unknown

feat/browser-scenario-summary

fix/pe-certificates

codex/verify-3407

cursor/rebase-5699

cursor/rebase-5352

cursor/rebase-5600

cursor/fix-cli-schema-omission-10a8

codex/audit-hopper-shutdown-reasons-20261021

fix/demangle-swift-omitted-record

fix/nib-boolean-value-types

cursor/cancellation-partial-observation-a5ac

fix/ib-object-limit-reasons

fix/electron-fuse-limit-advice

fix/kuna-doctor-dangling-cache

fix/fixed-budget-refusal-advice

fix/js-ipc-listener-dedup

fix/js-return-member-provenance

fix/dmg-integrity-retry-advice

fix/ida-doctor-readiness

fix/kuna-version-probe-output-drain

fix/legacy-swift-runtime-name-matching

fix/dylib-lazy-load-commands

fix/browser-scenario-startup-cancel

fix/swift-nested-punycode-classification

fix/compare-unselected-scopes

fix/objc-method-budget-coverage

fix/dmg-mounted-root-observations

audit/ci-tests-20261019-round2

release/6.7.0

fix/wabt-cleanup-retry-resolution

fix/electron-fuse-elf-pe-architecture

fix/native-plist-descriptor-ownership

fix/kuna-caller-cleanup-ownership

experiment/atomic-codemode-20261016

review/first-contributor-3776

fix/call-resolution-full-read-cycles

fix/member-mutation-selection-repeat

experiment/atomic-re-tools-20261015

perf/member-mutation-lazy-origins

perf/static-network-mutation-index

fix/hopper-startup-lifecycle

audit/3050-windows-proof-20261015

feat/windows-window-capture-2183

audit/3049-windows-proof-20261015

audit/3735-macos-fixtures-20261015

fix/batch-decompile-null-pseudocode

fix/kuna-inventory-honors-jobs

experiment/browser-codemode-tool-design-20261015

fix/hopper-clean-runtime-argv

codex/review-2049-27f1b367

review-fixes/pr-2787-routing

fix/3360-scoped-this-emitters

fix/3367-replaced-global-effects

fix/3838-compact-any-value-items

test/hopper-download-probe-20261015

codex/windows-runtime-creation-red-green-20261015

codex/windows-readonly-root-red-green-20261015

codex/windows-root-share-red-green-20261015

codex/exp-1685-win-mcp-startup

codex/bug-sweep-20261015

investigate/2190-windows-package-phases

investigate/3543-macos-cli-deadline

perf/3281-reverse-tools-feedback-quality

fix/3406-hopper-doctor-fixture

fix/3341-wrapper-require-test-context

fix/3301-owned-uninstall-fixtures

fix/3164-compiler-input-ownership

fix/pcap-cleanup-stdout-newline-20261014

perf/interface-builder-summary

codex/review-fixes-pr-1977

fix/ghidra-effective-jvm-platform

fix/docs-turkish-rust-link-20261013

fix/main-maintenance-ci-20261010

fix/recover-binary-session-process-effects

codex/review-fixes-pr-2457

codex/ci-required-cancellation-gate

fix/main-format-baseline-20261013

fix/setup-preserve-entry-fields

cursor/restore-main-checks-1ffc

fix/ghidra-bridge-hashmap-import

codex/shared-ci-jadx-json-default-20261013

codex/shared-ci-ghidra-test-groups-20261013

codex/shared-ci-java-fixture-format-20261013

codex/fix-intrinsic-invocation-boundaries

test/release-preflight-reusable-jobs

test/js-parameter-provenance-expectation

fix/linux-hopper-verification-current

test/2419-ghidra-elf-probe-size

followup/pr-1544-native-ida

codex/fold-pr-2230-contribution

docs/readme-responsible-use

fix/issue-2064

fix/issue-2050

fix/issue-2053

fix/issue-1968

fix/issue-1945

experiment/codemode-bridge-20261011

fix/tool-effects-negative-wording-1904-20261012

fix/1842-electron-interop-provenance

feat/recover-javascript-multi-input

refactor/website-i18n-prep

fix/nativeaot-pe-virtual-extent

fix/browser-verifier-ci-hang

fix/pe-resources-input-selection

docs/beginner-friendly-guides

docs/beginner-setup-guide

fix/javascript-analysis-worker-1563

fix/1649-ghidra-duplicate-names

fix/javascript-export-keys-integration-1369

test/maintenance-boundary-contracts-20261011

review/javascript-export-keys-1369

review/process-live-progress-1483

test/javascript-1495-growth-ratio

fix/ci-escape-timing

docs/normalized-terminal-geometry-1450

release/6.3.0

archive/release-6.3.0-pr1381

release/6.2.0

fix/electron-preload-dynamic-override

fix/javascript-self-referential-bundler-edges

release/6.1.0

cursor/grok-client-cherry-pick-0b56

feat/signature-posture

feat/dyld-shared-cache

feat/artifact-integrity-policy

feat/pkg-inventory

release/6.0.0

chore/sync-release-5.0.0

release/5.0.0

cursor/cloud-agent-node-787e

fix/javascript-xhr-open-endpoints

review/pr-711-realpath-fallback-wording

cleanup/replay-confinement

codex/test-suite-performance

codex/issue-foundations

codex/address-open-issues-2026-07-20

agent/javascript-vite-rollup-esbuild-adapters

agent/process-cleanup

agent/triage-integration

agent/unknown-commands-registry

feat/mcp-identity-metadata

morlvps/issue_cleanup

codex/installer-redesign

morl/roadmap-investigation-core

morl/roadmap-investigation-docs

release-please--branches--main--components--rea

rea-agents-6.8.0

rea-agents-6.7.0

rea-agents-6.6.0

experiment/atomic-codemode-wait-runtime-20261016

rea-agents-6.5.0

rea-agents-6.4.0

rea-agents-6.3.0

rea-agents-6.2.0

rea-agents-6.1.0

rea-agents-6.0.0

rea-agents-5.0.0

rea-agents-4.1.0

rea-agents-4.0.1

rea-agents-4.0.0

rea-agents-3.2.1

rea-agents-3.2.0

rea-agents-3.1.0

rea-agents-3.0.0

rea-agents-2.7.0

rea-agents-2.6.0

rea-agents-2.5.1

rea-agents-2.5.0

rea-agents-2.4.0

rea-agents-2.3.0

rea-agents-2.2.0

rea-agents-2.1.0

rea-agents-2.0.0

rea-agents-1.7.0

rea-agents-1.6.0

rea-agents-1.5.0

rea-agents-1.4.0

rea-agents-1.3.0

rea-agents-1.2.0

rea-agents-1.1.0

rea-agents-1.0.0

rea-agents-0.5.0

rea-agents-0.4.0

rea-agents-0.3.0

rea-0.2.1

rea-0.2.0

Labels

Clear labels

Mirrored from GitHub Pull Request

No labels

Milestone

Clear milestone

No items

No milestone

Projects

Clear projects

No items

No project

Assignees

Clear assignees

No assignees

1 participant

Notifications

Due date

The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference

morluto/rea#6939

Reference in a new issue

Repository

morluto/rea

Title

Body

No description provided.

Delete branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?

Rows
Columns