mirror of
https://github.com/morluto/rea.git
synced 2026-11-05 06:45:22 +00:00
[PR #5511] [MERGED] feat(desktop): suggest managed members for Unity script assemblies #6947
Closed
opened 2026-11-01 21:44:15 +00:00 by bsakaguchi
·
0 comments
No Branch/Tag specified
main
codex/procedure-reference-stacked
release-please--branches--main--components--rea-agents
release-please--branches--main--components--rea-agents--release-notes
codex/kuna-independent-retry
codex/byte-search-overlay-coverage
codex/open-failure-target-receipt
codex/kuna-xref-evidence
codex/ghidra-ambiguous-procedure-recovery
codex/function-source-bundle
codex/trace-function-integration-prototype
codex/snapshot-source-closure
codex/recorded-evidence-array-pages
codex/evidence-recovery-redesign
codex/trace-feature-address-scope
codex/call-discovery-scope
codex/ghidra-literal-candidate-evidence
codex/decompile-directory-independent-retry
codex/retry-provenance-base
codex/value-flow-capability-experiment
codex/ghidra-containing-instruction
cursor/readme-discord-button-ef9f
dependabot/github_actions/actions/setup-node-7.1.0
dependabot/github_actions/actions/upload-artifact-7.0.2
dependabot/npm_and_yarn/npm-minor-and-patch-d8d97ce6df
codex/kuna-1989
fix/8559-native-ui-fixture-ownership
fix/8555-go-verifier-mcp-ownership
codex/provider-capability-recovery
fix/8642-rizin-target-stdin
codex/ghidra-memory-effect-scope
codex/ghidra-annotation-entry-selector
codex/ghidra-readonly-recovery
codex/ghidra-regex-verifier-recovery
codex/evidence-discovery-view-guidance
fix/8545-bulk-append-overflow
fix/8428-navigation-refusal-alternatives
codex/address-context-recovery
codex/matching-member-limitations
codex/unknown-scope-contract
codex/evidence-view-guidance
feat/8373-native-trace-views
codex/ghidra-snapshot-verifier-binding
codex/elf-export-visibility
codex/evidence-view-recovery
codex/native-reference-cli-help
codex/provider-candidate-observation-scope
codex/kuna-session-verification
codex/ghidra-switch-lifetime-guidance
codex/pseudocode-paging-discovery
codex/clarify-evidence-view-support
codex/kuna-xrefs-selector-recovery
codex/context-capacity-recovery
codex/evidence-closure-large-links
codex/same-function-evidence-identity
codex/ghidra-verifier-inspected-jdk
codex/audit-guided-workflows
codex/crash-prompt-retained-dossiers
codex/analysis-view-error-recovery
codex/kuna-verifier-target-selection
codex/ghidra-selected-project-call-coverage
codex/docs-native-analysis-scope
codex/ghidra-java-socket-boundary
codex/ghidra-retained-snapshot-verifier
codex/ghidra-search-inventory-facts
fix/8284-zero-argument-parameter-bindings
fix/8198-ui-action-handler-offset
fix/8257-elf-entry-label-identity
fix/8304-deferred-output-schema-projection
fix/8277-call-path-computed-target-uncertainty
fix/pr-8089-conflicts
fix/ci-static-duplicate-export
dependabot/npm_and_yarn/lint-staged-17.6.0
dependabot/github_actions/actions/download-artifact-8.0.2
dependabot/npm_and_yarn/write-file-atomic-8.0.0
dependabot/npm_and_yarn/canonicalize-5.1.0
dependabot/github_actions/actions/cache/restore-6.1.0
dependabot/npm_and_yarn/toon-format/toon-4.4.0
dependabot/github_actions/actions/deploy-pages-5.0.1
codex/review-fixes-pr-2403
codex/review-fixes-pr-2400
codex/process-terminal-width
codex/test-brittleness-cleanup
verify/7167-browser-connect-macos
fix/7167-browser-connect
feat/native-matching-allowance-setting
feat/browser-scenario-dry-run
test/managed-caller-parameters-20261024
codex/parser-fortythird-boundaries
fix/6926-pinvoke-platform-decorations-20261023
fix/6889-har-body-encoding-20261023
fix/6888-sqlite-schema-budget-20261023
fix/dependency-security-gates-6708
cursor/evidence-overwrite-rebase-b4ac
feat/4057-verify-native-exports
fix/windows-acl-observer-overhead-20261022
cursor/erlang-beam-restack-4476
cursor/pe-certificate-review-bf32
fix/6116-javascript-application-fs-errors
fix/6061-unmapped-runtime-script-unknown
feat/browser-scenario-summary
fix/pe-certificates
codex/verify-3407
cursor/rebase-5699
cursor/rebase-5352
cursor/rebase-5600
cursor/fix-cli-schema-omission-10a8
codex/audit-hopper-shutdown-reasons-20261021
fix/demangle-swift-omitted-record
fix/nib-boolean-value-types
cursor/cancellation-partial-observation-a5ac
fix/ib-object-limit-reasons
fix/electron-fuse-limit-advice
fix/kuna-doctor-dangling-cache
fix/fixed-budget-refusal-advice
fix/js-ipc-listener-dedup
fix/js-return-member-provenance
fix/dmg-integrity-retry-advice
fix/ida-doctor-readiness
fix/kuna-version-probe-output-drain
fix/legacy-swift-runtime-name-matching
fix/dylib-lazy-load-commands
fix/browser-scenario-startup-cancel
fix/swift-nested-punycode-classification
fix/compare-unselected-scopes
fix/objc-method-budget-coverage
fix/dmg-mounted-root-observations
audit/ci-tests-20261019-round2
release/6.7.0
fix/wabt-cleanup-retry-resolution
fix/electron-fuse-elf-pe-architecture
fix/native-plist-descriptor-ownership
fix/kuna-caller-cleanup-ownership
experiment/atomic-codemode-20261016
review/first-contributor-3776
fix/call-resolution-full-read-cycles
fix/member-mutation-selection-repeat
experiment/atomic-re-tools-20261015
perf/member-mutation-lazy-origins
perf/static-network-mutation-index
fix/hopper-startup-lifecycle
audit/3050-windows-proof-20261015
feat/windows-window-capture-2183
audit/3049-windows-proof-20261015
audit/3735-macos-fixtures-20261015
fix/batch-decompile-null-pseudocode
fix/kuna-inventory-honors-jobs
experiment/browser-codemode-tool-design-20261015
fix/hopper-clean-runtime-argv
codex/review-2049-27f1b367
review-fixes/pr-2787-routing
fix/3360-scoped-this-emitters
fix/3367-replaced-global-effects
fix/3838-compact-any-value-items
test/hopper-download-probe-20261015
codex/windows-runtime-creation-red-green-20261015
codex/windows-readonly-root-red-green-20261015
codex/windows-root-share-red-green-20261015
codex/exp-1685-win-mcp-startup
codex/bug-sweep-20261015
investigate/2190-windows-package-phases
investigate/3543-macos-cli-deadline
perf/3281-reverse-tools-feedback-quality
fix/3406-hopper-doctor-fixture
fix/3341-wrapper-require-test-context
fix/3301-owned-uninstall-fixtures
fix/3164-compiler-input-ownership
fix/pcap-cleanup-stdout-newline-20261014
perf/interface-builder-summary
codex/review-fixes-pr-1977
fix/ghidra-effective-jvm-platform
fix/docs-turkish-rust-link-20261013
fix/main-maintenance-ci-20261010
fix/recover-binary-session-process-effects
codex/review-fixes-pr-2457
codex/ci-required-cancellation-gate
fix/main-format-baseline-20261013
fix/setup-preserve-entry-fields
cursor/restore-main-checks-1ffc
fix/ghidra-bridge-hashmap-import
codex/shared-ci-jadx-json-default-20261013
codex/shared-ci-ghidra-test-groups-20261013
codex/shared-ci-java-fixture-format-20261013
codex/fix-intrinsic-invocation-boundaries
test/release-preflight-reusable-jobs
test/js-parameter-provenance-expectation
fix/linux-hopper-verification-current
test/2419-ghidra-elf-probe-size
followup/pr-1544-native-ida
codex/fold-pr-2230-contribution
docs/readme-responsible-use
fix/issue-2064
fix/issue-2050
fix/issue-2053
fix/issue-1968
fix/issue-1945
experiment/codemode-bridge-20261011
fix/tool-effects-negative-wording-1904-20261012
fix/1842-electron-interop-provenance
feat/recover-javascript-multi-input
refactor/website-i18n-prep
fix/nativeaot-pe-virtual-extent
fix/browser-verifier-ci-hang
fix/pe-resources-input-selection
docs/beginner-friendly-guides
docs/beginner-setup-guide
fix/javascript-analysis-worker-1563
fix/1649-ghidra-duplicate-names
fix/javascript-export-keys-integration-1369
test/maintenance-boundary-contracts-20261011
review/javascript-export-keys-1369
review/process-live-progress-1483
test/javascript-1495-growth-ratio
fix/ci-escape-timing
docs/normalized-terminal-geometry-1450
release/6.3.0
archive/release-6.3.0-pr1381
release/6.2.0
fix/electron-preload-dynamic-override
fix/javascript-self-referential-bundler-edges
release/6.1.0
cursor/grok-client-cherry-pick-0b56
feat/signature-posture
feat/dyld-shared-cache
feat/artifact-integrity-policy
feat/pkg-inventory
release/6.0.0
chore/sync-release-5.0.0
release/5.0.0
cursor/cloud-agent-node-787e
fix/javascript-xhr-open-endpoints
review/pr-711-realpath-fallback-wording
cleanup/replay-confinement
codex/test-suite-performance
codex/issue-foundations
codex/address-open-issues-2026-07-20
agent/javascript-vite-rollup-esbuild-adapters
agent/process-cleanup
agent/triage-integration
agent/unknown-commands-registry
feat/mcp-identity-metadata
morlvps/issue_cleanup
codex/installer-redesign
morl/roadmap-investigation-core
morl/roadmap-investigation-docs
release-please--branches--main--components--rea
rea-agents-6.8.0
rea-agents-6.7.0
rea-agents-6.6.0
experiment/atomic-codemode-wait-runtime-20261016
rea-agents-6.5.0
rea-agents-6.4.0
rea-agents-6.3.0
rea-agents-6.2.0
rea-agents-6.1.0
rea-agents-6.0.0
rea-agents-5.0.0
rea-agents-4.1.0
rea-agents-4.0.1
rea-agents-4.0.0
rea-agents-3.2.1
rea-agents-3.2.0
rea-agents-3.1.0
rea-agents-3.0.0
rea-agents-2.7.0
rea-agents-2.6.0
rea-agents-2.5.1
rea-agents-2.5.0
rea-agents-2.4.0
rea-agents-2.3.0
rea-agents-2.2.0
rea-agents-2.1.0
rea-agents-2.0.0
rea-agents-1.7.0
rea-agents-1.6.0
rea-agents-1.5.0
rea-agents-1.4.0
rea-agents-1.3.0
rea-agents-1.2.0
rea-agents-1.1.0
rea-agents-1.0.0
rea-agents-0.5.0
rea-agents-0.4.0
rea-agents-0.3.0
rea-0.2.1
rea-0.2.0
Labels
Clear labels
area: bridge
area: bridge
area: build
area: build
area: build
area: cli
area: domain
area: evidence
area: mcp
area: native
area: providers
area: runtime
area: server
area: setup
area: tests
bug
design
documentation
enhancement
enhancement
enhancement
experiment
help wanted
i18n
invalid
P0: critical
P1: high
P2: medium
P2: medium
P2: medium
P3: low
performance
provider-request
pull-request
Mirrored from GitHub Pull Request
question
roadmap
triage
No labels
area: bridge
area: bridge
area: build
area: build
area: build
area: cli
area: domain
area: evidence
area: mcp
area: native
area: providers
area: runtime
area: server
area: setup
area: tests
bug
design
documentation
enhancement
enhancement
enhancement
experiment
help wanted
i18n
invalid
P0: critical
P1: high
P2: medium
P2: medium
P2: medium
P3: low
performance
provider-request
pull-request
question
roadmap
triage
Milestone
Clear milestone
No items
No milestone
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".
No due date set.
Dependencies
No dependencies set.
Reference
morluto/rea#6947
Loading…
Add table
Add a link
Reference in a new issue
No description provided.
Delete branch "%!s()"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
📋 Pull Request Information
Original PR: https://github.com/morluto/rea/pull/5511
Author: @8rulerstar
Created: 10/20/2026
Status: ✅ Merged
Merged: 11/4/2026
Merged by: @morluto
Base:
main← Head:feat/unity-script-assembly-probes📝 Commits (10+)
73f6d95feat(desktop): suggest managed members for Unity predefined script assemblies4ba27acdocs(desktop): describe Unity Mono managed member probes385391erefactor(desktop): read Unity managed directory from the witness fact6ac7bcfrefactor(desktop): reuse the managed directory index for predefined assembliesb1d0dc3feat(desktop): point Unity member probes at summary delivery first2a60361test(desktop): no member probes without a Unity reference witness63366a9docs(desktop): trim Unity member probe note622aca0feat(desktop): suggest managed members in Unity IL2CPP backup foldersa5011badocs(desktop): note IL2CPP backup folder member probes2e4e51ddocs(desktop): list IL2CPP metadata versions 24 and 27 for the metadata probe📊 Changes
7 files changed (+307 additions, -10 deletions)
View changed files
📝
docs/desktop-applications.md(+9 -0)📝
src/artifacts/DesktopApplicationReader.ts(+19 -6)📝
src/domain/desktopApplication.ts(+6 -0)📝
src/domain/desktopApplicationProjection.test.ts(+5 -0)📝
src/domain/desktopApplicationProjection.ts(+31 -1)📝
src/domain/nativeConvention.ts(+43 -3)📝
tests/boundary/filesystem/desktopApplication.test.ts(+194 -0)📄 Description
Summary
For a Unity Mono player,
inspect_desktop_applicationsuggestsinspect_managed_artifactfor every managed DLL (90 probes on a Unity 2022.3.62f3 Win64 sample, almost allUnityEngine.*,System.*,Mono.*) and neverinspect_managed_members. This adds oneinspect_managed_membersprobe for each Unity predefined script assembly (Assembly-CSharp.dll,Assembly-CSharp-firstpass.dll), listed first, and the same probe for those assemblies in an IL2CPP build's<Product>_BackUpThisFolder_ButDontShipItWithYourGame/Managed/. Related: #3607 (not a fix for it, so not linked with "Fixes").Problem and expected behavior
Use case: an agent triaging a Unity game wants the game's own code first. Today the probe list is dominated by engine and BCL assemblies, and the member-level operation that answers "what does this game's code contain" is never suggested.
Expected: when a managed directory has a
unity-assembly-referencewitness,Assembly-CSharp.dllandAssembly-CSharp-firstpass.dlldirectly in that directory get aninspect_managed_membersprobe ahead of everyinspect_managed_artifactprobe. The same applies to those names inManaged/of an IL2CPP backup folder, with a rationale stating that correspondence to the shipped native code is unknown. All other probes stay identical and in the same order.Change and scope
desktopPathConventions(src/domain/nativeConvention.ts), which already owns the Unity managed directory rule, also owns the predefined assembly name rule and the backup folder suffix rule (case-folded, non-empty product prefix). The admitted root name is passed in so the root itself can be the backup folder.pe-cli-directoryfact, sits directly in a managed directory that already has aunity-assembly-referencewitness, and has a predefined name. The Mono probe is derived from that existing witness fact plus the path, so it records no new fact; the backup probe has no comparable witness, so it recordsunity-il2cpp-backup-convention. This asymmetry is deliberate.unity-il2cpp-backup-convention(offset: null,backup_directory) is a path convention only. Nounity-monolabel is added from it.<Product>_DataorManagedfolder itself (an existing limit on main, now documented: point the scan at the game folder); DLLs past the probe byte budget, which get nope-cli-directoryfact, same as the ordinary managed probes.Follow the contribution scope.
Unresolved scope, authority, side effects, or required verification block
integration. Link the required maintainer scope decision for new providers or
capabilities involving target execution, injection, mutation, or protection
recovery; ordinary fixes within existing boundaries may state "not applicable".
Draft PRs may leave the scope decision pending and the readiness and merge checklists
unchecked. Maintainers can help resolve open questions.
Maintainer scope decision: not applicable (additive probe suggestion within the existing desktop triage boundary; no new provider or capability).
Contract and boundary impact
desktopPathConventionsinsrc/domain/nativeConvention.ts; projection insrc/domain/desktopApplicationProjection.ts.next_probes[].operationgains the additive valueinspect_managed_members; new additive fact kindunity-il2cpp-backup-conventioninfiles[].facts.offset: null; probe rationale states IL correspondence to shipped IL2CPP code is unknown.docs/public/product-catalog.json), package, or installation impact (CI generates and validates ignored catalogs andskills/; edit authored instructions in.agents/skills/reverse-engineer-anything/and never commit build outputs): none.Expected effects (check known effects; use documentation-only on its own).
Unchecked items do not establish absence; leave uncertainties visible.
Evidence and regression coverage
Tests added or updated:
tests/boundary/filesystem/desktopApplication.test.tscovers probe ordering for predefined assemblies inGame_Data/Managed; positive member probe in a macOS bundleContents/Resources/Data/Managed; no member probe when the root isGame_DataorGame_Data/Manageditself; no member probes without a Unity reference witness; backup folder probes (including the backup folder as root, case folding, and non-matching names).src/domain/desktopApplicationProjection.test.tsaddsunity-il2cpp-backup-conventionto the fact list that main's probe fan-out test checks againstDESKTOP_PROBES_PER_FACT.Base reproduction or other evidence: executed, on self-built samples at
2e4e51d87, before the main merges. Counts were not re-measured after merging main; the member-probe ordering is covered by committed tests, while "other probes identical" rests on these pre-merge runs only.Build/with backup folder (2022.3 / 2020.3)User-visible CLI/MCP output (if applicable): first two
next_probesrows for aGame_Data/Managedfixture withAssembly-CSharp.dll(Unity reference) andUnityEngine.CoreModule.dll, captured by running the boundary test'sinspecthelper on that fixture on Windows 11 (ids shortened with …, local root replaced by<root>, path separators shown as/):Response size on the Win64 sample:
inspect_managed_artifact12,977 B,inspect_managed_members104,955 B default, 12,805 B withdetail: "summary"; the rationale points to summary first.Remaining proof gaps: backup folders checked only on macOS builds, not Windows or Linux layouts or a shipped game. No sample contains
Assembly-CSharp-firstpass.dll(test only). Not run on Unity 6, Linux players, 32-bit Windows or commercial games. Agent tool selection after the change is unmeasured. How often large games exceed the probe byte budget is unmeasured.For boundary fixes, identify the applicable boundary regressions
and lifecycle regressions
covered by the evidence above, and explain relevant gaps.
Not applicable: this is a feature, not a boundary fix. The new behavior is covered by the boundary tests listed above.
For evidence-bearing changes:
Validation performed
At
5716a2429(merge of maind48e472fais967903f80), Windows 11, Node 24.19.0, below theenginesfloor 24.22.1 (dependencies installed with--engine-strict=false):npm run check:fast(typecheck and lint): passed.node scripts/run-exact-tests.mjs run tests/boundary/filesystem/desktopApplication.test.ts src/domain/desktopApplicationProjection.test.ts: 91 passed, 3 skipped, 1 failed:does not promote filenames, arbitrary pak files or symlink targets into byte factsfails withEPERMcreating a symlink (Windows without symlink privilege). That test already exists on main and is not touched by this PR.npm run test:focusedstops before running any test on this machine because its build step needs the Windows native build output (native/windows/build/manifest.json), so the CLI and MCP desktop tests were left to CI.npm run docs:checkwas not run locally.CI on
5716a2429:CI required,Build package,Documentation,Portable testsand all eight test shards passed.Compatibility, safety, and release
Author readiness
Human owner: @8rulerstar
Before merge
type(scope): outcome.🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.
[PR #5511] feat(desktop): suggest managed members for Unity script assembliesto [PR #5511] [MERGED] feat(desktop): suggest managed members for Unity script assemblies