[PR #5518] [CLOSED] docs(web-bundle): describe objectValue as a named-property lookup #6949

Closed
opened 2026-11-01 21:44:16 +00:00 by bsakaguchi · 0 comments
Owner

📋 Pull Request Information

Original PR: https://github.com/morluto/rea/pull/5518
Author: @Soumya95
Created: 10/20/2026
Status: ❌ Closed

Base: main ← Head: docs/object-value-jsdoc-5074


📝 Commits (1)

  • 6975cd4 docs(web-bundle): describe objectValue as a named-property lookup

📊 Changes

1 file changed (+5 additions, -2 deletions)

View changed files

📝 src/domain/webBundleAnalyzerAst.ts (+5 -2)

📄 Description

Summary

The JSDoc above objectValue in src/domain/webBundleAnalyzerAst.ts describes endpoint-argument selection, but the helper returns the value AST node of a named object property (used for WebMCP schema properties).

Fixes #5074

Problem and expected behavior

The JSDoc above objectValue in src/domain/webBundleAnalyzerAst.ts describes endpoint-argument selection, but the helper returns the value AST node of a named object property (used for WebMCP schema properties).

Change and scope

Replaced the comment with one derived from the implementation: last matching property wins; a later spread or unresolvable key yields undefined. Also removed the blank line that detached the comment from the declaration. No code change.

Documentation/source-comment only; no new capability, provider, or target interaction, so a maintainer scope decision is not applicable.

Contract and boundary impact

  • Semantic owner and earliest changed stage: the authored source named above.

  • Contribution scope fit and linked maintainer decision: existing-boundary fix; not applicable.

  • CLI and MCP/tool-catalog contract: unchanged.

  • Provider, bridge, target-format, or platform compatibility: unchanged.

  • Evidence, artifact, provenance, or reconstruction contract: unchanged.

  • Generated metadata, package, or installation impact: none; no generated outputs committed.

  • Read existing files or captured data.

  • Launch or attach to a process.

  • Inject instrumentation or run scripts/code.

  • Change process memory, registers, files, or configuration.

  • Contact network services.

  • Recover protected code or work around protections.

  • Documentation or usability only; no target interaction.

  • Not sure yet; investigation or maintainer guidance needed.

Evidence and regression coverage

Source-derived from the function body and its caller in webBundleAnalyzerInspection.ts. Not executed: typecheck/lint (dependencies not installed in this checkout); comment-only edit.

Author readiness

Human owner: @Soumya95

  • I reviewed the final diff and relevant existing code, understand the change and its edge cases, and take responsibility for the complete PR, including AI-assisted work.
  • I checked the evidence above, confirmed it supports the current change, and recorded meaningful validation gaps.
  • I declare this PR ready for initial maintainer review.

🤖 Generated with Claude Code


🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/morluto/rea/pull/5518 **Author:** [@Soumya95](https://github.com/Soumya95) **Created:** 10/20/2026 **Status:** ❌ Closed **Base:** `main` ← **Head:** `docs/object-value-jsdoc-5074` --- ### 📝 Commits (1) - [`6975cd4`](https://github.com/morluto/rea/commit/6975cd454ec4badd17c2252509ba13152379bd00) docs(web-bundle): describe objectValue as a named-property lookup ### 📊 Changes **1 file changed** (+5 additions, -2 deletions) <details> <summary>View changed files</summary> 📝 `src/domain/webBundleAnalyzerAst.ts` (+5 -2) </details> ### 📄 Description ## Summary The JSDoc above `objectValue` in `src/domain/webBundleAnalyzerAst.ts` describes endpoint-argument selection, but the helper returns the value AST node of a named object property (used for WebMCP schema properties). Fixes #5074 ## Problem and expected behavior The JSDoc above `objectValue` in `src/domain/webBundleAnalyzerAst.ts` describes endpoint-argument selection, but the helper returns the value AST node of a named object property (used for WebMCP schema properties). ## Change and scope Replaced the comment with one derived from the implementation: last matching property wins; a later spread or unresolvable key yields `undefined`. Also removed the blank line that detached the comment from the declaration. No code change. Documentation/source-comment only; no new capability, provider, or target interaction, so a maintainer scope decision is not applicable. ## Contract and boundary impact - Semantic owner and earliest changed stage: the authored source named above. - Contribution scope fit and linked maintainer decision: existing-boundary fix; not applicable. - CLI and MCP/tool-catalog contract: unchanged. - Provider, bridge, target-format, or platform compatibility: unchanged. - Evidence, artifact, provenance, or reconstruction contract: unchanged. - Generated metadata, package, or installation impact: none; no generated outputs committed. - [ ] Read existing files or captured data. - [ ] Launch or attach to a process. - [ ] Inject instrumentation or run scripts/code. - [ ] Change process memory, registers, files, or configuration. - [ ] Contact network services. - [ ] Recover protected code or work around protections. - [x] Documentation or usability only; no target interaction. - [ ] Not sure yet; investigation or maintainer guidance needed. ## Evidence and regression coverage Source-derived from the function body and its caller in `webBundleAnalyzerInspection.ts`. Not executed: typecheck/lint (dependencies not installed in this checkout); comment-only edit. ## Author readiness Human owner: @Soumya95 - [x] I reviewed the final diff and relevant existing code, understand the change and its edge cases, and take responsibility for the complete PR, including AI-assisted work. - [x] I checked the evidence above, confirmed it supports the current change, and recorded meaningful validation gaps. - [x] I declare this PR ready for initial maintainer review. 🤖 Generated with [Claude Code](https://claude.com/claude-code) --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
bsakaguchi 2026-11-01 21:44:16 +00:00
Sign in to join this conversation.
No milestone
No project
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference
morluto/rea#6949
No description provided.