[GH-ISSUE #2123] [Bug] Main CI fails prompt completion checks since `07b36c148` #695

New issue

Closed

opened 2026-10-15 18:27:28 +00:00 by bsakaguchi · 0 comments

bsakaguchi commented

2026-10-15 18:27:28 +00:00

Owner

Originally created by @kaoru0822-kitauji on GitHub (Oct 12, 2026).
Original GitHub issue: https://github.com/morluto/rea/issues/2123

Observed behavior

Main CI has failed since 07b36c148 (fix(mcp): keep prompt completion within ready provider sessions). It passed on 0d5033ad1; the 07b36c148 run was cancelled and c22111eca failed. Every PR based on current main inherits these failures (e.g. #2118).

Test shard (1/4): tests/boundary/mcp/promptCompletion.test.ts > guided prompt completion from live analysis > reads live documents and complete procedures without ambiguous names
```
AssertionError: expected [] to deeply equal [ 'App', 'AppTests' ]
```
Native package baseline (darwin arm64 / darwin x64): scripts/verify-package-prompts.mjs → packaged MCP prompt completion lifecycle failed (expects ["fixture"] after opening the fixture target).

Reproduced locally on c22111eca with npm run test:focused -- tests/boundary/mcp/promptCompletion.test.ts.

Cause (source-derived)

07b36c148 routes document/procedure completion through BinarySessionPort.executeIfProviderReady, which returns undefined (so no completions) unless the active client implements executeIfReady. The test client built by createTestBinarySession(() => client(requests)) in promptCompletion.test.ts does not implement executeIfReady, and the test still asserts the earlier eager behavior. The packaged smoke similarly still expects completions from the opened fixture target.

Expected behavior

CI green on main. Which side should change depends on the intended contract: either the test/smoke fixtures implement executeIfReady (a ready session still completes), or the assertions move to the new "no completion until ready" behavior. I'm leaving that choice to the commit author rather than guessing.

Originally created by @kaoru0822-kitauji on GitHub (Oct 12, 2026). Original GitHub issue: https://github.com/morluto/rea/issues/2123 ### Observed behavior Main CI has failed since 07b36c148 (`fix(mcp): keep prompt completion within ready provider sessions`). It passed on 0d5033ad1; the 07b36c148 run was cancelled and c22111eca failed. Every PR based on current main inherits these failures (e.g. #2118). - `Test shard (1/4)`: `tests/boundary/mcp/promptCompletion.test.ts > guided prompt completion from live analysis > reads live documents and complete procedures without ambiguous names` ```text AssertionError: expected [] to deeply equal [ 'App', 'AppTests' ] ``` - `Native package baseline (darwin arm64 / darwin x64)`: `scripts/verify-package-prompts.mjs` → `packaged MCP prompt completion lifecycle failed` (expects `["fixture"]` after opening the fixture target). Reproduced locally on c22111eca with `npm run test:focused -- tests/boundary/mcp/promptCompletion.test.ts`. ### Cause (source-derived) 07b36c148 routes document/procedure completion through `BinarySessionPort.executeIfProviderReady`, which returns `undefined` (so no completions) unless the active client implements `executeIfReady`. The test client built by `createTestBinarySession(() => client(requests))` in `promptCompletion.test.ts` does not implement `executeIfReady`, and the test still asserts the earlier eager behavior. The packaged smoke similarly still expects completions from the opened fixture target. ### Expected behavior CI green on main. Which side should change depends on the intended contract: either the test/smoke fixtures implement `executeIfReady` (a ready session still completes), or the assertions move to the new "no completion until ready" behavior. I'm leaving that choice to the commit author rather than guessing.

bsakaguchi

2026-10-15 18:27:28 +00:00