[PR #5599] [CLOSED] fix(mcp): align trace feature description with result #6988

Closed
opened 2026-11-01 21:44:31 +00:00 by bsakaguchi · 0 comments
Owner

📋 Pull Request Information

Original PR: https://github.com/morluto/rea/pull/5599
Author: @hifzabuildsai
Created: 10/20/2026
Status: ❌ Closed

Base: main ← Head: fix/trace-feature-description


📝 Commits (2)

  • fedcdba fix(mcp): align trace feature description with result
  • 6100144 test(mcp): pin truthful trace feature description

📊 Changes

2 files changed (+9 additions, -1 deletions)

View changed files

📝 src/contracts/enhancedToolContracts.ts (+1 -1)
📝 tests/boundary/mcp/enhancedTools.01-lists-the-complete-target-open.test.ts (+8 -0)

📄 Description

Summary

Superseded by upstream; closing without merging this branch. The unsupported trace_feature operation-count promise was removed independently in 2ebaadfa8. This was verified in pinned main fc43e285e: the description now says it returns observations and residual unknowns.

Related issue #5507 is closed as completed. Maintainer @morluto also closed the overlapping #5790 as superseded. This PR is not claimed as merged or as the source of the upstream fix.

Problem and expected behavior

The original catalog promised an operation count, but the output schema and successful results expose no such field or defined unit. The catalog should not promise unavailable information. Current main satisfies that requirement by removing the unsupported promise.

Change and scope

The original two-file proposal corrected the description and added a production-registration assertion. Its exact replacement wording is no longer needed: main already has a truthful description. No rebase or conflict-resolution commit is being published merely to replace valid upstream wording.

Follow the contribution scope.
Unresolved scope, authority, side effects, or required verification block
integration. Link the required maintainer scope decision for new providers or
capabilities involving target execution, injection, mutation, or protection
recovery; ordinary fixes within existing boundaries may state "not applicable".
Draft PRs may leave the scope decision pending and the readiness and merge checklists
unchecked. Maintainers can help resolve open questions.

Contract and boundary impact

  • Semantic owner and earliest changed stage: canonical enhanced-tool description, consumed by public MCP registration.
  • Contribution scope fit and linked maintainer decision: existing wording correction; a separate scope decision is not applicable.
  • CLI and MCP/tool-catalog contract: original proposal changed the description only; inputs and result schema unchanged.
  • Provider, bridge, target-format, or platform compatibility: unchanged by the original proposal.
  • Evidence, artifact, provenance, or reconstruction contract: unchanged.
  • Target selection, authority, upstream behavior, and cleanup details (if applicable): no target interaction or runtime behavior changes.
  • Generated metadata (docs/public/product-catalog.json), package, or installation impact (CI generates and validates ignored catalogs and skills/; edit authored instructions in .agents/skills/reverse-engineer-anything/ and never commit build outputs): no generated files or release changes proposed.

Expected effects (check known effects; use documentation-only on its own).
Unchecked items do not establish absence; leave uncertainties visible.

  • Read existing files or captured data.
  • Launch or attach to a process.
  • Inject instrumentation or run scripts/code.
  • Change process memory, registers, files, or configuration.
  • Contact network services.
  • Recover protected code or work around protections.
  • Documentation or usability only; no target interaction.
  • Not sure yet; investigation or maintainer guidance needed.

Evidence and regression coverage

  • Tests added or updated: the original branch added catalog assertions in tests/boundary/mcp/enhancedTools.01-lists-the-complete-target-open.test.ts; these are not claimed present on current main.
  • Base reproduction or other evidence: source-derived audit on 2026-10-25. Verified that 2ebaadfa847d3fd2e745a4619c44d3911efde2da is an ancestor of pinned main fc43e285eaae2155d32e2ca0ab5d2181a4e2f1b5. Inspected the canonical trace_feature declaration and confirmed the unsupported phrase is absent.
  • User-visible CLI/MCP output (if applicable): no new runtime output captured; closure is based on canonical source and upstream issue/PR history.
  • Remaining proof gaps: no new current-main test run or real-provider execution. The old branch still has conflicts and historical failed CI; neither is represented as repaired.

For boundary fixes, identify the applicable boundary regressions
and lifecycle regressions
covered by the evidence above, and explain relevant gaps.

The original boundary assertion checked the production MCP catalog. Lifecycle behavior was outside scope; no runtime fix is being integrated by this closure.

For evidence-bearing changes:

  • Observed, derived, and inferred claims remain distinguishable.
  • Artifact identity, source provenance, and failed attempts remain preserved.
  • Unsupported, incomplete, unavailable, or uncertain outcomes remain visible.

Not applicable to this description-only proposal: no Evidence-producing behavior changes.

Validation performed

Closure audit, executed 2026-10-25:

  • git merge-base --is-ancestor 2ebaadfa847d3fd2e745a4619c44d3911efde2da fc43e285eaae2155d32e2ca0ab5d2181a4e2f1b5 — exit 0.
  • Read the pinned main contract with git show; local assertions confirmed the trace_feature declaration contains "Returns observations and residual unknowns" and does not contain "operation count" — passed.
  • GitHub API inspection — #5507 closed as completed; #5790 closed unmerged with the maintainer's supersession explanation.
  • git status --short — clean; no source edits or branch pushes made for this closure.

Historical validation of the original branch (not current main), Linux / Node.js 24.19.0:

  • npm run test:focused -- tests/boundary/mcp/enhancedTools.01-lists-the-complete-target-open.test.ts — 3 passed.
  • npm run check:fast — typecheck and lint passed.
  • git diff --check — passed.

Compatibility, safety, and release

  • Breaking changes or migration steps: none published by this closure.
  • Real Hopper/Ghidra, browser, or OS coverage: no fresh real-provider workflow; source-derived closure only.
  • Package or release metadata impact: none.
  • Security, privacy, process, or containment review: no target execution, mutation or permission changes.

Author readiness

Human owner: @hifzabuildsai

  • I reviewed the final diff and relevant existing code, understand the change and its edge cases, and take responsibility for the complete PR, including AI-assisted work.
  • I checked the evidence above, confirmed it supports the current change, and recorded meaningful validation gaps.
  • I declare this PR ready for initial maintainer review.

Before merge

This checklist remains unchecked because this PR is superseded and is not requesting integration.

  • This PR addresses a concrete problem or an agreed enhancement.
  • Material scope and authority questions are resolved, and any required maintainer scope decision covers the final diff.
  • The PR has one focused outcome and the title follows type(scope): outcome.
  • Related issue is linked, or the reason for not linking one is stated above.
  • Tests cover changed observable behavior and meaningful failure paths.
  • Owning docs, contracts, and generated metadata are updated where needed.
  • User-visible CLI/MCP changes include representative output.
  • I checked the final diff for secrets, unrelated cleanup, and unsupported claims.

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/morluto/rea/pull/5599 **Author:** [@hifzabuildsai](https://github.com/hifzabuildsai) **Created:** 10/20/2026 **Status:** ❌ Closed **Base:** `main` ← **Head:** `fix/trace-feature-description` --- ### 📝 Commits (2) - [`fedcdba`](https://github.com/morluto/rea/commit/fedcdbab9efd606c1d1efa1e60eaeaabb69b40fd) fix(mcp): align trace feature description with result - [`6100144`](https://github.com/morluto/rea/commit/61001445d6bf4683ec3bfea1ef29e5da981ca1e1) test(mcp): pin truthful trace feature description ### 📊 Changes **2 files changed** (+9 additions, -1 deletions) <details> <summary>View changed files</summary> 📝 `src/contracts/enhancedToolContracts.ts` (+1 -1) 📝 `tests/boundary/mcp/enhancedTools.01-lists-the-complete-target-open.test.ts` (+8 -0) </details> ### 📄 Description ## Summary **Superseded by upstream; closing without merging this branch.** The unsupported `trace_feature` operation-count promise was removed independently in [`2ebaadfa8`](https://github.com/morluto/rea/commit/2ebaadfa847d3fd2e745a4619c44d3911efde2da). This was verified in pinned main [`fc43e285e`](https://github.com/morluto/rea/blob/fc43e285eaae2155d32e2ca0ab5d2181a4e2f1b5/src/contracts/enhancedToolContracts.ts): the description now says it returns observations and residual unknowns. Related issue #5507 is closed as completed. Maintainer @morluto also [closed the overlapping #5790 as superseded](https://github.com/morluto/rea/pull/5790). This PR is not claimed as merged or as the source of the upstream fix. ## Problem and expected behavior The original catalog promised an operation count, but the output schema and successful results expose no such field or defined unit. The catalog should not promise unavailable information. Current main satisfies that requirement by removing the unsupported promise. ## Change and scope The original two-file proposal corrected the description and added a production-registration assertion. Its exact replacement wording is no longer needed: main already has a truthful description. No rebase or conflict-resolution commit is being published merely to replace valid upstream wording. Follow the [contribution scope](https://github.com/morluto/rea/blob/main/CONTRIBUTING.md#contribution-scope). Unresolved scope, authority, side effects, or required verification block integration. Link the required maintainer scope decision for new providers or capabilities involving target execution, injection, mutation, or protection recovery; ordinary fixes within existing boundaries may state "not applicable". Draft PRs may leave the scope decision pending and the readiness and merge checklists unchecked. Maintainers can help resolve open questions. ## Contract and boundary impact - Semantic owner and earliest changed stage: canonical enhanced-tool description, consumed by public MCP registration. - Contribution scope fit and linked maintainer decision: existing wording correction; a separate scope decision is not applicable. - CLI and MCP/tool-catalog contract: original proposal changed the description only; inputs and result schema unchanged. - Provider, bridge, target-format, or platform compatibility: unchanged by the original proposal. - Evidence, artifact, provenance, or reconstruction contract: unchanged. - Target selection, authority, upstream behavior, and cleanup details (if applicable): no target interaction or runtime behavior changes. - Generated metadata (`docs/public/product-catalog.json`), package, or installation impact (CI generates and validates ignored catalogs and `skills/`; edit authored instructions in `.agents/skills/reverse-engineer-anything/` and never commit build outputs): no generated files or release changes proposed. Expected effects (check known effects; use documentation-only on its own). Unchecked items do not establish absence; leave uncertainties visible. - [ ] Read existing files or captured data. - [ ] Launch or attach to a process. - [ ] Inject instrumentation or run scripts/code. - [ ] Change process memory, registers, files, or configuration. - [ ] Contact network services. - [ ] Recover protected code or work around protections. - [x] Documentation or usability only; no target interaction. - [ ] Not sure yet; investigation or maintainer guidance needed. ## Evidence and regression coverage - Tests added or updated: the original branch added catalog assertions in `tests/boundary/mcp/enhancedTools.01-lists-the-complete-target-open.test.ts`; these are not claimed present on current main. - Base reproduction or other evidence: source-derived audit on 2026-10-25. Verified that `2ebaadfa847d3fd2e745a4619c44d3911efde2da` is an ancestor of pinned main `fc43e285eaae2155d32e2ca0ab5d2181a4e2f1b5`. Inspected the canonical `trace_feature` declaration and confirmed the unsupported phrase is absent. - User-visible CLI/MCP output (if applicable): no new runtime output captured; closure is based on canonical source and upstream issue/PR history. - Remaining proof gaps: no new current-main test run or real-provider execution. The old branch still has conflicts and historical failed CI; neither is represented as repaired. For boundary fixes, identify the applicable [boundary regressions](https://github.com/morluto/rea/blob/main/docs/testing.md#boundary-regressions) and [lifecycle regressions](https://github.com/morluto/rea/blob/main/docs/testing.md#lifecycle-regressions) covered by the evidence above, and explain relevant gaps. The original boundary assertion checked the production MCP catalog. Lifecycle behavior was outside scope; no runtime fix is being integrated by this closure. For evidence-bearing changes: - [ ] Observed, derived, and inferred claims remain distinguishable. - [ ] Artifact identity, source provenance, and failed attempts remain preserved. - [ ] Unsupported, incomplete, unavailable, or uncertain outcomes remain visible. Not applicable to this description-only proposal: no Evidence-producing behavior changes. ## Validation performed Closure audit, executed 2026-10-25: - `git merge-base --is-ancestor 2ebaadfa847d3fd2e745a4619c44d3911efde2da fc43e285eaae2155d32e2ca0ab5d2181a4e2f1b5` — exit 0. - Read the pinned main contract with `git show`; local assertions confirmed the `trace_feature` declaration contains "Returns observations and residual unknowns" and does not contain "operation count" — passed. - GitHub API inspection — #5507 closed as completed; #5790 closed unmerged with the maintainer's supersession explanation. - `git status --short` — clean; no source edits or branch pushes made for this closure. Historical validation of the original branch (not current main), Linux / Node.js 24.19.0: - `npm run test:focused -- tests/boundary/mcp/enhancedTools.01-lists-the-complete-target-open.test.ts` — 3 passed. - `npm run check:fast` — typecheck and lint passed. - `git diff --check` — passed. ## Compatibility, safety, and release - Breaking changes or migration steps: none published by this closure. - Real Hopper/Ghidra, browser, or OS coverage: no fresh real-provider workflow; source-derived closure only. - Package or release metadata impact: none. - Security, privacy, process, or containment review: no target execution, mutation or permission changes. ## Author readiness Human owner: @hifzabuildsai - [x] I reviewed the final diff and relevant existing code, understand the change and its edge cases, and take responsibility for the complete PR, including AI-assisted work. - [x] I checked the evidence above, confirmed it supports the current change, and recorded meaningful validation gaps. - [x] I declare this PR ready for initial maintainer review. ## Before merge This checklist remains unchecked because this PR is superseded and is not requesting integration. - [ ] This PR addresses a concrete problem or an agreed enhancement. - [ ] Material scope and authority questions are resolved, and any required maintainer scope decision covers the final diff. - [ ] The PR has one focused outcome and the title follows `type(scope): outcome`. - [ ] Related issue is linked, or the reason for not linking one is stated above. - [ ] Tests cover changed observable behavior and meaningful failure paths. - [ ] Owning docs, contracts, and generated metadata are updated where needed. - [ ] User-visible CLI/MCP changes include representative output. - [ ] I checked the final diff for secrets, unrelated cleanup, and unsupported claims. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
bsakaguchi 2026-11-01 21:44:31 +00:00
Sign in to join this conversation.
No milestone
No project
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference
morluto/rea#6988
No description provided.