mirror of
https://github.com/morluto/rea.git
synced 2026-11-05 06:45:22 +00:00
[PR #5633] [MERGED] fix(errors): name fixed allowances in resource-constraint recovery #7007
Closed
opened 2026-11-01 21:44:39 +00:00 by bsakaguchi
·
0 comments
No Branch/Tag specified
main
codex/procedure-reference-stacked
release-please--branches--main--components--rea-agents
release-please--branches--main--components--rea-agents--release-notes
codex/kuna-independent-retry
codex/byte-search-overlay-coverage
codex/open-failure-target-receipt
codex/kuna-xref-evidence
codex/ghidra-ambiguous-procedure-recovery
codex/function-source-bundle
codex/trace-function-integration-prototype
codex/snapshot-source-closure
codex/recorded-evidence-array-pages
codex/evidence-recovery-redesign
codex/trace-feature-address-scope
codex/call-discovery-scope
codex/ghidra-literal-candidate-evidence
codex/decompile-directory-independent-retry
codex/retry-provenance-base
codex/value-flow-capability-experiment
codex/ghidra-containing-instruction
cursor/readme-discord-button-ef9f
dependabot/github_actions/actions/setup-node-7.1.0
dependabot/github_actions/actions/upload-artifact-7.0.2
dependabot/npm_and_yarn/npm-minor-and-patch-d8d97ce6df
codex/kuna-1989
fix/8559-native-ui-fixture-ownership
fix/8555-go-verifier-mcp-ownership
codex/provider-capability-recovery
fix/8642-rizin-target-stdin
codex/ghidra-memory-effect-scope
codex/ghidra-annotation-entry-selector
codex/ghidra-readonly-recovery
codex/ghidra-regex-verifier-recovery
codex/evidence-discovery-view-guidance
fix/8545-bulk-append-overflow
fix/8428-navigation-refusal-alternatives
codex/address-context-recovery
codex/matching-member-limitations
codex/unknown-scope-contract
codex/evidence-view-guidance
feat/8373-native-trace-views
codex/ghidra-snapshot-verifier-binding
codex/elf-export-visibility
codex/evidence-view-recovery
codex/native-reference-cli-help
codex/provider-candidate-observation-scope
codex/kuna-session-verification
codex/ghidra-switch-lifetime-guidance
codex/pseudocode-paging-discovery
codex/clarify-evidence-view-support
codex/kuna-xrefs-selector-recovery
codex/context-capacity-recovery
codex/evidence-closure-large-links
codex/same-function-evidence-identity
codex/ghidra-verifier-inspected-jdk
codex/audit-guided-workflows
codex/crash-prompt-retained-dossiers
codex/analysis-view-error-recovery
codex/kuna-verifier-target-selection
codex/ghidra-selected-project-call-coverage
codex/docs-native-analysis-scope
codex/ghidra-java-socket-boundary
codex/ghidra-retained-snapshot-verifier
codex/ghidra-search-inventory-facts
fix/8284-zero-argument-parameter-bindings
fix/8198-ui-action-handler-offset
fix/8257-elf-entry-label-identity
fix/8304-deferred-output-schema-projection
fix/8277-call-path-computed-target-uncertainty
fix/pr-8089-conflicts
fix/ci-static-duplicate-export
dependabot/npm_and_yarn/lint-staged-17.6.0
dependabot/github_actions/actions/download-artifact-8.0.2
dependabot/npm_and_yarn/write-file-atomic-8.0.0
dependabot/npm_and_yarn/canonicalize-5.1.0
dependabot/github_actions/actions/cache/restore-6.1.0
dependabot/npm_and_yarn/toon-format/toon-4.4.0
dependabot/github_actions/actions/deploy-pages-5.0.1
codex/review-fixes-pr-2403
codex/review-fixes-pr-2400
codex/process-terminal-width
codex/test-brittleness-cleanup
verify/7167-browser-connect-macos
fix/7167-browser-connect
feat/native-matching-allowance-setting
feat/browser-scenario-dry-run
test/managed-caller-parameters-20261024
codex/parser-fortythird-boundaries
fix/6926-pinvoke-platform-decorations-20261023
fix/6889-har-body-encoding-20261023
fix/6888-sqlite-schema-budget-20261023
fix/dependency-security-gates-6708
cursor/evidence-overwrite-rebase-b4ac
feat/4057-verify-native-exports
fix/windows-acl-observer-overhead-20261022
cursor/erlang-beam-restack-4476
cursor/pe-certificate-review-bf32
fix/6116-javascript-application-fs-errors
fix/6061-unmapped-runtime-script-unknown
feat/browser-scenario-summary
fix/pe-certificates
codex/verify-3407
cursor/rebase-5699
cursor/rebase-5352
cursor/rebase-5600
cursor/fix-cli-schema-omission-10a8
codex/audit-hopper-shutdown-reasons-20261021
fix/demangle-swift-omitted-record
fix/nib-boolean-value-types
cursor/cancellation-partial-observation-a5ac
fix/ib-object-limit-reasons
fix/electron-fuse-limit-advice
fix/kuna-doctor-dangling-cache
fix/fixed-budget-refusal-advice
fix/js-ipc-listener-dedup
fix/js-return-member-provenance
fix/dmg-integrity-retry-advice
fix/ida-doctor-readiness
fix/kuna-version-probe-output-drain
fix/legacy-swift-runtime-name-matching
fix/dylib-lazy-load-commands
fix/browser-scenario-startup-cancel
fix/swift-nested-punycode-classification
fix/compare-unselected-scopes
fix/objc-method-budget-coverage
fix/dmg-mounted-root-observations
audit/ci-tests-20261019-round2
release/6.7.0
fix/wabt-cleanup-retry-resolution
fix/electron-fuse-elf-pe-architecture
fix/native-plist-descriptor-ownership
fix/kuna-caller-cleanup-ownership
experiment/atomic-codemode-20261016
review/first-contributor-3776
fix/call-resolution-full-read-cycles
fix/member-mutation-selection-repeat
experiment/atomic-re-tools-20261015
perf/member-mutation-lazy-origins
perf/static-network-mutation-index
fix/hopper-startup-lifecycle
audit/3050-windows-proof-20261015
feat/windows-window-capture-2183
audit/3049-windows-proof-20261015
audit/3735-macos-fixtures-20261015
fix/batch-decompile-null-pseudocode
fix/kuna-inventory-honors-jobs
experiment/browser-codemode-tool-design-20261015
fix/hopper-clean-runtime-argv
codex/review-2049-27f1b367
review-fixes/pr-2787-routing
fix/3360-scoped-this-emitters
fix/3367-replaced-global-effects
fix/3838-compact-any-value-items
test/hopper-download-probe-20261015
codex/windows-runtime-creation-red-green-20261015
codex/windows-readonly-root-red-green-20261015
codex/windows-root-share-red-green-20261015
codex/exp-1685-win-mcp-startup
codex/bug-sweep-20261015
investigate/2190-windows-package-phases
investigate/3543-macos-cli-deadline
perf/3281-reverse-tools-feedback-quality
fix/3406-hopper-doctor-fixture
fix/3341-wrapper-require-test-context
fix/3301-owned-uninstall-fixtures
fix/3164-compiler-input-ownership
fix/pcap-cleanup-stdout-newline-20261014
perf/interface-builder-summary
codex/review-fixes-pr-1977
fix/ghidra-effective-jvm-platform
fix/docs-turkish-rust-link-20261013
fix/main-maintenance-ci-20261010
fix/recover-binary-session-process-effects
codex/review-fixes-pr-2457
codex/ci-required-cancellation-gate
fix/main-format-baseline-20261013
fix/setup-preserve-entry-fields
cursor/restore-main-checks-1ffc
fix/ghidra-bridge-hashmap-import
codex/shared-ci-jadx-json-default-20261013
codex/shared-ci-ghidra-test-groups-20261013
codex/shared-ci-java-fixture-format-20261013
codex/fix-intrinsic-invocation-boundaries
test/release-preflight-reusable-jobs
test/js-parameter-provenance-expectation
fix/linux-hopper-verification-current
test/2419-ghidra-elf-probe-size
followup/pr-1544-native-ida
codex/fold-pr-2230-contribution
docs/readme-responsible-use
fix/issue-2064
fix/issue-2050
fix/issue-2053
fix/issue-1968
fix/issue-1945
experiment/codemode-bridge-20261011
fix/tool-effects-negative-wording-1904-20261012
fix/1842-electron-interop-provenance
feat/recover-javascript-multi-input
refactor/website-i18n-prep
fix/nativeaot-pe-virtual-extent
fix/browser-verifier-ci-hang
fix/pe-resources-input-selection
docs/beginner-friendly-guides
docs/beginner-setup-guide
fix/javascript-analysis-worker-1563
fix/1649-ghidra-duplicate-names
fix/javascript-export-keys-integration-1369
test/maintenance-boundary-contracts-20261011
review/javascript-export-keys-1369
review/process-live-progress-1483
test/javascript-1495-growth-ratio
fix/ci-escape-timing
docs/normalized-terminal-geometry-1450
release/6.3.0
archive/release-6.3.0-pr1381
release/6.2.0
fix/electron-preload-dynamic-override
fix/javascript-self-referential-bundler-edges
release/6.1.0
cursor/grok-client-cherry-pick-0b56
feat/signature-posture
feat/dyld-shared-cache
feat/artifact-integrity-policy
feat/pkg-inventory
release/6.0.0
chore/sync-release-5.0.0
release/5.0.0
cursor/cloud-agent-node-787e
fix/javascript-xhr-open-endpoints
review/pr-711-realpath-fallback-wording
cleanup/replay-confinement
codex/test-suite-performance
codex/issue-foundations
codex/address-open-issues-2026-07-20
agent/javascript-vite-rollup-esbuild-adapters
agent/process-cleanup
agent/triage-integration
agent/unknown-commands-registry
feat/mcp-identity-metadata
morlvps/issue_cleanup
codex/installer-redesign
morl/roadmap-investigation-core
morl/roadmap-investigation-docs
release-please--branches--main--components--rea
rea-agents-6.8.0
rea-agents-6.7.0
rea-agents-6.6.0
experiment/atomic-codemode-wait-runtime-20261016
rea-agents-6.5.0
rea-agents-6.4.0
rea-agents-6.3.0
rea-agents-6.2.0
rea-agents-6.1.0
rea-agents-6.0.0
rea-agents-5.0.0
rea-agents-4.1.0
rea-agents-4.0.1
rea-agents-4.0.0
rea-agents-3.2.1
rea-agents-3.2.0
rea-agents-3.1.0
rea-agents-3.0.0
rea-agents-2.7.0
rea-agents-2.6.0
rea-agents-2.5.1
rea-agents-2.5.0
rea-agents-2.4.0
rea-agents-2.3.0
rea-agents-2.2.0
rea-agents-2.1.0
rea-agents-2.0.0
rea-agents-1.7.0
rea-agents-1.6.0
rea-agents-1.5.0
rea-agents-1.4.0
rea-agents-1.3.0
rea-agents-1.2.0
rea-agents-1.1.0
rea-agents-1.0.0
rea-agents-0.5.0
rea-agents-0.4.0
rea-agents-0.3.0
rea-0.2.1
rea-0.2.0
Labels
Clear labels
area: bridge
area: bridge
area: build
area: build
area: build
area: cli
area: domain
area: evidence
area: mcp
area: native
area: providers
area: runtime
area: server
area: setup
area: tests
bug
design
documentation
enhancement
enhancement
enhancement
experiment
help wanted
i18n
invalid
P0: critical
P1: high
P2: medium
P2: medium
P2: medium
P3: low
performance
provider-request
pull-request
Mirrored from GitHub Pull Request
question
roadmap
triage
No labels
area: bridge
area: bridge
area: build
area: build
area: build
area: cli
area: domain
area: evidence
area: mcp
area: native
area: providers
area: runtime
area: server
area: setup
area: tests
bug
design
documentation
enhancement
enhancement
enhancement
experiment
help wanted
i18n
invalid
P0: critical
P1: high
P2: medium
P2: medium
P2: medium
P3: low
performance
provider-request
pull-request
question
roadmap
triage
Milestone
Clear milestone
No items
No milestone
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".
No due date set.
Dependencies
No dependencies set.
Reference
morluto/rea#7007
Loading…
Add table
Add a link
Reference in a new issue
No description provided.
Delete branch "%!s()"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
📋 Pull Request Information
Original PR: https://github.com/morluto/rea/pull/5633
Author: @morluto
Created: 10/20/2026
Status: ✅ Merged
Merged: 10/20/2026
Merged by: @morluto
Base:
main← Head:cursor/fixed-allowance-remediation-e4bd📝 Commits (10+)
cdcf981fix(errors): name fixed allowances in resource-constraint recovery461c836fix(il2cpp): keep a closing metadata reader non-retryable1d1bec7fix(errors): align fixed-cap recovery with retained factseb8c31ffix(errors): call byte caps a byte allowance2aea136merge(main): take non-retryable invalid requestsd98025btest(ida): keep unresolved procedure lookups non-retryablee7c2bfdfix(errors): qualify capture recovery for live output99fc090fix(adb): keep a truncated live capture retryablea7ccb97fix(adb): keep truncated mutations non-retryable5e053dbfix(errors): keep live capture recovery off deterministic limits📊 Changes
40 files changed (+888 additions, -51 deletions)
View changed files
📝
src/adb/AdbCommand.test.ts(+37 -0)📝
src/adb/AdbCommand.ts(+15 -2)📝
src/adb/AdbConfiguration.ts(+8 -1)📝
src/adb/AdbProvider.ts(+15 -3)📝
src/apktool/ApktoolProvider.ts(+5 -0)📝
src/application/wasm/WasmInterfaceComparisonService.test.ts(+72 -1)📝
src/application/wasm/WasmInterfaceComparisonService.ts(+5 -0)📝
src/captures/TsharkCaptureProvider.ts(+12 -1)📝
src/domain/analysisView/WebNetworkProjectionAccumulator.ts(+5 -0)➕
src/domain/fixedAllowanceRemediation.test.ts(+67 -0)➕
src/domain/fixedAllowanceRemediation.ts(+49 -0)📝
src/dotnet/ManagedSnapshot.ts(+2 -0)📝
src/electron/ElectronFuseFailures.ts(+10 -1)📝
src/electron/ElectronFuseProvider.test.ts(+11 -0)📝
src/flutter/FlutterBuildProvider.ts(+22 -1)📝
src/go/GoBinaryProvider.ts(+13 -1)📝
src/il2cpp/Il2cppGhidraSeeds.ts(+39 -9)📝
src/il2cpp/Il2cppMetadataProvider.ts(+41 -3)📝
src/native/AppleDispatchMetadata.ts(+5 -0)📝
src/native/NativeMacOSProvider.ts(+8 -1)...and 20 more files
📄 Description
Summary
Fixed inspection, report, and capture refusals told callers to add memory, wait and retry, or recover Evidence that the refusal never produced. The allowances stay fixed. Recovery now names the allowance that was exceeded.
Fixes #5556, #5405, #5456, #5459, #5460, #5504, #5505, #5506, #5537, #5628, #5630, #5631, #5632.
Problem and expected behavior
A fixed parser, count, report, input, or capture allowance was thrown as
AnalysisResourceConstraintErrorwithoutremediationAction. Shared projection then used the resource-kind fallback:memory: review worker and host memorycapacity: wait for an active analysis, andretryable: truetransport: retrieve retained Evidence or use complete CLI JSONfile-size: raise the evidence-reply file-size allowanceThose actions cannot admit the same input. Occupied IL2CPP reader capacity was also classified as memory, so a second inspection looked non-retryable.
Callers should still be refused. Recovery should name the fixed allowance. Deterministic caps stay
retryable: false. A second IL2CPP inspection stays retryable only while that reader remains open. Onceclose()has stopped admission, the reader iscapability_unavailableand non-retryable, including a second inspect that arrives while the active inspection is still finishing.Change and scope
fixedAllowanceRemediationowns the recovery sentences. Each producer that enforces a fixed allowance sets that recovery when it constructs the error. PE resource metadata refusals also reportmaximum_metadata_bytes. IL2CPP reader occupancy uses capacity and tells the caller to retry after the active inspection only when the reader has not started closing.close()records that admission has stopped before it waits for the active inspection, and later inspects use that fact.The IL2CPP complete-report refusal keeps source facts already observed on the error. Its recovery says no complete inventory is retained and does not deny that source observation. Command-output overruns use the retained command-output allowance. Ghidra seed recovery names the seed-name, seed-file, or seed-entry allowance that was exceeded. Byte budgets, including the WASM representation caps and the Ghidra seed-file cap, say they are a fixed byte allowance. Count limits stay a fixed count.
The generic fallback remains for genuine host, worker, or process resource failures that do not set their own recovery. Flutter snapshot-storage errors that forward an arbitrary filesystem code are unchanged.
Follow the contribution scope.
This is an ordinary recovery-text fix inside existing inspection and capture boundaries. No new provider, target execution, injection, mutation, or protection recovery. Maintainer scope decision: not applicable.
Contract and boundary impact
ArtifactAnalysisResources.commandFailure.resource_constraintcode and resource kinds, except IL2CPP reader occupancy changes frommemorytocapacityand stays retryable while the reader is open. A closing or closed reader projectscapability_unavailablewithretryable: false. Recovery text andretryablechange for the fixed allowances listed in the linked issues. No catalog schema change.docs/public/product-catalog.json), package, or installation impact (CI generates and validates ignored catalogs andskills/; edit authored instructions in.agents/skills/reverse-engineer-anything/and never commit build outputs): none.Expected effects (check known effects; use documentation-only on its own).
Unchecked items do not establish absence; leave uncertainties visible.
Evidence and regression coverage
maximum_metadata_bytes; IL2CPP occupied-open retryable capacity, closing/closed non-retryable admission, and complete-report source facts; Ghidra seed-file byte allowance and seed-name count; typed WASM interface inventory and a comparison of two inventories that together exceed the cap; command-output allowance inArtifactAnalysisResourcesand the tshark and sigrok provider simulators.remediation.actionand, for deterministic capacity caps,retryable: false. An open occupied IL2CPP reader projectsretryable: trueandresource: "capacity". A closing or closed reader projectscapability_unavailableandretryable: false. A fixed command-output cap names the retained command-output allowance. Byte caps sayfixed byte allowance.For evidence-bearing changes:
Validation performed
npm run test:local -- src/domain/fixedAllowanceRemediation.test.ts src/wasm/WasmInterfaceBudget.test.ts src/electron/ElectronFuseProvider.test.ts src/native/pe/PeResourcesProvider.test.ts— 38 passed, then the PE file again with the helper test: 14 passed.npm run test:focused -- tests/boundary/go/goBinaryProvider.test.ts tests/boundary/rust/rustBinaryBudget.test.ts tests/boundary/il2cpp/il2cppMetadataProvider.test.ts tests/boundary/filesystem/flutterBuildProvider.test.ts— 125 passed on an earlier head.1d1bec7ad:npm run test:local -- src/process/ArtifactAnalysisResources.test.ts src/application/wasm/WasmInterfaceComparisonService.test.ts— 23 passed and 7 passed.npm run test:focused -- tests/boundary/il2cpp/il2cppMetadataProvider.test.ts tests/boundary/il2cpp/il2cppGhidraSeeds.test.ts tests/boundary/captures/captureProvider.test.ts tests/boundary/signals/recordingProvider.test.ts— 19, 8, 37, and 36 passed.eb8c31fd0:npm run test:local -- src/domain/fixedAllowanceRemediation.test.ts src/wasm/WasmInterfaceBudget.test.ts src/application/wasm/WasmInterfaceComparisonService.test.ts— 7, 1, and 7 passed.npm run test:focused -- tests/boundary/il2cpp/il2cppGhidraSeeds.test.ts— 8 passed.npm run check:fast— typecheck and lint passed on this head.Not run:
npm run check:pr, real apktool/adb/tshark/sigrok/Ghidra/Hopper workflows, or the original issue CLI scripts.Compatibility, safety, and release
resource: "memory"/retryable: false, will see the new text and, for an open occupied reader,capacitywithretryable: true. A closing or closed reader iscapability_unavailablewithretryable: falseinstead of retryable capacity. Deterministic capacity caps that wereretryable: trueare nowretryable: false.Author readiness
Human owner: @morluto
Before merge
type(scope): outcome.🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.