mirror of
https://github.com/morluto/rea.git
synced 2026-11-05 06:45:22 +00:00
Closed
opened 2026-11-01 21:44:40 +00:00 by bsakaguchi
·
0 comments
No Branch/Tag specified
main
codex/procedure-reference-stacked
release-please--branches--main--components--rea-agents
release-please--branches--main--components--rea-agents--release-notes
codex/kuna-independent-retry
codex/byte-search-overlay-coverage
codex/open-failure-target-receipt
codex/kuna-xref-evidence
codex/ghidra-ambiguous-procedure-recovery
codex/function-source-bundle
codex/trace-function-integration-prototype
codex/snapshot-source-closure
codex/recorded-evidence-array-pages
codex/evidence-recovery-redesign
codex/trace-feature-address-scope
codex/call-discovery-scope
codex/ghidra-literal-candidate-evidence
codex/decompile-directory-independent-retry
codex/retry-provenance-base
codex/value-flow-capability-experiment
codex/ghidra-containing-instruction
cursor/readme-discord-button-ef9f
dependabot/github_actions/actions/setup-node-7.1.0
dependabot/github_actions/actions/upload-artifact-7.0.2
dependabot/npm_and_yarn/npm-minor-and-patch-d8d97ce6df
codex/kuna-1989
fix/8559-native-ui-fixture-ownership
fix/8555-go-verifier-mcp-ownership
codex/provider-capability-recovery
fix/8642-rizin-target-stdin
codex/ghidra-memory-effect-scope
codex/ghidra-annotation-entry-selector
codex/ghidra-readonly-recovery
codex/ghidra-regex-verifier-recovery
codex/evidence-discovery-view-guidance
fix/8545-bulk-append-overflow
fix/8428-navigation-refusal-alternatives
codex/address-context-recovery
codex/matching-member-limitations
codex/unknown-scope-contract
codex/evidence-view-guidance
feat/8373-native-trace-views
codex/ghidra-snapshot-verifier-binding
codex/elf-export-visibility
codex/evidence-view-recovery
codex/native-reference-cli-help
codex/provider-candidate-observation-scope
codex/kuna-session-verification
codex/ghidra-switch-lifetime-guidance
codex/pseudocode-paging-discovery
codex/clarify-evidence-view-support
codex/kuna-xrefs-selector-recovery
codex/context-capacity-recovery
codex/evidence-closure-large-links
codex/same-function-evidence-identity
codex/ghidra-verifier-inspected-jdk
codex/audit-guided-workflows
codex/crash-prompt-retained-dossiers
codex/analysis-view-error-recovery
codex/kuna-verifier-target-selection
codex/ghidra-selected-project-call-coverage
codex/docs-native-analysis-scope
codex/ghidra-java-socket-boundary
codex/ghidra-retained-snapshot-verifier
codex/ghidra-search-inventory-facts
fix/8284-zero-argument-parameter-bindings
fix/8198-ui-action-handler-offset
fix/8257-elf-entry-label-identity
fix/8304-deferred-output-schema-projection
fix/8277-call-path-computed-target-uncertainty
fix/pr-8089-conflicts
fix/ci-static-duplicate-export
dependabot/npm_and_yarn/lint-staged-17.6.0
dependabot/github_actions/actions/download-artifact-8.0.2
dependabot/npm_and_yarn/write-file-atomic-8.0.0
dependabot/npm_and_yarn/canonicalize-5.1.0
dependabot/github_actions/actions/cache/restore-6.1.0
dependabot/npm_and_yarn/toon-format/toon-4.4.0
dependabot/github_actions/actions/deploy-pages-5.0.1
codex/review-fixes-pr-2403
codex/review-fixes-pr-2400
codex/process-terminal-width
codex/test-brittleness-cleanup
verify/7167-browser-connect-macos
fix/7167-browser-connect
feat/native-matching-allowance-setting
feat/browser-scenario-dry-run
test/managed-caller-parameters-20261024
codex/parser-fortythird-boundaries
fix/6926-pinvoke-platform-decorations-20261023
fix/6889-har-body-encoding-20261023
fix/6888-sqlite-schema-budget-20261023
fix/dependency-security-gates-6708
cursor/evidence-overwrite-rebase-b4ac
feat/4057-verify-native-exports
fix/windows-acl-observer-overhead-20261022
cursor/erlang-beam-restack-4476
cursor/pe-certificate-review-bf32
fix/6116-javascript-application-fs-errors
fix/6061-unmapped-runtime-script-unknown
feat/browser-scenario-summary
fix/pe-certificates
codex/verify-3407
cursor/rebase-5699
cursor/rebase-5352
cursor/rebase-5600
cursor/fix-cli-schema-omission-10a8
codex/audit-hopper-shutdown-reasons-20261021
fix/demangle-swift-omitted-record
fix/nib-boolean-value-types
cursor/cancellation-partial-observation-a5ac
fix/ib-object-limit-reasons
fix/electron-fuse-limit-advice
fix/kuna-doctor-dangling-cache
fix/fixed-budget-refusal-advice
fix/js-ipc-listener-dedup
fix/js-return-member-provenance
fix/dmg-integrity-retry-advice
fix/ida-doctor-readiness
fix/kuna-version-probe-output-drain
fix/legacy-swift-runtime-name-matching
fix/dylib-lazy-load-commands
fix/browser-scenario-startup-cancel
fix/swift-nested-punycode-classification
fix/compare-unselected-scopes
fix/objc-method-budget-coverage
fix/dmg-mounted-root-observations
audit/ci-tests-20261019-round2
release/6.7.0
fix/wabt-cleanup-retry-resolution
fix/electron-fuse-elf-pe-architecture
fix/native-plist-descriptor-ownership
fix/kuna-caller-cleanup-ownership
experiment/atomic-codemode-20261016
review/first-contributor-3776
fix/call-resolution-full-read-cycles
fix/member-mutation-selection-repeat
experiment/atomic-re-tools-20261015
perf/member-mutation-lazy-origins
perf/static-network-mutation-index
fix/hopper-startup-lifecycle
audit/3050-windows-proof-20261015
feat/windows-window-capture-2183
audit/3049-windows-proof-20261015
audit/3735-macos-fixtures-20261015
fix/batch-decompile-null-pseudocode
fix/kuna-inventory-honors-jobs
experiment/browser-codemode-tool-design-20261015
fix/hopper-clean-runtime-argv
codex/review-2049-27f1b367
review-fixes/pr-2787-routing
fix/3360-scoped-this-emitters
fix/3367-replaced-global-effects
fix/3838-compact-any-value-items
test/hopper-download-probe-20261015
codex/windows-runtime-creation-red-green-20261015
codex/windows-readonly-root-red-green-20261015
codex/windows-root-share-red-green-20261015
codex/exp-1685-win-mcp-startup
codex/bug-sweep-20261015
investigate/2190-windows-package-phases
investigate/3543-macos-cli-deadline
perf/3281-reverse-tools-feedback-quality
fix/3406-hopper-doctor-fixture
fix/3341-wrapper-require-test-context
fix/3301-owned-uninstall-fixtures
fix/3164-compiler-input-ownership
fix/pcap-cleanup-stdout-newline-20261014
perf/interface-builder-summary
codex/review-fixes-pr-1977
fix/ghidra-effective-jvm-platform
fix/docs-turkish-rust-link-20261013
fix/main-maintenance-ci-20261010
fix/recover-binary-session-process-effects
codex/review-fixes-pr-2457
codex/ci-required-cancellation-gate
fix/main-format-baseline-20261013
fix/setup-preserve-entry-fields
cursor/restore-main-checks-1ffc
fix/ghidra-bridge-hashmap-import
codex/shared-ci-jadx-json-default-20261013
codex/shared-ci-ghidra-test-groups-20261013
codex/shared-ci-java-fixture-format-20261013
codex/fix-intrinsic-invocation-boundaries
test/release-preflight-reusable-jobs
test/js-parameter-provenance-expectation
fix/linux-hopper-verification-current
test/2419-ghidra-elf-probe-size
followup/pr-1544-native-ida
codex/fold-pr-2230-contribution
docs/readme-responsible-use
fix/issue-2064
fix/issue-2050
fix/issue-2053
fix/issue-1968
fix/issue-1945
experiment/codemode-bridge-20261011
fix/tool-effects-negative-wording-1904-20261012
fix/1842-electron-interop-provenance
feat/recover-javascript-multi-input
refactor/website-i18n-prep
fix/nativeaot-pe-virtual-extent
fix/browser-verifier-ci-hang
fix/pe-resources-input-selection
docs/beginner-friendly-guides
docs/beginner-setup-guide
fix/javascript-analysis-worker-1563
fix/1649-ghidra-duplicate-names
fix/javascript-export-keys-integration-1369
test/maintenance-boundary-contracts-20261011
review/javascript-export-keys-1369
review/process-live-progress-1483
test/javascript-1495-growth-ratio
fix/ci-escape-timing
docs/normalized-terminal-geometry-1450
release/6.3.0
archive/release-6.3.0-pr1381
release/6.2.0
fix/electron-preload-dynamic-override
fix/javascript-self-referential-bundler-edges
release/6.1.0
cursor/grok-client-cherry-pick-0b56
feat/signature-posture
feat/dyld-shared-cache
feat/artifact-integrity-policy
feat/pkg-inventory
release/6.0.0
chore/sync-release-5.0.0
release/5.0.0
cursor/cloud-agent-node-787e
fix/javascript-xhr-open-endpoints
review/pr-711-realpath-fallback-wording
cleanup/replay-confinement
codex/test-suite-performance
codex/issue-foundations
codex/address-open-issues-2026-07-20
agent/javascript-vite-rollup-esbuild-adapters
agent/process-cleanup
agent/triage-integration
agent/unknown-commands-registry
feat/mcp-identity-metadata
morlvps/issue_cleanup
codex/installer-redesign
morl/roadmap-investigation-core
morl/roadmap-investigation-docs
release-please--branches--main--components--rea
rea-agents-6.8.0
rea-agents-6.7.0
rea-agents-6.6.0
experiment/atomic-codemode-wait-runtime-20261016
rea-agents-6.5.0
rea-agents-6.4.0
rea-agents-6.3.0
rea-agents-6.2.0
rea-agents-6.1.0
rea-agents-6.0.0
rea-agents-5.0.0
rea-agents-4.1.0
rea-agents-4.0.1
rea-agents-4.0.0
rea-agents-3.2.1
rea-agents-3.2.0
rea-agents-3.1.0
rea-agents-3.0.0
rea-agents-2.7.0
rea-agents-2.6.0
rea-agents-2.5.1
rea-agents-2.5.0
rea-agents-2.4.0
rea-agents-2.3.0
rea-agents-2.2.0
rea-agents-2.1.0
rea-agents-2.0.0
rea-agents-1.7.0
rea-agents-1.6.0
rea-agents-1.5.0
rea-agents-1.4.0
rea-agents-1.3.0
rea-agents-1.2.0
rea-agents-1.1.0
rea-agents-1.0.0
rea-agents-0.5.0
rea-agents-0.4.0
rea-agents-0.3.0
rea-0.2.1
rea-0.2.0
Labels
Clear labels
area: bridge
area: bridge
area: build
area: build
area: build
area: cli
area: domain
area: evidence
area: mcp
area: native
area: providers
area: runtime
area: server
area: setup
area: tests
bug
design
documentation
enhancement
enhancement
enhancement
experiment
help wanted
i18n
invalid
P0: critical
P1: high
P2: medium
P2: medium
P2: medium
P3: low
performance
provider-request
pull-request
Mirrored from GitHub Pull Request
question
roadmap
triage
No labels
area: bridge
area: bridge
area: build
area: build
area: build
area: cli
area: domain
area: evidence
area: mcp
area: native
area: providers
area: runtime
area: server
area: setup
area: tests
bug
design
documentation
enhancement
enhancement
enhancement
experiment
help wanted
i18n
invalid
P0: critical
P1: high
P2: medium
P2: medium
P2: medium
P3: low
performance
provider-request
pull-request
question
roadmap
triage
Milestone
Clear milestone
No items
No milestone
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".
No due date set.
Dependencies
No dependencies set.
Reference
morluto/rea#7009
Loading…
Add table
Add a link
Reference in a new issue
No description provided.
Delete branch "%!s()"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
📋 Pull Request Information
Original PR: https://github.com/morluto/rea/pull/5644
Author: @morluto
Created: 10/20/2026
Status: ✅ Merged
Merged: 10/20/2026
Merged by: @morluto
Base:
main← Head:cursor/cancellation-partial-observation-a5ac📝 Commits (10+)
381fcbdfix(observation): keep incomplete cancellation observations87e5199fix(observation): drop non-JSON incomplete observationsc09a9cdfix(observation): validate incomplete partials without copyingd847710merge(main): take non-retryable invalid-request projectionb7ec2f6test(ida): expect non-retryable unresolved procedure lookups00785c0test(observation): share incomplete-observation assertions56583f1test(observation): keep the assertion helper out of the package134f627fix(observation): clear non-JSON partials on cleanup primaries97abf17fix(observation): freeze retained incomplete observationsfd1ed0cmerge(main): take landed audit fixes📊 Changes
15 files changed (+915 additions, -304 deletions)
View changed files
📝
src/application/BrowserObservationService.test.ts(+173 -12)📝
src/application/BrowserObservationService.ts(+41 -53)📝
src/application/BrowserScenarioCaptureService.test.ts(+107 -37)📝
src/application/BrowserScenarioCaptureService.ts(+13 -11)📝
src/application/ProviderOperationExecution.test.ts(+93 -2)📝
src/application/ProviderOperationExecution.ts(+53 -0)📝
src/application/WebRuntimeService.test.ts(+128 -7)📝
src/application/WebRuntimeService.ts(+53 -59)📝
src/application/javascript/ElectronObservationService.test.ts(+56 -42)📝
src/application/javascript/ElectronObservationService.ts(+27 -26)📝
src/application/javascript/JavaScriptRuntimeObservationService.test.ts(+49 -16)📝
src/application/javascript/JavaScriptRuntimeObservationService.ts(+14 -11)➕
src/application/ownerObservationExpectation.fixture.ts(+72 -0)➕
src/domain/javascript/electronPageInspection.fixture.ts(+34 -0)📝
tests/boundary/mcp/electronMcp.test.ts(+2 -28)📄 Description
Summary
Cancelling an observation that had already retained incomplete facts was reported as
unreadable_output, and the partial was dropped. The owner error now stays cancellation or timeout. A JSON partial is kept as one frozen snapshot, so a later mutation cannot make projection throw. A non-JSON partial is cleared from the returned error and from each cleanup primary that projection can select after a successful cleanup retry. AnAnalysisOutputErroris recorded on each cleared error, soprojectAnalysisErrorreturns the typed owner error instead of throwingZodError.Fixes #5364 and #5641.
Problem and expected behavior
Several observation services parsed a failure's
partialObservationwith the completed-result schema. When that parse failed and the error wasAnalysisCancelledError, they replaced it withAnalysisOutputErrorand discarded the partial.Keeping the raw partial fixed that classification, and then
projectAnalysisErrorcalledjsonValueSchema.parseon values such asNaNandundefinedarray entries. Those calls threw. On main, the same page timeout already returned the raw partial and threw the same way. A cleanup wrapper copies the partial onto both itself and its primary, so clearing only the wrapper still threw after cleanup retry. A JSON partial that stayed mutable could become non-JSON before projection.A completed capture still becomes Evidence. A JSON incomplete observation stays on the owner error as a frozen snapshot. A non-JSON incomplete observation is dropped and recorded as a secondary output failure. Cancellation and timeout stay primary.
Change and scope
keepIncompleteObservationinProviderOperationExecutionis the gate. It usesjsonValueValidationIssue, which checks JSON safety without copying a partial it will drop. A kept partial is replaced byfreezeJsonSnapshot(jsonValueSchema.parse(partial)), which projection recognizes and does not copy again. The gate walks the returned error and everycleanupPrimary. It runs at every service return that still holds an unpromoted partial: browser scenario, web page, web bundle, Electron page, web execution, event listeners, and JavaScript runtime observation. Page timeout paths that previously returned a raw non-JSON partial use the same gate.Shared test assertions live in
ownerObservationExpectation.fixture.ts, which the production build excludes.The branch also includes main's non-retryable
invalid_requestprojection. Unresolved IDA procedure lookups stayinvalid_requestand are not marked retryable.Follow the contribution scope. This is an ordinary failure-classification fix inside existing observation services. Maintainer scope decision: not applicable.
Not included: process-table refresh (#5206), Windows
CloseHandleownership (#4505), and the compiler-scratch race scoped to unmerged #5587 (#5616). Those remain separate.Contract and boundary impact
cancelledorprovider_timeoutwithpartial_observation. Non-JSON partials are omitted. The public code is notunreadable_outputand projection does not throw. No catalog or argument change.docs/public/product-catalog.json), package, or installation impact (CI generates and validates ignored catalogs andskills/; edit authored instructions in.agents/skills/reverse-engineer-anything/and never commit build outputs): none.Expected effects (check known effects; use documentation-only on its own).
Unchecked items do not establish absence; leave uncertainties visible.
Evidence and regression coverage
NaN,undefinedin arrays) throughprojectAnalysisError. Page timeout covers both a schema-shaped inspection (network.requests: NaN) and a shapeless{ requests: NaN }partial. Web execution timeout withundefinedin an array staysprovider_timeout.ProviderOperationExecution.test.tscovers a cleanup wrapper whose shared partial becomes non-JSON, then projectscleanup_incompletebefore retry andcancelledwith no partial afterresolveCleanup(). It also mutates a retained array after the gate and still projects the frozen{ steps: [] }snapshot. Shared assertions live inownerObservationExpectation.fixture.tsso those checks do not exceed the duplication limit and are not published.IdaOperationFailures.test.tsexpects unresolved procedure lookups to be non-retryable, matching main.bytes: NaN, bundleobservations: [undefined], pagerequests: NaN) project ascancelledwith the partial cleared and one secondaryAnalysisOutputError.For evidence-bearing changes:
Validation performed
npm run test:local --the five observation service tests andsrc/application/ProviderOperationExecution.test.ts— 6 files, 55 tests passed.src/ida/IdaOperationFailures.test.ts— 83 tests passed.npm run check:fast— typecheck and lint passed.npm run jscpd— 3.495% duplicated lines, 45 lines under the 3.5% threshold.tsc -p tsconfig.build.json --listFilesOnlydoes not list the fixture.Compatibility, safety, and release
unreadable_outputnow seecancelledand a JSON snapshot when one exists. A non-JSON partial is absent rather than thrown. Invalid requests are not retryable, matching main. No configuration migration.Author readiness
Human owner: @morluto
Before merge
type(scope): outcome.🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.