mirror of
https://github.com/morluto/rea.git
synced 2026-11-05 06:45:22 +00:00
[PR #5647] [MERGED] fix(doctor): reject unusable Kuna caches and invalid native settings #7010
Closed
opened 2026-11-01 21:44:41 +00:00 by bsakaguchi
·
0 comments
No Branch/Tag specified
main
codex/procedure-reference-stacked
release-please--branches--main--components--rea-agents
release-please--branches--main--components--rea-agents--release-notes
codex/kuna-independent-retry
codex/byte-search-overlay-coverage
codex/open-failure-target-receipt
codex/kuna-xref-evidence
codex/ghidra-ambiguous-procedure-recovery
codex/function-source-bundle
codex/trace-function-integration-prototype
codex/snapshot-source-closure
codex/recorded-evidence-array-pages
codex/evidence-recovery-redesign
codex/trace-feature-address-scope
codex/call-discovery-scope
codex/ghidra-literal-candidate-evidence
codex/decompile-directory-independent-retry
codex/retry-provenance-base
codex/value-flow-capability-experiment
codex/ghidra-containing-instruction
cursor/readme-discord-button-ef9f
dependabot/github_actions/actions/setup-node-7.1.0
dependabot/github_actions/actions/upload-artifact-7.0.2
dependabot/npm_and_yarn/npm-minor-and-patch-d8d97ce6df
codex/kuna-1989
fix/8559-native-ui-fixture-ownership
fix/8555-go-verifier-mcp-ownership
codex/provider-capability-recovery
fix/8642-rizin-target-stdin
codex/ghidra-memory-effect-scope
codex/ghidra-annotation-entry-selector
codex/ghidra-readonly-recovery
codex/ghidra-regex-verifier-recovery
codex/evidence-discovery-view-guidance
fix/8545-bulk-append-overflow
fix/8428-navigation-refusal-alternatives
codex/address-context-recovery
codex/matching-member-limitations
codex/unknown-scope-contract
codex/evidence-view-guidance
feat/8373-native-trace-views
codex/ghidra-snapshot-verifier-binding
codex/elf-export-visibility
codex/evidence-view-recovery
codex/native-reference-cli-help
codex/provider-candidate-observation-scope
codex/kuna-session-verification
codex/ghidra-switch-lifetime-guidance
codex/pseudocode-paging-discovery
codex/clarify-evidence-view-support
codex/kuna-xrefs-selector-recovery
codex/context-capacity-recovery
codex/evidence-closure-large-links
codex/same-function-evidence-identity
codex/ghidra-verifier-inspected-jdk
codex/audit-guided-workflows
codex/crash-prompt-retained-dossiers
codex/analysis-view-error-recovery
codex/kuna-verifier-target-selection
codex/ghidra-selected-project-call-coverage
codex/docs-native-analysis-scope
codex/ghidra-java-socket-boundary
codex/ghidra-retained-snapshot-verifier
codex/ghidra-search-inventory-facts
fix/8284-zero-argument-parameter-bindings
fix/8198-ui-action-handler-offset
fix/8257-elf-entry-label-identity
fix/8304-deferred-output-schema-projection
fix/8277-call-path-computed-target-uncertainty
fix/pr-8089-conflicts
fix/ci-static-duplicate-export
dependabot/npm_and_yarn/lint-staged-17.6.0
dependabot/github_actions/actions/download-artifact-8.0.2
dependabot/npm_and_yarn/write-file-atomic-8.0.0
dependabot/npm_and_yarn/canonicalize-5.1.0
dependabot/github_actions/actions/cache/restore-6.1.0
dependabot/npm_and_yarn/toon-format/toon-4.4.0
dependabot/github_actions/actions/deploy-pages-5.0.1
codex/review-fixes-pr-2403
codex/review-fixes-pr-2400
codex/process-terminal-width
codex/test-brittleness-cleanup
verify/7167-browser-connect-macos
fix/7167-browser-connect
feat/native-matching-allowance-setting
feat/browser-scenario-dry-run
test/managed-caller-parameters-20261024
codex/parser-fortythird-boundaries
fix/6926-pinvoke-platform-decorations-20261023
fix/6889-har-body-encoding-20261023
fix/6888-sqlite-schema-budget-20261023
fix/dependency-security-gates-6708
cursor/evidence-overwrite-rebase-b4ac
feat/4057-verify-native-exports
fix/windows-acl-observer-overhead-20261022
cursor/erlang-beam-restack-4476
cursor/pe-certificate-review-bf32
fix/6116-javascript-application-fs-errors
fix/6061-unmapped-runtime-script-unknown
feat/browser-scenario-summary
fix/pe-certificates
codex/verify-3407
cursor/rebase-5699
cursor/rebase-5352
cursor/rebase-5600
cursor/fix-cli-schema-omission-10a8
codex/audit-hopper-shutdown-reasons-20261021
fix/demangle-swift-omitted-record
fix/nib-boolean-value-types
cursor/cancellation-partial-observation-a5ac
fix/ib-object-limit-reasons
fix/electron-fuse-limit-advice
fix/kuna-doctor-dangling-cache
fix/fixed-budget-refusal-advice
fix/js-ipc-listener-dedup
fix/js-return-member-provenance
fix/dmg-integrity-retry-advice
fix/ida-doctor-readiness
fix/kuna-version-probe-output-drain
fix/legacy-swift-runtime-name-matching
fix/dylib-lazy-load-commands
fix/browser-scenario-startup-cancel
fix/swift-nested-punycode-classification
fix/compare-unselected-scopes
fix/objc-method-budget-coverage
fix/dmg-mounted-root-observations
audit/ci-tests-20261019-round2
release/6.7.0
fix/wabt-cleanup-retry-resolution
fix/electron-fuse-elf-pe-architecture
fix/native-plist-descriptor-ownership
fix/kuna-caller-cleanup-ownership
experiment/atomic-codemode-20261016
review/first-contributor-3776
fix/call-resolution-full-read-cycles
fix/member-mutation-selection-repeat
experiment/atomic-re-tools-20261015
perf/member-mutation-lazy-origins
perf/static-network-mutation-index
fix/hopper-startup-lifecycle
audit/3050-windows-proof-20261015
feat/windows-window-capture-2183
audit/3049-windows-proof-20261015
audit/3735-macos-fixtures-20261015
fix/batch-decompile-null-pseudocode
fix/kuna-inventory-honors-jobs
experiment/browser-codemode-tool-design-20261015
fix/hopper-clean-runtime-argv
codex/review-2049-27f1b367
review-fixes/pr-2787-routing
fix/3360-scoped-this-emitters
fix/3367-replaced-global-effects
fix/3838-compact-any-value-items
test/hopper-download-probe-20261015
codex/windows-runtime-creation-red-green-20261015
codex/windows-readonly-root-red-green-20261015
codex/windows-root-share-red-green-20261015
codex/exp-1685-win-mcp-startup
codex/bug-sweep-20261015
investigate/2190-windows-package-phases
investigate/3543-macos-cli-deadline
perf/3281-reverse-tools-feedback-quality
fix/3406-hopper-doctor-fixture
fix/3341-wrapper-require-test-context
fix/3301-owned-uninstall-fixtures
fix/3164-compiler-input-ownership
fix/pcap-cleanup-stdout-newline-20261014
perf/interface-builder-summary
codex/review-fixes-pr-1977
fix/ghidra-effective-jvm-platform
fix/docs-turkish-rust-link-20261013
fix/main-maintenance-ci-20261010
fix/recover-binary-session-process-effects
codex/review-fixes-pr-2457
codex/ci-required-cancellation-gate
fix/main-format-baseline-20261013
fix/setup-preserve-entry-fields
cursor/restore-main-checks-1ffc
fix/ghidra-bridge-hashmap-import
codex/shared-ci-jadx-json-default-20261013
codex/shared-ci-ghidra-test-groups-20261013
codex/shared-ci-java-fixture-format-20261013
codex/fix-intrinsic-invocation-boundaries
test/release-preflight-reusable-jobs
test/js-parameter-provenance-expectation
fix/linux-hopper-verification-current
test/2419-ghidra-elf-probe-size
followup/pr-1544-native-ida
codex/fold-pr-2230-contribution
docs/readme-responsible-use
fix/issue-2064
fix/issue-2050
fix/issue-2053
fix/issue-1968
fix/issue-1945
experiment/codemode-bridge-20261011
fix/tool-effects-negative-wording-1904-20261012
fix/1842-electron-interop-provenance
feat/recover-javascript-multi-input
refactor/website-i18n-prep
fix/nativeaot-pe-virtual-extent
fix/browser-verifier-ci-hang
fix/pe-resources-input-selection
docs/beginner-friendly-guides
docs/beginner-setup-guide
fix/javascript-analysis-worker-1563
fix/1649-ghidra-duplicate-names
fix/javascript-export-keys-integration-1369
test/maintenance-boundary-contracts-20261011
review/javascript-export-keys-1369
review/process-live-progress-1483
test/javascript-1495-growth-ratio
fix/ci-escape-timing
docs/normalized-terminal-geometry-1450
release/6.3.0
archive/release-6.3.0-pr1381
release/6.2.0
fix/electron-preload-dynamic-override
fix/javascript-self-referential-bundler-edges
release/6.1.0
cursor/grok-client-cherry-pick-0b56
feat/signature-posture
feat/dyld-shared-cache
feat/artifact-integrity-policy
feat/pkg-inventory
release/6.0.0
chore/sync-release-5.0.0
release/5.0.0
cursor/cloud-agent-node-787e
fix/javascript-xhr-open-endpoints
review/pr-711-realpath-fallback-wording
cleanup/replay-confinement
codex/test-suite-performance
codex/issue-foundations
codex/address-open-issues-2026-07-20
agent/javascript-vite-rollup-esbuild-adapters
agent/process-cleanup
agent/triage-integration
agent/unknown-commands-registry
feat/mcp-identity-metadata
morlvps/issue_cleanup
codex/installer-redesign
morl/roadmap-investigation-core
morl/roadmap-investigation-docs
release-please--branches--main--components--rea
rea-agents-6.8.0
rea-agents-6.7.0
rea-agents-6.6.0
experiment/atomic-codemode-wait-runtime-20261016
rea-agents-6.5.0
rea-agents-6.4.0
rea-agents-6.3.0
rea-agents-6.2.0
rea-agents-6.1.0
rea-agents-6.0.0
rea-agents-5.0.0
rea-agents-4.1.0
rea-agents-4.0.1
rea-agents-4.0.0
rea-agents-3.2.1
rea-agents-3.2.0
rea-agents-3.1.0
rea-agents-3.0.0
rea-agents-2.7.0
rea-agents-2.6.0
rea-agents-2.5.1
rea-agents-2.5.0
rea-agents-2.4.0
rea-agents-2.3.0
rea-agents-2.2.0
rea-agents-2.1.0
rea-agents-2.0.0
rea-agents-1.7.0
rea-agents-1.6.0
rea-agents-1.5.0
rea-agents-1.4.0
rea-agents-1.3.0
rea-agents-1.2.0
rea-agents-1.1.0
rea-agents-1.0.0
rea-agents-0.5.0
rea-agents-0.4.0
rea-agents-0.3.0
rea-0.2.1
rea-0.2.0
Labels
Clear labels
area: bridge
area: bridge
area: build
area: build
area: build
area: cli
area: domain
area: evidence
area: mcp
area: native
area: providers
area: runtime
area: server
area: setup
area: tests
bug
design
documentation
enhancement
enhancement
enhancement
experiment
help wanted
i18n
invalid
P0: critical
P1: high
P2: medium
P2: medium
P2: medium
P3: low
performance
provider-request
pull-request
Mirrored from GitHub Pull Request
question
roadmap
triage
No labels
area: bridge
area: bridge
area: build
area: build
area: build
area: cli
area: domain
area: evidence
area: mcp
area: native
area: providers
area: runtime
area: server
area: setup
area: tests
bug
design
documentation
enhancement
enhancement
enhancement
experiment
help wanted
i18n
invalid
P0: critical
P1: high
P2: medium
P2: medium
P2: medium
P3: low
performance
provider-request
pull-request
question
roadmap
triage
Milestone
Clear milestone
No items
No milestone
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".
No due date set.
Dependencies
No dependencies set.
Reference
morluto/rea#7010
Loading…
Add table
Add a link
Reference in a new issue
No description provided.
Delete branch "%!s()"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
📋 Pull Request Information
Original PR: https://github.com/morluto/rea/pull/5647
Author: @morluto
Created: 10/20/2026
Status: ✅ Merged
Merged: 10/20/2026
Merged by: @morluto
Base:
main← Head:cursor/doctor-readiness-4f30📝 Commits (8)
8129597fix(kuna): reject dangling cache roots in doctor0ca5bc2fix(doctor): admit the same settings native analysis rejects40e7f8cfix(doctor): report an invalid log level from doctor3e4c2b2fix(doctor): require log-level failures in every scopee7a2434fix(kuna): strip only the platform cache separatorf2b3cd3fix(doctor): fail every provider on an invalid Hopper timeout2ed26acstyle(doctor): format the Hopper timeout regression504ccbbfix(doctor): fail client scopes on MCP startup errors📊 Changes
15 files changed (+719 additions, -38 deletions)
View changed files
📝
docs/installation.md(+7 -0)📝
scripts/rea.mjs(+24 -1)📝
src/application/Doctor.test.ts(+268 -1)📝
src/application/Doctor.ts(+12 -0)📝
src/application/DoctorDiagnostics.ts(+39 -0)📝
src/application/DoctorScope.ts(+27 -0)📝
src/cli.ts(+6 -2)📝
src/config.test.ts(+23 -0)📝
src/config/parseConfig.ts(+25 -6)📝
src/kuna/KunaDoctor.ts(+57 -14)📝
src/logger.ts(+12 -0)📝
tests/boundary/cli/cliLogLevelConfiguration.test.ts(+50 -11)📝
tests/boundary/cli/doctorHopperDiscovery.test.ts(+69 -0)📝
tests/boundary/providers/kuna/kunaDoctor.test.ts(+95 -2)📝
tests/boundary/providers/kuna/kunaSetupReadiness.test.ts(+5 -1)📄 Description
Summary
Fixes #5454, #5554, and #5105.
Scoped
rea doctorcould report a selected engine healthy when shared native configuration was invalid, and Kuna doctor could report a dangling cache root as creatable and available. Readiness now uses the same environment admission as native commands, and a cache path is creatable only when no directory entry occupies its name.Problem and expected behavior
rea doctor --provider hopperstayed successful forREA_ANALYSIS_PROVIDER=HopperandREA_GHIDRA_STARTUP_TIMEOUT_MS=abc, whileanalyzeandsearch-bytesfailed withconfiguration_invalid.rea doctor --provider ghidracould likewise succeed withREA_HOPPER_STARTUP_TIMEOUT_MS=abc, because that setting had its own check and the check was required only for Hopper. A Kuna cache root that is a dangling symlink, including one written with a trailing separator, was reported ready becausestatfollows the link andENOENTwas treated as absence. Setup's ready-provider list already required passing checks, but the inspection still publishedavailable: true.An invalid
REA_LOG_LEVELwas rejected in the executable dispatcher before doctor ran, so the readiness check never reachedrea doctor --json. After that path reached doctor, a client-only or skill scope could still report healthy because the failure was included only when a provider was selected. That client cannot start REA: the dispatcher rejects every other command, and MCP startup rejects the same setting.Doctor should fail the selected engine and name the rejected setting. An invalid
REA_LOG_LEVELshould also fail client and skill scopes. Every otherparseConfigfailure, includingREA_GHIDRA_STARTUP_TIMEOUT_MSandREA_HOPPER_STARTUP_TIMEOUT_MS, should fail a selected client because MCP startup rejects it. A skill-only scope leaves those other settings informational. An invalidREA_HOPPER_STARTUP_TIMEOUT_MSshould fail every selected provider. A dangling cache link should fail the cache check, clear availability, and leave the installation check and caller-selected registration settings in place. A resolving link and a missing path under a writable parent stay ready. On Darwin and Linux, a trailing\is part of the configured cache path.REA_JEB_MCP_TIMEOUT_MSremains outside native admission. Commands other than doctor still stop before execution when the log level is invalid.Change and scope
parseConfigand doctor sharenativeAnalysisConfigurationError. Rejected settings becomeruntime-configuration:<setting>checks. They fail the full audit. An explicit provider scope includes every rejected native setting.REA_LOG_LEVELalso fails client and skill scopes. A selected client includes every other native admission failure, because MCP startup rejects it. A skill-only scope leaves those other settings informational.REA_HOPPER_STARTUP_TIMEOUT_MSkeeps its existinghopper-startup-timeoutcheck, and that check is required for every selected provider.The dispatcher lets
doctorcontinue after an invalidREA_LOG_LEVELso that check is in the public JSON report. Every other command keeps the existing stderr rejection.Kuna cache inspection strips the selected platform's terminal separator before
lstat, so a dangling link is not mistaken for a missing path. On Darwin and Linux that separator is/.availablefollows the cache check.Contribution scope: ordinary readiness fixes inside existing doctor and Kuna cache diagnosis. No new provider, target execution, injection, mutation, or protection recovery. Maintainer scope decision: not applicable.
Already fixed on main and not included: #5561, #5559, and #5604 (
dd0015aaf); #5568 (7b2087e44).Contract and boundary impact
parseConfigowns native environment admission;PROCESS_START_CONFIGURATION_SETTINGSowns which of those settings block process start; the executable dispatcher owns the log-level exception for doctor;KunaDoctorowns cache-root classification. Earliest stage is setup or provider admission, before a provider session.rea doctorJSON gainsruntime-configuration:<setting>checks when native admission fails, including an invalidREA_LOG_LEVEL. That log-level check is required in every explicit scope. A selected client also requires every other native admission failure andhopper-startup-timeout.hopper-startup-timeoutremains required for every selected provider. Exit status followshealthy. Other commands keep the plain stderr rejection for an invalid log level. No new command or tool.\. Other providers are unchanged. No engine protocol change.docs/public/product-catalog.json), package, or installation impact:docs/installation.mdstates that an invalidREA_LOG_LEVELfails every doctor scope, and that other MCP startup failures fail a selected client and every selected provider. CI generates and validates ignored catalogs andskills/.Expected effects (check known effects; use documentation-only on its own).
Evidence and regression coverage
Tests added or updated:
src/application/Doctor.test.ts,src/config.test.ts,tests/boundary/cli/doctorHopperDiscovery.test.ts,tests/boundary/cli/cliLogLevelConfiguration.test.ts,tests/boundary/providers/kuna/kunaDoctor.test.ts,tests/boundary/providers/kuna/kunaSetupReadiness.test.ts.Base reproduction or other evidence: source inspection of
stat/ENOENT, of doctor versusparseConfig, ofscripts/rea.mjsexiting before doctor whenREA_LOG_LEVELis invalid, of the scope partition that omitted process-start failures when no provider was selected, and ofhopper-startup-timeoutbeing required only when Hopper itself was selected. The historical CLI timings in #5454 and #5554 were not re-run on a real Hopper or Kuna engine.User-visible CLI/MCP output: focused CLI doctor with
REA_ANALYSIS_PROVIDER=HopperandREA_GHIDRA_STARTUP_TIMEOUT_MS=abcexited 1 and included bothruntime-configurationchecks inscope_checks.REA_JEB_MCP_TIMEOUT_MS=abcadded no such check.rea --json doctor --provider hopperandrea --json doctor --client codexwithREA_LOG_LEVEL=loudandINFOexited 1 with an empty stderr andruntime-configuration:REA_LOG_LEVELinscope_checks.rea --json doctor --client codexwithREA_GHIDRA_STARTUP_TIMEOUT_MS=abcexited 1 and included that check inscope_checkswithproviders: [].rea --helpwith an invalid log level still prints the stderr configuration error and no stdout.Remaining proof gaps: no real Hopper, Ghidra, IDA, or Kuna engine. Windows cache links were not run (
kunaDoctortests skip win32). The non-Hopper timeout regression uses a scripted Ghidra inspection.Observed, derived, and inferred claims remain distinguishable.
Artifact identity, source provenance, and failed attempts remain preserved.
Unsupported, incomplete, unavailable, or uncertain outcomes remain visible.
Validation performed
npm run test:local -- src/application/Doctor.test.ts src/config.test.ts src/application/Doctor.lifecycle.test.ts— 129 passed.npm run test:focused -- tests/boundary/providers/kuna/kunaDoctor.test.ts tests/boundary/providers/kuna/kunaSetupReadiness.test.ts tests/boundary/cli/doctorHopperDiscovery.test.ts— 16 passed.npm run test:focused -- tests/boundary/cli/cliLogLevelConfiguration.test.ts tests/boundary/cli/dispatcher.test.ts tests/boundary/cli/doctorHopperDiscovery.test.ts— 8 passed.npm run test:focused -- src/application/Doctor.test.ts tests/boundary/cli/cliLogLevelConfiguration.test.ts tests/boundary/providers/kuna/kunaDoctor.test.ts— 72 passed.npm run test:focused -- src/application/Doctor.test.ts tests/boundary/cli/doctorHopperDiscovery.test.ts— 64 passed ondf9a78014.npm run test:local -- src/ida/IdaOperationFailures.test.ts— 33 passed on91dc38c64.npm run check:fast— passed ondf9a78014.npx oxfmt --check .— passed ondf9a78014.npx tsc --noEmit— passed on an earlier revision;check:fasttypechecked this revision.Compatibility, safety, and release
rea doctorwith an invalidREA_LOG_LEVELnow returns the doctor report instead of the dispatcher's stderr line, and that failure makes client and skill scopes unhealthy. A selected client is also unhealthy for every other setting MCP startup rejects. An invalidREA_HOPPER_STARTUP_TIMEOUT_MSfails every selected provider and a selected client. Other commands are unchanged. Callers who treated a dangling Kuna cache, a POSIX cache path ending in\, or an invalid native setting as healthy now get a failing doctor result.Author readiness
Human owner: @morluto
Before merge
type(scope): outcome.🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.