[PR #5669] test: cover Unicode code point ordering #7027

New issue

Open

opened 2026-11-01 21:44:49 +00:00 by bsakaguchi · 0 comments

bsakaguchi commented

2026-11-01 21:44:49 +00:00

Owner

📋 Pull Request Information

Original PR: https://github.com/morluto/rea/pull/5669
Author: @ydv-prince
Created: 10/20/2026
Status: 🔄 Open

Base: main ← Head: test/unicode-code-point-order

📝 Commits (1)

aa2dac5 test: cover Unicode code point ordering

📊 Changes

1 file changed (+97 additions, -0 deletions)

View changed files

➕ src/domain/unicodeCodePointOrder.test.ts (+97 -0)

📄 Description

Summary

Add unit tests for compareUnicodeCodePoints.
Cover ASCII ordering, prefixes, Unicode code points outside the Basic Multilingual Plane, and strings containing astral characters.
Add coverage for compositeKey, including delimiter-collision resistance and primitive type distinctions.

Testing

npm run test:local -- src/domain/unicodeCodePointOrder.test.ts — passed (13 tests).
npm run check:fast — passed.
npm run verify:test-discovery — passed.
npm run check — passed.

Scope

This PR adds tests only; it does not change production code.

Author readiness

Human owner: @ydv-prince

I reviewed the final diff and relevant existing code, understand the change and its edge cases, and take responsibility for the complete PR, including AI-assisted work.
I checked the evidence above, confirmed it supports the current change, and recorded meaningful validation gaps.
I declare this PR ready for initial maintainer review.

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/morluto/rea/pull/5669 **Author:** [@ydv-prince](https://github.com/ydv-prince) **Created:** 10/20/2026 **Status:** 🔄 Open **Base:** `main` ← **Head:** `test/unicode-code-point-order` --- ### 📝 Commits (1) - [`aa2dac5`](https://github.com/morluto/rea/commit/aa2dac54799a0a6c470402ca2b084d719b55caae) test: cover Unicode code point ordering ### 📊 Changes **1 file changed** (+97 additions, -0 deletions) <details> <summary>View changed files</summary> ➕ `src/domain/unicodeCodePointOrder.test.ts` (+97 -0) </details> ### 📄 Description ## Summary - Add unit tests for `compareUnicodeCodePoints`. - Cover ASCII ordering, prefixes, Unicode code points outside the Basic Multilingual Plane, and strings containing astral characters. - Add coverage for `compositeKey`, including delimiter-collision resistance and primitive type distinctions. ## Testing - `npm run test:local -- src/domain/unicodeCodePointOrder.test.ts` — passed (13 tests). - `npm run check:fast` — passed. - `npm run verify:test-discovery` — passed. - `npm run check` — passed. ## Scope This PR adds tests only; it does not change production code. ## Author readiness Human owner: @ydv-prince - [x] I reviewed the final diff and relevant existing code, understand the change and its edge cases, and take responsibility for the complete PR, including AI-assisted work. - [x] I checked the evidence above, confirmed it supports the current change, and recorded meaningful validation gaps. - [x] I declare this PR ready for initial maintainer review. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>

bsakaguchi added the

pull-request

label

2026-11-01 21:44:49 +00:00

bsakaguchi referenced this issue

2026-11-03 13:38:55 +00:00

[PR #7032] [MERGED] fix(setup): materialize the pinned package-runner cache before the first client start #7588