mirror of
https://github.com/morluto/rea.git
synced 2026-11-05 06:45:22 +00:00
[PR #5803] [MERGED] fix(artifacts): admit ZIP archives after unclaimed leading bytes #7073
Closed
opened 2026-11-01 21:45:10 +00:00 by bsakaguchi
·
0 comments
No Branch/Tag specified
main
codex/procedure-reference-stacked
release-please--branches--main--components--rea-agents
release-please--branches--main--components--rea-agents--release-notes
codex/kuna-independent-retry
codex/byte-search-overlay-coverage
codex/open-failure-target-receipt
codex/kuna-xref-evidence
codex/ghidra-ambiguous-procedure-recovery
codex/function-source-bundle
codex/trace-function-integration-prototype
codex/snapshot-source-closure
codex/recorded-evidence-array-pages
codex/evidence-recovery-redesign
codex/trace-feature-address-scope
codex/call-discovery-scope
codex/ghidra-literal-candidate-evidence
codex/decompile-directory-independent-retry
codex/retry-provenance-base
codex/value-flow-capability-experiment
codex/ghidra-containing-instruction
cursor/readme-discord-button-ef9f
dependabot/github_actions/actions/setup-node-7.1.0
dependabot/github_actions/actions/upload-artifact-7.0.2
dependabot/npm_and_yarn/npm-minor-and-patch-d8d97ce6df
codex/kuna-1989
fix/8559-native-ui-fixture-ownership
fix/8555-go-verifier-mcp-ownership
codex/provider-capability-recovery
fix/8642-rizin-target-stdin
codex/ghidra-memory-effect-scope
codex/ghidra-annotation-entry-selector
codex/ghidra-readonly-recovery
codex/ghidra-regex-verifier-recovery
codex/evidence-discovery-view-guidance
fix/8545-bulk-append-overflow
fix/8428-navigation-refusal-alternatives
codex/address-context-recovery
codex/matching-member-limitations
codex/unknown-scope-contract
codex/evidence-view-guidance
feat/8373-native-trace-views
codex/ghidra-snapshot-verifier-binding
codex/elf-export-visibility
codex/evidence-view-recovery
codex/native-reference-cli-help
codex/provider-candidate-observation-scope
codex/kuna-session-verification
codex/ghidra-switch-lifetime-guidance
codex/pseudocode-paging-discovery
codex/clarify-evidence-view-support
codex/kuna-xrefs-selector-recovery
codex/context-capacity-recovery
codex/evidence-closure-large-links
codex/same-function-evidence-identity
codex/ghidra-verifier-inspected-jdk
codex/audit-guided-workflows
codex/crash-prompt-retained-dossiers
codex/analysis-view-error-recovery
codex/kuna-verifier-target-selection
codex/ghidra-selected-project-call-coverage
codex/docs-native-analysis-scope
codex/ghidra-java-socket-boundary
codex/ghidra-retained-snapshot-verifier
codex/ghidra-search-inventory-facts
fix/8284-zero-argument-parameter-bindings
fix/8198-ui-action-handler-offset
fix/8257-elf-entry-label-identity
fix/8304-deferred-output-schema-projection
fix/8277-call-path-computed-target-uncertainty
fix/pr-8089-conflicts
fix/ci-static-duplicate-export
dependabot/npm_and_yarn/lint-staged-17.6.0
dependabot/github_actions/actions/download-artifact-8.0.2
dependabot/npm_and_yarn/write-file-atomic-8.0.0
dependabot/npm_and_yarn/canonicalize-5.1.0
dependabot/github_actions/actions/cache/restore-6.1.0
dependabot/npm_and_yarn/toon-format/toon-4.4.0
dependabot/github_actions/actions/deploy-pages-5.0.1
codex/review-fixes-pr-2403
codex/review-fixes-pr-2400
codex/process-terminal-width
codex/test-brittleness-cleanup
verify/7167-browser-connect-macos
fix/7167-browser-connect
feat/native-matching-allowance-setting
feat/browser-scenario-dry-run
test/managed-caller-parameters-20261024
codex/parser-fortythird-boundaries
fix/6926-pinvoke-platform-decorations-20261023
fix/6889-har-body-encoding-20261023
fix/6888-sqlite-schema-budget-20261023
fix/dependency-security-gates-6708
cursor/evidence-overwrite-rebase-b4ac
feat/4057-verify-native-exports
fix/windows-acl-observer-overhead-20261022
cursor/erlang-beam-restack-4476
cursor/pe-certificate-review-bf32
fix/6116-javascript-application-fs-errors
fix/6061-unmapped-runtime-script-unknown
feat/browser-scenario-summary
fix/pe-certificates
codex/verify-3407
cursor/rebase-5699
cursor/rebase-5352
cursor/rebase-5600
cursor/fix-cli-schema-omission-10a8
codex/audit-hopper-shutdown-reasons-20261021
fix/demangle-swift-omitted-record
fix/nib-boolean-value-types
cursor/cancellation-partial-observation-a5ac
fix/ib-object-limit-reasons
fix/electron-fuse-limit-advice
fix/kuna-doctor-dangling-cache
fix/fixed-budget-refusal-advice
fix/js-ipc-listener-dedup
fix/js-return-member-provenance
fix/dmg-integrity-retry-advice
fix/ida-doctor-readiness
fix/kuna-version-probe-output-drain
fix/legacy-swift-runtime-name-matching
fix/dylib-lazy-load-commands
fix/browser-scenario-startup-cancel
fix/swift-nested-punycode-classification
fix/compare-unselected-scopes
fix/objc-method-budget-coverage
fix/dmg-mounted-root-observations
audit/ci-tests-20261019-round2
release/6.7.0
fix/wabt-cleanup-retry-resolution
fix/electron-fuse-elf-pe-architecture
fix/native-plist-descriptor-ownership
fix/kuna-caller-cleanup-ownership
experiment/atomic-codemode-20261016
review/first-contributor-3776
fix/call-resolution-full-read-cycles
fix/member-mutation-selection-repeat
experiment/atomic-re-tools-20261015
perf/member-mutation-lazy-origins
perf/static-network-mutation-index
fix/hopper-startup-lifecycle
audit/3050-windows-proof-20261015
feat/windows-window-capture-2183
audit/3049-windows-proof-20261015
audit/3735-macos-fixtures-20261015
fix/batch-decompile-null-pseudocode
fix/kuna-inventory-honors-jobs
experiment/browser-codemode-tool-design-20261015
fix/hopper-clean-runtime-argv
codex/review-2049-27f1b367
review-fixes/pr-2787-routing
fix/3360-scoped-this-emitters
fix/3367-replaced-global-effects
fix/3838-compact-any-value-items
test/hopper-download-probe-20261015
codex/windows-runtime-creation-red-green-20261015
codex/windows-readonly-root-red-green-20261015
codex/windows-root-share-red-green-20261015
codex/exp-1685-win-mcp-startup
codex/bug-sweep-20261015
investigate/2190-windows-package-phases
investigate/3543-macos-cli-deadline
perf/3281-reverse-tools-feedback-quality
fix/3406-hopper-doctor-fixture
fix/3341-wrapper-require-test-context
fix/3301-owned-uninstall-fixtures
fix/3164-compiler-input-ownership
fix/pcap-cleanup-stdout-newline-20261014
perf/interface-builder-summary
codex/review-fixes-pr-1977
fix/ghidra-effective-jvm-platform
fix/docs-turkish-rust-link-20261013
fix/main-maintenance-ci-20261010
fix/recover-binary-session-process-effects
codex/review-fixes-pr-2457
codex/ci-required-cancellation-gate
fix/main-format-baseline-20261013
fix/setup-preserve-entry-fields
cursor/restore-main-checks-1ffc
fix/ghidra-bridge-hashmap-import
codex/shared-ci-jadx-json-default-20261013
codex/shared-ci-ghidra-test-groups-20261013
codex/shared-ci-java-fixture-format-20261013
codex/fix-intrinsic-invocation-boundaries
test/release-preflight-reusable-jobs
test/js-parameter-provenance-expectation
fix/linux-hopper-verification-current
test/2419-ghidra-elf-probe-size
followup/pr-1544-native-ida
codex/fold-pr-2230-contribution
docs/readme-responsible-use
fix/issue-2064
fix/issue-2050
fix/issue-2053
fix/issue-1968
fix/issue-1945
experiment/codemode-bridge-20261011
fix/tool-effects-negative-wording-1904-20261012
fix/1842-electron-interop-provenance
feat/recover-javascript-multi-input
refactor/website-i18n-prep
fix/nativeaot-pe-virtual-extent
fix/browser-verifier-ci-hang
fix/pe-resources-input-selection
docs/beginner-friendly-guides
docs/beginner-setup-guide
fix/javascript-analysis-worker-1563
fix/1649-ghidra-duplicate-names
fix/javascript-export-keys-integration-1369
test/maintenance-boundary-contracts-20261011
review/javascript-export-keys-1369
review/process-live-progress-1483
test/javascript-1495-growth-ratio
fix/ci-escape-timing
docs/normalized-terminal-geometry-1450
release/6.3.0
archive/release-6.3.0-pr1381
release/6.2.0
fix/electron-preload-dynamic-override
fix/javascript-self-referential-bundler-edges
release/6.1.0
cursor/grok-client-cherry-pick-0b56
feat/signature-posture
feat/dyld-shared-cache
feat/artifact-integrity-policy
feat/pkg-inventory
release/6.0.0
chore/sync-release-5.0.0
release/5.0.0
cursor/cloud-agent-node-787e
fix/javascript-xhr-open-endpoints
review/pr-711-realpath-fallback-wording
cleanup/replay-confinement
codex/test-suite-performance
codex/issue-foundations
codex/address-open-issues-2026-07-20
agent/javascript-vite-rollup-esbuild-adapters
agent/process-cleanup
agent/triage-integration
agent/unknown-commands-registry
feat/mcp-identity-metadata
morlvps/issue_cleanup
codex/installer-redesign
morl/roadmap-investigation-core
morl/roadmap-investigation-docs
release-please--branches--main--components--rea
rea-agents-6.8.0
rea-agents-6.7.0
rea-agents-6.6.0
experiment/atomic-codemode-wait-runtime-20261016
rea-agents-6.5.0
rea-agents-6.4.0
rea-agents-6.3.0
rea-agents-6.2.0
rea-agents-6.1.0
rea-agents-6.0.0
rea-agents-5.0.0
rea-agents-4.1.0
rea-agents-4.0.1
rea-agents-4.0.0
rea-agents-3.2.1
rea-agents-3.2.0
rea-agents-3.1.0
rea-agents-3.0.0
rea-agents-2.7.0
rea-agents-2.6.0
rea-agents-2.5.1
rea-agents-2.5.0
rea-agents-2.4.0
rea-agents-2.3.0
rea-agents-2.2.0
rea-agents-2.1.0
rea-agents-2.0.0
rea-agents-1.7.0
rea-agents-1.6.0
rea-agents-1.5.0
rea-agents-1.4.0
rea-agents-1.3.0
rea-agents-1.2.0
rea-agents-1.1.0
rea-agents-1.0.0
rea-agents-0.5.0
rea-agents-0.4.0
rea-agents-0.3.0
rea-0.2.1
rea-0.2.0
Labels
Clear labels
area: bridge
area: bridge
area: build
area: build
area: build
area: cli
area: domain
area: evidence
area: mcp
area: native
area: providers
area: runtime
area: server
area: setup
area: tests
bug
design
documentation
enhancement
enhancement
enhancement
experiment
help wanted
i18n
invalid
P0: critical
P1: high
P2: medium
P2: medium
P2: medium
P3: low
performance
provider-request
pull-request
Mirrored from GitHub Pull Request
question
roadmap
triage
No labels
area: bridge
area: bridge
area: build
area: build
area: build
area: cli
area: domain
area: evidence
area: mcp
area: native
area: providers
area: runtime
area: server
area: setup
area: tests
bug
design
documentation
enhancement
enhancement
enhancement
experiment
help wanted
i18n
invalid
P0: critical
P1: high
P2: medium
P2: medium
P2: medium
P3: low
performance
provider-request
pull-request
question
roadmap
triage
Milestone
Clear milestone
No items
No milestone
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".
No due date set.
Dependencies
No dependencies set.
Reference
morluto/rea#7073
Loading…
Add table
Add a link
Reference in a new issue
No description provided.
Delete branch "%!s()"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
📋 Pull Request Information
Original PR: https://github.com/morluto/rea/pull/5803
Author: @kaoru0822-kitauji
Created: 10/21/2026
Status: ✅ Merged
Merged: 10/21/2026
Merged by: @kaoru0822-kitauji
Base:
main← Head:fix/zip-executable-prefix📝 Commits (3)
41948ccfix(artifacts): admit ZIP archives after unclaimed leading bytes93e5576fix(artifacts): share the root ZIP family across recognition paths63ba251Merge remote-tracking branch 'origin/main' into fix/zip-executable-prefix📊 Changes
7 files changed (+405 additions, -18 deletions)
View changed files
📝
src/application/BinaryTargetResolver.ts(+51 -8)📝
src/artifacts/inventory/classify.ts(+17 -8)📝
src/domain/binaryTarget.ts(+16 -0)📝
src/domain/zipPackageFormat.ts(+86 -1)➕
tests/acceptance/artifactZipLeadingBytes.test.ts(+74 -0)📝
tests/boundary/filesystem/artifactComparison.test.ts(+1 -1)📝
tests/boundary/filesystem/zipDetection.test.ts(+160 -0)📄 Description
What broke:
inspect-artifactandextract-artifactrefused a valid ZIP behind a script or self-extractor stub as "unsupported binary format", although Info-ZIP, bsdtar and Python read it (#5732).Fix: target resolution and root inventory now locate a trailing single-disk ZIP from its end record, central directory and first local header. This applies only when no other format claims the leading bytes; executable-led files keep their executable route.
Risk: low to medium. It is additive for previously refused files. Classification stays unchanged for files any existing format recognizes, and Zip64, split and empty archives still fail closed.
Summary
Fixes #5732. A ZIP preceded by inert leading bytes, such as a
#!/bin/shstub or a self-extractor, was refused before inventory or extraction because ZIP recognition only checked the first four bytes. Both prefix styles in common use now inventory and extract with the same verified member bytes as the plain archive:zip -A, or Python'szipfileappending to the stub);Problem and expected behavior
Trigger: a 17-byte shell stub followed by a ZIP. Before this change, on main
d672cc239(macOS arm64),inspect-artifactreturnedtarget_unavailable/ "Cannot open artifact: unsupported binary format." for both prefix styles, while the plain ZIP passed.Expected: a file whose leading bytes are claimed by no other format, and which ends in a structurally consistent ZIP, is a ZIP archive. A file whose leading bytes begin an executable header keeps the executable classification. For example,
/bin/lswith an appended ZIP staysmach-o-universal.Change and scope
src/domain/zipPackageFormat.tsnow owns ZIP recognition at both ends of a file:hasZipSignaturefor the start and the newlocateTrailingZipArchivefor a trailing archive. The locator takes an injected positional read and is bounded to the last 22 + 65,535 bytes, one 46-byte central-directory header and one 4-byte local-header signature. It requires:src/domain/binaryTarget.tsaddsclaimsExecutableHeader, which recognizes the ELF, MZ, Mach-O and FAT families thatparseExecutableHeaderinterprets, whether or not the header is valid. Both callers use it, so they make the same decision.BinaryTargetResolverconsults the locator only after native header detection fails and only when no executable family claims the leading bytes. Root inventory classification (classify.ts) consults it only when the bytes classify asfileorunknownand no executable family claims them.ZIP_NON_ENTRY_LIMITATIONnow names leading bytes before the first entry, such as a self-extractor stub, as non-entry bytes that are not occurrences.Not included:
Admitting any of these would need a separate decision.
Scope decision: not applicable. This is format recognition within the existing ZIP reader boundary. The reader (
@zip.js/zip.js2.15.0) already reads both prefix styles, as verified below.Contract and boundary impact
src/domain/zipPackageFormat.ts, consumed by target resolution and root inventory classification.zipartifact inventories and extractions.Expected effects:
Evidence and regression coverage
tests/acceptance/artifactZipLeadingBytes.test.ts: the public CLIinspect-artifactandextract-artifacton a script-stubbed ZIP. It checksziproot format, verified members, the non-entry limitation, and the extracted bytes. This fails on the base revision withtarget_unavailable.tests/boundary/filesystem/zipDetection.test.ts:zipthrough root classification andparseBinaryTarget, with member identities equal to the plain archive's.tests/boundary/filesystem/artifactComparison.test.ts: updated for the widened limitation text.d672cc239):plain.zippassed;prefixed.zip(offsets include the stub) andconcat.zip(raw concatenation) failed with "unsupported binary format".a.txt,d, andd/b.txtasverified, and extract members with identical digests./bin/ls+ ZIP staysmach-o-universal.@zip.js/zip.js2.15.0 reads both prefix styles. For raw concatenation it rebases entry offsets itself (a.txtat offset 17).inspect-artifacton the concatenated file): root formatzip; occurrences.,a.txt,d,d/b.txt, allverified.locateTrailingZipArchivetakes 0.112 ms per call on a 50 MB unrecognized random file and 0.023 ms on the prefixed ZIP. It runs only for files that no other format claims; the cold-cache cost of one ≤64 KiB tail read was not measured separately.For evidence-bearing changes:
Validation performed
npm run test:focused -- tests/acceptance/artifactZipLeadingBytes.test.ts tests/boundary/filesystem/zipDetection.test.ts tests/boundary/filesystem/artifactComparison.test.ts tests/acceptance/artifactZipCurrentDirectory.test.ts tests/acceptance/artifactZipExtractionPaths.test.ts tests/acceptance/pyinstallerArchive.test.ts tests/acceptance/godotPck.test.ts src/artifacts/ZipArtifactReader.test.ts src/artifacts/apple/machoContainer.test.ts: 76 passed.npm run test:focused --every test file that referencesparseBinaryTarget,classifyAndHashRoot,BinaryTargetResolverorparseExecutableHeader(46 files): 822 passed, 1 skipped.npm run check:fast: passed (typecheck, lint).npm run format:check: passed.CLI reproduction and non-regression checks above: passed.
Review follow-up (
93e55760e): the root ZIP family mapping (.app→app-pack) now lives once inzipRootPackageFormatand is shared by both resolver routes and root inventory; a stub-prefixed rootExample.appisapp-packfrom both.zipDetection+ CLI acceptance: 25 passed;check:fast,format:checkpassed. The first CI run failed onlypeResources(30 s timeout, also seen on main on 2026-10-20); it passed locally in 9 s.Compatibility, safety, and release
Author readiness
Human owner: @kaoru0822-kitauji
Before merge
type(scope): outcome.🤖 Generated with Claude Code
🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.