mirror of
https://github.com/morluto/rea.git
synced 2026-11-05 06:45:22 +00:00
[PR #5810] [MERGED] fix(javascript): count one IPC observation per site-resolved channel #7075
Closed
opened 2026-11-01 21:45:12 +00:00 by bsakaguchi
·
0 comments
No Branch/Tag specified
main
codex/procedure-reference-stacked
release-please--branches--main--components--rea-agents
release-please--branches--main--components--rea-agents--release-notes
codex/kuna-independent-retry
codex/byte-search-overlay-coverage
codex/open-failure-target-receipt
codex/kuna-xref-evidence
codex/ghidra-ambiguous-procedure-recovery
codex/function-source-bundle
codex/trace-function-integration-prototype
codex/snapshot-source-closure
codex/recorded-evidence-array-pages
codex/evidence-recovery-redesign
codex/trace-feature-address-scope
codex/call-discovery-scope
codex/ghidra-literal-candidate-evidence
codex/decompile-directory-independent-retry
codex/retry-provenance-base
codex/value-flow-capability-experiment
codex/ghidra-containing-instruction
cursor/readme-discord-button-ef9f
dependabot/github_actions/actions/setup-node-7.1.0
dependabot/github_actions/actions/upload-artifact-7.0.2
dependabot/npm_and_yarn/npm-minor-and-patch-d8d97ce6df
codex/kuna-1989
fix/8559-native-ui-fixture-ownership
fix/8555-go-verifier-mcp-ownership
codex/provider-capability-recovery
fix/8642-rizin-target-stdin
codex/ghidra-memory-effect-scope
codex/ghidra-annotation-entry-selector
codex/ghidra-readonly-recovery
codex/ghidra-regex-verifier-recovery
codex/evidence-discovery-view-guidance
fix/8545-bulk-append-overflow
fix/8428-navigation-refusal-alternatives
codex/address-context-recovery
codex/matching-member-limitations
codex/unknown-scope-contract
codex/evidence-view-guidance
feat/8373-native-trace-views
codex/ghidra-snapshot-verifier-binding
codex/elf-export-visibility
codex/evidence-view-recovery
codex/native-reference-cli-help
codex/provider-candidate-observation-scope
codex/kuna-session-verification
codex/ghidra-switch-lifetime-guidance
codex/pseudocode-paging-discovery
codex/clarify-evidence-view-support
codex/kuna-xrefs-selector-recovery
codex/context-capacity-recovery
codex/evidence-closure-large-links
codex/same-function-evidence-identity
codex/ghidra-verifier-inspected-jdk
codex/audit-guided-workflows
codex/crash-prompt-retained-dossiers
codex/analysis-view-error-recovery
codex/kuna-verifier-target-selection
codex/ghidra-selected-project-call-coverage
codex/docs-native-analysis-scope
codex/ghidra-java-socket-boundary
codex/ghidra-retained-snapshot-verifier
codex/ghidra-search-inventory-facts
fix/8284-zero-argument-parameter-bindings
fix/8198-ui-action-handler-offset
fix/8257-elf-entry-label-identity
fix/8304-deferred-output-schema-projection
fix/8277-call-path-computed-target-uncertainty
fix/pr-8089-conflicts
fix/ci-static-duplicate-export
dependabot/npm_and_yarn/lint-staged-17.6.0
dependabot/github_actions/actions/download-artifact-8.0.2
dependabot/npm_and_yarn/write-file-atomic-8.0.0
dependabot/npm_and_yarn/canonicalize-5.1.0
dependabot/github_actions/actions/cache/restore-6.1.0
dependabot/npm_and_yarn/toon-format/toon-4.4.0
dependabot/github_actions/actions/deploy-pages-5.0.1
codex/review-fixes-pr-2403
codex/review-fixes-pr-2400
codex/process-terminal-width
codex/test-brittleness-cleanup
verify/7167-browser-connect-macos
fix/7167-browser-connect
feat/native-matching-allowance-setting
feat/browser-scenario-dry-run
test/managed-caller-parameters-20261024
codex/parser-fortythird-boundaries
fix/6926-pinvoke-platform-decorations-20261023
fix/6889-har-body-encoding-20261023
fix/6888-sqlite-schema-budget-20261023
fix/dependency-security-gates-6708
cursor/evidence-overwrite-rebase-b4ac
feat/4057-verify-native-exports
fix/windows-acl-observer-overhead-20261022
cursor/erlang-beam-restack-4476
cursor/pe-certificate-review-bf32
fix/6116-javascript-application-fs-errors
fix/6061-unmapped-runtime-script-unknown
feat/browser-scenario-summary
fix/pe-certificates
codex/verify-3407
cursor/rebase-5699
cursor/rebase-5352
cursor/rebase-5600
cursor/fix-cli-schema-omission-10a8
codex/audit-hopper-shutdown-reasons-20261021
fix/demangle-swift-omitted-record
fix/nib-boolean-value-types
cursor/cancellation-partial-observation-a5ac
fix/ib-object-limit-reasons
fix/electron-fuse-limit-advice
fix/kuna-doctor-dangling-cache
fix/fixed-budget-refusal-advice
fix/js-ipc-listener-dedup
fix/js-return-member-provenance
fix/dmg-integrity-retry-advice
fix/ida-doctor-readiness
fix/kuna-version-probe-output-drain
fix/legacy-swift-runtime-name-matching
fix/dylib-lazy-load-commands
fix/browser-scenario-startup-cancel
fix/swift-nested-punycode-classification
fix/compare-unselected-scopes
fix/objc-method-budget-coverage
fix/dmg-mounted-root-observations
audit/ci-tests-20261019-round2
release/6.7.0
fix/wabt-cleanup-retry-resolution
fix/electron-fuse-elf-pe-architecture
fix/native-plist-descriptor-ownership
fix/kuna-caller-cleanup-ownership
experiment/atomic-codemode-20261016
review/first-contributor-3776
fix/call-resolution-full-read-cycles
fix/member-mutation-selection-repeat
experiment/atomic-re-tools-20261015
perf/member-mutation-lazy-origins
perf/static-network-mutation-index
fix/hopper-startup-lifecycle
audit/3050-windows-proof-20261015
feat/windows-window-capture-2183
audit/3049-windows-proof-20261015
audit/3735-macos-fixtures-20261015
fix/batch-decompile-null-pseudocode
fix/kuna-inventory-honors-jobs
experiment/browser-codemode-tool-design-20261015
fix/hopper-clean-runtime-argv
codex/review-2049-27f1b367
review-fixes/pr-2787-routing
fix/3360-scoped-this-emitters
fix/3367-replaced-global-effects
fix/3838-compact-any-value-items
test/hopper-download-probe-20261015
codex/windows-runtime-creation-red-green-20261015
codex/windows-readonly-root-red-green-20261015
codex/windows-root-share-red-green-20261015
codex/exp-1685-win-mcp-startup
codex/bug-sweep-20261015
investigate/2190-windows-package-phases
investigate/3543-macos-cli-deadline
perf/3281-reverse-tools-feedback-quality
fix/3406-hopper-doctor-fixture
fix/3341-wrapper-require-test-context
fix/3301-owned-uninstall-fixtures
fix/3164-compiler-input-ownership
fix/pcap-cleanup-stdout-newline-20261014
perf/interface-builder-summary
codex/review-fixes-pr-1977
fix/ghidra-effective-jvm-platform
fix/docs-turkish-rust-link-20261013
fix/main-maintenance-ci-20261010
fix/recover-binary-session-process-effects
codex/review-fixes-pr-2457
codex/ci-required-cancellation-gate
fix/main-format-baseline-20261013
fix/setup-preserve-entry-fields
cursor/restore-main-checks-1ffc
fix/ghidra-bridge-hashmap-import
codex/shared-ci-jadx-json-default-20261013
codex/shared-ci-ghidra-test-groups-20261013
codex/shared-ci-java-fixture-format-20261013
codex/fix-intrinsic-invocation-boundaries
test/release-preflight-reusable-jobs
test/js-parameter-provenance-expectation
fix/linux-hopper-verification-current
test/2419-ghidra-elf-probe-size
followup/pr-1544-native-ida
codex/fold-pr-2230-contribution
docs/readme-responsible-use
fix/issue-2064
fix/issue-2050
fix/issue-2053
fix/issue-1968
fix/issue-1945
experiment/codemode-bridge-20261011
fix/tool-effects-negative-wording-1904-20261012
fix/1842-electron-interop-provenance
feat/recover-javascript-multi-input
refactor/website-i18n-prep
fix/nativeaot-pe-virtual-extent
fix/browser-verifier-ci-hang
fix/pe-resources-input-selection
docs/beginner-friendly-guides
docs/beginner-setup-guide
fix/javascript-analysis-worker-1563
fix/1649-ghidra-duplicate-names
fix/javascript-export-keys-integration-1369
test/maintenance-boundary-contracts-20261011
review/javascript-export-keys-1369
review/process-live-progress-1483
test/javascript-1495-growth-ratio
fix/ci-escape-timing
docs/normalized-terminal-geometry-1450
release/6.3.0
archive/release-6.3.0-pr1381
release/6.2.0
fix/electron-preload-dynamic-override
fix/javascript-self-referential-bundler-edges
release/6.1.0
cursor/grok-client-cherry-pick-0b56
feat/signature-posture
feat/dyld-shared-cache
feat/artifact-integrity-policy
feat/pkg-inventory
release/6.0.0
chore/sync-release-5.0.0
release/5.0.0
cursor/cloud-agent-node-787e
fix/javascript-xhr-open-endpoints
review/pr-711-realpath-fallback-wording
cleanup/replay-confinement
codex/test-suite-performance
codex/issue-foundations
codex/address-open-issues-2026-07-20
agent/javascript-vite-rollup-esbuild-adapters
agent/process-cleanup
agent/triage-integration
agent/unknown-commands-registry
feat/mcp-identity-metadata
morlvps/issue_cleanup
codex/installer-redesign
morl/roadmap-investigation-core
morl/roadmap-investigation-docs
release-please--branches--main--components--rea
rea-agents-6.8.0
rea-agents-6.7.0
rea-agents-6.6.0
experiment/atomic-codemode-wait-runtime-20261016
rea-agents-6.5.0
rea-agents-6.4.0
rea-agents-6.3.0
rea-agents-6.2.0
rea-agents-6.1.0
rea-agents-6.0.0
rea-agents-5.0.0
rea-agents-4.1.0
rea-agents-4.0.1
rea-agents-4.0.0
rea-agents-3.2.1
rea-agents-3.2.0
rea-agents-3.1.0
rea-agents-3.0.0
rea-agents-2.7.0
rea-agents-2.6.0
rea-agents-2.5.1
rea-agents-2.5.0
rea-agents-2.4.0
rea-agents-2.3.0
rea-agents-2.2.0
rea-agents-2.1.0
rea-agents-2.0.0
rea-agents-1.7.0
rea-agents-1.6.0
rea-agents-1.5.0
rea-agents-1.4.0
rea-agents-1.3.0
rea-agents-1.2.0
rea-agents-1.1.0
rea-agents-1.0.0
rea-agents-0.5.0
rea-agents-0.4.0
rea-agents-0.3.0
rea-0.2.1
rea-0.2.0
Labels
Clear labels
area: bridge
area: bridge
area: build
area: build
area: build
area: cli
area: domain
area: evidence
area: mcp
area: native
area: providers
area: runtime
area: server
area: setup
area: tests
bug
design
documentation
enhancement
enhancement
enhancement
experiment
help wanted
i18n
invalid
P0: critical
P1: high
P2: medium
P2: medium
P2: medium
P3: low
performance
provider-request
pull-request
Mirrored from GitHub Pull Request
question
roadmap
triage
No labels
area: bridge
area: bridge
area: build
area: build
area: build
area: cli
area: domain
area: evidence
area: mcp
area: native
area: providers
area: runtime
area: server
area: setup
area: tests
bug
design
documentation
enhancement
enhancement
enhancement
experiment
help wanted
i18n
invalid
P0: critical
P1: high
P2: medium
P2: medium
P2: medium
P3: low
performance
provider-request
pull-request
question
roadmap
triage
Milestone
Clear milestone
No items
No milestone
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".
No due date set.
Dependencies
No dependencies set.
Reference
morluto/rea#7075
Loading…
Add table
Add a link
Reference in a new issue
No description provided.
Delete branch "%!s()"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
📋 Pull Request Information
Original PR: https://github.com/morluto/rea/pull/5810
Author: @kaoru0822-kitauji
Created: 10/21/2026
Status: ✅ Merged
Merged: 10/21/2026
Merged by: @kaoru0822-kitauji
Base:
main← Head:fix/js-ipc-const-channel-duplicate📝 Commits (10+)
59dda3cfix(javascript): count one IPC observation per site-resolved channel5430e98fix(javascript): keep wrapper invocations distinct while removing repeats7d145b4fix(javascript): compare site-determined IPC handlers by value2ad374afix(javascript): keep closures over invocation values as distinct IPC handlers42f4cd6Merge remote-tracking branch 'origin/main' into fix/js-ipc-const-channel-duplicated27d1e4test(javascript): guard optional call paths in closure handler test8f88b60fix(javascript): decide IPC handler identity from activation captures784eb39fix(javascript): treat implicit captures and bundle modules precisely in IPC handler identityf37215cfix(javascript): attribute an arrow handler's inherited context to its owner6e6c48bfix(javascript): skip suffix scans for per-invocation IPC handlers📊 Changes
5 files changed (+735 additions, -13 deletions)
View changed files
📝
docs/javascript-artifact-reconstruction.md(+9 -1)📝
src/domain/javascript/electronWrappedCallPaths.test.ts(+318 -0)📝
src/domain/javascript/electronWrappedCallPaths.ts(+325 -12)📝
src/domain/javascript/javascriptSymbolicBindings.ts(+7 -0)➕
tests/acceptance/applications/electronIpcConstantChannelCli.test.ts(+76 -0)📄 Description
What broke:
analyze-javascript-applicationcounted a send likeipcRenderer.send(PING), withconst PING = "ping", as two renderer operations, and a wrapper call reached through a bridge member plus its own entry as two invocations (#5710).Fix: wrapper substitution now resolves the syntax pass's unresolved observation in place when the call site itself determines the finding (channel, and for registrations the handler). A finding repeated through the same trailing local calls is recorded once.
Risk: low to medium. IPC counts drop only where one physical operation was recorded twice. A channel supplied through a wrapper argument stays an unresolved observation beside its resolved candidates, so unknowns are preserved.
Summary
Fixes #5710. One physical IPC operation could be recorded two or three times:
send(PING)asdynamic(channel_expression: "PING"), and wrapper substitution added a separateliteral"ping"record. Deduplication is keyed on the channel value, so the two never matched. The issue's fixture reported 3 operations and 2 transmissions instead of 2 and 1.forward("forward-chan")is an entry seed (string-literal first argument) and is also reached through the enclosingexposeInMainWorldor local call. The finding's invocation identity was the walk's outermost seed, so the same call looked like two invocations. This duplicated literal sends and listener registrations (coygeek's helper-forwarding report: 4/3 and 4/0/3).Problem and expected behavior
Expected, from the issue and the existing invariants in
electronWrappedCallPaths.test.ts:Separately, a channel that only a wrapper argument supplies must not erase the operation's unresolved observation. Callers outside the traced paths may pass other channels, and dropping the dynamic record would hide that, for example an exposed
any: name => forward(name).Change and scope
All in the wrapper-substitution producer,
src/domain/javascript/electronWrappedCallPaths.ts:parse_status: complete. A handler supplied through a wrapper parameter keeps the generic source registration, with per-invocation candidates beside it. A handler closure that reads a binding of a function the trace activated (a wrapper parameter, a factory local or an outer call's parameter) is per-invocation: it never replaces the direct observation and is never skipped as a repeated path. An arrow handler's inheritedthis/argumentscount as captures; bundle module factories (markedmoduleFactoryby the resolver) run once per module load, so their bindings do not.docs/javascript-artifact-reconstruction.mddocuments the rule.Contract and boundary impact
electronWrappedCallPaths.ts, which owns symbolic channel resolution.resolution_basis: "wrapper-substitution".Expected effects:
Evidence and regression coverage
Tests added:
src/domain/javascript/electronWrappedCallPaths.test.ts:aandb, all at one site.tests/acceptance/applications/electronIpcConstantChannelCli.test.tschecks the public CLI summary counts for one constant send (2/1, dynamic 0), two constant sends (3/2, dynamic 0), and a helper-forwarded channel (3/2, dynamic 1).origin/main's producer and pass with this change (executed by restoring main'selectronWrappedCallPaths.ts).Base reproduction (executed, main
d672cc239, built CLI, macOS arm64). Operations / transmissions (/ listeners) for the issue's fixtures:Note on the helper-forwarded fixtures: the issue proposed 2/1 and 2/0/1. Instead, the parameter
chkeeps its unresolved observation beside the resolvedforward-chancandidate, and the duplicate literal is removed.Related shapes (executed, after the change):
aandb: unresolved,a,b;a;aplus unresolved, previously twoa.Real application (executed): Tabby's
app.asar(29 MB,--integrity-policy record-and-continue) produces identical IPC summaries before and after (39 operations, 22 transmissions, 6 listeners, 11 handlers, 13 dynamic). Elapsed time was 116.15 s before and 116.50 s after. Peak RSS was 1.72 GB vs 1.87 GB, but that is one run each, so it is within run-to-run variance, not an established difference. Discord's ASAR has no IPC observations. Notion and Signal fail identically before and after (integrity mismatch; Signal also with record-and-continue after about 8.5 minutes).Remaining proof gaps:
For evidence-bearing changes:
Validation performed
npm run test:focused --the 20 test files that reference Electron IPC,ipcRenderer,renderer_transmissions,electronWrappedCallPaths,ElectronBoundaryAnalysisorcall_paths: 816 passed (before the new tests were added).npm run test:focused -- src/domain/javascript/electronWrappedCallPaths.test.ts tests/acceptance/applications/electronIpcConstantChannelCli.test.ts tests/acceptance/applications/electronIpcListenerCallsiteCli.test.ts: 161 passed.The same new tests against
origin/main's producer: 7 failed, 152 passed (as expected).npm run check:fast: passed.npm run format:check: passed.npm run docs:check: passed.Review follow-up (
5430e9892): restored entry-based invocation identity after Greptile showed that nearest-literal-call identity collapsed distinct outer handlers. Repeats are now detected by identical value plus a shared call suffix, and in-place resolution of registrations requires a site-determined handler (Codex). New regression tests cover both reviewer examples. Results: the 21 Electron/IPC test files pass (825 tests);check:fast,format:checkanddocs:checkpass. Issue fixtures unchanged: 2/1, 2/1, 3/2, helper send 3/2 (1 dynamic), helper listener 3/0/2 (1 dynamic).Review follow-up (
7d145b456): handlers are compared by lexical value rather than by representation, so a named local handler resolves in place (Greptile). The stale unknown-channel contribution is removed on replacement (Codex). New tests cover both. Results: the 21 Electron/IPC test files pass (826 tests);check:fastandformat:checkpass.Compatibility, safety, and release
Author readiness
Human owner: @kaoru0822-kitauji
Before merge
type(scope): outcome.🤖 Generated with Claude Code
🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.