[PR #5807] [MERGED] ci(windows): run remaining Windows-only path admission cases in the lane #7077

New issue

Closed

opened 2026-11-01 21:45:12 +00:00 by bsakaguchi · 0 comments

bsakaguchi commented

2026-11-01 21:45:12 +00:00

Owner

📋 Pull Request Information

Original PR: https://github.com/morluto/rea/pull/5807
Author: @Iyanuoluwa007
Created: 10/21/2026
Status: ✅ Merged
Merged: 10/21/2026
Merged by: @morluto

Base: main ← Head: ci/windows-lane-remaining

📝 Commits (1)

43b89e3 ci(windows): run remaining Windows-only path admission cases in the lane

📊 Changes

3 files changed (+18 additions, -0 deletions)

View changed files

📝 .github/workflows/ci.yml (+3 -0)
📝 scripts/ci/scopes.mjs (+3 -0)
📝 tests/process-global/curatedWindowsLane.test.ts (+12 -0)

📄 Description

Summary

Three test files contain cases that run only on Windows, but the windows-curated CI job runs an explicit file list that doesn't name them. Linux shards skip those cases, so CI never runs them anywhere. This adds them to the lane, the package change scope, and the lane guard. It's the same gap #4988 closes for windowsTargetSeparators.test.ts, and independent of it.

Problem and expected behavior

File	Windows-only cases
`src/contracts/sessionPathInputs.test.ts`	`describe.runIf(win32)` "Windows absolute path forms"
`tests/boundary/filesystem/directAnalysisSnapshotReplay.test.ts`	"does not replay a CLI snapshot through a Windows junction"; "…before native admission on a canonical path"
`tests/boundary/mcp/rawBinaryMcp.test.ts`	"does not replay a saved read after switching to a Windows junction"; "reuses saved reads after a fixture admits a noncanonical Windows path"

These cover junction and noncanonical-path handling at snapshot admission, the Windows-specific boundary the curated lane exists for. As listed today, they only run when someone runs them by hand on Windows.

Change and scope

.github/workflows/ci.yml: add the three files to "Run curated Windows capability tests", next to binaryTarget.test.ts.
scripts/ci/scopes.mjs: add them to the package scope. ciChangeScope.test.ts requires every windows-curated path to belong to it.
tests/process-global/curatedWindowsLane.test.ts: assert the lane keeps the three paths, like its other Windows-only regressions.

Not included:

tests/boundary/sqlite/sqliteDatabaseBusy.test.ts also has a Windows-only case, but it needs the packaged Windows native addon, which my checkout lacks, so I couldn't run it.
tests/acceptance/electronFusesCli.test.ts needs the built CLI, which I can't build here.

Both are worth adding once someone verifies them on Windows.

Contract and boundary impact

Semantic owner and earliest changed stage: CI test selection only.
Contribution scope fit and linked maintainer decision: not applicable.
CLI and MCP/tool-catalog contract: none.
Provider, bridge, target-format, or platform compatibility: none.
Evidence, artifact, provenance, or reconstruction contract: none.
Target selection, authority, upstream behavior, and cleanup details: not applicable.
Generated metadata, package, or installation impact: none.
Documentation or usability only; no target interaction.

Evidence and regression coverage

Executed on Windows 11 x64 (Node 24), whole files as the lane runs them: sessionPathInputs.test.ts 17 passed, directAnalysisSnapshotReplay.test.ts 21 passed, rawBinaryMcp.test.ts 11 passed. The Windows-only cases ran (not skipped).
curatedWindowsLane.test.ts + ciChangeScope.test.ts: 254 passed, 2 skipped. With the ci.yml change stashed, the new guard fails (1 failed, 8 passed).
Remaining proof gaps: the windows-curated job itself runs on windows-latest in this PR's CI; I could not run the workflow locally. My checkout lacks the native addon that job installs, so the job's environment is stricter than, not identical to, what I ran.
Observed, derived, and inferred claims remain distinguishable.
Artifact identity, source provenance, and failed attempts remain preserved.
Unsupported, incomplete, unavailable, or uncertain outcomes remain visible.

Validation performed

The three files on Windows 11: 49 tests passed in total.
npx vitest run tests/process-global/curatedWindowsLane.test.ts tests/boundary/filesystem/ciChangeScope.test.ts: 254 passed, 2 skipped; the guard fails without the lane entries.
npm run check:fast (typecheck, lint, pre-push hook): passed.

Compatibility, safety, and release

Breaking changes or migration steps: none.
Real Hopper/Ghidra, browser, or OS coverage: adds three Windows filesystem/MCP test files to the existing Windows lane.
Package or release metadata impact: none.
Security, privacy, process, or containment review: none.

Author readiness

Human owner: @Iyanuoluwa007

I reviewed the final diff and relevant existing code, understand the change and its edge cases, and take responsibility for the complete PR, including AI-assisted work.
I checked the evidence above, confirmed it supports the current change, and recorded meaningful validation gaps.
I declare this PR ready for initial maintainer review.

Before merge

This PR addresses a concrete problem or an agreed enhancement.
Material scope and authority questions are resolved, and any required maintainer scope decision covers the final diff.
The PR has one focused outcome and the title follows type(scope): outcome.
Related issue is linked, or the reason for not linking one is stated above.
Tests cover changed observable behavior and meaningful failure paths.
Owning docs, contracts, and generated metadata are updated where needed.
User-visible CLI/MCP changes include representative output.
I checked the final diff for secrets, unrelated cleanup, and unsupported claims.

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/morluto/rea/pull/5807 **Author:** [@Iyanuoluwa007](https://github.com/Iyanuoluwa007) **Created:** 10/21/2026 **Status:** ✅ Merged **Merged:** 10/21/2026 **Merged by:** [@morluto](https://github.com/morluto) **Base:** `main` ← **Head:** `ci/windows-lane-remaining` --- ### 📝 Commits (1) - [`43b89e3`](https://github.com/morluto/rea/commit/43b89e37e2dec29c9825936927e931ac162d7fdc) ci(windows): run remaining Windows-only path admission cases in the lane ### 📊 Changes **3 files changed** (+18 additions, -0 deletions) <details> <summary>View changed files</summary> 📝 `.github/workflows/ci.yml` (+3 -0) 📝 `scripts/ci/scopes.mjs` (+3 -0) 📝 `tests/process-global/curatedWindowsLane.test.ts` (+12 -0) </details> ### 📄 Description ## Summary Three test files contain cases that run only on Windows, but the `windows-curated` CI job runs an explicit file list that doesn't name them. Linux shards skip those cases, so CI never runs them anywhere. This adds them to the lane, the `package` change scope, and the lane guard. It's the same gap #4988 closes for `windowsTargetSeparators.test.ts`, and independent of it. ## Problem and expected behavior | File | Windows-only cases | |---|---| | `src/contracts/sessionPathInputs.test.ts` | `describe.runIf(win32)` "Windows absolute path forms" | | `tests/boundary/filesystem/directAnalysisSnapshotReplay.test.ts` | "does not replay a CLI snapshot through a Windows junction"; "…before native admission on a canonical path" | | `tests/boundary/mcp/rawBinaryMcp.test.ts` | "does not replay a saved read after switching to a Windows junction"; "reuses saved reads after a fixture admits a noncanonical Windows path" | These cover junction and noncanonical-path handling at snapshot admission, the Windows-specific boundary the curated lane exists for. As listed today, they only run when someone runs them by hand on Windows. ## Change and scope - `.github/workflows/ci.yml`: add the three files to "Run curated Windows capability tests", next to `binaryTarget.test.ts`. - `scripts/ci/scopes.mjs`: add them to the `package` scope. `ciChangeScope.test.ts` requires every `windows-curated` path to belong to it. - `tests/process-global/curatedWindowsLane.test.ts`: assert the lane keeps the three paths, like its other Windows-only regressions. Not included: - `tests/boundary/sqlite/sqliteDatabaseBusy.test.ts` also has a Windows-only case, but it needs the packaged Windows native addon, which my checkout lacks, so I couldn't run it. - `tests/acceptance/electronFusesCli.test.ts` needs the built CLI, which I can't build here. Both are worth adding once someone verifies them on Windows. ## Contract and boundary impact - Semantic owner and earliest changed stage: CI test selection only. - Contribution scope fit and linked maintainer decision: not applicable. - CLI and MCP/tool-catalog contract: none. - Provider, bridge, target-format, or platform compatibility: none. - Evidence, artifact, provenance, or reconstruction contract: none. - Target selection, authority, upstream behavior, and cleanup details: not applicable. - Generated metadata, package, or installation impact: none. - [x] Documentation or usability only; no target interaction. ## Evidence and regression coverage - Executed on Windows 11 x64 (Node 24), whole files as the lane runs them: `sessionPathInputs.test.ts` 17 passed, `directAnalysisSnapshotReplay.test.ts` 21 passed, `rawBinaryMcp.test.ts` 11 passed. The Windows-only cases ran (not skipped). - `curatedWindowsLane.test.ts` + `ciChangeScope.test.ts`: 254 passed, 2 skipped. With the `ci.yml` change stashed, the new guard fails (1 failed, 8 passed). - Remaining proof gaps: the `windows-curated` job itself runs on `windows-latest` in this PR's CI; I could not run the workflow locally. My checkout lacks the native addon that job installs, so the job's environment is stricter than, not identical to, what I ran. - [x] Observed, derived, and inferred claims remain distinguishable. - [x] Artifact identity, source provenance, and failed attempts remain preserved. - [x] Unsupported, incomplete, unavailable, or uncertain outcomes remain visible. ## Validation performed - The three files on Windows 11: 49 tests passed in total. - `npx vitest run tests/process-global/curatedWindowsLane.test.ts tests/boundary/filesystem/ciChangeScope.test.ts`: 254 passed, 2 skipped; the guard fails without the lane entries. - `npm run check:fast` (typecheck, lint, pre-push hook): passed. ## Compatibility, safety, and release - Breaking changes or migration steps: none. - Real Hopper/Ghidra, browser, or OS coverage: adds three Windows filesystem/MCP test files to the existing Windows lane. - Package or release metadata impact: none. - Security, privacy, process, or containment review: none. ## Author readiness Human owner: @Iyanuoluwa007 - [x] I reviewed the final diff and relevant existing code, understand the change and its edge cases, and take responsibility for the complete PR, including AI-assisted work. - [x] I checked the evidence above, confirmed it supports the current change, and recorded meaningful validation gaps. - [x] I declare this PR ready for initial maintainer review. ## Before merge - [x] This PR addresses a concrete problem or an agreed enhancement. - [x] Material scope and authority questions are resolved, and any required maintainer scope decision covers the final diff. - [x] The PR has one focused outcome and the title follows `type(scope): outcome`. - [x] Related issue is linked, or the reason for not linking one is stated above. - [x] Tests cover changed observable behavior and meaningful failure paths. - [x] Owning docs, contracts, and generated metadata are updated where needed. - [x] User-visible CLI/MCP changes include representative output. - [x] I checked the final diff for secrets, unrelated cleanup, and unsupported claims. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>

bsakaguchi

2026-11-01 21:45:12 +00:00